1. 07 Mar, 2019 1 kayıt (commit)
  2. 17 Ara, 2018 1 kayıt (commit)
  3. 08 Ara, 2018 1 kayıt (commit)
  4. 07 Ara, 2018 5 kayıt (commit)
  5. 06 Ara, 2018 1 kayıt (commit)
    • Stephan Bergmann's avatar
      Remove broken rebuild of compilerplugins when CLANG_FULL_VERSION changed · efe28895
      Stephan Bergmann yazdı
      Not all compilerplugins/clang/*.cxx depend on config_clang.h (e.g., check.cxx
      doesn't), so this mechanism trying to rebuild compilerplugins once the
      underlying Clang installation changes doesn't work reliably in practice (just
      debugged through this with Miklos on IRC, and it wasn't the first time that
      `make distclean` fixed compilerplugins for somebody after they upgraded their
      Clang installation).  Removing the brittle mechanism shows that plugin.hxx
      doesn't actually depend on config_clang.h.
      
      (There's a second mechanism trying to rebuild compilerplugins once the
      underlying Clang installation changes, namely
      
      > # Clang most probably doesn't maintain binary compatibility, so rebuild when clang changes.
      > $(CLANGOUTDIR)/clang-timestamp: $(CLANGDIR)/bin/clang$(CLANG_EXE_EXT)
      >         $(QUIET)touch $@
      
      in compilerplugins/Makefile-clang.mk, but that doesn't work reliably either, as
      it depends on the newly installed clang executable being newer than our
      clang-timestamp file, which will be the case for self-built Clang installations,
      but not necessarily when updating e.g. a distro-provided Clang installation.)
      
      Change-Id: Ie576f14356b3f0e55444375095c86aa851404bf3
      Reviewed-on: https://gerrit.libreoffice.org/64623
      Tested-by: Jenkins
      Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      efe28895
  6. 29 Kas, 2018 1 kayıt (commit)
  7. 09 Kas, 2018 2 kayıt (commit)
    • Stephan Bergmann's avatar
      Fix creation/removal of GPG socketdir · f0305ec0
      Stephan Bergmann yazdı
      <https://gerrit.libreoffice.org/#/c/50978/> "gpg4libre: fix failing gpg test due
      to over-long filenames" had introduced the gb_CppunitTest_run_gpgconf target in
      xmlsecurity/CppunitTest_xmlsecurity_signing.mk, calling `gpgconf
      --craete-socketdir`.  A 2018-03-18 comment there notes that "Stephan's last
      comment: (and `gpgconf --remove-sockedir` be called after the test?) is not
      addressed yet, will do in follow-up commit".
      
      Follow-up d7ecf4a4 "properly check for gpgconf
      (and --create-socketdir) working" makes gb_CppunitTest_run_gpgconf conditional.
      However, in configure.ac,
      
        HAVE_GPGCONF_SOCKETDIR=TRUE
      
      is missing, so even after follow-up 7a95ee8d
      "actually add HAVE_GPGCONF_SOCKETDIR to config_host.mk.in...", config_host.mk
      will always contain
      
        export HAVE_GPGCONF_SOCKETDIR=
      
      so gb_CppunitTest_run_gpgconf will never be executed (and `pgconf
      --crate-socketdir` will never called).
      
      But even if it were executed, it would not create the socket dir that the test
      code in xmlsecurity/qa/unit/signing/signing.cxx is actually using, as
      gb_CppunitTest_run_gpgconf sets
      
        GNUPGHOME=.../workdir/CppunitTest/xmlsecurity_signing.test.user
      
      while xmlsecurity/qa/unit/signing/signing.cxx's SigningTest::setUp sets
      
        GNUPGHOME=.../workdir//CppunitTest/xmlsecurity_signing.test.user/
      
      and the GPG software is apparently picky about extra slashes when computing the
      socket dir name from the GNUPGHOME env var.
      
      (That `gpgconf --create-socketdir` was never executed with the current setup
      shows that calling it explicitly is probably not really needed, as the GPG
      software apparently creates it automatically on demand.)
      
      However, what is still missing is to remove the socket dir again (see the
      comment quoted above), and, probably more importantly, to exit any gpg-agent
      daemon operating on that socket dir that has (indirectly) been started by the
      tests in xmlsecurity/qa/unit/signing/signing.cxx.  At least with Fedora 29
      gpgconf from gnupg2-2.2.9-1.fc29.x86_64, that daemon is successfully terminated
      by calling `gpgconf --remove-socket`.
      
      So move the call to `gpgconf --create-socketdir` from the makefile to the test
      setup code (which makes it easier to guarantee that a single GNUPGHOME value,
      and thus a single socket dir, is used), and add a corresponding `gpgconf
      --remove-socketdir` call to the test shutdown code.  (As argued above, the
      `gpgconf --create-socketdir` call shouldn't be stricktly necessary, but it looks
      cleaner to do it explicitly anyway.)
      
      Change-Id: I2ec8f08943ed63ec27f8507461588ee7cdadf372
      Reviewed-on: https://gerrit.libreoffice.org/63181Reviewed-by: 's avatarThorsten Behrens <Thorsten.Behrens@CIB.de>
      Tested-by: Jenkins
      Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      f0305ec0
    • Caolán McNamara's avatar
      fix oss-fuzz build · c1ed005e
      Caolán McNamara yazdı
      Change-Id: I22823323e0b4e15dbd6ea5f7efd35301995315bf
      c1ed005e
  8. 11 Eyl, 2018 2 kayıt (commit)
  9. 31 Agu, 2018 1 kayıt (commit)
  10. 30 Agu, 2018 1 kayıt (commit)
  11. 29 Agu, 2018 1 kayıt (commit)
  12. 08 Agu, 2018 1 kayıt (commit)
  13. 04 Agu, 2018 1 kayıt (commit)
  14. 07 Tem, 2018 1 kayıt (commit)
  15. 04 Tem, 2018 1 kayıt (commit)
  16. 23 May, 2018 1 kayıt (commit)
  17. 21 May, 2018 1 kayıt (commit)
  18. 11 May, 2018 1 kayıt (commit)
  19. 10 May, 2018 2 kayıt (commit)
  20. 08 May, 2018 1 kayıt (commit)
  21. 07 May, 2018 1 kayıt (commit)
    • Noel Grandin's avatar
      configure option to disable libnumbertext · 24d59c9e
      Noel Grandin yazdı
      Because we get a crash in CppunitTest_sw_odfexport when compiling with
      clang >= 6.0.0
      
      Also had to fix the ENABLE_LIBNUMBERTEXT being propogated, and the
      way the code checked it.
      
      Change-Id: I68e4a0078016d176f478ca4c1110fc296b6ca921
      24d59c9e
  22. 18 Mar, 2018 1 kayıt (commit)
  23. 23 Ock, 2018 2 kayıt (commit)
    • Milian Wolff's avatar
      Introduce gtk3_kde5 vcl plugin · ecb5fcff
      Milian Wolff yazdı
      This is a hybrid plugin which mostly wraps the GTK3 vclplug. Only
      the file and folder picker are replaced by KDE dialogs. This gives
      us a well-maintained GTK LO base with basic KDE integration with
      minimum effort.
      
      To prevent issues with nested event loops, the KDE dialogs are
      launched from a separate process, the new lo_kde5filepicker helper
      executable. A trivial stdin/stdout IPC mechanism transfers the data
      between LO and the Qt/KDE helper. The usage of an external process
      also allows us to copy'n'paste between LO and the KDE file dialog
      without freezing the UI, as would happen when one would do this
      in-process. This is in general also the architecture applied by the
      kmozillahelper, which is used to integrate KDE file dialogs into
      Firefox.
      
      While the KDE dialog is shown, the GTK3 main window is disabled and
      close requests are ignored. The KDE dialog in turn also sets the LO
      window as transient parent. Together, this makes the illusion perfect
      and the KDE dialog behaves like a modal dialog. This works properly
      also with multiple LO main windows, and only individual windows will
      get blocked as one would expect.
      
      Functionality wise, most of the features of the KDE4 dialog are
      supported. You can pick files and folders, and save files under a new
      name. Some custom checkbox widgets are supported, but lists, buttons
      and preview widgets are not yet implemented. Also, loading remote
      files via KIO is not possible yet.
      
      Change-Id: I1a97cf7c272307a19ace4222d5f12253bc722829
      Reviewed-on: https://gerrit.libreoffice.org/47718Tested-by: 's avatarJenkins <ci@libreoffice.org>
      Reviewed-by: 's avatarThorsten Behrens <Thorsten.Behrens@CIB.de>
      ecb5fcff
    • Milian Wolff's avatar
      Extend build system to support linking against KDE Frameworks 5 · 4d78cf97
      Milian Wolff yazdı
      Pass --enable-kde5 to autogen.sh to enable this feature. Then
      add kde5 to the list of externals to link against KF5. I will
      introduce other code that depends on KF5 though which will
      leverage this feature.
      
      Change-Id: I17e434a53ac769000b0f805b1f41cdc5c2c84ee2
      Reviewed-on: https://gerrit.libreoffice.org/47715Tested-by: 's avatarJenkins <ci@libreoffice.org>
      Reviewed-by: 's avatarThorsten Behrens <Thorsten.Behrens@CIB.de>
      4d78cf97
  24. 22 Ara, 2017 1 kayıt (commit)
    • Caolán McNamara's avatar
      request installation of langpack via packagekit · 1c7d3390
      Caolán McNamara yazdı
      if ui is set to track the locale automatically and the current locale
      has no match in installed resources but has a match in the list of
      languages that libreoffice was compiled to contain
      
      so e.g. de_AT locale shouldn't trigger the installation of anything if
      langpack-de is already installed and yue_HK shouldn't trigger install
      of anything cause that not supported (at time of writing) for libreoffice
      
      put Fedora/RHEL/Ubuntu naming schemes in here.
      
      I moved the lang code from svl to svtools so I could use the restart dialog
      to prompt to restart after the langpack is installed, but packagekit's blocking
      mode seems to be no longer blocking and control returns immediately which is a
      change since the last time I played with this stuff, so drop the restart thing
      for now. The lack of a blocking modal also makes the "run this on idle when there's
      a toplevel window up and running" a bit futile, but lets keep that for now anyway.
      
      caolanm->rene: I know you'd disable this anyway, so Debian is left out, there's
      also config key Office/Common/PackageKit/EnableLangpackInstallation to disable
      this too.
      
      Change-Id: Ice731be539850338ccdd8af87839e0b4d83f01e7
      Reviewed-on: https://gerrit.libreoffice.org/46856Tested-by: 's avatarJenkins <ci@libreoffice.org>
      Reviewed-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      Tested-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      1c7d3390
  25. 14 Ara, 2017 1 kayıt (commit)
  26. 09 Ara, 2017 1 kayıt (commit)
  27. 08 Ara, 2017 1 kayıt (commit)
  28. 06 Ara, 2017 1 kayıt (commit)
  29. 05 Ara, 2017 2 kayıt (commit)
  30. 23 Kas, 2017 1 kayıt (commit)
  31. 08 Kas, 2017 1 kayıt (commit)
    • Stephan Bergmann's avatar
      Drop HAVE_GCC_ATTRIBUTE_WARN_UNUSED_STL · e62b087f
      Stephan Bergmann yazdı
      For one, loplugin:unusedvariablecheck does not merely check for unused variables
      with types from the standard library since
      fe216494 "teach unusedvariablecheck plugin about
      SfxPoolItem subclasses", so disabling loplugin:unusedvariablecheck based on
      HAVE_GCC_ATTRIBUTE_WARN_UNUSED_STL is wrong.
      
      For another, I have seen no standard library implementation that decorates its
      types with such "warn-if-unused" attributes, and
      <http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2017/p0600r0.pdf>
      "[[nodiscard]] in the Library" (which proposes to add the corresponding C++17
      attribute to just a few select functions and no types at all) makes it appear
      unlikely that will happen.
      
      Change-Id: I0a7759e1caf3e3137057c9689080948a4d6747e0
      e62b087f