Change-Id: I0026e0a1890b984675e82ab7be5cdbc56e142a87
Reviewed-on: https://gerrit.libreoffice.org/36722Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

As suggested at <https://gerrit.libreoffice.org/#/c/36142/>, and it
indeed matches the Word behavior.

Change-Id: I1ba5b70fc5a7acab52fa4baf816e9f6cd2f913ba
Reviewed-on: https://gerrit.libreoffice.org/36719Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Project: help  1b5413f89863008ab15c2233506298e1a657f421

HID bookmark is not localizable

Change-Id: Iae1909e7afc7504fb53f8fa3d861419a3415ea25

Change-Id: Ib7a9b1b0802ca751da258065e89b412b090bb672
Reviewed-on: https://gerrit.libreoffice.org/36718Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

By default nothing changes. But users have the possibility to avoid the
confusing (?) Merge Cell dialog. Also, when the dialog is disabled, users
may want to set the EmptyMergedCells to true, to mimic Excel's behaviour.

Change-Id: I9656ae59199bb697c45786dd478379f5c89eb08f
Reviewed-on: https://gerrit.libreoffice.org/36679Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>

Change-Id: Iaada61d19c601aa01bba85323e815872feae2c4a
Reviewed-on: https://gerrit.libreoffice.org/36705Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
Tested-by: Heiko Tietze <tietze.heiko@googlemail.com>

ever since it was added in

   commit c8330937
   Author: Vladimir Glazounov <vg@openoffice.org>
   Date:   Wed Apr 11 16:52:58 2007 +0000
   INTEGRATION: CWS hedaburemove01 (1.1.2); FILE ADDED

Change-Id: Iceb44ea4da620e1e7b9c9494486954db9e5d7959
Reviewed-on: https://gerrit.libreoffice.org/36691Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I79b82d37e6cf4c1dde474f0f90b6370c2359a0b3
Reviewed-on: https://gerrit.libreoffice.org/36673Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

and make the memory management a little more obvious with
std::unique_ptr.

Change-Id: Ie0dad6a52f70896e144cc396d39c10e9cbff4316
Reviewed-on: https://gerrit.libreoffice.org/36667Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I6650d39f8f4c2f271e3936d590fe7eb500e674fe
Reviewed-on: https://gerrit.libreoffice.org/36665Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I5e9f2552f83e72d1f6eb1a12df19c0fdfa012e31

Translated leftovers in:
- svx/source/inc/ which slipped through on the commit
324adfcc (and a correction of "ist" to "list"
in an unrelated comment)

- svx/source/form/formcontroller.cxx which slipped through on the commit
ea8f69e4

Change-Id: Ida5b3d0e685558bc2d8facba02fa80ae9e92eab3
Reviewed-on: https://gerrit.libreoffice.org/36648Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Project: help  9ed1958ba7f75bb4184f09d79814849d06313d72

I don’t think Macs have Control keys…

Change-Id: I808fd2b09a4b61b726f090d2f0c214d3ee842d04

Change-Id: I384bf36a79adccdccdecb836b122958ce925c376
Reviewed-on: https://gerrit.libreoffice.org/36628Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

and then forgotten again

Change-Id: Id94639415bd1679b67d5d3094dee8b8f8f3d3167
Reviewed-on: https://gerrit.libreoffice.org/36690Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

this all is a hold over from the initial tentitive changeover to using it in
the first place

Change-Id: I70e28023798d8ea637c61f9fac252bc698e8100d
Reviewed-on: https://gerrit.libreoffice.org/36683Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

In the assumption that users who more use a pointer device to enter
references are also likely less familiar with the difference between
relative and absolute sheet references and its implication when copying
sheets, which some other spreadsheet software doesn't offer.

Change-Id: Ia1e16d1fef47429d4f4c100cac699bbc446ba6c9

Change-Id: I97d3391d6d9d59626bace2ce0cf2b5d9b45d9261
Reviewed-on: https://gerrit.libreoffice.org/36627Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

If a pivot table only has a row field and data field, creating a
pivot chart crashes. The crash happens when setting the labels
for a data series as there is none set. This fixes the problem
with setting a fixed "Total" label in this case.

Change-Id: I870c5c635ee64abb635296329dcfc277834f8f03
Reviewed-on: https://gerrit.libreoffice.org/36626Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>

This changes tests so that we fill example data and create a new
pivot table from scratch, and create a new pivot chart using that
pivot table.
This enables that we test different cases without an example
document which creates a pivot table for us.
In addition add two test cases:
- pivot table with one column field and one data field
- pivot table with one row field and one data field (disabled, as
  it currently crashes)

Change-Id: I8397a598857953e0b2d7da8dd91d7709a3495b71
Reviewed-on: https://gerrit.libreoffice.org/36625Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>

With LOK, it steals focus from the user, and the user has no chance to get the
focus back again.

Change-Id: Ie54a377a9543ddda88e739fe1ebdfcb04d000ea7
Reviewed-on: https://gerrit.libreoffice.org/36686Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit 68e50768)
Reviewed-on: https://gerrit.libreoffice.org/36687Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>

Change-Id: I9c8e00be8823f8f2cbf1368b33e2f18b3a386a88

Change-Id: I406d2418413729479fd96f9b4918c3e0a2b03e9f

Change-Id: Ia854d1d6a8bd5f5f9a87aebb57337a992606c03f

Change-Id: I97ff3f7c4ebfb7c9db2ceed234da1095ed0eeed6

Change-Id: I4e3db61fdfe0b984d36b4f67f8e891da48f79ddb

Change-Id: I079dbe10bc5ef335354bcc94354644f0ec0c3c5a
Reviewed-on: https://gerrit.libreoffice.org/36685Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I384e3ccb6bfaf491a4616ee89c714a510f1f670b

Change-Id: I40e49716c3188f403f7bbe15bb0dca820eb353a9

Actually one case was missing.

Change-Id: I08895f730c48d1d4bef6965ff39595ac7db5b42a

Change-Id: Ic3962728abc31accc7dd51b5291c58c5bfaa21a6

Change-Id: I96e1bd4000f4ade6ccfac53c57653772b249df99
Reviewed-on: https://gerrit.libreoffice.org/36678Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

This commit adds the BottomSheetBehavior to the
formatting toolbar appearing from bottom.
CoordinatorLayout replaces the RelativeLayout in activity_main
and bottom toolbar is made the child of it.
Also, Add 'adjustPan' option to LibreOfficeMainActivity's
windowSoftInputMode flag so as to prevent soft keyboard
from pushing the views up

Change-Id: Ic9999c1177ac238bc7c482a69daec4e629fe6d93
Reviewed-on: https://gerrit.libreoffice.org/35768Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I49f155d4311de4b9c298a494ebdff7e53eb49e3b

Change-Id: Iae27da322c6ede592e6b268fb2210d3525ed22cc
Reviewed-on: https://gerrit.libreoffice.org/36677Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

...so allow for that by reporting failure to call
osl::DirectoryItem::getFileStatus from TaskManager::getv, and make
XResultSet_impl::OneMore ignore such lost entries.  While there may be
legitimate cases where getFileStatus in getv would fail (and thus SAL_INFO would
be more appropriate), the broken, non-atomic design means that such failure is
likely unexpected (and worth a SAL_WARN).

Occasionally ran into this when building UBSan builds, which sometimes failed in
one of the extras/Gallery_*.mk like

> ucb/source/ucp/file/filrset.cxx:235:60: runtime error: load of value 96, which is not a valid value for type 'bool'
>     #0 0x7f079bff575e in fileaccess::XResultSet_impl::OneMore() ucb/source/ucp/file/filrset.cxx:234:60
>     #1 0x7f079bff823e in fileaccess::XResultSet_impl::next() ucb/source/ucp/file/filrset.cxx:288:16
>     #2 0x7f0800a109a8 in Gallery::ImplLoadSubDirs(INetURLObject const&, bool&) svx/source/gallery2/gallery1.cxx:291:36
>     #3 0x7f0800a0c88c in Gallery::ImplLoad(rtl::OUString const&) svx/source/gallery2/gallery1.cxx:202:5
>     #4 0x7f0800a0bfa5 in Gallery::Gallery(rtl::OUString const&) svx/source/gallery2/gallery1.cxx:167:5
>     #5 0x522e13 in createGallery(rtl::OUString const&) svx/source/gengal/gengal.cxx:62:16
>     #6 0x52979a in createTheme(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, std::__debug::vector<INetURLObject, std::allocator<INetURLObject> >&, bool) svx/source/gengal/gengal.cxx:76:16
>     #7 0x52853d in GalApp::Main() svx/source/gengal/gengal.cxx:318:9
>     #8 0x7f080f6f8c36 in ImplSVMain() vcl/source/app/svmain.cxx:191:35
>     #9 0x7f080f706571 in SVMain() vcl/source/app/svmain.cxx:229:16
>     #10 0x56aa0a in sal_main() vcl/source/salmain/salmain.cxx:41:12
>     #11 0x56a99f in main vcl/source/salmain/salmain.cxx:35:1
>     #12 0x7f07fbaf5400 in __libc_start_main /usr/src/debug/glibc-2.24-33-ge9e69e4/csu/../csu/libc-start.c:289
>     #13 0x42e219 in _start (instdir/program/gengal.bin+0x42e219)
>
> SUMMARY: AddressSanitizer: undefined-behavior ucb/source/ucp/file/filrset.cxx:235:60 in
> solenv/gbuild/Gallery.mk:58: recipe for target 'workdir/Gallery/education.done' failed

presumably because some other part of the build changed instdir/share/config/
in parallel.  (And doing

> while (touch instdir/share/config/TEST && rm instdir/share/config/TEST); do :; done

in parallel to 'make extras' indeed causes this issue to occur easily.)

Change-Id: I115ac727f99eed209b223d828c33060b275daaaa

likely a remnant of (Uni)String to OUString

Change-Id: I431723d7c390f1396855f91c26a9b72a417f7dbc

Change-Id: Ifcd79abe8641894be836642586c65180cbaad8aa
Reviewed-on: https://gerrit.libreoffice.org/36681Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

currently the build runs out of space

Change-Id: I24a68051b7fd1df7c55849f27aa43cedc9909b1a
Reviewed-on: https://gerrit.libreoffice.org/36682Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I39b84b1d0272c2e8aa606e8b2e9ab0d2d88c3586
Reviewed-on: https://gerrit.libreoffice.org/36671Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>