Change-Id: I73fbad626ab1d37448ea12052a2fbafab5656fc7
Reviewed-on: https://gerrit.libreoffice.org/60971
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

but actually this object should be held by rtl::Reference

Change-Id: Iabf068bd909201af5df6f987c6dcdb64679fefbd
Reviewed-on: https://gerrit.libreoffice.org/60970
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I299e97c276b60be86491bfeee22d46774739ca44
Reviewed-on: https://gerrit.libreoffice.org/60969
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I8ee34ced61a23d7ade71b25f547c607cd4fe37bb
Reviewed-on: https://gerrit.libreoffice.org/60968
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

* Update helpcontent2 from branch 'master'
  - Add debug info for HID in new help
    
    To enable Help page debug, add '&Debug=1' to the page URL.
    
    This patch pass the HID in the URL of the help page and
    displays it in the debug div in the bottom of the page.
    It should help to locate missing pages for a given HID.
    
    Change-Id: I671feb2dc34baaef5230028ba918a407d4cfea76
    Reviewed-on: https://gerrit.libreoffice.org/60843
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

According to idl, removeByName() should throw
NoSuchElementException on invalid element, but it does not

Change-Id: I4ae84cd8c5a0f46bedeb3df6da4dee076888295f
Reviewed-on: https://gerrit.libreoffice.org/60978
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: I44c2fd97beeaa328774e241459b2a631b6a72030
Reviewed-on: https://gerrit.libreoffice.org/60794Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

AccessibleTextHelper already queues notifications, so another queue in
editeng isn't needed.

Change-Id: I31c69a21e2379da99cba559208eb5475ddccddfe
Reviewed-on: https://gerrit.libreoffice.org/60918
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Output current UI file being processed, in case any random exception
pops up.

Change-Id: If6937f70718cc801494f424f7e09e9cb8c8758f0
(cherry picked from commit fb5d849cdeebe5299da399efc9d0ca36b6fc192b)
Reviewed-on: https://gerrit.libreoffice.org/60964
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: I222179c92cda3e0b2503544b7f120f35957265ac
Reviewed-on: https://gerrit.libreoffice.org/60815
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: Ide5e7dd75ddb30eb1db61406c6811c6846d603bd
Reviewed-on: https://gerrit.libreoffice.org/60694
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: I59aa026217ed250fab68afc4aa0086d4d1300eac
Reviewed-on: https://gerrit.libreoffice.org/60627
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Id6f7bf29ff957455bfb2e1687a285a45529b77a0
Reviewed-on: https://gerrit.libreoffice.org/60966
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I83241bd2ed172594704f4b115b584dc39b234086
Reviewed-on: https://gerrit.libreoffice.org/60959
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I30ae51c05dfbee5fc754d26d3de3e41c30834b31
Reviewed-on: https://gerrit.libreoffice.org/60952
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ib759d5bcc7ce7cd9ea8ad752e5363375fa24e8f0
Reviewed-on: https://gerrit.libreoffice.org/60957
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: If12889ffe320c6a2e2808709ce53438e92077a58
Reviewed-on: https://gerrit.libreoffice.org/60958
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

and simplify usage in SvxIconChoiceCtrl_Impl

Change-Id: If72d14be66cdf3135ad4edf5502a478a0857d7dd
Reviewed-on: https://gerrit.libreoffice.org/60951
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I113160675aa7af0a3a425fe0cab4f68ee24adf27
Reviewed-on: https://gerrit.libreoffice.org/60956
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I8d3f700fcdcb853518729f966dd8651579676a36
Reviewed-on: https://gerrit.libreoffice.org/60954
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: If54a2c546cb3c65417c1ebcc4957cce41597dd07
Reviewed-on: https://gerrit.libreoffice.org/60955
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I95817a03afedbee4ffb28041a9834e591356102d
Reviewed-on: https://gerrit.libreoffice.org/60953
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Use range-based loop or replace with STL functions.

Change-Id: I2af2d739d55a0bf480bb6e9d57b49dd16806af30
Reviewed-on: https://gerrit.libreoffice.org/60734
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Deciding when to and when not to deduplicate repeated direct formatting
of paragraph / character properties is stricky, this bug is about a case
when deduplication should happen and did not, since commit
1970a686 (tdf#113408 RTF import style
dedup: separate paragraph and character handling, 2017-10-31).
Especially that deduplication works in both directions: it should remove
properties which are duplicated and also should insert explicit default
values for not repeated properties.

Fix the problem by making the getDefaultSPRM() aware of the context
(which style type it deals with), and then by making sure that only
default properties relevant for the given style type are inserted.

Change-Id: I35b6599cc47fa51b8754fd921c61a3b31a283547
Reviewed-on: https://gerrit.libreoffice.org/60946Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins

Change-Id: Iee80ba5e1dab7d36798dc3e9dcbae3dfc86e86a0

Change-Id: I28f0e7b964a229320ede7accfd3a98e35ef113b7

Change-Id: Iec5e591f51ab13efa4b014b82df213e91eb5b793
Reviewed-on: https://gerrit.libreoffice.org/60949
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: Icac79eb1c0c47388f96d37d2921c81fb6c848607
Reviewed-on: https://gerrit.libreoffice.org/60948
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: I766ae652ef08c865eb5faa0f2d53220ccb00c828

Change-Id: I1e8c28f477602c7578ca7e40bd7d14550dc1aaf8
Reviewed-on: https://gerrit.libreoffice.org/60930
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I22ba2c8aec235e34cd7835b8a0a716bf3057db7a
Reviewed-on: https://gerrit.libreoffice.org/60837
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: I2e0c060a86cd199a640589a7599fa5f01ef77e3b
Reviewed-on: https://gerrit.libreoffice.org/60943
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Regression from commit 221b0ab1 ("WIN use Reschedule instead
of own dispatch loops"). This limit the maximum reschedule loops
as the original code did. There is still a busy loop when opening
the print dialog, as it was before the patch, but this at least
gets printing started.

Change-Id: If867329b82b13c898bb15b08584244084488a66c
Reviewed-on: https://gerrit.libreoffice.org/60310
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Change-Id: I6a2bcdd8403494490a44c11179bf87411f73d32a

Including:

* expanding STDAPI to its definition (as per
  <https://msdn.microsoft.com/library/ms686631(vs.85).aspx> "STDAPI"), to add
  __declspec(dllexport) into its middle, in
  extensions/source/activex/so_activex.cxx; as discussed in the comments at
  <https://gerrit.libreoffice.org/#/c/60691/> "Get rid of Windows .def files in
  setup_native, use __declspec(dllexport)", having a function both listed in a
  .def file EXPORTS and marking it dllexport is OK, and the latter helps the
  heuristics of loplugin:external; however, the relevant functions in
  extensions/source/activex/so_activex.cxx probably don't even need to be
  exported in the first place?

* follow-up loplugin:salcall in sal/osl/w32/file-impl.hxx

Change-Id: Ida6e17eba19cfa3d7e5c72dda57409005c0a0191
Reviewed-on: https://gerrit.libreoffice.org/60938
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I4132e02ce9a4eb509a2e70a705068102f95ffd3e
Reviewed-on: https://gerrit.libreoffice.org/60937
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

icons are off by default so not usually seen

Change-Id: I6076fd87250fc4595d279c830e14779147b7857a
Reviewed-on: https://gerrit.libreoffice.org/60935Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I021b378b2ae001a38c8f84a71e90ec4f14c905e6
Reviewed-on: https://gerrit.libreoffice.org/60928
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

This way we don't have to search the whole list for a higher
priority event, if an immediate Task is found. This probably
helps bugs like tdf#119724 and tdf#119428.

Change-Id: Ic5685193d1bedb6996cf46f0ee2cba42190ff7cc
Reviewed-on: https://gerrit.libreoffice.org/60572
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Change-Id: I3a52b0e2517cfd88f661dde2b01b2e6bc6913ba2
Reviewed-on: https://gerrit.libreoffice.org/60927
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>