- 13 Eyl, 2017 13 kayıt (commit)
-
-
Stephan Bergmann yazdı
...motivated by <https://gerrit.libreoffice.org/#/c/41565/2> adding dead code at the end of a switch statement, after the last case's "break". -Wunreachable-code appears to work well on Clang, while it appears to have no effect on GCC. Most of the affected places are apparently temporary/TODO/FIXME cases of disabling code via "if (false)", which can be written with an extra set of parentheses as "if ((false))" to silence -Wunreachable-code on Clang (which thus needed loplugin:unnecessaryparen to be adapted accordingly). In some cases, the controlling expression was more complex than just "false" and needed to be rewritten by taking it out of the if statement to silence Clang. One noteworthy case where the nature of the disabled code wasn't immediately apparent: Sep 12 16:59:58 <sberg> quikee, is that "if (false)" in ScExponentialSmoothingDialog::ApplyOutput (sc/source/ui/StatisticsDialogs/ExponentialSmoothingDialog.cxx) some work-in- progress or dead code? Sep 12 17:02:03 <quikee> sberg: WIP, but you can remove it Sep 12 17:04:47 <sberg> quikee, I'll wrap the false in an extra set of parentheses for now, to silence -Wunreachable-code (I wouldn't want to remove it, as I have no idea whether I should then also remove the "Initial value" comment preceding it) Sep 12 17:07:29 <quikee> sberg: both are different ways to calculate the "intital value"... so no Another case where the nature of the dead code, following while (true) loops without breaks, is unclear is sd/source/ui/remotecontrol/BluetoothServer.cxx, where I added TODO markers to the workarounds that silence the warnings for now. basic/source/sbx/sbxvalue.cxx had a variable of type double, of automatic storage duration, and without an initalizer at the top of a switch statement. Clang warning about it is arguably a false positive. Apart from that, this didn't find any cases of genuinely dead code in the existing code base. Change-Id: Ib00b822c8efec94278c048783d5997b8ba86a94c Reviewed-on: https://gerrit.libreoffice.org/42217Tested-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
-
Damjan Jovanovic yazdı
to disposed, the relevant variables (bDisposed and bInDispose) are written to outside a synchronized block. The equivalent C++ implementation in main/cppuhelper/source/implbase.cxx, method WeakComponentImplHelperBase::dispose(), already does this. Patch by: me (cherry picked from commit 2d382cef) Change-Id: I6c3e2ef78bc3c945245fe9fb7b6b713eb83710be Reviewed-on: https://gerrit.libreoffice.org/42189Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
-
Caolán McNamara yazdı
Change-Id: I9dc7301bed990838ac5fbb3bb5394bae5171bc22
-
Stephan Bergmann yazdı
Change-Id: Ia37347108f9fe7094f055a5c6f2ec9511c3aff1d
-
Jan Holesovsky yazdı
Change-Id: I6f0f18629c6a61b6a4c52c2b16cc7b45525a5259
-
Stephan Bergmann yazdı
This reverts commit 274b2aee, which breaks in external/icu on macOS, <https://ci.libreoffice.org/job/lo_tb_master_mac/20605/>: > digitlst.cpp:497:8: error: unknown type name 'locale_t' > static locale_t gCLocale = (locale_t)0; > ^
-
Noel Grandin yazdı
since it's the last row that the pattern applies to Change-Id: I80d6d5787768b1e98e958d7adc4c13c37c560ccd Reviewed-on: https://gerrit.libreoffice.org/42211Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Jan Holesovsky yazdı
This was the hard part of the fix :-) Change-Id: Iae335c9d41d9b3420472b5d02113e2b42ab825da Reviewed-on: https://gerrit.libreoffice.org/42203Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
-
Jan Holesovsky yazdı
Change-Id: Ibea54f857e78a850ea05643743884ae2157dae57 Reviewed-on: https://gerrit.libreoffice.org/42202Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
-
Stephan Bergmann yazdı
This reverts commit fc670f63, which is no longer needed after 08e78607 "Make reading UTF-8 strict". The bug doc fdo67610-1.doc (aka <https://bugs.documentfoundation.org/attachment.cgi?id=83417>) now opens fine without hitting the assert in OUString::toUtf8.
-
Stephan Bergmann yazdı
Consider non-shortest forms, surrogates, and representations of values larger than 0x10FFFF (which can even cover five or six bytes, for historical reasons) as "invalid" (they used to be considered as "undefined" instead). This is in response to fc670f63 "svtools: HTML import: don't put lone surrogates in OUString" (which can now be reverted again in a follow-up commit). My fear would have been that some places in the code rely on the original, relaxed handling, but at least 'make check' still succeeded for me. Change-Id: I017e6c04ed3c577c3694b417167f853987a1d1ce
-
Tor Lillqvist yazdı
I hit it multiple times and have no interest in figuring out why. Or time. Change-Id: I3f22c8b62fdcf987b760ac16bfe8a21a8870d33e Reviewed-on: https://gerrit.libreoffice.org/42212Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
-
Justin Luth yazdı
The formula previously divided by 1000, which was a common dxaGoal width from MSO2003 (based on round-trip testing). But for the bug document, that formuala didn't work. An "assert (false)" with "make check" indicates that only unit test n757118.doc contains a percentage-derived width, and that test also has dxaGoal == 1000. So, my pool of test documents is pretty small, but it seems logical that this is a better formula since it fixes an obviously bad example, and explains why it "worked before". Change-Id: I7bf666e88e7e59e06bbfa3c0961fa8eabbc80310 Reviewed-on: https://gerrit.libreoffice.org/41957Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org>
-
- 12 Eyl, 2017 27 kayıt (commit)
-
-
Olivier Hallot yazdı
Project: help 42fbc7890755b7f6322be2fc2c7bc934d3c07b1e TDF#97745 Add support custom search in helponline Added some language support for the helponline global search Each custom search engine of google has a unique token, which configuration is handled by CSE owner. The CSE attempt to seach in helponline in the page language. If a page is already indexed, it shows what it has. If not, pages indexed from the *.libreoffice.org domain and wiki.tdf.org are shown. The CSE prevents display of indexed pages of other suites. Change-Id: I133e1a7af867c2380ccb1f20c483af63337a58b9 Reviewed-on: https://gerrit.libreoffice.org/42218Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
-
Eike Rathke yazdı
"The file and this data structure is not standardized. Don't rely on it. It can go away without warning." ... And since glibc 2.26 it's gone. https://ssl.icu-project.org/trac/ticket/13329 Change-Id: Iaf595b9c1be4eaab4306acb2c63c5a13dcb7a4e3 Reviewed-on: https://gerrit.libreoffice.org/42219Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
-
Jan Holesovsky yazdı
Change-Id: I765e1cc25ac79d2cebf54f7a247a200647c984da Reviewed-on: https://gerrit.libreoffice.org/32296Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
-
Julien Nabet yazdı
Change-Id: I6d9426c66b0952a3eac7d418a187ec4e3759eea6 Reviewed-on: https://gerrit.libreoffice.org/42221Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
-
Julien Nabet yazdı
Change-Id: I43ad46f95538477ad5d9fae330f1e01892cc41fb Reviewed-on: https://gerrit.libreoffice.org/42220Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
-
Muhammet Kara yazdı
Also: * Remove unnecessary frame "contents" * Remove unnecessary alignment * Remove extra column from the left grid (grid4) * Move all into a new grid for better sizing Change-Id: I4d805a800ca6e487bf788cd9401e5f77303ddd1d Reviewed-on: https://gerrit.libreoffice.org/42186Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
-
Caolán McNamara yazdı
Change-Id: Ic6872ec80cc4a36192fe23f9abf76c4fa10b94bd Reviewed-on: https://gerrit.libreoffice.org/42213Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Miklos Vajna yazdı
Minimal effort to not loose content, no actual list formatting yet. Change-Id: Ic49ed2f1877c608fc4af5d4aa7ebb3b49908fd86 Reviewed-on: https://gerrit.libreoffice.org/42214Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
-
Miklos Vajna yazdı
EPUBExportUIComponent::execute() still needs to launch an actual dialog, but otherwise it has enough functionality that only tweaking maFilterData is necessary in the UNO component to pass custom filter options to the exporter. Change-Id: I95af024f5babd66a5aa0b446550f4f0fec45ef43 Reviewed-on: https://gerrit.libreoffice.org/42204Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
-
Caolán McNamara yazdı
Change-Id: I3cf6df721f89493a527a0b65b24354d3e6135c68
-
Eike Rathke yazdı
Change-Id: Iac2b892f3b3e4146101a99d1febb6110c83e56ed
-
Eike Rathke yazdı
LanguageTagImpl::simpleExtract() needs to handle them because for known tags mpImplLangtag is not used to extract language, country, region; which for the malformed 'es-ES_tradnl' wouldn't work anyway. Change-Id: I1efcf32e90e513d5af4624c7ae15848d1fe951a7
-
Caolán McNamara yazdı
Change-Id: Ie8cb8e1bfb32669c2b4487f02d107b08c60b2399
-
Caolán McNamara yazdı
and then the manual removal of ,|. is unnecessary Change-Id: I40d96beb895f815bb7aad9c0f36c3722b614f9a2
-
Tamás Zolnai yazdı
Change-Id: I3477cd17f679bdfefb9340656999630380713d3f Reviewed-on: https://gerrit.libreoffice.org/42201Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
-
Stephan Bergmann yazdı
Change-Id: I6fe1690b6f66e31753da993a256b7586478ef4f1
-
Dennis Francis yazdı
GL_MAX_TEXTURE_SIZE in OpenGLSalBitmap::Create() Change-Id: I3d9538cc8004241972bc63d09eeb2914ce511df6 Reviewed-on: https://gerrit.libreoffice.org/42194Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
-
Mike Kaganski yazdı
This also makes ww8 floating-table conversion decision heuristics somewhat closer to OOXML code. Change-Id: I29ca2ebabd1758ad98e02aaf560cf2f44daec3a8 Reviewed-on: https://gerrit.libreoffice.org/42196Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
-
Caolán McNamara yazdı
on arm Change-Id: Ibeca07800d02f5f69046c7bdee57143c78c03aad
-
jan Iversen yazdı
flag for bitcode needed for compiling some of the xml stuff. Change-Id: I0b696279180916757a1996fcc689e69326d22ddb
-
Stephan Bergmann yazdı
...so that that mode can be requested via either 'clang-cl' or 'clang --driver-mode=cl' (where the latter will be needed for --enable-compiler-plugins on Windows). The patch assumes that Clang uses the CL driver mode iff running on Windows. Moves the SHOWINCLUDES_PREFIX check around so that the code dropping -FIIntrin.h from CC can be shared (new CC_PLAIN variable). Change-Id: I85ee19d0e6f8da5136b38f1892e5dd9240df6e9c Reviewed-on: https://gerrit.libreoffice.org/42195Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
-
Fridrich Štrba yazdı
Change-Id: I80b6619a95ccac43a06ffd9b1b64dc1115510d90
-
Fridrich Štrba yazdı
Change-Id: I75e3973ed3fe2489233cdce127a29ff19f604903
-
Fridrich Štrba yazdı
Change-Id: Ie8eb53a915682b7a188b1af4b2d435eb0cc9ff81
-
Armin Le Grand yazdı
TextFillColor was added to TextSimplePortionPrimitive2D, but not added to TextSimplePortionPrimitive2D::operator==, so when this changed it was not detected. Added this. Also added was bFilled and nWidthToFill, all defaulted. This is not accessible for TextDecoratedPortionPrimitive2D and seems to be some special solution just for one special case in DrawPortionInfo, only used from Outliner::DrawingTab, so I am not sure if that change to the central TextSimplePortionPrimitive2D is good and should stay Change-Id: Ief8da74a8b66281e47c4c8a47131125e30b90e7d Reviewed-on: https://gerrit.libreoffice.org/42188Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de> Tested-by: Armin Le Grand <Armin.Le.Grand@cib.de>
-
Caolán McNamara yazdı
but we do mirror the event for normal mousemove, this looks like the real bug here Change-Id: I178d53f5f40dbd075984019e25e6d7665b6cdf87
-
Noel Grandin yazdı
Change-Id: I4f3b0762e197d5397e723aba1dc43e3c857be145 Reviewed-on: https://gerrit.libreoffice.org/42193Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-