1. 13 Kas, 2018 1 kayıt (commit)
  2. 12 Kas, 2018 1 kayıt (commit)
  3. 09 Kas, 2018 1 kayıt (commit)
  4. 08 Kas, 2018 1 kayıt (commit)
  5. 05 Kas, 2018 1 kayıt (commit)
  6. 01 Kas, 2018 1 kayıt (commit)
  7. 31 Eki, 2018 1 kayıt (commit)
  8. 26 Eki, 2018 1 kayıt (commit)
  9. 24 Eki, 2018 3 kayıt (commit)
  10. 22 Eki, 2018 1 kayıt (commit)
  11. 19 Eki, 2018 2 kayıt (commit)
  12. 17 Eki, 2018 1 kayıt (commit)
  13. 15 Eki, 2018 3 kayıt (commit)
  14. 12 Eki, 2018 1 kayıt (commit)
  15. 11 Eki, 2018 1 kayıt (commit)
  16. 09 Eki, 2018 2 kayıt (commit)
  17. 01 Eki, 2018 1 kayıt (commit)
    • Stephan Bergmann's avatar
      Consistently have both copy functions for utl::ConfigurationBroadcaster · f780a64a
      Stephan Bergmann yazdı
      The ctor was added with d1e47b14 "enhance
      useuniqueptr loplugin" apparently because it was needed and the implicitly
      declared one stareted to be defined as deleted, while the assignment op was
      left implicitly defined as deleted (presumably because it wasn't needed anyway).
      
      Adding a non-deleted definition of the assignment op probably is a good move
      towards consistency, and was assumed it could help avoid new Clang trunk
      -Werror,-Wdefaulted-function-deleted in derived ConfigItem
      (include/unotools/configitem.hxx), but which appears not to be the case.
      
      And ConfigurationBroadcaster can't easily switch from copy to move semantics, as
      SdOptionsLayoutItem::Clone needs SdOptionsLayoutItem copy ctor needs
      SdOptionsLayout copy ctor needs SdOptionsGeneric copy ctor needs
      SdOptionsItem copy ctor needs utl::ConfigItem copy ctor needs
      utl::ConfigurationBroadcaster copy ctor.
      
      Change-Id: Ie1f4e72eacb9b6b776103c4cf04a959acfa6648f
      Reviewed-on: https://gerrit.libreoffice.org/61208
      Tested-by: Jenkins
      Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      f780a64a
  18. 19 Eyl, 2018 1 kayıt (commit)
  19. 18 Eyl, 2018 1 kayıt (commit)
  20. 17 Eyl, 2018 1 kayıt (commit)
    • Stephan Bergmann's avatar
      New loplugin:external · 206b5b26
      Stephan Bergmann yazdı
      ...warning about (for now only) functions and variables with external linkage
      that likely don't need it.
      
      The problems with moving entities into unnamed namespacs and breaking ADL
      (as alluded to in comments in compilerplugins/clang/external.cxx) are
      illustrated by the fact that while
      
        struct S1 { int f() { return 0; } };
        int f(S1 s) { return s.f(); }
        namespace N {
          struct S2: S1 { int f() { return 1; } };
          int f(S2 s) { return s.f(); }
        }
        int main() { return f(N::S2()); }
      
      returns 1, both moving just the struct S2 into an nunnamed namespace,
      
        struct S1 { int f() { return 0; } };
        int f(S1 s) { return s.f(); }
        namespace N {
          namespace { struct S2: S1 { int f() { return 1; } }; }
          int f(S2 s) { return s.f(); }
        }
        int main() { return f(N::S2()); }
      
      as well as moving just the function f overload into an unnamed namespace,
      
        struct S1 { int f() { return 0; } };
        int f(S1 s) { return s.f(); }
        namespace N {
          struct S2: S1 { int f() { return 1; } };
          namespace { int f(S2 s) { return s.f(); } }
        }
        int main() { return f(N::S2()); }
      
      would each change the program to return 0 instead.
      
      Change-Id: I4d09f7ac5e8f9bcd6e6bde4712608444b642265c
      Reviewed-on: https://gerrit.libreoffice.org/60539
      Tested-by: Jenkins
      Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      206b5b26
  21. 13 Eyl, 2018 1 kayıt (commit)
  22. 12 Eyl, 2018 1 kayıt (commit)
  23. 11 Eyl, 2018 1 kayıt (commit)
  24. 09 Eyl, 2018 1 kayıt (commit)
    • Noel Grandin's avatar
      Revert "clang-tidy performance-move-const-arg" · fcc31cd0
      Noel Grandin yazdı
      This reverts commit 3d604d1c.
      
      comments from sberg:
      
      I assume dropping the std::move from aCurSel(std::move(aSel)) is caused
      by performance-move-const-arg's warning "if std::move() is called with
      an argument of a trivially-copyable type"
      (<https://clang.llvm.org/extra/clang-tidy/checks/performance-move-const-arg.html>).
      
      For my taste, that approach is too tightly tied to a class's current
      implementation details, something that may change over time.  Imagine a
      trivially copyable class C with a raw pointer member (where the
      lifecycle of the pointed-to object is tracked by some higher-level,
      likely broken protocol).  Now, that protocol is fixed and the raw
      pointer member is replaced with a std::shared_ptr.  C is no longer
      trivially copyable, and the dropped std::move would turn out to be
      beneficial again.
      
      (Also, if Clang and clang-tidy did implement the fixed rules for
      trivially copyable classes from CWG1734/C++17, where a subset of a
      trivially copyable class's copy/move members may be deleted, the above
      rule to warn "if std::move() is called with an argument of a
      trivially-copyable type" would no longer make sense as written; consider
      a trivially copyable class whose copy ctor has been deleted.)
      
      Change-Id: Icb91610e50ed98b8f55fe6323bdfa48c8cb9b4b9
      Reviewed-on: https://gerrit.libreoffice.org/60166
      Tested-by: Jenkins
      Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
      fcc31cd0
  25. 06 Eyl, 2018 1 kayıt (commit)
  26. 05 Eyl, 2018 1 kayıt (commit)
  27. 31 Agu, 2018 1 kayıt (commit)
  28. 29 Agu, 2018 1 kayıt (commit)
  29. 14 Agu, 2018 1 kayıt (commit)
  30. 13 Agu, 2018 1 kayıt (commit)
  31. 02 Agu, 2018 1 kayıt (commit)
    • Gabor Kelemen's avatar
      Add missing sal/log.hxx headers · 82828c6c
      Gabor Kelemen yazdı
      rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it.
      This is a continuation of commit 6ff2d84a to be able to remove those unneeded includes.
      
      This commit adds missing headers to every file found by:
      grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG')
      to directories from test to vbahelper
      
      Change-Id: Ia7f773511624099505d6a36a8d6e23c0cde4a737
      Reviewed-on: https://gerrit.libreoffice.org/58225
      Tested-by: Jenkins
      Reviewed-by: 's avatarMiklos Vajna <vmiklos@collabora.co.uk>
      82828c6c
  32. 29 Tem, 2018 1 kayıt (commit)
  33. 27 Tem, 2018 2 kayıt (commit)
    • Noel Grandin's avatar
      new loplugin:stringloop, and applied in various · c8fa03b1
      Noel Grandin yazdı
      look for OUString being appended to in a loop, better to use
      OUStringBuffer to accumulate the results.
      
      Change-Id: Ia36e06e2781a7c546ce9cbad62727aa4c5f10c4b
      Reviewed-on: https://gerrit.libreoffice.org/58092
      Tested-by: Jenkins
      Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
      c8fa03b1
    • Stephan Bergmann's avatar
      unotools: avoid -Werror=deprecated-copy (GCC trunk towards GCC 9) · 7f0bdd5e
      Stephan Bergmann yazdı
      ...by explicitly defaulting the copy/move functions (and, where needed in turn,
      also a default ctor) for classes that have a user-declared dtor that does
      nothing other than an implicitly-defined one would do, but needs to be user-
      declared because it is virtual and potentially serves as a key function to
      emit the vtable, or is non-public, etc.; and by removing explicitly user-
      provided functions that do the same as their implicitly-defined counterparts,
      but may prevent implicitly declared copy functions from being defined as non-
      deleted in the future.  (Even if such a user-provided function was declared
      non-inline in an include file, the apparently-used implicitly-defined copy
      functions are already include, so why bother with non-inline functions.)
      
      Change-Id: Iaa08ef916a2d266e011a2cb66592b377cb1eb23c
      Reviewed-on: https://gerrit.libreoffice.org/58095
      Tested-by: Jenkins
      Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      7f0bdd5e