Skip to content

C
core
Dal (branch)/etiket değiştir
  1. 17 Eki, 2018 1 kayıt (commit)
  3. 09 Eki, 2018 1 kayıt (commit)
  5. 08 Eki, 2018 1 kayıt (commit)
  7. 10 Eyl, 2018 1 kayıt (commit)
  9. 31 Tem, 2018 1 kayıt (commit)
    • Gabor Kelemen's avatar
      Add missing sal/log.hxx headers · b5867945
      Gabor Kelemen yazdı 
      rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it.
This is a continuation of commit 6ff2d84a to be able to remove those unneeded includes.

This commit adds missing headers to every file found by:
grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG')
to directories from sfx2 to starmath

Change-Id: I40ee7bfae6efdadd862319b7b693ad22c648e1c4
Reviewed-on: https://gerrit.libreoffice.org/58222
Tested-by: Jenkins
Reviewed-by: 's avatarMiklos Vajna <vmiklos@collabora.co.uk>
      b5867945
  11. 13 Tem, 2018 1 kayıt (commit)
  13. 09 May, 2018 1 kayıt (commit)
  15. 05 May, 2018 1 kayıt (commit)
  17. 29 Nis, 2018 1 kayıt (commit)
  19. 10 Nis, 2018 2 kayıt (commit)
  21. 09 Nis, 2018 1 kayıt (commit)
  23. 03 Nis, 2018 1 kayıt (commit)
  25. 22 Mar, 2018 1 kayıt (commit)
  27. 13 Mar, 2018 1 kayıt (commit)
  29. 28 Şub, 2018 1 kayıt (commit)
  31. 20 Şub, 2018 1 kayıt (commit)
  33. 22 Ock, 2018 1 kayıt (commit)
  35. 19 Ock, 2018 1 kayıt (commit)
  37. 10 Ock, 2018 1 kayıt (commit)
  39. 22 Ara, 2017 1 kayıt (commit)
  41. 21 Ara, 2017 2 kayıt (commit)
  43. 14 Ara, 2017 1 kayıt (commit)
  45. 13 Ara, 2017 1 kayıt (commit)
  47. 22 Kas, 2017 1 kayıt (commit)
  49. 26 Eki, 2017 1 kayıt (commit)
  51. 23 Eki, 2017 1 kayıt (commit)
  53. 03 Agu, 2017 2 kayıt (commit)
  55. 21 Tem, 2017 2 kayıt (commit)
    • Caolán McNamara's avatar
      de-hrc various things · 182a74d9
      Caolán McNamara yazdı 
      e.g.  helpid[s].hrc -> helpids.h
and insert include guards where missing

move "ordinary" defines into .hxx files

remove .hrc entries that are used as arguments to dialog factory
when a dedicated method can be added instead

Change-Id: I792fb8eb0adfaa63cf354e6e57401fc943e9196e
      182a74d9
    • Caolán McNamara's avatar
      migrate to boost::gettext · 00657aef
      Caolán McNamara yazdı 
      * all .ui files go from <interface> to <interface domain="MODULE"> e.g. vcl
* all .src files go away and the english source strings folded into the .hrc as NC_("context", "source string")
* ResMgr is dropped in favour of std::locale imbued by boost::locale::generator pointed at matching
  MODULE .mo files
* UIConfig translations are folded into the module .mo, so e.g. UIConfig_cui
  goes from l10n target to normal one, so the res/lang.zips of UI files go away
* translation via Translation::get(hrc-define-key, imbued-std::locale)
* python can now be translated with its inbuilt gettext support (we keep the name strings.hrc there
  to keep finding the .hrc file uniform) so magic numbers can go away there
* java and starbasic components can be translated via the pre-existing css.resource.StringResourceWithLocation
  mechanism
* en-US res files go away, their strings are now the .hrc keys in the source code
* remaining .res files are replaced by .mo files
* in .res/.ui-lang-zip files, the old scheme missing translations of strings
  results in inserting the english original so something can be found, now the
  standard fallback of using the english original from the source key is used, so
  partial translations shrink dramatically in size
* extract .hrc strings with hrcex which backs onto
   xgettext -C --add-comments --keyword=NC_:1c,2 --from-code=UTF-8 --no-wrap
* extract .ui strings with uiex which backs onto
   xgettext --add-comments --no-wrap
* qtz for gettext translations is generated at runtime as ascii-ified crc32 of
   content + "|" + msgid
* [API CHANGE] remove deprecated binary .res resouce loader related uno apis
      com::sun::star::resource::OfficeResourceLoader
      com::sun::star::resource::XResourceBundleLoader
      com::sun::star::resource::XResourceBundle
    when translating strings via uno apis
      com.sun.star.resource.StringResourceWithLocation
    can continue to be used

Change-Id: Ia2594a2672b7301d9c3421fdf31b6cfe7f3f8d0a
      00657aef
  57. 19 Haz, 2017 1 kayıt (commit)
    • Stephan Bergmann's avatar
      Make SfxItemSet ranges correct by construction: Fix static cases · 1e3a00f0
      Stephan Bergmann yazdı 
      ...with the aid of an extended compilerplugins/clang/store/sfxitemsetrewrite.cxx
(which in turn needed a small addition to compilerplugins/clang/check.hxx).

Enable svl::detail::validGap check for the static case, but keep it disabled for
now for the dynamic case.

Change-Id: I4846ba8e99aff94a86518e2cb5044e575093386e
      1e3a00f0
  59. 17 Haz, 2017 1 kayıt (commit)
  61. 16 Haz, 2017 2 kayıt (commit)
    • Stephan Bergmann's avatar
      Make SfxItemSet ranges correct by construction · 13bb5a4b
      Stephan Bergmann yazdı 
      This is a follow-up to 45a7f5b6 "Keep WID ranges
sorted, and join adjacent ones".  While SfxItemSet::MergeRange relies on the
m_pWhichRanges being sorted (and, under DBG_UTIL, asserts if they are not), the
various SfxItemSet constructors curiously only check (via assert or DBG_ASSERT)
that each individual range has an upper bound not smaller than its lower bound.
Arguably, all SfxItemSet instances should fulfill the stronger guarantees
required and checked by MergeRange.

And in many cases the ranges are statically known, so that the checking can
happen at compile time.  Therefore, replace the two SfxItemSet ctors taking
explicit ranges with two other ctors that actually do proper checking.  The
(templated) overload taking an svl::Items struct should be used in all cases
where the range values are statically known at compile time, while the overload
taking a std::initializer_list<Pair> is for the remaining cases (that can only
do runtime checking via assert).  Most of those latter cases are simple cases
with a single range covering a single item, but a few are more complex.

(At least some of the uses of the existing SfxItemSet overload taking a

  const sal_uInt16* pWhichPairTable

can probably also be strengthened, but that is left for another day.)

This commit is the first in a series of two.  Apart from the manual changes to
compilerplugins/clang/store/sfxitemsetrewrite.cxx, include/svl/itemset.hxx, and
svl/source/items/itemset.cxx, it only consists of automatic rewriting of the
relevant SfxItemSet ctor calls (plus a few required manual fixes, see next).
But it does not yet check that the individual ranges are properly sorted (see
the TODO in svl::detail::validGap).  That check will be enabled, and the ensuing
manual fixes will be made in a follow-up commit, to reduce the likelyhood of
accidents.

There were three cases of necessary manual intervention:

* sw/source/core/unocore/unostyle.cxx uses eAtr of enum type RES_FRMATR in
braced-init-list syntax now, so needs explicit narrowing conversion to
sal_uInt16.

* In sw/source/uibase/uiview/formatclipboard.cxx, the trailiing comma in the
definition of macro FORMAT_PAINTBRUSH_FRAME_IDS needed to be removed manually.

* In svx/source/svdraw/svdoashp.cxx, svx/source/svdraw/svdotext.cxx,
sw/source/uibase/app/docstyle.cxx, sw/source/uibase/shells/frmsh.cxx,
sw/source/uibase/shells/grfsh.cxx, and sw/source/uibase/shells/textsh1.cxx,
some comments had to be put back (see "TODO: the replaced range can contain
relevant comments" in compilerplugins/clang/store/sfxitemsetrewrite.cxx).

A few uses of the variadic form erroneously used nullptr instead of 0 for
termination.  But this should have been harmless even if promoted std::nullptr_t
is larger than promoted sal_uInt16, assuming that the part of the nullptr value
that was interpreted as sal_uInt16/promoted int was all-zero bits.  Similarly,
some uses made the harmless error of using 0L instead of 0.

Change-Id: I2afea97282803cb311b9321a99bb627520ef5e35
Reviewed-on: https://gerrit.libreoffice.org/38861Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
Tested-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      13bb5a4b
    • Takeshi Abe's avatar
      starmath: SfxObjectShell::GetMiscStatus() returns sal_uIntPtr · 19e92644
      Takeshi Abe yazdı 
      Change-Id: I2a4fa44414975e7b87c8313d01d7120d13a205e6
Reviewed-on: https://gerrit.libreoffice.org/38790Tested-by: 's avatarJenkins <ci@libreoffice.org>
Reviewed-by: 's avatarTakeshi Abe <tabe@fixedpoint.jp>
      19e92644
  63. 14 Haz, 2017 2 kayıt (commit)
  65. 13 Haz, 2017 1 kayıt (commit)
  67. 19 May, 2017 1 kayıt (commit)