1. 07 Agu, 2018 1 kayıt (commit)
  2. 02 Agu, 2018 1 kayıt (commit)
    • Julien Nabet's avatar
      Reportdesign: try to fix EndListening · c8d8fdea
      Julien Nabet yazdı
      Looking at history:
          reportdesign: sal_Bool->bool
          INTEGRATION: CWS rptchart02 (1.7.4); FILE MERGED
          2008/05/16 12:53:21 oj #i89365# copy props before set args at chart
          2008/05/07 06:56:32 oj #i88842# set databaseprovider at chart
          2008/04/30 13:03:34 oj #i88843# impl clone method
          2008/04/16 06:28:15 oj RESYNC: (1.7-1.8); FILE MERGED
          2008/04/03 06:35:18 oj #i86343# remove unused code
          2008/03/12 09:45:16 oj impl chart handling
      @@ -299,10 +297,9 @@ void OObjectBase::EndListening(sal_Bool /*bRemoveListener*/)
           DBG_CHKTHIS( rpt_OObjectBase,NULL);
           OSL_ENSURE(!m_xReportComponent.is() || isListening(), "OUnoObject::EndListening: not listening currently!");
      +    m_bIsListening = sal_False;
           if ( isListening() && m_xReportComponent.is() )
      -        m_bIsListening = sal_False;
               // XPropertyChangeListener
               if ( m_xPropertyChangeListener.is() )
      Since isListening() returns the value of m_bIsListening
      (see https://opengrok.libreoffice.org/xref/core/reportdesign/inc/RptObject.hxx#79)
      quite suspicious.
      We may think that "m_bIsListening = false;" should be put if we succeed in removing the listener
      382      if ( isListening() && m_xReportComponent.is() )
      383      {
      384          // XPropertyChangeListener
      385          if ( m_xPropertyChangeListener.is() )
      386          {
      387              // remove listener
      388              try
      389              {
      390                  m_xReportComponent->removePropertyChangeListener( OUString() , m_xPropertyChangeListener );
      391              }
      392              catch(const uno::Exception &)
      393              {
      394                  OSL_FAIL("OObjectBase::EndListening: Exception caught!");
      395              }
      396          }
      397          m_xPropertyChangeListener.clear();
      398      }
      Either in the try after the remove or in a finally if we don't want to care about catch part.
      (see https://opengrok.libreoffice.org/xref/core/reportdesign/source/core/sdr/RptObject.cxx#377)
      But considering the 2008 commit and the former state before it, it seems it was on purpose to put m_bIsListening in all cases so...
      Change-Id: I7db8ba45d915e28e707cea61d16ef94fc13b969a
      Reviewed-on: https://gerrit.libreoffice.org/56898
      Tested-by: Jenkins
      Reviewed-by: 's avatarJulien Nabet <serval2412@yahoo.fr>
  3. 31 Tem, 2018 1 kayıt (commit)
  4. 30 Tem, 2018 1 kayıt (commit)
    • Gabor Kelemen's avatar
      Add missing sal/log.hxx headers · c6e5d551
      Gabor Kelemen yazdı
      rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it.
      This is a continuation of commit 6ff2d84a to be able to remove those unneeded includes.
      This commit adds missing headers to every file found by:
      to directories from l10ntools to reportdesign
      Change-Id: Ia2dc93dd848c2dc0b6a8cb6e19849c614ec55198
      Reviewed-on: https://gerrit.libreoffice.org/58205
      Tested-by: Jenkins
      Reviewed-by: 's avatarMiklos Vajna <vmiklos@collabora.co.uk>
  5. 29 Tem, 2018 1 kayıt (commit)
  6. 28 Tem, 2018 1 kayıt (commit)
  7. 25 Tem, 2018 1 kayıt (commit)
    • Armin Le Grand's avatar
      tdf#118730 Correct ReportDesigner Object creation · 96b338e6
      Armin Le Grand yazdı
      This is a follow up problem to removing the old stuff
      that first a SdrPage* at the SdrObjects was set *without*
      the SdrObject being inserted to any SdrObjList. It works
      no longer - the SdrPage which you can get now is the one
      the SdrObject *is* inserted at.
      Solution is to move that stuff - plus other initializations
      which were done in OUnoObject::EndCreate before - to where
      it belongs. This gets rid of OUnoObject::EndCreate
      It makes OUnoObject::impl_setReportComponent_nothrow no
      longer needed due to being used only in one place. All
      initializations move to OUnoObject::CreateMediator which
      anyways needs to be done when a OUnoObject got created.
      Change-Id: I86f968dc6e867c5752d3c8cee1b3b2af57e467c8
      Reviewed-on: https://gerrit.libreoffice.org/57976
      Tested-by: Jenkins
      Reviewed-by: 's avatarArmin Le Grand <Armin.Le.Grand@cib.de>
  8. 24 Tem, 2018 1 kayıt (commit)
  9. 20 Tem, 2018 1 kayıt (commit)
  10. 13 Tem, 2018 1 kayıt (commit)
  11. 03 Tem, 2018 1 kayıt (commit)
  12. 02 Tem, 2018 1 kayıt (commit)
    • Noel Grandin's avatar
      pass OutlinerParaObject around by std::unique_ptr · 50c63e5c
      Noel Grandin yazdı
      SdrText::SetOutlinerParaObject was modified to not check for
      self-assign, and instead assert because
      the existing check was no longer possible.
      Fix bug in SdrUndoObjSetText::Undo(), where it was calling
      SdrText::SetOutlinerParaObject unnecessarily,
      because NbcSetOutlinerParaObjectForText already does that.
      Optimise Outliner::GetEmptyParaObject by creating a new constructor for
      so we don't need to copy the new object we get back from
      GetEmptyTextObject, unnecessarily.
      Change-Id: I57c475583d6c31658c154e24992b3d587bad9841
      Reviewed-on: https://gerrit.libreoffice.org/56730
      Tested-by: Jenkins
      Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
  13. 22 Haz, 2018 1 kayıt (commit)
  14. 15 Haz, 2018 2 kayıt (commit)
  15. 12 Haz, 2018 2 kayıt (commit)
  16. 09 Haz, 2018 1 kayıt (commit)
  17. 07 Haz, 2018 1 kayıt (commit)
  18. 05 Haz, 2018 1 kayıt (commit)
  19. 31 May, 2018 1 kayıt (commit)
    • Armin Le Grand's avatar
      SOSAW080: Cleanup of SdrModel · 4be44a7a
      Armin Le Grand yazdı
      First step: Find all constructors/derivations, mark
      all of them.
      Removed two-value-constructors, adapted code as needed
      Reduced constructors for SdrModel/FmFormModel
      to a single one.
      Removed PathName for List creation, this is not
      needed and anyways all calls used the default
      SvtPathOptions().GetPalettePath(). This is also
      true for usage of IsFuzzing() that is also part
      of the default creation process (without path).
      All usages that need an extra-List were setting
      it after construction explicitely.
      Removed UseExtColorTable. This prevents a single
      List to be not created by default, the ColorTable
      which is replaced later by all callers that used
      this. This is not needed since the default
      ColorTable gets constructed just by default, no
      expensive stuff is triggered (e.g. loading the
      ColorTable). Thus now a default ColorTable is
      created and kept for a short moment, destructed
      again when a ColorTable is explicitely set.
      Doing so is also more safe - it avoids not
      creating a default-ColorTable and then not setting
      one (what would be urgently required).
      Change-Id: I865de4bb23f673c6684d83c2c6390439506dc5b6
      Reviewed-on: https://gerrit.libreoffice.org/55028Tested-by: 's avatarJenkins <ci@libreoffice.org>
      Reviewed-by: 's avatarArmin Le Grand <Armin.Le.Grand@cib.de>
  20. 29 May, 2018 1 kayıt (commit)
  21. 25 May, 2018 2 kayıt (commit)
    • Noel Grandin's avatar
      Improve re-throwing of UNO exceptions · 3a51daea
      Noel Grandin yazdı
      (*) if we are already throwing a Wrapped*Exception, get the
      exception using cppu::getCaughtexception.
      (*) when catching and then immediately throwing UNO exceptions,
      use cppu::getCaughtException to prevent exception slicing
      (*) if we are going to catch an exception and then
      immediately throw a RuntimeException, rather throw a
      WrappedTargetRuntimeException and preserve the original exception information.
      Change-Id: Ia7a501a50ae0e6f4d05186333c8517fdcb17d558
      Reviewed-on: https://gerrit.libreoffice.org/54692Tested-by: 's avatarJenkins <ci@libreoffice.org>
      Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
    • Armin Le Grand's avatar
      SOSAW080: Derive SdrObjGroup from SdrObjList · 4b494222
      Armin Le Grand yazdı
      Also simplify parent/child relationships, get rid
      of double data (SdrPage/Parent infos in SdrObjects,
      also in SdrObjList). This is all not needed - when a
      SdrObject is inserted to a SdrPage, get SdrPage by
      traveling over parents (no double info, member as soon
      as inserted, ...).
      More cleanups/reworks included, will need some more
      cleanups, too.
      Stabilizing: SetRectsDirty/DefaultStyleSheet
      Had to correct the SetRectsDirty stuff for 3D due to
      going down the hierarchy while the 2D implementation
      goes the other direction -> endless loops. Added special
      handling for 3D stuff for now (will be chnaged again when
      SnapRect is no longer needed at SdrObject level).
      Also had to adapt how the DefaultStyleSheet is set at
      incarnated SdrObjects - better: their properties. Since
      we now always have a SdrModel, it is possible to correctly
      initialize with the correct default StyleSheet from that
      This needs to be done after ForceDefaultAttributes and in a
      way that again deletes Items that are set in the StyleSheet.
      This leads to an error in CppunitTest_sd_import_tests where
      I checked tdf100491 - it is okay and thus I change the control
      instance of the imported, XML-dumped file.
      The less hard attributes, the better for Styles in general.
      Cleanup of comments for last two commits
      Corrected SvxShape::getParent()
      Needed to get the direct parent, so test for SdrObject
      first (to get SdrObjGroup/E3DScene), for SdrPage second
      Fixed CppunitTest_sc_subsequent_export_test
      Several problems arose. The used SdrCaptionObj was
      Cloned, but the clone not inserted to a SdrPage. This
      leads to not being able to access a UNO API imlementation
      of the SdrPage (SvxPage) on lower levels.
      It worked before due to SdrObject having a SdrPage*
      additionally to being added to a SdrPage - this is exactly
      the main cleanup this change does.
      Looked for why it is cloned, could see no reasons. The
      SdrCaptionObj exists during all im/export, not difference
      to other SdrObjects (that do not get cloned). It is not
      changed in any way. It *might* be to suppress a crash that
      happened due to UNO API Service emfio/emfio not being
      available in the UnitTest scenario. Interestingly it
      did not crash with the cloned SdrCaptionObj, but the
      Graphic exported was probably wrong.
      Fixed by no longer Cloning the SdrCaptionObj and adding
      emfio/emfio UNO API Service.
      Change-Id: I986586e326b563acebf00d931a7084c6eb09e5f8
      Reviewed-on: https://gerrit.libreoffice.org/54689Tested-by: 's avatarJenkins <ci@libreoffice.org>
      Reviewed-by: 's avatarArmin Le Grand <Armin.Le.Grand@cib.de>
  22. 23 May, 2018 1 kayıt (commit)
  23. 21 May, 2018 1 kayıt (commit)
  24. 17 May, 2018 4 kayıt (commit)
  25. 07 May, 2018 1 kayıt (commit)
  26. 27 Nis, 2018 1 kayıt (commit)
  27. 26 Nis, 2018 1 kayıt (commit)
    • Tomaž Vajngerl's avatar
      [API CHANGE] deprecate XGraphicObjectResolver · 45f20a89
      Tomaž Vajngerl yazdı
      XGraphicObjectResolver was used to get the GraphicObject URL from
      an storage (package) URL. This isn't possible anymore in LO 6.1
      since creating GraphicObject from uniqueID was removed for its
      lifecycle issues. XGraphicObjectResolver is now deprecated and
      when the "resolveGraphicObjectURL" is called, it throws a
      In places where XGraphicObjectResolver was used, we now use the
      XGraphicStorageHandler as the alternative. Both share a common
      implementation so previously we could cast one to the other at
      any time. Now only XGraphicStorageHandler is used.
      GraphicObjectResolver was removed and replaced by the alternative
      GraphicStorageHandler for instance creation - where needed.
      Change-Id: I5d3f759c6f95b7dbe2d93688d99c8aa4899ffa84
      Reviewed-on: https://gerrit.libreoffice.org/53279Reviewed-by: 's avatarTomaž Vajngerl <quikee@gmail.com>
      Tested-by: 's avatarTomaž Vajngerl <quikee@gmail.com>
  28. 25 Nis, 2018 1 kayıt (commit)
  29. 21 Nis, 2018 1 kayıt (commit)
  30. 19 Nis, 2018 1 kayıt (commit)
  31. 16 Nis, 2018 1 kayıt (commit)
    • Noel Grandin's avatar
      follow on for tdf#116981 · 0973e1f4
      Noel Grandin yazdı
      the previous commit 235d61890512894e27f4f81e38a325eee3c67b30, fixed just
      exactly the problem reported in tdf#116981.
      This commit fixes similar issues that may exist elsewhere.
      To recap, this started as a regression from
              commit  433fc221 (patch)
              sal_uIntPtr->sal_Int32 in MultiSelection
      Previously, MultiSelection stored it's values internally as sal_uIntPtr,
      but returned them as long in FirstSelected(), NextSelected(),
      and SFX_ENDOFSELECTION was defined to be ULONG_MAX.
      On 64-bit Linux, sal_uIntPtr is typedefed to sal_uInt64, and ULONG_MAX
      is 2^64, which means that previously, the SFX_ENDOFSELECTION value was
      being converted from 2^64 to -2^63 when it was returned, which was why
      these loop worked.
      So convert SFX_ENDOFSELECTION to SAL_MIN_INT32, so we get a large
      negative value which can never be a valid index, and which works more
      like it did before the regression.
      Also fix as many loops as I can find, to check against
      SFX_ENDOFSELECTION explicitly.
      Change-Id: I947d43dbe23a08105be3d849e33d7e774a8a19fa
      Reviewed-on: https://gerrit.libreoffice.org/52934Tested-by: 's avatarJenkins <ci@libreoffice.org>
      Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
  32. 15 Nis, 2018 1 kayıt (commit)
  33. 13 Nis, 2018 2 kayıt (commit)