Skip to content

C
core
Dal (branch)/etiket değiştir
  1. 01 Agu, 2018 2 kayıt (commit)
  3. 30 Tem, 2018 1 kayıt (commit)
    • Gabor Kelemen's avatar
      Add missing sal/log.hxx headers · bdb0775a
      Gabor Kelemen yazdı 
      rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it.
This is a continuation of commit 6ff2d84a to be able to remove those unneeded includes.

This commit adds missing headers to every file found by:
grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG')
to directories from filter to jvmfwk

Change-Id: I2a73d63f2aaef5f26d7d08957daaa8a30b412ac5
Reviewed-on: https://gerrit.libreoffice.org/58204
Tested-by: Jenkins
Reviewed-by: 's avatarMiklos Vajna <vmiklos@collabora.co.uk>
      bdb0775a
  5. 11 Haz, 2018 1 kayıt (commit)
  7. 15 Nis, 2018 1 kayıt (commit)
  9. 01 Nis, 2018 1 kayıt (commit)
  11. 16 Mar, 2018 1 kayıt (commit)
  13. 05 Mar, 2018 1 kayıt (commit)
  15. 12 Ock, 2018 1 kayıt (commit)
  17. 11 Ara, 2017 2 kayıt (commit)
  19. 07 Ara, 2017 1 kayıt (commit)
  21. 05 Ara, 2017 1 kayıt (commit)
  23. 03 Ara, 2017 1 kayıt (commit)
  25. 30 Kas, 2017 1 kayıt (commit)
  27. 23 Eki, 2017 1 kayıt (commit)
  29. 04 Eki, 2017 1 kayıt (commit)
  31. 22 Eyl, 2017 1 kayıt (commit)
  33. 11 Eyl, 2017 3 kayıt (commit)
    • Stephan Bergmann's avatar
      ...and fix previous commit cd8aeed1 · 31d606d4
      Stephan Bergmann yazdı 
      "Fix data races during CppunitTest_filter_xslt".  (Funny how after each
attempted fix, 'make CppunitTest_filter_xslt' succeeded multiple times in a row,
and only started to fail ThreadSanitizer after pushing the attempted fix.)

Change-Id: I24cab2dd1b068b02ccd4827cf8dcb11cf301d1c0
      31d606d4
    • Stephan Bergmann's avatar
      Fix further data race during CppunitTest_filter_xslt · b58777e6
      Stephan Bergmann yazdı 
      > WARNING: ThreadSanitizer: data race (pid=25817)
>   Write of size 8 at 0x7b50000108a8 by thread T2:
>     #0 memset compiler-rt/lib/tsan/../sanitizer_common/sanitizer_common_interceptors.inc:710 (cppunittester+0x46672b)
>     #1 xsltFreeTransformContext workdir/UnpackedTarball/xslt/libxslt/transform.c:760:5 (libxslt.so.1+0x383a2)
>     #2 XSLT::Reader::execute() filter/source/xsltfilter/LibXSLTTransformer.cxx:338:9 (libxsltfilterlo.so+0x10aa9)
>     #3 salhelper::Thread::run() salhelper/source/thread.cxx:40:9 (libuno_salhelpergcc3.so.3+0x5f6c)
>     #4 non-virtual thunk to salhelper::Thread::run() salhelper/source/thread.cxx (libuno_salhelpergcc3.so.3+0x603c)
>     #5 threadFunc include/osl/thread.hxx:185:15 (libuno_salhelpergcc3.so.3+0x6fac)
>     #6 osl_thread_start_Impl(void*) sal/osl/unx/thread.cxx:237:9 (libuno_sal.so.3+0xeb6b5)
>
>   Previous write of size 4 at 0x7b50000108a8 by main thread (mutexes: write M713392882458407696):
>     #0 XSLT::Reader::forceStateStopped() filter/source/xsltfilter/LibXSLTTransformer.cxx:375:25 (libxsltfilterlo.so+0x1100e)
>     #1 XSLT::LibXSLTTransformer::~LibXSLTTransformer() filter/source/xsltfilter/LibXSLTTransformer.hxx:127:27 (libxsltfilterlo.so+0x18346)
>     #2 XSLT::LibXSLTTransformer::~LibXSLTTransformer() filter/source/xsltfilter/LibXSLTTransformer.hxx:124:48 (libxsltfilterlo.so+0x1850c)
>     #3 cppu::OWeakObject::release() cppuhelper/source/weak.cxx:232:9 (libuno_cppuhelpergcc3.so.3+0x20a527)
>     #4 cppu::WeakImplHelper<com::sun::star::xml::xslt::XXSLTTransformer>::release() include/cppuhelper/implbase.hxx:112:62 (libxsltfilterlo.so+0x18168)
>     #5 non-virtual thunk to cppu::WeakImplHelper<com::sun::star::xml::xslt::XXSLTTransformer>::release() include/cppuhelper/implbase.hxx (libxsltfilterlo.so+0x188fc)
>     #6 com::sun::star::uno::Reference<com::sun::star::xml::xslt::XXSLTTransformer>::~Reference() include/com/sun/star/uno/Reference.hxx:110:22 (libtest_filter_xslt.so+0x14c44)
>     #7 (anonymous namespace)::XsltFilterTest::testXsltCopyOld() filter/qa/cppunit/xslt-test.cxx:201:1 (libtest_filter_xslt.so+0x94c6)
>     #8 void std::__invoke_impl<void, void ((anonymous namespace)::XsltFilterTest::* const&)(), (anonymous namespace)::XsltFilterTest*&>(std::__invoke_memfun_deref, void ((anonymous namespace)::XsltFilterTest::* const&)(), (anonymous namespace)::XsltFilterTest*&) /usr/lib/gcc/x86_64-redhat-linux/6.4.1/../../../../include/c++/6.4.1/functional:227:14 (libtest_filter_xslt.so+0xeeae)
>     #9 std::result_of<void ((anonymous namespace)::XsltFilterTest::* const&((anonymous namespace)::XsltFilterTest*&))()>::type std::__invoke<void ((anonymous namespace)::XsltFilterTest::* const&)(), (anonymous namespace)::XsltFilterTest*&>(void ((anonymous namespace)::XsltFilterTest::* const&)(), (anonymous namespace)::XsltFilterTest*&) /usr/lib/gcc/x86_64-redhat-linux/6.4.1/../../../../include/c++/6.4.1/functional:250:14 (libtest_filter_xslt.so+0xed9d)
>     #10 _ZNKSt12_Mem_fn_baseIMN12_GLOBAL__N_114XsltFilterTestEFvvELb1EEclIJRPS1_EEEDTclsr3stdE8__invokedtdefpT6_M_pmfspclsr3stdE7forwardIT_Efp_EEEDpOS8_ /usr/lib/gcc/x86_64-redhat-linux/6.4.1/../../../../include/c++/6.4.1/functional:604:11 (libtest_filter_xslt.so+0xec7b)
>     #11 void std::_Bind<std::_Mem_fn<void ((anonymous namespace)::XsltFilterTest::*)()> ((anonymous namespace)::XsltFilterTest*)>::__call<void, , 0ul>(std::tuple<>&&, std::_Index_tuple<0ul>) /usr/lib/gcc/x86_64-redhat-linux/6.4.1/../../../../include/c++/6.4.1/functional:933:11 (libtest_filter_xslt.so+0xebeb)
>     #12 void std::_Bind<std::_Mem_fn<void ((anonymous namespace)::XsltFilterTest::*)()> ((anonymous namespace)::XsltFilterTest*)>::operator()<, void>() /usr/lib/gcc/x86_64-redhat-linux/6.4.1/../../../../include/c++/6.4.1/functional:991:17 (libtest_filter_xslt.so+0xeaf6)
>     #13 std::_Function_handler<void (), std::_Bind<std::_Mem_fn<void ((anonymous namespace)::XsltFilterTest::*)()> ((anonymous namespace)::XsltFilterTest*)> >::_M_invoke(std::_Any_data const&) /usr/lib/gcc/x86_64-redhat-linux/6.4.1/../../../../include/c++/6.4.1/functional:1731:2 (libtest_filter_xslt.so+0xe4ba)
>     #14 std::function<void ()>::operator()() const /usr/lib/gcc/x86_64-redhat-linux/6.4.1/../../../../include/c++/6.4.1/functional:2127:14 (libtest_filter_xslt.so+0x1fb3e)
>     #15 CppUnit::TestCaller<(anonymous namespace)::XsltFilterTest>::runTest() workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:175:7 (libtest_filter_xslt.so+0xdc5c)
>     #16 CppUnit::TestCaseMethodFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:32:5 (libcppunit-1.14.so.0+0xd61d2)
>     #17 (anonymous namespace)::Protector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) test/source/vclbootstrapprotector.cxx:39:14 (libvclbootstrapprotector.so+0x1114)
>     #18 CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 (libcppunit-1.14.so.0+0xc7614)
>     #19 (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) unotest/source/cpp/unobootstrapprotector/unobootstrapprotector.cxx:89:12 (unobootstrapprotector.so+0x2204)
>     #20 CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 (libcppunit-1.14.so.0+0xc7614)
>     #21 (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) unotest/source/cpp/unoexceptionprotector/unoexceptionprotector.cxx:63:16 (unoexceptionprotector.so+0x23e9)
>     #22 CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 (libcppunit-1.14.so.0+0xc7614)
>     #23 CppUnit::DefaultProtector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) workdir/UnpackedTarball/cppunit/src/cppunit/DefaultProtector.cpp:15:12 (libcppunit-1.14.so.0+0xa57ad)
>     #24 CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 (libcppunit-1.14.so.0+0xc7614)
>     #25 CppUnit::ProtectorChain::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:86:18 (libcppunit-1.14.so.0+0xc4a96)
>     #26 CppUnit::TestResult::protect(CppUnit::Functor const&, CppUnit::Test*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:182:28 (libcppunit-1.14.so.0+0xf4714)
>     #27 CppUnit::TestCase::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:91:13 (libcppunit-1.14.so.0+0xd5750)
>     #28 CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:30 (libcppunit-1.14.so.0+0xd6d5a)
>     #29 CppUnit::TestComposite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3 (libcppunit-1.14.so.0+0xd6a2e)
>     #30 CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:30 (libcppunit-1.14.so.0+0xd6d5a)
>     #31 CppUnit::TestComposite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3 (libcppunit-1.14.so.0+0xd6a2e)
>     #32 CppUnit::TestRunner::WrappingSuite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:47:27 (libcppunit-1.14.so.0+0x10282c)
>     #33 CppUnit::TestResult::runTest(CppUnit::Test*) workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:149:9 (libcppunit-1.14.so.0+0xf4223)
>     #34 CppUnit::TestRunner::run(CppUnit::TestResult&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:96:14 (libcppunit-1.14.so.0+0x102c76)
>     #35 (anonymous namespace)::ProtectedFixtureFunctor::run() const sal/cppunittester/cppunittester.cxx:316:20 (cppunittester+0x4bd658)
>     #36 sal_main() sal/cppunittester/cppunittester.cxx:466:20 (cppunittester+0x4bc28e)
>     #37 main sal/cppunittester/cppunittester.cxx:373:1 (cppunittester+0x4bbb05)

Change-Id: I2bee009247fe00d5b3386327164766822bfa4bf3
      b58777e6
    • Stephan Bergmann's avatar
      Fix data races during CppunitTest_filter_xslt · cd8aeed1
      Stephan Bergmann yazdı 
      Change-Id: I140ac8a24326959ba341adddbbf505ff16616283
      cd8aeed1
  35. 26 Tem, 2017 1 kayıt (commit)
  37. 06 Tem, 2017 1 kayıt (commit)
  39. 28 May, 2017 1 kayıt (commit)
  41. 10 May, 2017 1 kayıt (commit)
  43. 07 May, 2017 2 kayıt (commit)
  45. 06 Mar, 2017 1 kayıt (commit)
  47. 28 Ock, 2017 1 kayıt (commit)
  49. 26 Ock, 2017 1 kayıt (commit)
    • Stephan Bergmann's avatar
      Remove dynamic exception specifications · e57ca028
      Stephan Bergmann yazdı 
      ...(for now, from LIBO_INTERNAL_CODE only).  See the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html>
"Dynamic Exception Specifications" for details.

Most changes have been done automatically by the rewriting loplugin:dynexcspec
(after enabling the rewriting mode, to be committed shortly).  The way it only
removes exception specs from declarations if it also sees a definition, it
identified some dead declarations-w/o-definitions (that have been removed
manually) and some cases where a definition appeared in multiple include files
(which have also been cleaned up manually).  There's also been cases of macro
paramters (that were used to abstract over exception specs) that have become
unused now (and been removed).

Furthermore, some code needed to be cleaned up manually
(avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no
configurations available that would actually build that code.  Missing @throws
documentation has not been applied in such manual clean-up.

Change-Id: I3408691256c9b0c12bc5332de976743626e13960
Reviewed-on: https://gerrit.libreoffice.org/33574Tested-by: 's avatarJenkins <ci@libreoffice.org>
Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      e57ca028
  51. 25 Ock, 2017 1 kayıt (commit)
  53. 05 Ara, 2016 2 kayıt (commit)
  55. 13 Eyl, 2016 1 kayıt (commit)
    • Stephan Bergmann's avatar
      loplugin:override: No more need for the "MSVC dtor override" workaround · 91dd2db1
      Stephan Bergmann yazdı 
      The issue of 362d4f0c "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.

(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to

  OOO_DLLPUBLIC_CHARTTOOLS    virtual ~CloseableLifeTimeManager();

in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro.  Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)

Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
      91dd2db1
  57. 21 Agu, 2016 2 kayıt (commit)
  59. 19 Agu, 2016 3 kayıt (commit)
  61. 10 Haz, 2016 1 kayıt (commit)