1. 01 Agu, 2018 1 kayıt (commit)
  2. 28 Tem, 2018 1 kayıt (commit)
  3. 26 Tem, 2018 1 kayıt (commit)
  4. 20 Tem, 2018 1 kayıt (commit)
  5. 13 Tem, 2018 1 kayıt (commit)
  6. 09 Tem, 2018 3 kayıt (commit)
  7. 06 Tem, 2018 1 kayıt (commit)
  8. 03 Tem, 2018 1 kayıt (commit)
  9. 29 Haz, 2018 1 kayıt (commit)
  10. 26 Haz, 2018 1 kayıt (commit)
  11. 19 Haz, 2018 1 kayıt (commit)
  12. 18 Haz, 2018 1 kayıt (commit)
  13. 14 Haz, 2018 1 kayıt (commit)
  14. 02 Haz, 2018 1 kayıt (commit)
  15. 31 May, 2018 1 kayıt (commit)
    • Armin Le Grand's avatar
      SOSAW080: Cleanup of SdrModel · 4be44a7a
      Armin Le Grand yazdı
      First step: Find all constructors/derivations, mark
      all of them.
      
      Removed two-value-constructors, adapted code as needed
      
      Reduced constructors for SdrModel/FmFormModel
      to a single one.
      
      Removed PathName for List creation, this is not
      needed and anyways all calls used the default
      SvtPathOptions().GetPalettePath(). This is also
      true for usage of IsFuzzing() that is also part
      of the default creation process (without path).
      All usages that need an extra-List were setting
      it after construction explicitely.
      
      Removed UseExtColorTable. This prevents a single
      List to be not created by default, the ColorTable
      which is replaced later by all callers that used
      this. This is not needed since the default
      ColorTable gets constructed just by default, no
      expensive stuff is triggered (e.g. loading the
      ColorTable). Thus now a default ColorTable is
      created and kept for a short moment, destructed
      again when a ColorTable is explicitely set.
      Doing so is also more safe - it avoids not
      creating a default-ColorTable and then not setting
      one (what would be urgently required).
      
      f23c24a8548d5246b77b1cc359ba89564538e81a
      f124468c3898c5842d37123bdeb87d79a2b19c62
      
      Change-Id: I865de4bb23f673c6684d83c2c6390439506dc5b6
      Reviewed-on: https://gerrit.libreoffice.org/55028Tested-by: 's avatarJenkins <ci@libreoffice.org>
      Reviewed-by: 's avatarArmin Le Grand <Armin.Le.Grand@cib.de>
      4be44a7a
  16. 28 May, 2018 2 kayıt (commit)
  17. 25 May, 2018 2 kayıt (commit)
    • Noel Grandin's avatar
      Improve re-throwing of UNO exceptions · 3a51daea
      Noel Grandin yazdı
      (*) if we are already throwing a Wrapped*Exception, get the
      exception using cppu::getCaughtexception.
      
      (*) when catching and then immediately throwing UNO exceptions,
      use cppu::getCaughtException to prevent exception slicing
      
      (*) if we are going to catch an exception and then
      immediately throw a RuntimeException, rather throw a
      WrappedTargetRuntimeException and preserve the original exception information.
      
      Change-Id: Ia7a501a50ae0e6f4d05186333c8517fdcb17d558
      Reviewed-on: https://gerrit.libreoffice.org/54692Tested-by: 's avatarJenkins <ci@libreoffice.org>
      Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
      3a51daea
    • Armin Le Grand's avatar
      SOSAW080: Derive SdrObjGroup from SdrObjList · 4b494222
      Armin Le Grand yazdı
      Also simplify parent/child relationships, get rid
      of double data (SdrPage/Parent infos in SdrObjects,
      also in SdrObjList). This is all not needed - when a
      SdrObject is inserted to a SdrPage, get SdrPage by
      traveling over parents (no double info, member as soon
      as inserted, ...).
      More cleanups/reworks included, will need some more
      cleanups, too.
      
      Stabilizing: SetRectsDirty/DefaultStyleSheet
      
      Had to correct the SetRectsDirty stuff for 3D due to
      going down the hierarchy while the 2D implementation
      goes the other direction -> endless loops. Added special
      handling for 3D stuff for now (will be chnaged again when
      SnapRect is no longer needed at SdrObject level).
      Also had to adapt how the DefaultStyleSheet is set at
      incarnated SdrObjects - better: their properties. Since
      we now always have a SdrModel, it is possible to correctly
      initialize with the correct default StyleSheet from that
      SdrModel.
      This needs to be done after ForceDefaultAttributes and in a
      way that again deletes Items that are set in the StyleSheet.
      This leads to an error in CppunitTest_sd_import_tests where
      I checked tdf100491 - it is okay and thus I change the control
      instance of the imported, XML-dumped file.
      The less hard attributes, the better for Styles in general.
      
      Cleanup of comments for last two commits
      
      Corrected SvxShape::getParent()
      
      Needed to get the direct parent, so test for SdrObject
      first (to get SdrObjGroup/E3DScene), for SdrPage second
      
      Fixed CppunitTest_sc_subsequent_export_test
      
      Several problems arose. The used SdrCaptionObj was
      Cloned, but the clone not inserted to a SdrPage. This
      leads to not being able to access a UNO API imlementation
      of the SdrPage (SvxPage) on lower levels.
      It worked before due to SdrObject having a SdrPage*
      additionally to being added to a SdrPage - this is exactly
      the main cleanup this change does.
      Looked for why it is cloned, could see no reasons. The
      SdrCaptionObj exists during all im/export, not difference
      to other SdrObjects (that do not get cloned). It is not
      changed in any way. It *might* be to suppress a crash that
      happened due to UNO API Service emfio/emfio not being
      available in the UnitTest scenario. Interestingly it
      did not crash with the cloned SdrCaptionObj, but the
      Graphic exported was probably wrong.
      Fixed by no longer Cloning the SdrCaptionObj and adding
      emfio/emfio UNO API Service.
      
      d139f821a5b39535a3e7b9c6261df7e18f8ae8ac
      910e7f4bc628a715fda7545dffaf3369d5e76ea0
      ca1de01b723051e09ac37d7ec7bba978beea41c5
      3a76da1471dfe75e69847f64a6a3519ad21c8c9c
      
      Change-Id: I986586e326b563acebf00d931a7084c6eb09e5f8
      Reviewed-on: https://gerrit.libreoffice.org/54689Tested-by: 's avatarJenkins <ci@libreoffice.org>
      Reviewed-by: 's avatarArmin Le Grand <Armin.Le.Grand@cib.de>
      4b494222
  18. 23 May, 2018 1 kayıt (commit)
  19. 22 May, 2018 1 kayıt (commit)
  20. 14 May, 2018 1 kayıt (commit)
  21. 07 May, 2018 1 kayıt (commit)
  22. 04 May, 2018 1 kayıt (commit)
    • Armin Le Grand's avatar
      tdf#116879 Separate SdrObjList::Clear() as needed · 0fe7bda2
      Armin Le Grand yazdı
      SdrObjList::Clear() does broadcast the SdrObject
      removals and deletions and a SetChanged() to SdrModel.
      The old version avoided this in the destructor (with
      a comment to not call virtual methods in destructor,
      but  the problem is more that the ::Notify triggered
      works on the SdrPage already in destruction). To allow
      calls to Clear() without broadcasting I splitted this
      to a impClearSdrObjList(bool bBrodacast) and rename
      of ::Clear to ::ClearSdrObjList to get all places.
      Adapted all places in the code as needed, already pre-
      checked on Linux that this fixes the problem.
      
      Change-Id: Iea46758fb6b57f2b3d9896959a35260c6f6d52d5
      Reviewed-on: https://gerrit.libreoffice.org/53839Tested-by: 's avatarJenkins <ci@libreoffice.org>
      Reviewed-by: 's avatarArmin Le Grand <Armin.Le.Grand@cib.de>
      0fe7bda2
  23. 28 Nis, 2018 1 kayıt (commit)
  24. 25 Nis, 2018 1 kayıt (commit)
  25. 21 Nis, 2018 1 kayıt (commit)
  26. 20 Nis, 2018 1 kayıt (commit)
  27. 15 Nis, 2018 1 kayıt (commit)
  28. 11 Nis, 2018 2 kayıt (commit)
  29. 06 Nis, 2018 4 kayıt (commit)
    • Armin Le Grand's avatar
      SOSAW080: Added first bunch of basic changes to helpers · dfefe448
      Armin Le Grand yazdı
      SOSAW080: Make SdrModel& prerequisite to SdrObjects
      
      Added need for SdrModel& in constructors of SdrModel,
      SdrPage, SdrView and SdrObjList. Builds, not finished.
      
      SOSAW080: removed and replaced old SdrModel
      
      Removed and replaced GetModel()/SetModel() in all using
      classes (SdrObject, SdrPage, SdrView), added accessors
      to new referenced SdrModel, adapted all accessing places.
      Refactored/Extended ::Clone and ::operator== for these
      classes to allow cloning objects to a target SdrModel.
      Adapted places where this is done AFAP. Added quite some
      comments (tagged with 'TTTT') where possible further work
      is needed. Builds completely, thus checking in. This does
      not mean that this change is done yet.
      
      SOSAW080: Adapted SdrPage/SdrModel relationship
      
      Also needed to work on copy-construction of SdrPage and hierarchy,
      quite some stuff removed, no copy-constructor anymore, no
      MigrateItemPool stuff. Builds well, test stuck, will need
      some cleanup/finetunung
      
      SOSAW080: Smaller corrections/includes adapted
      
      SOSAW080: Smaller corrections/includes adapted
      
      SOSAW080: Debugging/Stabilizing/MakeUnitTestWork
      
      SOSAW080: Stabilized for UnitTests, cleanups
      
      SOSAW080: Adapted GetObjGraphic to just take a const SdrObject&
      
      SOSAW080: Removed ChangeModel from classes
      
      Classes SvxTextEditSource and SvxDrawPage (including
      TextEditSource stuff) do not need change of SdrModel
      anymore.
      
      SOSAW080: Adapted some comments to make more readable
      
      SOSAW080: Corrected constructor
      
      SOSAW080: getSdrModelFromUnoModel added override marks
      
      SOSAW080: Added missing includes
      
      SOSAW080: Corrected SdrPage constructor
      
      SOSAW080: Corrected some SdrObject::Clone scenarios
      
      Especially when cloning to another SdrModel and taking
      the sdr::properties into account.
      
      SOSAW080: Added include for Mac-Build
      
      SOSAW080: Added Scale to DefaultProperties
      
      If a SdrModel change happens in DefaultProperties copy
      constructor (used from Clone()), potentially a Scale
      for the SfxItems has to be done.
      
      SOSAW080: Added missing include for MacBuild
      
      SOSAW080: Corrected CppunitTest_sc_anchor_test
      
      An adaption of a SdrPathObj instantiation was missing,
      added that. Seems as if that test is no tpart of the
      usual 'make' scenario, but used/executed in gerrit builds
      
      SOSAW080: Reworked SvxShape to use SdrObject's SdrModel
      
      SOSAW080: Reworked SvxShape to use SdrObject's SdrModel
      
      SOSAW080: Free SdrObjects when SdrModel goes down
      
      In an UNO API test problem is that SvxShapes reference
      SdrShapes, but these are not added to a SdrPage and not
      'owned' by the SvxShape. Thus these do not get deleted
      at all (same in master, memory leak). I extended
      SvxShape::Notify the case for ModelCleared to also
      Free the SdrObject when not owner and it's not added to
      a SdrPage (in that case it gets deleted with deleting
      the SdrModel)
      
      SOSAW080: Solve UNO API calls that move SvxShapes to other Model
      
      Due to UNO API tests I got a call to insert an xShape to a
      xDrawPage which was constructed in another Model, this has now to
      be done by Cloning the SdrObject to the new SdrModel, getting
      rid of the old one and getting all the UNO implementation
      stuff right (referemces SdrObject <-> xShape).
      
      1cb7d573d323e98a89761fe662c10c4a654fdec0
      24617494a0ef79f6e33dfcb02782a833a81c6434
      763f39094b6a48b529a6952d01468f8776c97679
      242b9e228a9a042c3a5bdd38b1ea6600144276d5
      242b9e228a9a042c3a5bdd38b1ea6600144276d5
      33a6f3f306b70c223171aef796dd5ee041ad14df
      6878b33f8b05738a44c0910e40a60a0f0d1d58ed
      0a636caf3cb36c2f9c6cd11aa22cb9bc435dc8f2
      8c4626274a5cc531dad27f27c0c45d4c528fb2fb
      446685a49a6d67aedd01cfbbd5e87b07f97a4d7b
      c1b5ed3c99bc7219a0061e4ece24ea42afd2889a
      22de9a1c8af7c25be5c108671ddc548ba323ed47
      4caf6b6fbbe6e8130741d793dffb560fd01d4ed5
      488b9601735ec1822433f82f633990063951fe08
      c366d60299f239e3df856ddffedb19e743e4be0c
      c5137ba8c597c7b5f90318df50e87b93a39a28dc
      f9e646242cf89f6fde1315046952252a2c429779
      f830fbc5fadd89d04be5edd2a5abf9b0d4bf0410
      1694b54903df784385abaa8452e1201e12344238
      17bcb44d2e29920c0c74430c2d9c703b36cfa0ad
      17bcb44d2e29920c0c74430c2d9c703b36cfa0ad
      7b5c241faec7488924e5935ae8b19f785846b5e4
      bf097ee7467895823fbd158a2a9543da3b5a5078
      
      Change-Id: Iaf53535de0502a481466be74a1768bbb39f0e78c
      Reviewed-on: https://gerrit.libreoffice.org/52526Tested-by: 's avatarJenkins <ci@libreoffice.org>
      Reviewed-by: 's avatarArmin Le Grand <Armin.Le.Grand@cib.de>
      dfefe448
    • Armin Le Grand's avatar
      eba4d5b2
    • Armin Le Grand's avatar
      SOSAW080: Added first bunch of basic changes to helpers · 6c14c27c
      Armin Le Grand yazdı
      SOSAW080: Make SdrModel& prerequisite to SdrObjects
      
      Added need for SdrModel& in constructors of SdrModel,
      SdrPage, SdrView and SdrObjList. Builds, not finished.
      
      SOSAW080: removed and replaced old SdrModel
      
      Removed and replaced GetModel()/SetModel() in all using
      classes (SdrObject, SdrPage, SdrView), added accessors
      to new referenced SdrModel, adapted all accessing places.
      Refactored/Extended ::Clone and ::operator== for these
      classes to allow cloning objects to a target SdrModel.
      Adapted places where this is done AFAP. Added quite some
      comments (tagged with 'TTTT') where possible further work
      is needed. Builds completely, thus checking in. This does
      not mean that this change is done yet.
      
      SOSAW080: Adapted SdrPage/SdrModel relationship
      
      Also needed to work on copy-construction of SdrPage and hierarchy,
      quite some stuff removed, no copy-constructor anymore, no
      MigrateItemPool stuff. Builds well, test stuck, will need
      some cleanup/finetunung
      
      SOSAW080: Smaller corrections/includes adapted
      
      SOSAW080: Smaller corrections/includes adapted
      
      SOSAW080: Debugging/Stabilizing/MakeUnitTestWork
      
      SOSAW080: Stabilized for UnitTests, cleanups
      
      SOSAW080: Adapted GetObjGraphic to just take a const SdrObject&
      
      SOSAW080: Removed ChangeModel from classes
      
      Classes SvxTextEditSource and SvxDrawPage (including
      TextEditSource stuff) do not need change of SdrModel
      anymore.
      
      SOSAW080: Adapted some comments to make more readable
      
      SOSAW080: Corrected constructor
      
      SOSAW080: getSdrModelFromUnoModel added override marks
      
      SOSAW080: Added missing includes
      
      SOSAW080: Corrected SdrPage constructor
      
      SOSAW080: Corrected some SdrObject::Clone scenarios
      
      Especially when cloning to another SdrModel and taking
      the sdr::properties into account.
      
      SOSAW080: Added include for Mac-Build
      
      SOSAW080: Added Scale to DefaultProperties
      
      If a SdrModel change happens in DefaultProperties copy
      constructor (used from Clone()), potentially a Scale
      for the SfxItems has to be done.
      
      SOSAW080: Added missing include for MacBuild
      
      SOSAW080: Corrected CppunitTest_sc_anchor_test
      
      An adaption of a SdrPathObj instantiation was missing,
      added that. Seems as if that test is no tpart of the
      usual 'make' scenario, but used/executed in gerrit builds
      
      SOSAW080: Reworked SvxShape to use SdrObject's SdrModel
      
      SOSAW080: Reworked SvxShape to use SdrObject's SdrModel
      
      SOSAW080: Free SdrObjects when SdrModel goes down
      
      In an UNO API test problem is that SvxShapes reference
      SdrShapes, but these are not added to a SdrPage and not
      'owned' by the SvxShape. Thus these do not get deleted
      at all (same in master, memory leak). I extended
      SvxShape::Notify the case for ModelCleared to also
      Free the SdrObject when not owner and it's not added to
      a SdrPage (in that case it gets deleted with deleting
      the SdrModel)
      
      SOSAW080: Solve UNO API calls that move SvxShapes to other Model
      
      Due to UNO API tests I got a call to insert an xShape to a
      xDrawPage which was constructed in another Model, this has now to
      be done by Cloning the SdrObject to the new SdrModel, getting
      rid of the old one and getting all the UNO implementation
      stuff right (referemces SdrObject <-> xShape).
      
      Change-Id: Iaf53535de0502a481466be74a1768bbb39f0e78c
      1cb7d573d323e98a89761fe662c10c4a654fdec0
      24617494a0ef79f6e33dfcb02782a833a81c6434
      763f39094b6a48b529a6952d01468f8776c97679
      242b9e228a9a042c3a5bdd38b1ea6600144276d5
      242b9e228a9a042c3a5bdd38b1ea6600144276d5
      33a6f3f306b70c223171aef796dd5ee041ad14df
      6878b33f8b05738a44c0910e40a60a0f0d1d58ed
      0a636caf3cb36c2f9c6cd11aa22cb9bc435dc8f2
      8c4626274a5cc531dad27f27c0c45d4c528fb2fb
      446685a49a6d67aedd01cfbbd5e87b07f97a4d7b
      c1b5ed3c99bc7219a0061e4ece24ea42afd2889a
      22de9a1c8af7c25be5c108671ddc548ba323ed47
      4caf6b6fbbe6e8130741d793dffb560fd01d4ed5
      488b9601735ec1822433f82f633990063951fe08
      c366d60299f239e3df856ddffedb19e743e4be0c
      c5137ba8c597c7b5f90318df50e87b93a39a28dc
      f9e646242cf89f6fde1315046952252a2c429779
      f830fbc5fadd89d04be5edd2a5abf9b0d4bf0410
      1694b54903df784385abaa8452e1201e12344238
      17bcb44d2e29920c0c74430c2d9c703b36cfa0ad
      17bcb44d2e29920c0c74430c2d9c703b36cfa0ad
      7b5c241faec7488924e5935ae8b19f785846b5e4
      bf097ee7467895823fbd158a2a9543da3b5a5078
      6c14c27c
    • Caolán McNamara's avatar
      weld linkeditdialog · 8ed2fb30
      Caolán McNamara yazdı
      which enables changing FileDialogHelper over to welded
      
      Change-Id: I988342a6574cb7ed09b2724929e8c7117474a56c
      Reviewed-on: https://gerrit.libreoffice.org/52388Tested-by: 's avatarJenkins <ci@libreoffice.org>
      Reviewed-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      Tested-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      8ed2fb30
  30. 05 Nis, 2018 1 kayıt (commit)
  31. 03 Nis, 2018 1 kayıt (commit)
  32. 02 Nis, 2018 1 kayıt (commit)