Kayıtlar (commit) · 6ddecf61ecada646fbd6f8809270d47289727e8a · LibreOffice / core

04 Agu, 2018 5 kayıt (commit)

fillUnoException not working on std::rethrow_exception exceptions · 6ddecf61

Caolán McNamara Agu 02, 2018 yazdı

used since...

commit dacc1b40
Date:   Sat Jul 28 16:33:22 2018 +0100

    ofz#9597 rethrown IOException not caught by catch IOException

the adjustedPtr seems to be as expected, but the type_info not.  Presumably
these are thrown as 'dependent exceptions' (?)
https://github.com/gcc-mirror/gcc/blob/master/libstdc%2B%2B-v3/libsupc%2B%2B/eh_type.cc#L42

Change-Id: Ibd736abe941bb1d5facdb88139b3a0e6cf32cf1f
Reviewed-on: https://gerrit.libreoffice.org/58477
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

6ddecf61

Update git submodules · 3aab478e

Adolfo Jayme Barrientos Agu 04, 2018 yazdı

* Update helpcontent2 from branch 'master'
  - Remove repeated word
    
    Change-Id: I71bf44d3f962c830f6057ced2f0930724f1a394b

3aab478e

tdf#118980 - No "clear list" control on formatting toolbar · b512cea3

heiko tietze Agu 02, 2018 yazdı

Change-Id: I87517885b5adf4a2fc43630769bb52342c936786
Reviewed-on: https://gerrit.libreoffice.org/58467
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>

b512cea3

Fix typos · 3466475d

Andrea Gelmini Agu 03, 2018 yazdı

Change-Id: I5ffa6366875d29c8a8bc8273057205c221e04a64
Reviewed-on: https://gerrit.libreoffice.org/58581
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

3466475d

Remove local deg<->rad functions: use what we already have in basegfx · 5d516b4c

Mike Kaganski Agu 03, 2018 yazdı

Change-Id: I33848d0b973999f486bb980e78b51e3d109ed1bf
Reviewed-on: https://gerrit.libreoffice.org/58582
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

5d516b4c

03 Agu, 2018 27 kayıt (commit)

Fix use-after-free in SwLayAction::IsShortCut · 554e0905

Stephan Bergmann Agu 03, 2018 yazdı

...as seen with valgrind during CppunitTest_sw_odfexport (see below).

It looks like the

  if ( !IsEmptyPage() ) //#59184# unnecessary for empty pages

optimization in SwPageFrame::DestroyImpl (which was there ever since at least
84a3db80 "initial import") was wrong, preventing
the call to

  pImp->GetLayAction().SetAgain();

that would cause SwLayAction::IsShortCut (sw/source/core/layout/layact.cxx) to
quit early from an IsAgain() call, before accessing prPage again that has
meanwhile been destroyed from within its

  pContent->Calc(pRenderContext);

call.

The same failure started to show in ASan+UBSan builds only now after
integration of <https://gerrit.libreoffice.org/#/c/58263/> "the custom SAL
allocator is no longer used", for reasons I explained in a comment there:  "For
FORCE_SYSALLOC (which was esp. set for ASan/UBSan builds), alloc_mode was always
left at AllocMode::UNSET (as determine_alloc_mode was never called in
FORCE_SYSALLOC blocks), so rtl_cache_alloc (which only checked alloc_mode for
AllocMode::SYSTEM, but never called determine_alloc, and wasn't entirely short-
circuited under FORCE_SYSALLOC) actually called into the legacy, supposed-dead
slab allocator code.  That's apparently how some use-after-free bug in sw got
hidden from ASan+UBSan builds in the past, and only now starts to show up
(<https://ci.libreoffice.org/job/lo_ubsan/989/>)."

The valgrind failure log:
[...]
> testFdo58949::Import_Export_Import finished in: 191975ms
> File tested,Execution Time (ms)
> warn:sw:12555:12555:sw/inc/swrect.hxx:283: SVRect() without Width or Height
> warn:sw:12555:12555:sw/inc/swrect.hxx:283: SVRect() without Width or Height
> warn:sw:12555:12555:sw/inc/swrect.hxx:283: SVRect() without Width or Height
> warn:sw:12555:12555:sw/inc/swrect.hxx:283: SVRect() without Width or Height
> warn:sw:12555:12555:sw/inc/swrect.hxx:283: SVRect() without Width or Height
> warn:sw:12555:12555:sw/inc/swrect.hxx:283: SVRect() without Width or Height
> warn:sw:12555:12555:sw/inc/swrect.hxx:283: SVRect() without Width or Height
> warn:sw:12555:12555:sw/inc/swrect.hxx:283: SVRect() without Width or Height
> warn:sw:12555:12555:sw/inc/swrect.hxx:283: SVRect() without Width or Height
> warn:sw:12555:12555:sw/inc/swrect.hxx:283: SVRect() without Width or Height
> ==12555== Invalid read of size 8
> ==12555==    at 0x2AFDAA7C: SwFrame::GetPrev() (/sw/source/core/inc/frame.hxx:649)
> ==12555==    by 0x2B6A4F7A: SwLayAction::IsShortCut(SwPageFrame*&) (/sw/source/core/layout/layact.cxx:1071)
> ==12555==    by 0x2B6A342D: SwLayAction::InternalAction(OutputDevice*) (/sw/source/core/layout/layact.cxx:473)
> ==12555==    by 0x2B6A2E46: SwLayAction::Action(OutputDevice*) (/sw/source/core/layout/layact.cxx:340)
> ==12555==    by 0x2BE0F8A2: SwViewShell::ImplEndAction(bool) (/sw/source/core/view/viewsh.cxx:281)
> ==12555==    by 0x2AF7A6C0: SwViewShell::EndAction(bool) (/sw/inc/viewsh.hxx:595)
> ==12555==    by 0x2AF68B50: SwCursorShell::EndAction(bool, bool) (/sw/source/core/crsr/crsrsh.cxx:258)
> ==12555==    by 0x2C464281: SwView::OuterResizePixel(Point const&, Size const&) (/sw/source/uibase/uiview/viewport.cxx:1124)
> ==12555==    by 0x2A29D78F: SfxViewFrame::DoAdjustPosSizePixel(SfxViewShell*, Point const&, Size const&, bool) (/sfx2/source/view/viewfrm.cxx:1604)
> ==12555==    by 0x2A2A390E: SfxViewFrame::Resize(bool) (/sfx2/source/view/viewfrm.cxx:2395)
> ==12555==    by 0x2A2AF1A7: SfxFrameViewWindow_Impl::Resize() (/sfx2/source/view/viewfrm2.cxx:73)
> ==12555==    by 0x1A8C2A64: vcl::Window::ImplCallResize() (/vcl/source/window/event.cxx:523)
> ==12555==    by 0x1AA2AF8D: vcl::Window::Show(bool, ShowFlags) (/vcl/source/window/window.cxx:2277)
> ==12555==    by 0x2A282069: SfxBaseController::ConnectSfxFrame_Impl(SfxBaseController::ConnectSfxFrame) (/sfx2/source/view/sfxbasecontroller.cxx:1250)
> ==12555==    by 0x2A2815BA: SfxBaseController::attachFrame(com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) (/sfx2/source/view/sfxbasecontroller.cxx:550)
> ==12555==    by 0x2A265C78: (anonymous namespace)::SfxFrameLoader_Impl::impl_createDocumentView(com::sun::star::uno::Reference<com::sun::star::frame::XModel2> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&, comphelper::NamedValueCollection const&, rtl::OUString const&) (/sfx2/source/view/frmload.cxx:594)
> ==12555==    by 0x2A26374F: (anonymous namespace)::SfxFrameLoader_Impl::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) (/sfx2/source/view/frmload.cxx:711)
> ==12555==    by 0x36E8A2A1: framework::LoadEnv::impl_loadContent() (/framework/source/loadenv/loadenv.cxx:1149)
> ==12555==    by 0x36E84F2A: framework::LoadEnv::startLoading() (/framework/source/loadenv/loadenv.cxx:383)
> ==12555==    by 0x36E83979: framework::LoadEnv::loadComponentFromURL(com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (/framework/source/loadenv/loadenv.cxx:169)
> ==12555==    by 0x36EDDEB8: framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (/framework/source/services/desktop.cxx:619)
> ==12555==    by 0x36EDDF6A: non-virtual thunk to framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (/framework/source/services/desktop.cxx:0)
> ==12555==    by 0x2D456C63: unotest::MacrosTest::loadFromDesktop(rtl::OUString const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (/unotest/source/cpp/macros_test.cxx:50)
> ==12555==    by 0x295BCC30: SwModelTestBase::loadURL(rtl::OUString const&, char const*, char const*) (/sw/qa/extras/inc/swmodeltestbase.hxx:762)
> ==12555==    by 0x295BC7E9: SwModelTestBase::load(rtl::OUString const&, char const*, char const*) (/sw/qa/extras/inc/swmodeltestbase.hxx:717)
> ==12555==    by 0x295BC660: SwModelTestBase::executeImportTest(char const*, char const*) (/sw/qa/extras/inc/swmodeltestbase.hxx:264)
> ==12555==    by 0x295E4B5F: testStylePageNumber::Import() (/sw/qa/extras/odfexport/odfexport.cxx:686)
[...]
> ==12555==  Address 0x28ddde10 is 160 bytes inside a block of size 280 free'd
> ==12555==    at 0x4C2FDAC: free (/builddir/build/BUILD/valgrind-3.13.0/coregrind/m_replacemalloc/vg_replace_malloc.c:530)
> ==12555==    by 0x519E494: rtl_freeMemory (/sal/rtl/alloc_global.cxx:51)
> ==12555==    by 0x519DCDB: rtl_cache_free (/sal/rtl/alloc_cache.cxx:172)
> ==12555==    by 0x19BB090A: FixedMemPool::Free(void*) (/tools/source/memtools/mempool.cxx:49)
> ==12555==    by 0x2B68B89D: SwPageFrame::operator delete(void*, unsigned long) (/sw/source/core/inc/pagefrm.hxx:111)
> ==12555==    by 0x2B6DA2E8: SwPageFrame::~SwPageFrame() (/sw/source/core/layout/pagechg.cxx:301)
> ==12555==    by 0x2B74E763: SwFrame::DestroyFrame(SwFrame*) (/sw/source/core/layout/ssfrm.cxx:384)
> ==12555==    by 0x2B6E18D3: SwRootFrame::RemovePage(SwPageFrame**, SwRemoveResult) (/sw/source/core/layout/pagechg.cxx:1414)
> ==12555==    by 0x2B6E145D: (anonymous namespace)::doInsertPage(SwRootFrame*, SwPageFrame**, SwFrameFormat*, SwPageDesc*, bool, SwPageFrame**) (/sw/source/core/layout/pagechg.cxx:1270)
> ==12555==    by 0x2B6E0CA0: SwFrame::InsertPage(SwPageFrame*, bool) (/sw/source/core/layout/pagechg.cxx:1324)
> ==12555==    by 0x2B65373D: SwFrame::GetNextLeaf(MakePageType) (/sw/source/core/layout/flowfrm.cxx:997)
> ==12555==    by 0x2B65331A: SwFrame::GetLeaf(MakePageType, bool) (/sw/source/core/layout/flowfrm.cxx:818)
> ==12555==    by 0x2B657637: SwFlowFrame::MoveFwd(bool, bool, bool) (/sw/source/core/layout/flowfrm.cxx:1876)
> ==12555==    by 0x2B657133: SwFlowFrame::CheckMoveFwd(bool&, bool, bool) (/sw/source/core/layout/flowfrm.cxx:1796)
> ==12555==    by 0x2B634109: SwContentFrame::MakeAll(OutputDevice*) (/sw/source/core/layout/calcmove.cxx:1322)
> ==12555==    by 0x2B62CEF4: SwFrame::PrepareMake(OutputDevice*) (/sw/source/core/layout/calcmove.cxx:343)
> ==12555==    by 0x2B770166: SwFrame::Calc(OutputDevice*) const (/sw/source/core/layout/trvlfrm.cxx:1799)
> ==12555==    by 0x2B6A4F11: SwLayAction::IsShortCut(SwPageFrame*&) (/sw/source/core/layout/layact.cxx:1065)
> ==12555==    by 0x2B6A342D: SwLayAction::InternalAction(OutputDevice*) (/sw/source/core/layout/layact.cxx:473)
> ==12555==    by 0x2B6A2E46: SwLayAction::Action(OutputDevice*) (/sw/source/core/layout/layact.cxx:340)
> ==12555==    by 0x2BE0F8A2: SwViewShell::ImplEndAction(bool) (/sw/source/core/view/viewsh.cxx:281)
[...]

Change-Id: I57ebbab536ca41554e4681477cf1dea62abbc688
Reviewed-on: https://gerrit.libreoffice.org/58550
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

554e0905

Move angle normalization code from various places to tools · 81302f33

Mike Kaganski Agu 03, 2018 yazdı

Also rename svx angle normalization functions in include/svx/svdtrans.hxx, that
deal with 100ths of degree, to avoid confusion: NormAngle180 -> NormAngle18000;
NormAngle360 -> NormAngle36000.

Some places were fixed that previously returned inclusive ranges (i.e., both 0
and 360), see changes in these files:

    chart2/source/view/main/PlottingPositionHelper.cxx
    chart2/source/view/main/PolarLabelPositionHelper.cxx
    chart2/source/view/main/ShapeFactory.cxx
    filter/source/graphicfilter/idxf/dxf2mtf.cxx
    sw/source/core/graphic/grfatr.cxx

(the latter now matches the comment in the function).

Change-Id: I9f274bbb4168360d60dceff02aeba6332c519a59
Reviewed-on: https://gerrit.libreoffice.org/58556
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

81302f33

forcepoint#71 sanity check when copying pieces of imported pdf · 83b25e4b

Caolán McNamara Agu 03, 2018 yazdı

Change-Id: I7e340e15c95cdfa8b185f61fad7e14bd00babf21
Reviewed-on: https://gerrit.libreoffice.org/58555
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

83b25e4b

Allow forcing of intercept to zero in regression dialog · 2ffe2282

Dennis Francis Agu 01, 2018 yazdı

Change-Id: I3958c139141a9e717256a638d319e0bb5879e6a4
Reviewed-on: https://gerrit.libreoffice.org/58565
Tested-by: Jenkins
Reviewed-by: Dennis Francis <dennis.francis@collabora.co.uk>

2ffe2282

inline RegexpMapIterImpl into RegexpMapConstIter · 6b8874e7

Noel Grandin Agu 03, 2018 yazdı

no need for header only classes to have an Impl

Change-Id: I66236e3f9137320cfe39d4312cf7682c1d808815
Reviewed-on: https://gerrit.libreoffice.org/58561
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

6b8874e7

inline RegexpMapImpl into RegexpMap · 95f21c30

Noel Grandin Agu 03, 2018 yazdı

no need for header-only classes to have Impl's

Change-Id: I65b7f84ebd9eec67ad8be694b7752da59af39a9d
Reviewed-on: https://gerrit.libreoffice.org/58560
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

95f21c30

Update git submodules · 48cef810

Christian Lohmaier Agu 03, 2018 yazdı

* Update translations from branch 'master'
  - update translations for master
    
    Change-Id: If7b8b1685d00503ee3d1e84b978c8f59359a73b5

48cef810

Remove svx::Round; use FRound from tools instead · b5b601b1

Mike Kaganski Agu 03, 2018 yazdı

Change-Id: Idb8d16f59823d9065b82d6312def36601457af1a
Reviewed-on: https://gerrit.libreoffice.org/58546
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

b5b601b1

forcepoint#70 give all escher client data objects a common parent class · a61b4c21

Caolán McNamara Agu 03, 2018 yazdı

and make NotifyFreeObj a virtual method of SvxMSDffClientData, finding
the sc case where the client data was neither SvxMSDffImportData nor
ProcessData.

make the sc case a XclImpDrawObjClientData whose NotifyFreeObj is a noop

Change-Id: I07422e7a3415114674bb1e3c1ef120299adf2dc8
Reviewed-on: https://gerrit.libreoffice.org/58551Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

a61b4c21

Resolve unnecessary typedef · ea59fc48

Stephan Bergmann Agu 03, 2018 yazdı

Change-Id: Ide89f6082f877046eac0415f23a3e29c5f7f1e65
Reviewed-on: https://gerrit.libreoffice.org/58554
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

ea59fc48

loplugin:useuniqueptr in lru_cache · ed1e2967

Noel Grandin Agu 02, 2018 yazdı

Change-Id: I8ccd3acdcb160a19466da2bbf05527617c9f9ad2
Reviewed-on: https://gerrit.libreoffice.org/58491
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

ed1e2967

icu: fix Android build · 03e0d86f

Miklos Vajna Agu 03, 2018 yazdı

Change-Id: I9c2f508098610ff97f059bb325401de052a35e3c
Reviewed-on: https://gerrit.libreoffice.org/58549Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins

03e0d86f

solenv: adapt native code script to oox FastTokenHandler changes · 834ac18e

Miklos Vajna Agu 03, 2018 yazdı

Change-Id: I67900740fce6df6bf3a4025eb7a4d6e279930edf
Reviewed-on: https://gerrit.libreoffice.org/58547Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins

834ac18e

loplugin:useuniqueptr in LRU_Cache · a0c29585

Noel Grandin Agu 02, 2018 yazdı

Change-Id: I30d008f01318f9e484b08398ed1ca1b41f90946a
Reviewed-on: https://gerrit.libreoffice.org/58490
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

a0c29585

loplugin:useuniqueptr in bridges · 8d5b917d

Noel Grandin Agu 02, 2018 yazdı

Change-Id: I7248f8b5031e9659b2a58644952e59cc99d6a2d6
Reviewed-on: https://gerrit.libreoffice.org/58483
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

8d5b917d

NormAngle180: avoid two extra operations · 47eaea7d

Mike Kaganski Agu 03, 2018 yazdı

Change-Id: Ib661c57c652c407baef3b6b7390be731fa83ab5d
Reviewed-on: https://gerrit.libreoffice.org/58545
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

47eaea7d

tdf#119007 Crash when paste table from web · 071d1432

Noel Grandin Agu 02, 2018 yazdı

regression from
    commit 51003378
    loplugin:useuniqueptr in ScHTMLLayoutParser

Change-Id: I3c6f04ac2c8f188856ec4c9eb6bf520fa03ee97a
Reviewed-on: https://gerrit.libreoffice.org/58480
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

071d1432

forcepoint#69 ditch any unclosed m_pPosAfterTOC before dropping cursor · 4f891d87

Caolán McNamara Agu 02, 2018 yazdı

Change-Id: I6b56a48f5449b25fe3bdc2e02d3885388b0da74f
Reviewed-on: https://gerrit.libreoffice.org/58496
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

4f891d87

Add missing sal/log.hxx headers · 4760bc99

Gabor Kelemen Tem 31, 2018 yazdı

rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it.
This is a continuation of commit 6ff2d84a to be able to remove those unneeded includes.

Change-Id: I1ede3f86e390bfec1a2d3ee8e8bb6ec67083b194
Reviewed-on: https://gerrit.libreoffice.org/58372
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

4760bc99

loplugin:useuniqueptr in VclMetafileProcessor2D · 28fa6461

Noel Grandin Agu 02, 2018 yazdı

Change-Id: Ib80eae7d024153f4d765dc08a0856fac3c540052
Reviewed-on: https://gerrit.libreoffice.org/58489
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

28fa6461

loplugin:useuniqueptr in SvParser · 5d746e19

Noel Grandin Agu 02, 2018 yazdı

Change-Id: I1850fc979394120be8aa0540140da13cda86bccb
Reviewed-on: https://gerrit.libreoffice.org/58487
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

5d746e19

loplugin:useuniqueptr in SbiProcDef · 02caaef2

Noel Grandin Agu 02, 2018 yazdı

Change-Id: I31c43f8fe40d90094d550b02c5d6213e59149bad
Reviewed-on: https://gerrit.libreoffice.org/58486
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

02caaef2

loplugin:useuniqueptr in BasicManager · cd6486b1

Noel Grandin Agu 02, 2018 yazdı

Change-Id: I9774a1651c8754f575ebb4b98fbddee5a99a7719
Reviewed-on: https://gerrit.libreoffice.org/58485
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

cd6486b1

oox: create FastTokenHandler instances with an uno constructor · 28dc7c3c

Miklos Vajna Agu 02, 2018 yazdı

Change-Id: I1d7bca67c493d31a2a833a8254a9c01c76f1d286
Reviewed-on: https://gerrit.libreoffice.org/58495
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

28dc7c3c

loplugin:useuniqueptr in ImplHomMatrixTemplate · 1da9761c

Noel Grandin Agu 02, 2018 yazdı

Change-Id: I31175a5110672e864b07d6b5508b8b04b14e66ee
Reviewed-on: https://gerrit.libreoffice.org/58484
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

1da9761c

tdf#116350 Export preset text geometry (text effects) · 5934d4ab

Szymon Kłos Agu 01, 2018 yazdı

Change-Id: Ifb921b56387ca183b5a57126f6e88e2f9a4ecb3d
Reviewed-on: https://gerrit.libreoffice.org/58430
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

5934d4ab

uitest Impress Document properties · dc05737d

Zdeněk Crhonek Agu 01, 2018 yazdı

Change-Id: Ida877ab6e65d4bcbd42d37fd2567db63f84ed8ad
Reviewed-on: https://gerrit.libreoffice.org/58456
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

dc05737d

02 Agu, 2018 8 kayıt (commit)

[pt_PT] Added 20 autocorrect words · 6ec8c8ed

Marco A.G.Pinto Tem 16, 2018 yazdı

Change-Id: If2cd89b76433ce32e072805969e2381a30f62125
Reviewed-on: https://gerrit.libreoffice.org/57482
Tested-by: Jenkins
Reviewed-by: Aron Budea <aron.budea@collabora.com>

6ec8c8ed

turn SfxPickList singleton a member of SfxApplication · 653394fb

Caolán McNamara Agu 02, 2018 yazdı

SfxPickList listens to the SfxApplication so it can
be made a member of that, and drop the singleton, which
is causing trouble like...

 #0  0x00007ffff613ad7d in ImplDbgTestSolarMutex() () at /libreoffice/symbols/vcl/source/app/dbggui.cxx:47
 #1  0x00007ffff6ee86e1 in SfxBroadcaster::RemoveListener(SfxListener&) (this=0x5555565d0380, rListener=...) at /libreoffice/symbols/svl/source/notify/SfxBroadcaster.cxx:126
 #2  0x00007ffff6eea993 in SfxListener::~SfxListener() (this=0x555556622620, __in_chrg=<optimized out>) at /libreoffice/symbols/svl/source/notify/lstner.cxx:66
 #3  0x00007ffff7207b45 in SfxPickListImpl::~SfxPickListImpl() (this=0x555556622620, __in_chrg=<optimized out>) at /libreoffice/symbols/sfx2/source/appl/sfxpicklist.cxx:84
 #4  0x00007ffff7207b45 in SfxPickListImpl::~SfxPickListImpl() (this=0x555556622620, __in_chrg=<optimized out>) at /libreoffice/symbols/sfx2/source/appl/sfxpicklist.cxx:84
 #5  0x00007ffff7206aa5 in std::default_delete<SfxPickListImpl>::operator()(SfxPickListImpl*) const (this=<optimized out>, __ptr=<optimized out>) at /usr/include/c++/7/bits/unique_ptr.h:78
 #6  0x00007ffff7206aa5 in std::unique_ptr<SfxPickListImpl, std::default_delete<SfxPickListImpl> >::reset(SfxPickListImpl*) (__p=<optimized out>, this=0x7ffff76775a8 <SfxPickList::ensure()::aUniqueInstance>) at /usr/include/c++/7/bits/unique_ptr.h:376
 #7  0x00007ffff7206aa5 in SfxPickList::~SfxPickList() (this=0x7ffff76775a8 <SfxPickList::ensure()::aUniqueInstance>, __in_chrg=<optimized out>) at /libreoffice/symbols/sfx2/source/appl/sfxpicklist.cxx:188
 #8  0x00007ffff44dc041 in __run_exit_handlers (status=0, listp=0x7ffff4884718 <__exit_funcs>, run_list_atexit=run_list_atexit@entry=true, run_dtors=run_dtors@entry=true) at exit.c:108
 #9  0x00007ffff44dc13a in __GI_exit (status=<optimized out>) at exit.c:139
 #10 0x00007ffff44bab9e in __libc_start_main (main=0x555555557880 <main(int, char**)>, argc=10, argv=0x7fffffffdde8, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7fffffffddd8) at ../csu/libc-start.c:344
 #11 0x00005555555578da in _start ()

Change-Id: Ic781f3eb065fef14da1f10a56246b9b7068e1529
c781f3eb065fef14da1f10a56246b9b7068e1529
Reviewed-on: https://gerrit.libreoffice.org/58494
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

653394fb

coverity#1438198 silence using invalid iterator · 1cb3195f

Caolán McNamara Agu 02, 2018 yazdı

Change-Id: Ibccf6d3838335ae2d8a3a7f8187df8f2e173f043
Reviewed-on: https://gerrit.libreoffice.org/58482
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

1cb3195f

coverity#1438194 silence Resource leak · 668e68d3

Caolán McNamara Agu 02, 2018 yazdı

Change-Id: I54cf8e4fc430feb2e34d3f6f0f2abce81973b09a
Reviewed-on: https://gerrit.libreoffice.org/58481
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

668e68d3

m_xStringLength is unused · 46d5bde3

Caolán McNamara Agu 02, 2018 yazdı

Change-Id: I244ca2c34363d0776a3cc18953a1c9b28467da44
Reviewed-on: https://gerrit.libreoffice.org/58493
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

46d5bde3

KF5_HAVE_GLIB etc. are apparently unused · 8fee33ba

Stephan Bergmann Agu 02, 2018 yazdı

...ever since their introduction with 4d78cf97
"Extend build system to support linking against KDE Frameworks 5"

Change-Id: I47f0b6c440aa345d564abac5a12a4af35b8fcf4e
Reviewed-on: https://gerrit.libreoffice.org/58476
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

8fee33ba

Remove no-longer functional --with-alloc · 0e2a8bbf

Stephan Bergmann Agu 02, 2018 yazdı

...after db354dfa "the custom SAL allocator is
no longer used"

Change-Id: Ia897e2d3cf20bb240dcc3eed801b81f86267dc6a
Reviewed-on: https://gerrit.libreoffice.org/58475
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

0e2a8bbf

update credits · cbd383aa
Christian Lohmaier Agu 02, 2018 yazdı
```
Change-Id: Idfce6ffe88615f64319d7e1112ac6c4bde2a88d9
```
cbd383aa