add some unit tests, and improve the heuristics

Change-Id: I95aa97a87e178ce8d506bd245710d0ae66ad08a4
Reviewed-on: https://gerrit.libreoffice.org/63647Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

very weird code, no need for hiding this bool inside a method

Change-Id: I75ee67af32ab012fe5ab5ae766abc56212bb08e6
Reviewed-on: https://gerrit.libreoffice.org/63643Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I99f5ce24743a14a78d24da8c64bc6f9adfda6c4c
Reviewed-on: https://gerrit.libreoffice.org/63615Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

which arrived with
   commit bee74696
   Date:   Tue Feb 1 13:42:47 2011 +0100
    dba34d: limit invalidate calls
and looks extremely dodgy, because it means only the very first report
design window will be correctly configured.

Change-Id: I127c733faaddcacd8507fa74aebe3b6da761327f
Reviewed-on: https://gerrit.libreoffice.org/63641
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

(cherry picked from commit 58a04e69)

Change-Id: I3004f9607d9551e9c8bce1bedcfe8426ed392170
Reviewed-on: https://gerrit.libreoffice.org/63609
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I301a27edf47588d11080b91507b79be177a6f99c
Reviewed-on: https://gerrit.libreoffice.org/63608
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I3b00ee5c851df368a98c6afa0b4c466fc8970fed
Reviewed-on: https://gerrit.libreoffice.org/63566
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I762eb7766a5cbe788c0a360c8a6f37b9b1106412
Reviewed-on: https://gerrit.libreoffice.org/63639
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

In DOCX, w:pos specifies the position of the current custom tab stop
with respect to the current page margins.
But in ODT, zero position could be page margins or paragraph indent
according to used settings DocumentSettingId::TABS_RELATIVE_TO_INDENT

Added new unit test.

Change-Id: Ic56a8527380b6562f4239df1edce0c9b4649af24
Reviewed-on: https://gerrit.libreoffice.org/63460
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Added checks for filter title, so filter titles are Windows
conform.

Change-Id: I42485c465ea58540a99b8300c5205b902cb86a92
Reviewed-on: https://gerrit.libreoffice.org/63573
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

See https://lists.freedesktop.org/archives/libreoffice/2018-November/081410.html

Change-Id: I258e08894486a925bed50a3a4232b6e805af6784
Reviewed-on: https://gerrit.libreoffice.org/63625
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...(ExprWithCleanups around the CXXConstructExpr in initializers for members of
O[U]String type, with older Clang, as used in
compilerplugins/clang/test/staticconstfield.cxx), and thus revert
e3e8d526 "Temporarily disable
compilerplugins/clang/test/staticconstfield" again.

Change-Id: Ic5fcdd1a26e4a6810369e4f9d909200d25feb12e
Reviewed-on: https://gerrit.libreoffice.org/63628
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I69ee7466d6e13d3b0c51c27a8668d567c0427a35
Reviewed-on: https://gerrit.libreoffice.org/63562
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I031faa67192f21d20938c8cc8056db138326a1ca
Reviewed-on: https://gerrit.libreoffice.org/63143
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: I23956b671a24cc8ac85cec4ea6220d1107f99b1e
Reviewed-on: https://gerrit.libreoffice.org/63624
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: Ibcb56c6c0f1456c472061039ecc0835928846724
Reviewed-on: https://gerrit.libreoffice.org/63458
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Move XEnumeration Java test to C++
for ScIndexEnumeration_SubTotalFieldsEnumeration.

Change-Id: Ibe2b283e99230c5e517eb80858ff31459f2c9844
Reviewed-on: https://gerrit.libreoffice.org/63627
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

additional changes will come

Change-Id: Ia7f8c7d7b3c1471a4c851d1e362f1b67ef8e413c
Reviewed-on: https://gerrit.libreoffice.org/63055
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I442c4bf9acbd85f340371014c20be3292a016beb
Reviewed-on: https://gerrit.libreoffice.org/63613
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>

This fixes OSX "make debugrun" by dropping VCL_HIDE_WINDOWS
handling and removing the internal GetPseudoHeadless() API.

While at it moves the DialogCancelMode enum out of Application.

Change-Id: I4876e752ddbfc39dd44faa673fb0e97810089a75
Reviewed-on: https://gerrit.libreoffice.org/61598
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Regression from commit af313fc1
(tdf#105143 DOCX import: enable DoNotCaptureDrawObjsOnPage layout compat
option, 2017-01-06), the group shape which covers most of the single
page in the document had a negative left position, while it should have
a small positive one (checking the drawingML markup).

This was a pre-existing problem, but now it's visible since we no longer
force objects to be on the page in Word compat mode.

Seeing the ODT import never positions group shapes (it's just a
container for child shapes), probably the DOCX import shouldn't do that
either. Start moving into this direction, first only for
absolute-positioned toplevel group shapes only, which already fixes the
bug.

Change-Id: I152ba06a81a2bd09195a4c724da4b8878b0457bb
Reviewed-on: https://gerrit.libreoffice.org/63606
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Move XEnumeration Java tests to C++
for ScIndexEnumeration_SpreadsheetViewPanesEnumeration.

Change-Id: I03c05cd894bf84816618ac28deb01ecb2fd8779e
Reviewed-on: https://gerrit.libreoffice.org/63622
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

This is just a minimal solution and obviously not fully parallel.
We still have to walk the tree twice:
1. copy all needed headers to dist (export export_private)
2. the parallel build (libs)

The fixes are:
* Add a few rm and @$(MAKE_OBJDIR) calls to various targets
* Serialize minimal steps in nss_build_all
  => Build libs of nss/lib and nss/cmd/lib before all other
  => drop the minimal all target
* Make $(SHARED_LIBRARY) depend on $(LIBRARY), otherwise dll lib
  creation on Windows builds a static lib, instead of the dll one
* Drop all "export:: private_export" rules. We run this before
  the build and duplicate targets break the header install

Change-Id: I1c35985c90d2d63990e04a0d2bb9d8ae921a2182
Reviewed-on: https://gerrit.libreoffice.org/62011
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Move XEnumeration Java tests to C++
for ScIndexEnumeration_SpreadsheetsEnumeration.

Change-Id: Id6fbc4dab54e2b50be42df7ade912a5aaf1cb97c
Reviewed-on: https://gerrit.libreoffice.org/63621
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: I5d0d44be038f61616fe71cbfecf492b5abffbc8a
Reviewed-on: https://gerrit.libreoffice.org/63612
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: Ie454dab3f23bee4bf0321fe6f5a657a57cc5ef5e
Reviewed-on: https://gerrit.libreoffice.org/63611
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Move XEnumeration Java tests to C++
for ScIndexEnumeration_TableAutoFormatEnumeration.

Change-Id: Ibe9f4cffaecc4f3fada04f82425031e6773b32d7
Reviewed-on: https://gerrit.libreoffice.org/63619
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Move XEnumeration Java tests to C++
for ScIndexEnumeration_SheetCellRangesEnumeration.

Change-Id: Ic3bc6f38244c4f476d29826accc397b4b6902f31
Reviewed-on: https://gerrit.libreoffice.org/63605
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Move XEnumeration Java tests to C++
for ScIndexEnumeration_FunctionDescriptionEnumeration.

Change-Id: I6c15abff293996a6bac8e4a6c0004853fae13990
Reviewed-on: https://gerrit.libreoffice.org/63604
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: Ie54292794aa4ecfce3fed97102aef75d0fec2d33
Reviewed-on: https://gerrit.libreoffice.org/63614Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

• No need for a horizontal line to be randomly there.
• Get rid of GtkFrames that enclose only one element.
  Seriously, they are cancer. Use them properly!
• … and while I’m here, use a stock label for the Search button.
  I noticed the associated help page not using the “Go” name.

Change-Id: Id196d8d970a219285c5cc606ab9b4327cdce2e91
Reviewed-on: https://gerrit.libreoffice.org/62238
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

Change-Id: I267904c751c9b32b9b64b0cf1b7f9d922bc7e1f7
Reviewed-on: https://gerrit.libreoffice.org/63529
Tested-by: Jenkins
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>

for draw from impress

Change-Id: I60bb28ddf47ca4aa3ef16c9fd61e26ac80d4e721
Reviewed-on: https://gerrit.libreoffice.org/63563
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I00fa63f9cb7c31f54732446aaf62b4a9b9fce522
Reviewed-on: https://gerrit.libreoffice.org/63565
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

its removed when the object was removed from the page to be reinserted
as as a group member

Change-Id: I8edeb89ae07b73572b65413817212a79ef8957b3
Reviewed-on: https://gerrit.libreoffice.org/63578
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Move XEnumeration Java tests to C++
for ScIndexEnumeration_DatabaseRangesEnumeration.

Change-Id: I33fac410b4b05f88dad45f859ae466fabb8303fc
Reviewed-on: https://gerrit.libreoffice.org/63592
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Of the "Gerrit Linux clang/dbgutil" build nodes, one (tb79-pollux) has done the
lode update to use Clang 3.9.1, while the other two nodes (tb75-lilith and
tb76-maggie) are still at the old Clang 3.8.0.  When building Gerrit changes for
master, tb79-pollux started to fail in
compilerplugins/clang/test/staticconstfield now
(<https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/20247/> and
<https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/20252/>) while such
builds on the other two nodes still succeed.  So it looks like Clang 3.9.1 has
some issue with that loplugin, which will need further inspection.  For now, to
not break Gerrit/Jenkins builds, disable that test.

Change-Id: I1bd380fb98d3b9a411dd04578a5620cdb27cd35b

Otherwise they would be passed to the other running instance, and
processed there, without outputting the data to the callng console

Change-Id: I5cd9d11b567dfed06e19e9a2c4c29bc82868c064
Reviewed-on: https://gerrit.libreoffice.org/63577
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Move XEnumeration Java tests to C++
for ScIndexEnumeration_CellAreaLinksEnumeration.

Change-Id: I0cbb97689522d9ff5d3ba0799b6d1e3f215cf533
Reviewed-on: https://gerrit.libreoffice.org/63590
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: Ic13f33d37d9f8e472bde5a2708a8a7cbdc6d26f4
Reviewed-on: https://gerrit.libreoffice.org/63583
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>