detect static variables that can be made const.

Thanks to mike kaganski for suggesting this.

Here I introduce a new plugin feature - using markers
in nearby comments to disable the plugin for specific
vars.

Some of this stuff was old debugging code. I removed the stuff
that was older than 5 years.

Change-Id: I6ec7742a7fdadf28fd128b592fcdf6da8257585c
Reviewed-on: https://gerrit.libreoffice.org/68807
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Move XNamed Java tests to C++ for ScDataPilotItemObj.

Change-Id: I2fcffbd7e7329357ac30fa14716bf2bcf49c5666
Reviewed-on: https://gerrit.libreoffice.org/68891
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: I65fb4a444e7e072004adcc9f9ad7af77a3f9f919
Reviewed-on: https://gerrit.libreoffice.org/68888
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Prefix variable nMaxFieldIndex with m_ to show it's a data member of the
class.

Change-Id: I207b3552f460b3433af6892abb6c4693e990d7bb
Reviewed-on: https://gerrit.libreoffice.org/68887
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

workaround baseclass NotifyStartDrag weirdness rather than risk changing it

Change-Id: I70b56a913e6192da9b3a57653924dcc4160352c0
Reviewed-on: https://gerrit.libreoffice.org/68879
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I911b6822b1c631700d7f43630e5a6fbb21de1c1f
Reviewed-on: https://gerrit.libreoffice.org/68878
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Regression from commit b160db92
(tdf#96947 vcl opengl win: fix background of menu items w/ check/radio
marks, 2018-05-14), the problem was that GetMenuPopupMarkRegion() did an
unconditional downcast from ImplControlValue to MenupopupValue.  This
looked safe, but when the extracted function was used in
WinSalGraphics::drawNativeControl(), then that argument was not safe to
downcast.

Fix the problem by switching to safe downcast, and returning an empty
rectangle (instead of a bogus one) on error.

This way the old bug stays fixed but fontwork popup menu works again as
well.

Change-Id: I2b69b9f2e6823850892ac73df78dac5c2f04ec03
Reviewed-on: https://gerrit.libreoffice.org/68883Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

Change-Id: I8385acf7ecd46b7c8b990abb688bd2ddddcb6bc5
Reviewed-on: https://gerrit.libreoffice.org/68867
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I0dfdaaf74c9b31ecd9b1de511b48dacf2e90f59f
Reviewed-on: https://gerrit.libreoffice.org/68866Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: Ie5e28883d70ad61340c58bcacd8c2ffb2ced1536
Reviewed-on: https://gerrit.libreoffice.org/68865
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I7e7cd05ce516ab24d380bb8b6a264fd45e1d553c
Reviewed-on: https://gerrit.libreoffice.org/68864
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I398293c30e015eeb53b8403f1e6fc628227de9ac
Reviewed-on: https://gerrit.libreoffice.org/68863
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I1d1944faed05ec3753709e39fa1a820d795e26d5
Reviewed-on: https://gerrit.libreoffice.org/68862
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Even though in theory it was worse to get an exception and return an
empty Any for CommandBars, in practice there are not resources to
figure out why that change apparently then caused a crash in the
customer application. Let's hope that it doesn't actually need the
CommandBars object for anything essential.

This reverts commit 87b4bd61.

Change-Id: Id2ec3a7254c5dd5a36ce2d5e930a457b9abd44f1
Reviewed-on: https://gerrit.libreoffice.org/68881Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>

Change-Id: I969ec999aa1efdcd1a5b85190657d53c882fe6ec
Reviewed-on: https://gerrit.libreoffice.org/68875
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: Ic762bc91fc7d5beca80d8713b5435a8368566c83
Reviewed-on: https://gerrit.libreoffice.org/68874
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I98bff3b4fcaf112cd1afd71abfe286398cb0aacf
Reviewed-on: https://gerrit.libreoffice.org/68869
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

This causes asserts from std::upper_bound in ooo26330-3.sxw (without the
fix to the initial expansion, when the fields all expand empty)

Change-Id: I1005e68d27f53986b9216541e0b26ce52082cf55

Change-Id: I655dca755ed8e1c1266c191f61998b3838fe9797
Reviewed-on: https://gerrit.libreoffice.org/68860
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

* Update helpcontent2 from branch 'master'
  - tdf105445 Change help
    
    Change-Id: Icfaee7ace4c03b6c647f7256561201cefc867f33
    Reviewed-on: https://gerrit.libreoffice.org/68847
    Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

* Update helpcontent2 from branch 'master'
  - tdf#102265 update Impress Help as Format - Page was moved
    
    This is a complex task and the intertwined nature of Draw and
    Impress does not help.
    
    In the patches for tdf#84258 .uno:SlideSetup was created as an
    alias for .uno:PageSetup. The corresponding menu items are
    Slide - Properties in Impress and Page - Properties in Draw.
    
    Currently some Draw help pages refer to the simpress/01/01180000.xhp
    file. This file needs to be cloned under sdraw and the contents
    of both files along with all references to them have to be
    brought up to date.
    
    The Impress Slide menu documentation needs to be fleshed out in
    simpress/main0117.xhp and new files have to be created for the
    individual menu item references.
    
    The Impress Format menu documentation simpress/main0105.xhp
    needs a big overhaul. The same is true for sdraw/main0105.xhp.
    
    The Help for Draw's Page menu has to be created.
    
    To find the interrelations, I use
    find /path -name '*.xhp' -exec grep --color=always -Hi 'string' {} +
    or with -type f instead of -name to get maximum coverage.
    
    Change-Id: I5d130846da6640aeebab758c0f6dae2c78f9e355
    Reviewed-on: https://gerrit.libreoffice.org/68830
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

Include the numeric member id in the name. Hopefully makes it a bit
easier to interpret log files produced by LibreOffice or by the COLEAT
tool.

Change-Id: I7270b9538cf1a75db8972fb91eb57b931fe8e320
Reviewed-on: https://gerrit.libreoffice.org/68859
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I9dd7984affc4343f148c66077feaac19176adf51
Reviewed-on: https://gerrit.libreoffice.org/68769
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I75bb860272e23ebc04912295b0ce4f2c8fe540b7
Reviewed-on: https://gerrit.libreoffice.org/68604
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

See https://bugs.documentfoundation.org/attachment.cgi?id=149773

Change-Id: I1696984a8df1b38a359a8177a5f3670526d2696e
Reviewed-on: https://gerrit.libreoffice.org/68832
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

This adds --enable-poppler configure option.
Poppler can be enabled/disabled by setting this
parameter to yes or no.

Change-Id: I42ba2d27de7b5014d28523394310616d20073b71
Reviewed-on: https://gerrit.libreoffice.org/68602Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/68842
Tested-by: Jenkins

* Update dictionaries from branch 'master'
  - tdf#117389 Make sure all comments also ends with #
    
    Change-Id: I68f513c0ad8b63b416608f8e221450622ef10c2d
    
  - tdf#117389 Remove empty line, update total number
    
    Change-Id: I4f492ab621d5a41466f55e79e86eeda5c7da1e52
    
  - substantive rework of af_ZA hunspell
    
    Change-Id: I873d6135e65089e5905b5c650428b4d9ad7fa4c6
    

If nStartPos == size() and !bUseFirst.

(regression from d0e9cc83)

Change-Id: I571d24ec5e9d4f2780e7c6d5c8cee09baeaffcc1
Reviewed-on: https://gerrit.libreoffice.org/68821
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

After import, SwGetExpField are empty if ShowRedlineChanges=false
because the content from the document is lost in SwGetExpField::Copy().

Example is ooo26330-3.sxw, which then asserts once fields are updated,
but that is a different problem.

(regression from 57f358f1)

Change-Id: I1bf939d69e599919c3a5c5631091ca0a0074d139
Reviewed-on: https://gerrit.libreoffice.org/68820
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

* Update dictionaries from branch 'master'
  - Replace : with # in comments lines
    
    Change-Id: I1bcd51d4dab501a051dd6bebe98380299390fc3b
    Reviewed-on: https://gerrit.libreoffice.org/67282Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
    

* Update dictionaries from branch 'master'
  - tdf#117389 Remove RLM/LRM from Arabic dictionary
    
    Change-Id: I002d7be2de961b7a20d48eed628ae35df0b600df
    Reviewed-on: https://gerrit.libreoffice.org/67281Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
    

The problem was seen here:
https://bugzilla.suse.com/show_bug.cgi?id=1127857.

One needs to call SwGlobals::ensure in order to initialize
SfxApplication via SfxApplication::SetModule(SfxToolsModule::Writer.

Change-Id: I3add24b56dc44a93ad81c1b52539da821f6244fc
Reviewed-on: https://gerrit.libreoffice.org/68839
Tested-by: Jenkins
Reviewed-by: Tomáš Chvátal <tchvatal@suse.cz>

See bt https://bugs.documentfoundation.org/attachment.cgi?id=149389
It seems the method from cui/numpages.cxx takes more things into account

At least, it doesn't crash for the attachment of this tracker

Change-Id: I05ca0b019ac483890bea4acdbb695d73b660e638
Reviewed-on: https://gerrit.libreoffice.org/68033
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

Change-Id: Icf4d3a649c5e6a53035c2a1573a8dd7154db2edd
Reviewed-on: https://gerrit.libreoffice.org/68831
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

For some control parts we need to provide the size or redefine
the size. Previously this was hardcoded, but this adds new
attriburtes for widget part definition:
- width, height: defines size for buttons in spinbox, the size of
  the checkbox or radiobutton
- margin-width, margin-height: increases the size (margin) of
  tab items by the specified amount

Change-Id: Ieea69b92ad21adc4f4954e7555f4d59348f5dea8
Reviewed-on: https://gerrit.libreoffice.org/68829
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

...and remove all the "any" from definition.xml

Change-Id: I8a91129c89255c83c1c2f975bf9acb710b664efc
Reviewed-on: https://gerrit.libreoffice.org/68828
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: Ic19bd2167cc359eef02648fa0ebd1d858fdeaec5
Reviewed-on: https://gerrit.libreoffice.org/68827Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I63231929679377a53b85aa7e2ee5363512f23912
Reviewed-on: https://gerrit.libreoffice.org/68834
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: Icafc637004e219b523c862cb5fbad55a2bd4eaaf
Reviewed-on: https://gerrit.libreoffice.org/68835
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Idd125c18bee1a39b9ea8cc4f8c55cddfd37c33e1
Reviewed-on: https://gerrit.libreoffice.org/68579
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>