It passed "make check" on Linux.

Change-Id: I893b7873f3a7d3f43bf742f2ee126524310dfafb
Reviewed-on: https://gerrit.libreoffice.org/61029Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: If22b13087ab193ed37ca092c2b252579d5ac5d0e
Reviewed-on: https://gerrit.libreoffice.org/61003
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

This way it's easier to read the follow up patch.

Change-Id: I42e8f78b69b4ed2cb28bf0f36496eb751e8cb433
Reviewed-on: https://gerrit.libreoffice.org/61036
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Also removes the function comments before the implementations,
as these are just the same as already in the header.

Change-Id: I11425dc4aa372423fcf469ab1374159ce8b180e2
Reviewed-on: https://gerrit.libreoffice.org/61035
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Change-Id: I3473cb5a565aba822428178030572325425c6a13
Reviewed-on: https://gerrit.libreoffice.org/61030
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I355fad84ed8765e8eb3fadb7c239b3b902ec1747
Reviewed-on: https://gerrit.libreoffice.org/61059
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I1493733ebbe796e4ba3ec6f2dc69b4b91f79efdf
Reviewed-on: https://gerrit.libreoffice.org/61027
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Id179245161d707e27e009b6ebc53d925aae5ce0f
Reviewed-on: https://gerrit.libreoffice.org/61000
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I7c3209dff1c09c40d7a3bb57db0f0b26254318f2
Reviewed-on: https://gerrit.libreoffice.org/60996
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I835e37a99ddab174e45681fe6cf55edaa41a727c
Reviewed-on: https://gerrit.libreoffice.org/60995
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I9fc3364d83fa5e55cee6c823f16c05934ee2dc43
Reviewed-on: https://gerrit.libreoffice.org/61053
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Happened while trying the qt5 a11y stuff that mpWindowImpl was invalid.

Change-Id: Ibe238bdcce6410689b1e65f7f45f7b9deea06de7
Reviewed-on: https://gerrit.libreoffice.org/61032
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: Ie2ef115bc655d0f64e8b269e73d3343176f115e3
Reviewed-on: https://gerrit.libreoffice.org/61042
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

It passed "make check" on Linux

Change-Id: Id25a7893e536a579cef58f63e8ec7ce240ad16fb
Reviewed-on: https://gerrit.libreoffice.org/60633
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

It passed "make check" on Linux.

Change-Id: I96b34c818f6d4170c110ecd1fb93af79c3279e57
Reviewed-on: https://gerrit.libreoffice.org/61028
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

...that had been removed with 28b4f4ae "Get rid
of Windows .def files in setup_native, use __declspec(dllexport)".  Looks like
for 32-bit builds, the .def file EXPORTS are still needed to avoid __stdcall's
_...@NN symbol decoration (and for 64-bit builds __stdcall is effectively
ignored, so the removed .def files didn't make a difference there).

This is only a partial revert of 28b4f4ae, the
addition of __declspec(dllexport) for the benefit of loplguin:external should
still be fine.

Change-Id: I76a1a3f4671824367bab495afeba291c0340108d
Reviewed-on: https://gerrit.libreoffice.org/61047
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

RES_POOLCOLL_HTML_HR had the absolute minimum width of 1 (0.05pt).
Dividing by 3 in the "convert to word size" formula returned zero.
It looks like import or export must increase the size to 3 because
round-tripping in ODT format loads in a larger value that works
when resaving as .doc.

cui/source/tabpages/border.cxx sets the default for a double
style border to 10, but the minimal value of 3 will be better
since it matches the ODT round-tripped value (and looks more
like a single line which people probably expect from the
horizontal line).

Change-Id: I32a90f2add3fe746359cd9cece14762ccc2a58c1
Reviewed-on: https://gerrit.libreoffice.org/61022
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>

If the tblBorder does not exist, or if first row's
left-border has a different sized border than the
overall table settings, use the cell's lineWidth
value to determine the the spacing needed.

The potential regression here is the spacing given to
the cells. However, the current calculation is totally
wrong (it needs to be based on per-cell, not on some
table-level default) and so it was "wrong" a different
way before. The unit test shows this visually.

Plus, MS Office version are inconsistent in handling this
unit test. The latest versions base the position on the
*last* row and not the first row.

The key reason for making this change is to support a
table that doesn't have a table default, needed to
fix tdf#92026.

Change-Id: I319513a2f5550c1527dc564fb8b3806d1251a0c2
Reviewed-on: https://gerrit.libreoffice.org/60988
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>

It passed "make check" on Linux.

Change-Id: Ia28f23b78b467fc70431fa4a7ed41ae2f3a4c5fd
Reviewed-on: https://gerrit.libreoffice.org/61046Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins

Change-Id: Ie46de317003ebbfca3ee99d7ab60bef4ac762f76
Reviewed-on: https://gerrit.libreoffice.org/61054
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I921db377c257dc50e3f39fe04f0ad093f3db6a81
Reviewed-on: https://gerrit.libreoffice.org/59896
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>

...found by <https://ci.libreoffice.org//job/lo_tb_random_config_linux/1504/>

Change-Id: I8ebbe48cdbbdf378731bbc4548031d8799d91532
Reviewed-on: https://gerrit.libreoffice.org/61023
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

The problem in the bugdoc is that there are 2 styles; "First Page"
has "Default Style" as the follow, and vice versa.

When the "First Page" style is copied, its follow is copied as well, but
the follow of the follow doesn't point to the *new* "First PageN" style
that was just created, but the original "First Page" one.

Change-Id: Ie5b0064581a585a3a545360ea5c05f60652f0d4e
Reviewed-on: https://gerrit.libreoffice.org/60993
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

Change-Id: Iaf34e5f14b0753960a13b0a9ff3d734bfc08d139

Change-Id: Idedcaddeab80fcfdc3d5a4f2852712827a98e848

Not just some stuff in one corner. When using this test code, I want
to see the borders of the actual (combined) tiles that we attempt to
render.

Change-Id: I270d5a6b16ec717f8613def57d710b97fbd33672

I am writing a separate unit test app that will include selected
existing unit tests that make sense and are important to run on iOS.

Change-Id: I4722f1ed872ba21e181eeba5ed3b58e82d8fed72
Reviewed-on: https://gerrit.libreoffice.org/61049Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>

Change-Id: Icf508473d194bc8c6f01e551b6659a625b8ee229
Reviewed-on: https://gerrit.libreoffice.org/60141
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Change-Id: I38d86705de3215a7e8c24f03c2d253751e66b2d8
Reviewed-on: https://gerrit.libreoffice.org/61040
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Widget tree is displayed and basic role mapping is available.
Still needs quite some work (positions, actions, texts, etc.)

Change-Id: I9d26a762f1d9684f33bbb80a384cf2a0b8a905c0
Reviewed-on: https://gerrit.libreoffice.org/60853
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Regression from 2157a353

  sfx2 store: try rename before copying

  Rename is cheaper then copying the content over manually, so try that
  first.

On Windows, we need to keep the file's dentity, including metadata (e.g.,
creation time, which is kept in FS). WinAPI has ReplaceFileW specifically
for this, and it keeps ACLs of the original file, and otherwise makes the
changed file not a separate entry, but updated old file from system's PoV.

Eventually, we could try to restructure creating backup copies (e.g., for
documents when configured so) to take advantage of this function being able
to do that.

Change-Id: I6001a2a3af5e10bc010f5ef129f4bb6f83ee1581
Reviewed-on: https://gerrit.libreoffice.org/60163Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins

since...

commit c6b8587e
Date:   Wed Sep 19 16:35:10 2018 +0200

    loplugin:useuniqueptr in SvxRTFParser

Change-Id: Id901d5645500fedcb54b11e1b5b27fe81281f5a2
Reviewed-on: https://gerrit.libreoffice.org/61033Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I9f477e063fd764fff24843562a2de34b5498d4c5
Reviewed-on: https://gerrit.libreoffice.org/61038Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I0542342f4a55bf4740fd8360b8e26dbd7e2ffa2d
Reviewed-on: https://gerrit.libreoffice.org/61031
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I53a88116148db9e1ceac4024781516173c3d4666
Reviewed-on: https://gerrit.libreoffice.org/61021Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins

Change-Id: Icfe120db02a70d43e4120d1f4cbb2704640d3990
Reviewed-on: https://gerrit.libreoffice.org/59470
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

implemeent a reduction approach, which is good at finding virtual
methods that only themselves or their virtual partners.

The accessibility GetVisArea stuff is dead since
    commit 891e41fa
    Date:   Wed Apr 4 11:23:22 2018 +0200
    dead code in AccessibleTextHelper_Impl::UpdateVisibleChildren

Change-Id: I78d9d8bca585ecec8394f2c3fe2baa93db0e58f5
Reviewed-on: https://gerrit.libreoffice.org/60912
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Iea80ffff0b36e093e4b8e513e924a21da67cb2ce
Reviewed-on: https://gerrit.libreoffice.org/61009Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I5496bf0bcce442c60d2ecd4207734d0e8b17935b
Reviewed-on: https://gerrit.libreoffice.org/61026
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: I1dc3041408c3f9fa9ce6023d7c668bc5baa65b4e
Reviewed-on: https://gerrit.libreoffice.org/61025
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>