Found with bin/find-unneeded-includes
Only removal proposals are dealt with here
and only for files that are actually compiling

Change-Id: I70357eade9552984fdb3b7590f1e8237a02a7d1d
Reviewed-on: https://gerrit.libreoffice.org/65650
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: I3e6c7f5af6edb1c7ae4867aa46f56fec695e5bcf
Reviewed-on: https://gerrit.libreoffice.org/65984
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: Iea1d992fb7b7e0d60ee3432a20b74cb8d312fc08
Reviewed-on: https://gerrit.libreoffice.org/65991
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

The current TAB-ing order of Gallery sidebar panel is not sequential
and the order needed to be changed. This patch fixes the TAB-ing order
of the gallery sidebar panel to a more sequential and convenient one.
It also fixes the reverse TAB-ing order (Shift+TAB).

Change-Id: Ib0b22ccef1fa4676e535f42a794fb7c836741d0b
Reviewed-on: https://gerrit.libreoffice.org/65907Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: Ie212034c286146067c3ce49e62b2c47478ad7282
Reviewed-on: https://gerrit.libreoffice.org/65967
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

This reverts commit 144ee02f.

Change-Id: I8dac626851895b67d24a2ee413c0121f7a5cfe16
Reviewed-on: https://gerrit.libreoffice.org/65988
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>

a few problems here

*) each symbol was drawn on top of the previous one instead of clearing it
*) some spurious placeholder text in the menu entry
*) m_nSymbolType not set correctly on activation of a submenu entry
*) under gtk3 adding entries to the submenus didn't inform the
   menubutton of their addition
*) we can drop m_xMenu because set_item_sensitive can be used
   instead, which didn't exist at the initial time of writing

Change-Id: Id339992c4192f3782fddfd56cb3e9b67cfcbe2a2
Reviewed-on: https://gerrit.libreoffice.org/65977
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ie7e97d3beedfa007243e4a6b7408341857f2d903
Reviewed-on: https://gerrit.libreoffice.org/65979
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

And use that in sfx2 Redaction code to be independent of
the document/module type

Change-Id: Ic206f7a10a27d8d44566df34a10d009a34adf0a5
Reviewed-on: https://gerrit.libreoffice.org/65971
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>

Change-Id: I3e91bc82e5857116f5d94103a7c22ce333e4f89b
Reviewed-on: https://gerrit.libreoffice.org/65976
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>

Normally the first section is considered a BreakCode == 2,
which guarantees that the headers/footers will attempt
to be written.
In the cases where it isn't, the very first section
definitely needs to include any possible Headers/Footers.

This was already done for DOCX via bug 78606 in LO 5.0.

Both DOCX and RTF seem to ignore this first aSect,
so this change won't affect them.

Change-Id: Ie08eedea9202f0922e0e505a92fe4a66ef6c4a24
Reviewed-on: https://gerrit.libreoffice.org/65859
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>

Change-Id: Ic698f23e71dbc613db2acf884fdefdeab06fde0f
Reviewed-on: https://gerrit.libreoffice.org/65968
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

... and not SetRedlineFlags(), similar to the way the ODF filter does it.

The RTF/DOCX filters don't appear to be able to export the show/hide
flag currently, they can only handle the enabled flag.

Change-Id: I76bc19292882d7de5c28ea6afe0f81eadbd4a04f
Reviewed-on: https://gerrit.libreoffice.org/65966
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

Rearrange the code added in 15f1555d
to set all layouts to non-hidden before moving redlines in the model.

tdf52550-1.doc contains lots of consecutive delete redlines that
when exported to ODF trigger asserts about wrong start nodes in
CheckParaRedlineMerge().

Change-Id: I89c3d4fefd26691a9632807b9899138eee895fff
Reviewed-on: https://gerrit.libreoffice.org/65965
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

Change-Id: I0664d1b39e97b7555c0a3cba442db52b84f37134
Reviewed-on: https://gerrit.libreoffice.org/65960
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

Change-Id: I0f2f69bc1c5ed15ff4c2580ad7d81259add27007
Reviewed-on: https://gerrit.libreoffice.org/65948Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins

Use range-based loop or replace with STL functions

Change-Id: Ia117ee3bea76c1cee84c0d2bb43195c59764fe93
Reviewed-on: https://gerrit.libreoffice.org/65961
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I816269e022ad85f247f8691f669898beb24775b6

Change-Id: I98e29a832509f4ea0453f92ccd6fb274e39b5afc
Reviewed-on: https://gerrit.libreoffice.org/65956
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I3d103dcb6ebb81d50bb8a10371dba7feb92c421d
Reviewed-on: https://gerrit.libreoffice.org/65924
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

by removing the DOCX custom number format string
which caused a syntax error message here instead
of the formula calculation.

Change-Id: Ia643e966440117871f6b4ddceab610100ac34138
Reviewed-on: https://gerrit.libreoffice.org/65945
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>

Change-Id: Ic307226591ff9702957ccdec486ccf70357eb6d9
Reviewed-on: https://gerrit.libreoffice.org/65951
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I54bd8fbac488182d2017e90b7afced2659f01728
Reviewed-on: https://gerrit.libreoffice.org/65955
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Id5c7e66b8f8bc324f097dd739ce683d74fc6491b
Reviewed-on: https://gerrit.libreoffice.org/65953
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I99f1611f41378a0baa7688db5a5f78e0169f0d5b
Reviewed-on: https://gerrit.libreoffice.org/65649
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

lcov points out this was uncovered previously.

Change-Id: I831b7e6c2b475d2b3ddd64fb21714c3b6667832a
Reviewed-on: https://gerrit.libreoffice.org/65944
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: I20aa503bb011d7222ecc29cb87bb72c0f3ee7539
Reviewed-on: https://gerrit.libreoffice.org/65949
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I7f67b4c9a157d7a1a5992174397c061b14c8a674
Reviewed-on: https://gerrit.libreoffice.org/65952
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ie628d666f3f8d8bf0cfefd212706d5ce4e76dfe0
Reviewed-on: https://gerrit.libreoffice.org/65946
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

like the other smart pointer types

Change-Id: I3ac1888c84fc1411cdfc3357b005afbb3b7d8bbe
Reviewed-on: https://gerrit.libreoffice.org/65926Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

In my testing on Windows, the crashing scenario was this:
1. FileDialogHelper_Impl::updateVersions() creates storage calling
   comphelper::OStorageHelper::GetStorageFromURL;
2. Content::openStream() calls isDocument first;
3. Content::isDocument() indirectly initiates WebDAV session,
   creating a NeonSession;
4. All operations of NeonSession call Init() first; its first call
   initializes m_pHttpSession using ne_session_create, and then
   adds auth callbacks using ne_add_server_auth/ne_add_proxy_auth
5. Then NeonSession performs the rest of PROPFIND task, calling
   ah_post_send and auth_challenge; the latter fails, then
   ah_post_send calls clean_session, which cleans m_pHttpSession's
   auth_session's sspi_host;
6. NeonSession::HandleError throws DAVException for NE_AUTH error;
7. Content::isDocument() returns true to Content::openStream(),
   which proceeds to execute the command, which in turn re-uses
   the NeonSession and its m_pHttpSession;
8. NeonSession::OPTIONS then indirectly calls continue_sspi, which
   tries to dereference the m_pHttpSession's auth_session's
   sspi_host which is nullptr at this point.

So in case NeonSession detects the NE_AUTH error condition, let's
set a flag indicating that the next Init() should reinitialize its
m_pHttpSession.

Also fixed a case when xProps was used before initialization in
Content::getPropertyValues.

Change-Id: Ifc9eec4fe0333ff6be17c5089068441b4a6eb78c
Reviewed-on: https://gerrit.libreoffice.org/65950
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

It explains better, what this button is.

Change-Id: I93b78c7907686179ec4fe6b3f45daa15c846c316
Reviewed-on: https://gerrit.libreoffice.org/65942
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

To draw any shape with EMF+ the shape needs to be created
and next the transformation matrix needs to be applied.
Unfortunately for Ellipse, Arc and Pie only position and ratio
was transformed. The rotation was not handled correctly.
With this patch the transformation matrix is applied after
creation of the shape.

Change-Id: I63a797e7cddfd304f94e7e5c8e2ce15063dc55e5
Reviewed-on: https://gerrit.libreoffice.org/65898
Tested-by: Jenkins
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

It's yet unclear whether
ECMA-376-1:2016 OOXML 18.17.7.127 FREQUENCY
"A call to FREQUENCY shall be an array formula."
indicates that the entire formula expression should be in array
mode as well, see
https://bugs.documentfoundation.org/show_bug.cgi?id=122301#c8

If so, that will need a follow-up change.

Change-Id: Ic302d25631fb870b46989b922c95912ab5d123df
Reviewed-on: https://gerrit.libreoffice.org/65940Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

Just like bug 121374 for DOCX, which was just fixed in LO62,
DOC apparently also sometimes can miss out on headers and footers.

It wouldn't be terrible to duplicate headers/footers
unnecessarily, but it is terrible to have them disappear.
If the last SectPr has no idea about the section start,
it can't know whether it is continuous or started with
a page break. In that case, just ensure that the
header and footer are explicitly written out.

RTF continues to work without this in all known cases.

Change-Id: I93f2b08535a3548c0a9e9bcdb6ee2cd965dc8367
Reviewed-on: https://gerrit.libreoffice.org/65840
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>

Change-Id: Id7c8d5eb7f865db5db82beffe96dab605d8ae36f
Reviewed-on: https://gerrit.libreoffice.org/65941Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Put various preps into place, that enable us to read txbxContent from
group shape children via the writerfilter parser, which gets us much
more features

Also:
- store shapecontexthandler on wrapper class in writerfilter
- move adding children shapes to ctor, not dtor
- remove RuntimeException in Writer's XShapes::add(), aligns this
  with Draw/Impress API semantics, and helps here when trying to
  add the same shape a 2nd time (which we then simply ignore)
- make oox's Shape notion of 'inside group' less ad-hoc
- make SwTextBoxHelper::getTextRectangle() cope with more than
  CustomShape - so passing in a group shape will also yield some
  sensible bounding box
- have SwTextBoxHelper handle group content, too
- derive WpsContext from ShapeContext, so we can later substitute it
  for that inside WpgContext
- keep WpgContext::onCreateContext() _for the moment_ with the old
  delegation to ShapeContext (needs to use WpsContext to enable
  writerfilter text input)

Change-Id: I2b0f0583e21137f3321a8dc13823058b14d19773
Reviewed-on: https://gerrit.libreoffice.org/65914
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

createStyleMatrixContext() assumed that <dgm:style> contains
<dgm:fontRef>, but it contains <a:fontRef> instead.

This resulted in a 0 mnThemedIdx, which meant that since commit
89206c47 (bnc#862510: PPTX import: Wrong
text color inside shape, 2014-12-21) we ignored the theme color in
oox::drawingml::Shape::createAndInsert().

Change-Id: I81045fa58df5cb9e31a4ed3f1b1625224bcd06ad
Reviewed-on: https://gerrit.libreoffice.org/65938Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

  * Creates one GDIMetaFile from each Writer page
  * Inserts them as Shapes into the newly created Draw doc
  * Has some 'magic' numbers needs to be figured out
  * Tried with a 100-page Writer doc, seems okay
  * Seems slow, might need to be optimized
    * Seems like getDocumentSizeInPixels() and getDocumentSizeIn100mm()
      are consuming most of the cycles. Will look into this at the end.

Change-Id: Ie40cd64b69fad3e66d74b6b05600cb9f52f1021b
Reviewed-on: https://gerrit.libreoffice.org/65847
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>

Change-Id: Id068f1c1b70c3db3d3a0faa5ebe7706f205fe4da
Reviewed-on: https://gerrit.libreoffice.org/65932
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>