A very basic implementation of the proposed std::array_view, similar to
clang's llvm::ArrayRef.

Mostly cribbed from the string_view implementation :-)

Use it for the SfxDispatcher::setSlotFilter function

Change-Id: Ife7e4971741b41827e145787899872c9b2bea82b
Reviewed-on: https://gerrit.libreoffice.org/38817Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I5a6319ba1667af6e9b7b92c22f858188c28c4c61
Reviewed-on: https://gerrit.libreoffice.org/38835Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Icd02f63e9738c0bb91348e2084649f9edc281e67
Reviewed-on: https://gerrit.libreoffice.org/38833Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I67d176003f39992cd0ff9271a7d6ce26d2cb6619
Reviewed-on: https://gerrit.libreoffice.org/38828Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

... instead of double checked locking patterns.

Change-Id: I1b86ce723ff22dd357b3ed69a52757b085472424
Reviewed-on: https://gerrit.libreoffice.org/38906Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

In this case we can not update right now.

Change-Id: I19cda5ddef448ff81e1ca457774b2db036038c88

Change-Id: I6b3bbe9dda2461ed83ef8b4e15179ad345c08bd4

Change-Id: Id9df2e685b7a7ff420bb7289089dc1e5c5f5c074

Project: help  1a2f0ac70b638ac316e081ba2b72309829f00fcc

tdf#84675 Add help page for NPer function of VBA

Change-Id: Id601138bc4ad390f8ec6c14fe41dc1f936ab5aab
Reviewed-on: https://gerrit.libreoffice.org/38902Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br>
Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>

which means that SfxObjectShell::GetMiscStatus becomes unused

Change-Id: I5c89a2cd5c77c7f08a57fdac08237aab514fc7fa
Reviewed-on: https://gerrit.libreoffice.org/38843Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Project: help  139a1c699caadd5365e335a432ffd5fdad8d73de

tdf#84675 Add help page for MIRR function of VBA

Change-Id: I7b55b4994a1c65b714be3ad4114aee9233502276
Reviewed-on: https://gerrit.libreoffice.org/38897Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br>
Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>

Project: help  23d9c94939bb42e08f5e21579748e00dde514073

tdf#84675 Add help page for IRR function of VBA

Change-Id: If4218b4b9619766e25676d5c4be35db42d51b007
Reviewed-on: https://gerrit.libreoffice.org/38896Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br>
Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>

Additionally, it *may* have caused document corruption when loading such an
.xlsx file, though a small test case with an embedded literal tab character
could not reproduce the behaviour.
See
https://ask.libreoffice.org/en/question/100615/sudden-corruption-of-xlsx-file-bug/
and note that the literal tab character is a mere assumption, but it would be
possible.

Change-Id: Ia9d33955f1196222d335a1a4807fba78df4e4d85

...in code recently introduced with cea45899
"tdf#106679 UI:SideBar Master Slide Button label corrected", causing
CppunitTest_sd_svg_export_tests to fail with

> sd/source/ui/sidebar/SlideBackground.cxx:178:41: runtime error: downcast of address 0x6130001f60c0 which does not point to an object of type 'sd::DrawViewShell'
> 0x6130001f60c0: note: object is of type 'sd::slidesorter::SlideSorterViewShell'
>  4d 02 80 04  f0 16 e8 25 5c 7f 00 00  50 5e 1c 00 b0 60 00 00  80 47 64 00 10 61 00 00  90 63 87 00
>               ^~~~~~~~~~~~~~~~~~~~~~~
>               vptr for 'sd::slidesorter::SlideSorterViewShell'
>     #0 0x7f5c22d85a7f in sd::sidebar::SlideBackground::Initialize() sd/source/ui/sidebar/SlideBackground.cxx:178:41
>     #1 0x7f5c22d8d5fd in sd::sidebar::SlideBackground::SlideBackground(vcl::Window*, sd::ViewShellBase&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&, SfxBindings*) sd/source/ui/sidebar/SlideBackground.cxx:135:5
>     #2 0x7f5c22d0d440 in VclPtr<sd::sidebar::SlideBackground> VclPtr<sd::sidebar::SlideBackground>::Create<VclPtr<vcl::Window>&, sd::ViewShellBase&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame>&, SfxBindings*&>(VclPtr<vcl::Window>&, sd::ViewShellBase&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame>&, SfxBindings*&) include/vcl/vclptr.hxx:131:46
>     #3 0x7f5c22d013fb in sd::sidebar::PanelFactory::createUIElement(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) sd/source/ui/sidebar/PanelFactory.cxx:129:20
>     #4 0x7f5c22d01b4a in non-virtual thunk to sd::sidebar::PanelFactory::createUIElement(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) sd/source/ui/sidebar/PanelFactory.cxx
>     #5 0x7f5bd0ff8577 in (anonymous namespace)::UIElementFactoryManager::createUIElement(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) framework/source/uifactory/uielementfactorymanager.cxx:443:39
>     #6 0x7f5bd0ffe46a in non-virtual thunk to (anonymous namespace)::UIElementFactoryManager::createUIElement(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) framework/source/uifactory/uielementfactorymanager.cxx
>     #7 0x7f5c1a9de8e7 in sfx2::sidebar::SidebarController::CreateUIElement(com::sun::star::uno::Reference<com::sun::star::awt::XWindowPeer> const&, rtl::OUString const&, bool, sfx2::sidebar::Context const&) sfx2/source/sidebar/SidebarController.cxx:852:32
>     #8 0x7f5c1a9d794d in sfx2::sidebar::SidebarController::CreatePanel(rtl::OUString const&, vcl::Window*, bool, sfx2::sidebar::Context const&, VclPtr<sfx2::sidebar::Deck> const&) sfx2/source/sidebar/SidebarController.cxx:793:43
>     #9 0x7f5c1a9d5a09 in sfx2::sidebar::SidebarController::CreatePanels(rtl::OUString const&, sfx2::sidebar::Context const&) sfx2/source/sidebar/SidebarController.cxx:625:41
>     #10 0x7f5c1a9d3535 in sfx2::sidebar::SidebarController::CreateDeck(rtl::OUString const&, sfx2::sidebar::Context const&, bool) sfx2/source/sidebar/SidebarController.cxx:578:9
>     #11 0x7f5c1a9ccdee in sfx2::sidebar::SidebarController::SwitchToDeck(sfx2::sidebar::DeckDescriptor const&, sfx2::sidebar::Context const&) sfx2/source/sidebar/SidebarController.cxx:708:5
>     #12 0x7f5c1a9bc841 in sfx2::sidebar::SidebarController::UpdateConfigurations() sfx2/source/sidebar/SidebarController.cxx:496:13
>     #13 0x7f5c1a9b9815 in sfx2::sidebar::SidebarController::notifyContextChangeEvent(com::sun::star::ui::ContextChangeEventObject const&) sfx2/source/sidebar/SidebarController.cxx:282:9
>     #14 0x7f5bd059e2a9 in (anonymous namespace)::ContextChangeEventMultiplexer::BroadcastEventToSingleContainer(com::sun::star::ui::ContextChangeEventObject const&, com::sun::star::uno::Reference<com::sun::star::uno::XInterface> const&) framework/source/services/ContextChangeEventMultiplexer.cxx:269:27
>     #15 0x7f5bd0590328 in (anonymous namespace)::ContextChangeEventMultiplexer::broadcastContextChangeEvent(com::sun::star::ui::ContextChangeEventObject const&, com::sun::star::uno::Reference<com::sun::star::uno::XInterface> const&) framework/source/services/ContextChangeEventMultiplexer.cxx:248:5
>     #16 0x7f5c0e48b44c in ContextChangeEventMultiplexer::NotifyContextChange(com::sun::star::uno::Reference<com::sun::star::frame::XController> const&, vcl::EnumContext::Context) svx/source/sidebar/ContextChangeEventMultiplexer.cxx:49:27
>     #17 0x7f5c0e48bfa0 in ContextChangeEventMultiplexer::NotifyContextChange(SfxViewShell*, vcl::EnumContext::Context) svx/source/sidebar/ContextChangeEventMultiplexer.cxx:59:9
>     #18 0x7f5c233622a0 in sd::slidesorter::SlideSorterViewShell::Activate(bool) sd/source/ui/slidesorter/shell/SlideSorterViewShell.cxx:491:5
>     #19 0x7f5c192e6f13 in SfxShell::DoActivate_Impl(SfxViewFrame*, bool) sfx2/source/control/shell.cxx:313:5
>     #20 0x7f5c1909261f in SfxDispatcher::DoActivate_Impl(bool) sfx2/source/control/dispatch.cxx:743:42
>     #21 0x7f5c1b09783a in SfxViewFrame::DoActivate(bool) sfx2/source/view/viewfrm.cxx:1036:20
>     #22 0x7f5c1878dc80 in SfxApplication::SetViewFrame_Impl(SfxViewFrame*) sfx2/source/appl/app.cxx:313:21
>     #23 0x7f5c1b09763e in SfxViewFrame::SetViewFrame(SfxViewFrame*) sfx2/source/view/viewfrm.cxx:2985:19
>     #24 0x7f5c1b0b12c1 in SfxViewFrame::MakeActive_Impl(bool) sfx2/source/view/viewfrm.cxx:1611:21
>     #25 0x7f5c1aff905d in SfxBaseController::ConnectSfxFrame_Impl(SfxBaseController::ConnectSfxFrame) sfx2/source/view/sfxbasecontroller.cxx:1304:33
>     #26 0x7f5c1aff1cc4 in SfxBaseController::attachFrame(com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) sfx2/source/view/sfxbasecontroller.cxx:569:13
>     #27 0x7f5c1af714a4 in (anonymous namespace)::SfxFrameLoader_Impl::impl_createDocumentView(com::sun::star::uno::Reference<com::sun::star::frame::XModel2> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&, comphelper::NamedValueCollection const&, rtl::OUString const&) sfx2/source/view/frmload.cxx:601:18
>     #28 0x7f5c1af67b6d in (anonymous namespace)::SfxFrameLoader_Impl::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) sfx2/source/view/frmload.cxx:718:13
>     #29 0x7f5bd050b813 in framework::LoadEnv::impl_loadContent() framework/source/loadenv/loadenv.cxx:1081:37
>     #30 0x7f5bd04f68df in framework::LoadEnv::startLoading() framework/source/loadenv/loadenv.cxx:370:20
>     #31 0x7f5bd04f0a39 in framework::LoadEnv::loadComponentFromURL(com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) framework/source/loadenv/loadenv.cxx:156:14
>     #32 0x7f5bd06c6735 in framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) framework/source/services/desktop.cxx:620:12
>     #33 0x7f5bd06c693a in non-virtual thunk to framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) framework/source/services/desktop.cxx
>     #34 0x7f5bfdb14f64 in unotest::MacrosTest::loadFromDesktop(rtl::OUString const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) unotest/source/cpp/macros_test.cxx:50:60
>     #35 0x7f5c3523aa5d in SdSVGFilterTest::loadURL(rtl::OUString const&, char const*) sd/qa/unit/SVGExportTests.cxx:52:23
>     #36 0x7f5c352392e1 in SdSVGFilterTest::load(char const*, char const*) sd/qa/unit/SVGExportTests.cxx:42:16
>     #37 0x7f5c3523700e in SdSVGFilterTest::executeExport(char const*) sd/qa/unit/SVGExportTests.cxx:88:9
>     #38 0x7f5c3522cf4a in SdSVGFilterTest::testSVGExportTextDecorations() sd/qa/unit/SVGExportTests.cxx:94:9
>     #39 0x7f5c3525419d in void std::__invoke_impl<void, void (SdSVGFilterTest::* const&)(), SdSVGFilterTest*&>(std::__invoke_memfun_deref, void (SdSVGFilterTest::* const&)(), SdSVGFilterTest*&) /usr/lib/gcc/x86_64-redhat-linux/6.3.1/../../../../include/c++/6.3.1/functional:227:14
>     #40 0x7f5c35253f0c in std::result_of<void (SdSVGFilterTest::* const&(SdSVGFilterTest*&))()>::type std::__invoke<void (SdSVGFilterTest::* const&)(), SdSVGFilterTest*&>(void (SdSVGFilterTest::* const&)(), SdSVGFilterTest*&) /usr/lib/gcc/x86_64-redhat-linux/6.3.1/../../../../include/c++/6.3.1/functional:250:14
>     #41 0x7f5c35253b68 in _ZNKSt12_Mem_fn_baseIM15SdSVGFilterTestFvvELb1EEclIJRPS0_EEEDTclsr3stdE8__invokedtdefpT6_M_pmfspclsr3stdE7forwardIT_Efp_EEEDpOS7_ /usr/lib/gcc/x86_64-redhat-linux/6.3.1/../../../../include/c++/6.3.1/functional:604:11
>     #42 0x7f5c35253953 in void std::_Bind<std::_Mem_fn<void (SdSVGFilterTest::*)()> (SdSVGFilterTest*)>::__call<void, , 0ul>(std::tuple<>&&, std::_Index_tuple<0ul>) /usr/lib/gcc/x86_64-redhat-linux/6.3.1/../../../../include/c++/6.3.1/functional:933:11
>     #43 0x7f5c35253380 in void std::_Bind<std::_Mem_fn<void (SdSVGFilterTest::*)()> (SdSVGFilterTest*)>::operator()<, void>() /usr/lib/gcc/x86_64-redhat-linux/6.3.1/../../../../include/c++/6.3.1/functional:991:17
>     #44 0x7f5c35251cf9 in std::_Function_handler<void (), std::_Bind<std::_Mem_fn<void (SdSVGFilterTest::*)()> (SdSVGFilterTest*)> >::_M_invoke(std::_Any_data const&) /usr/lib/gcc/x86_64-redhat-linux/6.3.1/../../../../include/c++/6.3.1/functional:1731:2
>     #45 0x7f5c35254a3b in std::function<void ()>::operator()() const /usr/lib/gcc/x86_64-redhat-linux/6.3.1/../../../../include/c++/6.3.1/functional:2127:14
>     #46 0x7f5c35250377 in CppUnit::TestCaller<SdSVGFilterTest>::runTest() workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:175:7
>     #47 0x7f5c7a739862 in CppUnit::TestCaseMethodFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:32:5
>     #48 0x7f5c5e7a4b64 in (anonymous namespace)::Protector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) test/source/vclbootstrapprotector.cxx:39:14
>     #49 0x7f5c7a6fad02 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25
>     #50 0x7f5c6a84e214 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) unotest/source/cpp/unobootstrapprotector/unobootstrapprotector.cxx:89:12
>     #51 0x7f5c7a6fad02 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25
>     #52 0x7f5c6e4ff426 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) unotest/source/cpp/unoexceptionprotector/unoexceptionprotector.cxx:63:16
>     #53 0x7f5c7a6fad02 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25
>     #54 0x7f5c7a66edcf in CppUnit::DefaultProtector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) workdir/UnpackedTarball/cppunit/src/cppunit/DefaultProtector.cpp:15:12
>     #55 0x7f5c7a6fad02 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25
>     #56 0x7f5c7a6f1eb2 in CppUnit::ProtectorChain::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:86:18
>     #57 0x7f5c7a7ba5fa in CppUnit::TestResult::protect(CppUnit::Functor const&, CppUnit::Test*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:182:28
>     #58 0x7f5c7a737b03 in CppUnit::TestCase::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:91:13
>     #59 0x7f5c7a73c128 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:30
>     #60 0x7f5c7a73b1ae in CppUnit::TestComposite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3
>     #61 0x7f5c7a73c128 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:30
>     #62 0x7f5c7a73b1ae in CppUnit::TestComposite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3
>     #63 0x7f5c7a7f9470 in CppUnit::TestRunner::WrappingSuite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:47:27
>     #64 0x7f5c7a7b8bcb in CppUnit::TestResult::runTest(CppUnit::Test*) workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:149:9
>     #65 0x7f5c7a7fa670 in CppUnit::TestRunner::run(CppUnit::TestResult&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:96:14
>     #66 0x533c2e in (anonymous namespace)::ProtectedFixtureFunctor::run() const sal/cppunittester/cppunittester.cxx:316:20
>     #67 0x52fa86 in sal_main() sal/cppunittester/cppunittester.cxx:466:20
>     #68 0x52e38f in main sal/cppunittester/cppunittester.cxx:373:1
>     #69 0x7f5c78901400 in __libc_start_main /usr/src/debug/glibc-2.24-51-g7b60553/csu/../csu/libc-start.c:289
>     #70 0x438989 in _start (workdir/LinkTarget/Executable/cppunittester+0x438989)

Change-Id: I3f819308f9525539dc0672dabb6b57d0171a7cf4
Reviewed-on: https://gerrit.libreoffice.org/38884Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Tested-by: Jenkins <ci@libreoffice.org>

This might actually matter in practice given

https://stackoverflow.com/questions/27422871/does-deletedc-automatically-unselect-objects

"DCs get a default 1x1x1 bitmap when they're created. This will leak if you don't put it back."

Change-Id: Ib2d361995621ad429277ff52cb8c9fdfc0009953
Reviewed-on: https://gerrit.libreoffice.org/38875Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I5622786c5192ea7a5225f3b9cd81a4b6a0dae594
Reviewed-on: https://gerrit.libreoffice.org/38877Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I6d77039f0cafe0f436cc687bb424588a59c3d464

Change-Id: I221c81ff2f0bee7a8643304201722dbbbc114bec

Change-Id: I672bbb2ac30c5e27b729fe34e206642e436c076b

Change-Id: Ic0cfa565048793181ece17b33337e011028a2aad

Change-Id: I5261d8d96f83b8b81b0dc2576cbd9241705ae9b7

Change-Id: I563aa8ee285d4c2ecdb45835b5cee38074295106

Change-Id: I8c605e2c64fee4d369732f783cc9dd76f7dc858c

This is a follow-up to 45a7f5b6 "Keep WID ranges
sorted, and join adjacent ones".  While SfxItemSet::MergeRange relies on the
m_pWhichRanges being sorted (and, under DBG_UTIL, asserts if they are not), the
various SfxItemSet constructors curiously only check (via assert or DBG_ASSERT)
that each individual range has an upper bound not smaller than its lower bound.
Arguably, all SfxItemSet instances should fulfill the stronger guarantees
required and checked by MergeRange.

And in many cases the ranges are statically known, so that the checking can
happen at compile time.  Therefore, replace the two SfxItemSet ctors taking
explicit ranges with two other ctors that actually do proper checking.  The
(templated) overload taking an svl::Items struct should be used in all cases
where the range values are statically known at compile time, while the overload
taking a std::initializer_list<Pair> is for the remaining cases (that can only
do runtime checking via assert).  Most of those latter cases are simple cases
with a single range covering a single item, but a few are more complex.

(At least some of the uses of the existing SfxItemSet overload taking a

  const sal_uInt16* pWhichPairTable

can probably also be strengthened, but that is left for another day.)

This commit is the first in a series of two.  Apart from the manual changes to
compilerplugins/clang/store/sfxitemsetrewrite.cxx, include/svl/itemset.hxx, and
svl/source/items/itemset.cxx, it only consists of automatic rewriting of the
relevant SfxItemSet ctor calls (plus a few required manual fixes, see next).
But it does not yet check that the individual ranges are properly sorted (see
the TODO in svl::detail::validGap).  That check will be enabled, and the ensuing
manual fixes will be made in a follow-up commit, to reduce the likelyhood of
accidents.

There were three cases of necessary manual intervention:

* sw/source/core/unocore/unostyle.cxx uses eAtr of enum type RES_FRMATR in
braced-init-list syntax now, so needs explicit narrowing conversion to
sal_uInt16.

* In sw/source/uibase/uiview/formatclipboard.cxx, the trailiing comma in the
definition of macro FORMAT_PAINTBRUSH_FRAME_IDS needed to be removed manually.

* In svx/source/svdraw/svdoashp.cxx, svx/source/svdraw/svdotext.cxx,
sw/source/uibase/app/docstyle.cxx, sw/source/uibase/shells/frmsh.cxx,
sw/source/uibase/shells/grfsh.cxx, and sw/source/uibase/shells/textsh1.cxx,
some comments had to be put back (see "TODO: the replaced range can contain
relevant comments" in compilerplugins/clang/store/sfxitemsetrewrite.cxx).

A few uses of the variadic form erroneously used nullptr instead of 0 for
termination.  But this should have been harmless even if promoted std::nullptr_t
is larger than promoted sal_uInt16, assuming that the part of the nullptr value
that was interpreted as sal_uInt16/promoted int was all-zero bits.  Similarly,
some uses made the harmless error of using 0L instead of 0.

Change-Id: I2afea97282803cb311b9321a99bb627520ef5e35
Reviewed-on: https://gerrit.libreoffice.org/38861Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Ib543b4a84305467e8a9ce34bdc2c6a211f399cad

This used to require extra SDKs in days of yore but now just always build
those libraries on WNT.

Change-Id: I92c0a35917df42e136c022c762f0333f657a9ec6

Change-Id: I789051e4721cf9f0af13e1fdb128953c8ba2521e
Reviewed-on: https://gerrit.libreoffice.org/38696Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

The following changes made:
- Unnecessary line breaks makes reading the file difficult
- Convert to doxygen comments
- Move comment at end of file to more appropriate position,
  convert to doxygen style commenting, and remove sig
- Remove unnecessary comments

Change-Id: I0c2c40de953cd9ad90133ca2d96ae742594f4ec6
Reviewed-on: https://gerrit.libreoffice.org/38505Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: I06d0cd4c7986a59f54102f945a560f710887ad8b
Reviewed-on: https://gerrit.libreoffice.org/38514Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: I5a339a4211ec8eb547459996be69610b9f2b3766
Reviewed-on: https://gerrit.libreoffice.org/38147Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: I1131f246c43806adb8a83f6eeafca2b734851a0e
Reviewed-on: https://gerrit.libreoffice.org/38888Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

This was even more confusing than previously..

Change-Id: I9cbdd05e9b59662dfde4a08422d0d2846849719f

Only font name switch (f) is implemented.

Change-Id: I09df8230dff3cf0619065da69bfaf3caad0a39ae
Reviewed-on: https://gerrit.libreoffice.org/38654Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mark Hung <marklh9@gmail.com>

Field commands were closed when a seperator appeared. Those
fields that only had begin and end fldChar just disapeared.

Change-Id: I77928393826a3ffd4a35fb8fe9adeb1892f99683
Reviewed-on: https://gerrit.libreoffice.org/38653Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mark Hung <marklh9@gmail.com>

...that were missing from 3de594d3 "More tests
to suppress (all .PHONY test targets should be covered now)" (and one wasn't
even properly marked as .PHONY).  Thanks to Rene for spotting.

Change-Id: Ieed81a3999921bdfe9bca96c6002d8906b2ddfad

...after 57949716 "Bump GCC baseline to 4.8.1"

Make this a fatal configuration error for now.  The check should be removed
completely after LO 6.0 branch-off.

Change-Id: I70cf65d6b0eb7158008f28449794c66c1b775916
Reviewed-on: https://gerrit.libreoffice.org/38869Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Keep the exclusion for determining the direction, but include them in the final
formula result and selection.

Change-Id: Ic752229bad17ac25de9ef598f3da32e0fd257fd1

Change-Id: Ie5669bd75d9b4be047d98402cb69ac313ab618df
Reviewed-on: https://gerrit.libreoffice.org/38787Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

The intention here is to deny the move of a frame that's inside a table
inside a section.  But the code also checked if there a column frame
in-between, so it allowed the move for a frame in a section with 2 cols,
but not without columns (which does not sound intentional, since that's
a simpler case). So drop the requirement to have a column frame between
the argument and the section frame, just check that there is no table
frame in between.

This is needed, but not enough to split the section in the bugdoc (but
at least now the content of the section is marked as movable).

Change-Id: I9155b291a19c692efc30f01f8e206fac5f1ccf81
Reviewed-on: https://gerrit.libreoffice.org/38858Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Project: help  e24e053c82ad4ee86dd7eb4e9490c9c62af2b291

tdf#107573 help page for change of UI term outline

Change Tools -> Outline numbering to Tools -> Chapter numbering

Change-Id: Id820b226f08d3c224512e34fd96d37ed4c2c300d
Reviewed-on: https://gerrit.libreoffice.org/38853Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br>
Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>