Change-Id: Ibf040e9b48a5545550e1ee830852a75ca82262e7
Reviewed-on: https://gerrit.libreoffice.org/52695Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

collection of heuristics to look for local variables that are never read
from i.e. do not contribute to the surrounding logic

This is an expensive plugin, since it walks up the parent tree,
so it is off by default.

Change-Id: Ib8ba292241bd16adf299e8bba4502cb473513a06
Reviewed-on: https://gerrit.libreoffice.org/52450Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

namely:
com.sun.star.awt.UnoControlProgressBarModel
com.sun.star.awt.UnoControlScrollBarModel
com.sun.star.awt.UnoControlFixedLineModel
com.sun.star.awt.UnoControlRoadmapModel

They seems accidentally dropped at 45fe7716.

Change-Id: Iebd72cadc9eb9bdcb80f9b8c11f6e5e40bdb50a2
Reviewed-on: https://gerrit.libreoffice.org/52673Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Show "Ctrl-click to open..." or "Click to open..." depending on
security options.

Change-Id: I93024a894967ddd378cc436efffb22302f6034d7
Reviewed-on: https://gerrit.libreoffice.org/52672Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: Ia0d35c17dc63fa4bcf1b5ebc2b1989a539017c41
Reviewed-on: https://gerrit.libreoffice.org/52692Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: I8850f20679c330c17b15f964ca7cf320126618af
Reviewed-on: https://gerrit.libreoffice.org/52282Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

Partial regression from 6ca16a4c

Change-Id: Ie9eded8673131e19428411e430951feaf33218bb
Reviewed-on: https://gerrit.libreoffice.org/52701Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I71f4529c2e02fd0ac2561191e4cb35e18e206037
Reviewed-on: https://gerrit.libreoffice.org/52682Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I7fd04d0e09fcbf6d9f2a5ec617f23e08f7bc5fa3
Reviewed-on: https://gerrit.libreoffice.org/52697Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

...like we do resultset.

Thanks to Lionel for this solution

Change-Id: I44f307cd6bddf76716d7c73b8783070abe43bdf3
Reviewed-on: https://gerrit.libreoffice.org/52662Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Jenkins <ci@libreoffice.org>

Revert small part of this commit:
83b7bfc0

Thanks Jan Holesovsky to catching it.

Change-Id: I885c9f3da622052685d1e46f6358783fc7f8cb9a
Reviewed-on: https://gerrit.libreoffice.org/52684Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Also don't accept partial matches ie. CONTAINS != EQUAL,
for VLOOKUP even if document option "search criteria =, <>
for whole cells" is turned off.

This also adds a new spreadsheet test file vlookup2.fods
with the option "search criteria =,<> for whole cells" turned off,
with VLOOKUP test cases that ensures that partial matches are not
accepted.

Change-Id: Ib1f4781b216431546c3fd6967f22518e86abf36b
Reviewed-on: https://gerrit.libreoffice.org/52589Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

Change-Id: I9b41a4b65fda895ed73fa346fb0b8e13df010706
Reviewed-on: https://gerrit.libreoffice.org/52688Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ida9077b19ad78001c632796257651e4314a9a538
Reviewed-on: https://gerrit.libreoffice.org/52676Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Automatic color is determined in SwDrawTextInfo::ApplyAutoColor(), but
it uses this function to determine the background color.

Be consistent and consider the same background in both the
shape-with-editeng-text and shape-with-sw-text cases.

Change-Id: I52249a908193765bc128789d96187af334c1017c
Reviewed-on: https://gerrit.libreoffice.org/52687Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: I9c1ac64745301deda1501806534f13c1527a33b3
Reviewed-on: https://gerrit.libreoffice.org/52670Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Project: help  9bce1e3e0fffe38f701b7452e4e3c7564ea10469

fix validation errors

Change-Id: I0288d52b4420b2be76a136cbd34b1fee87f1cf71
Reviewed-on: https://gerrit.libreoffice.org/52686Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

This reverts commit 2935287e, now that
4544713d "Adapt remaining cpp_uno bridges to
 #i114635#" should fix the underyling issue.

Change-Id: I60c185f724721f251e7e52087c5183cf985c3c4d
Reviewed-on: https://gerrit.libreoffice.org/52671Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I00f83da44d2f07fe570f9ce6c0f506e4204a5ef9
Reviewed-on: https://gerrit.libreoffice.org/52633Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>

so that the next time I accidentally leave one turned on, and commit it,
the buildbots will clean up naturally the next time they run 'make
clean'

Change-Id: Ia09dea9c272c322c7e2773c5458cb54aceb50dd1

Change-Id: Id5cda4775e405ed708de09ee1332cd84461b265d
Reviewed-on: https://gerrit.libreoffice.org/52669Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I343262e0c61e9ecde5395f13732c212197e7fd03

..."C++ UNO bridge should convert non-UNO exceptions into RuntimeException"
(<https://bz.apache.org/ooo/show_bug.cgi?id=114635>), see
<https://lists.freedesktop.org/archives/libreoffice/2018-April/079985.html>
"Re: CppunitTest_sw_filters_test failing on x86 Linux, std::exception ->
uno::RuntimeException".

(The msvc_win32_{intel,x86-64} versions already handle non-UNO exceptions in
their msc{i,x}_filterCppException functions, in a different way.)

Change-Id: Ie359affed6831d16be0de3e3ff065484e28bd9c3
Reviewed-on: https://gerrit.libreoffice.org/52665Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

ever since

commit e0bc1ab9
Date:   Mon Oct 4 16:54:47 2004 +0000

    INTEGRATION: CWS mav09 (1.42.58); FILE MERGED

SdrOle2Obj::SetObjRef calls mpImpl->mxObjRef.Clear();
so SdrOle2Obj::Disconnect_Impl cannot removeobj the
object from the olecache, i.e.

if ( mpImpl->mxObjRef.is() && mpImpl->mxLightClient.is() )
    ...
    GetSdrGlobalData().GetOLEObjCache().RemoveObj(this);
    ...

so the object remains in the cache and later on is dereferenced
with the usual sad results.

So, this band-aid ensures that if we get to the dtor and are still in the cache
we get removed.

Change-Id: Icf519e4db3eadf1c0d9acb7751dbea9cc04ca382
Reviewed-on: https://gerrit.libreoffice.org/52667Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Project: help  fbf5957db266aac2defee013a79be1ffc6ca9a04

Fix missing bookmarks on MS Office compatibility page

Change-Id: I33711b69218bec6d080c07c93d0f2357bab0ce70
Reviewed-on: https://gerrit.libreoffice.org/52660Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>

The XMLNamedBoolPropertyHdl should be owned by
OControlPropertyHandlerFactory like all the other handlers created in
that function.

Thanks to Julien Nabet for pointing out the problem.

Change-Id: Id474b2fdb84ca74f686d0c888fbedbee623c31bb
Reviewed-on: https://gerrit.libreoffice.org/52666Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

Change-Id: I0de14f370f81b6b1e37cb7c9e517d4e9b857ab83
Reviewed-on: https://gerrit.libreoffice.org/52644Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Id4cfb69079f0150c9cca2626c16df7fab441d916
Reviewed-on: https://gerrit.libreoffice.org/52611Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Bunth <btomi96@gmail.com>

Since by default we don't write XHTML markup in the sw HTML export.

Change-Id: Ifbf9850652d7838582725be391b2fd1a062495e5
Reviewed-on: https://gerrit.libreoffice.org/52663Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

improve the read-only check to ignore reads from fields that are guarded
by a boolean check, something like:
   if (field)
       field.foo();
this produces some false positives at the moment because I'm not
correctly handling the else block, but also some useful new dead code.

Change-Id: Id21fa1a56c171d09d979769b978b6eef14e8b695
Reviewed-on: https://gerrit.libreoffice.org/52664Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I421f10f19647888e508c6487271e29d5ab543e0b
Reviewed-on: https://gerrit.libreoffice.org/52659Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

and give it a parent via SfxRequest::GetFrameWeld

Change-Id: I126c300ce4b3f477fd927efbcc83b1a6d315f594
Reviewed-on: https://gerrit.libreoffice.org/52637Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Found by searching for the header names and the localization function:
git grep -l -e \<dp_shared.hxx\> -e \<strings.hrc\> desktop | xargs grep -c DpResId | grep :0$ | grep -v /pch

Change-Id: I6608eb94c7572040ae20ce8a3926f3a522ee66bd
Reviewed-on: https://gerrit.libreoffice.org/52593Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

* For paragraphs or tables whose styles specify style:master-page-name,
it indicate starting a new page style and should invoke
openPageSpan / closePageSapn properly.

* closePageSpan at the end of text body is invoked.

Change-Id: Ic85157c9b1a43c94a027b464ad9105e9072afcf7
Reviewed-on: https://gerrit.libreoffice.org/52082Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

looks like a regression from
    commit de60fd06
    Date:   Fri Dec 17 09:02:23 2010 +0100
    CWS swlayoutrefactoring: #i115510#: first step to clean up the
SwClient mess

Change-Id: Ifc1d3e3f87b4b0d48fc5f311086bb5404b0aa1fb
Reviewed-on: https://gerrit.libreoffice.org/52614Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I6f976ba8f792d2cee34859e9258798351eed8b1d
Reviewed-on: https://gerrit.libreoffice.org/52636Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ia3df85292aba5a506a60b2ae5345e4e78c676c93
Reviewed-on: https://gerrit.libreoffice.org/52650Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I05a22f05a7d41aa06539e05a1969f9520cc3ab31
Reviewed-on: https://gerrit.libreoffice.org/52649Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I06e211f69cafd88080680a22919f1c16eef2aaa9
Reviewed-on: https://gerrit.libreoffice.org/52648Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I72305ce2f235efb42055f71fe2ee3c59ba99c9d3
Reviewed-on: https://gerrit.libreoffice.org/52647Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>