Regression from e80aef4e

The InternetQueryOption has two variants: ANSI (A) and Unicode (W)
(see https://msdn.microsoft.com/en-us/library/aa385101).
INTERNET_PROXY_INFO struct we are using is defined to contain two
LPCTSTR members (see https://msdn.microsoft.com/en-us/library/aa385148).
When UNICODE is defined, InternetQueryOption expands to W variant,
and at the same time, all MS-specific generic string types (like
TCHAR or LPCTSTR) are expanded to wchar_t-based types.

So, the expectation is that InternetQueryOptionW fills the struct
with pointers to widechar strings.

But actually this is not true: InternetQueryOptionW still returns
char-based strings in the struct; so just revert partially commit
above.

Change-Id: I0facb1baf2a191f7bafdf185e684bfe741ca677a
Reviewed-on: https://gerrit.libreoffice.org/51629Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

And add/use an IsHelpInstalled() method to SfxHelp.

Change-Id: Ib87573067d6c44fa5adb22253c1a51a78580acf6
Reviewed-on: https://gerrit.libreoffice.org/51584Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Pro tip: The user doesn’t have to know that the updater is a separate program.

Change-Id: I04c447a16a322b7f4139e69f6cababc797148bb1

regression from

    commit 890d6790
    convert TableChgWidthHeightType to o3tl::typed_flags

in the process, improve the fix from

    commit bfafda58
    tdf#107866 - Changing table column width with Alt+arrow key strokes
is broken

Change-Id: I8740d2e1b925ad72ac69f87c5a06d30a55afeb72
Reviewed-on: https://gerrit.libreoffice.org/51625Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Move trivial comparisons to front; return early on object comparison

Change-Id: I4db927ac87dbb165e80b70046ff44a260b8a504b
Reviewed-on: https://gerrit.libreoffice.org/51624Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: Ie46096b3198852c6ef70960b22652767c09d4779
Reviewed-on: https://gerrit.libreoffice.org/51532Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Change-Id: If128194d45a4cf7265d0ca839f062ab70c22bcc1

...see commit message of f07e2496 "sdk/lib dir
missing from Linux installation sets"

Change-Id: Idb0f3437c27c867bc628fd3084f2a54c47beef17
Reviewed-on: https://gerrit.libreoffice.org/51428Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I019b73b3ae6bf2d61a90cf893b7f4cb356771192
Reviewed-on: https://gerrit.libreoffice.org/51605Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Id70d0d93027f6e9e35227b20f6a22f982b287eaa
Reviewed-on: https://gerrit.libreoffice.org/51602Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ib95ac17011ca2cc98a4d2288cb5879e163482932
Reviewed-on: https://gerrit.libreoffice.org/51573Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I623f9f317496f281af408d1418d3cc7f2bd2d412
Reviewed-on: https://gerrit.libreoffice.org/51569Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

and then MessageDialog can become a vcl internal

Change-Id: I8bf1f963971420b11f6c4163f624be26603cc942
Reviewed-on: https://gerrit.libreoffice.org/51601Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I6d544b97c2b22a16d6a12b898cbe25580c433b61
Reviewed-on: https://gerrit.libreoffice.org/51570Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

This is the same mechanism that was added in commit
1be0a3fa (n#825305: writerfilter RTF
import: override style properties like Word, 2014-06-17), except that
here the reference is a list definition, not a paragraph style.

Also, this commit only implements the part that inserts explicit
defaults for not repeated properties, not the actual deduplication, as
that already works at a dmapper level.

(Saving the bugdoc as DOCX, it's visible in document.xml that DOCX marks
these defaults explicitly:

<w:ind w:left="0" w:right="-6" w:firstLine="0"/>

but RTF does not, so the right place to fix this is in the tokenizer.)

Change-Id: Iec88d9bf1032d1d89194bd272500d6780c3c2224
Reviewed-on: https://gerrit.libreoffice.org/51589Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: I4c55b19c9f7eaeb7c1c8df4266ea72ce24b17428
Reviewed-on: https://gerrit.libreoffice.org/51620Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: I73ec0af22c19674c4b120a68c63710a1b46928ae
Reviewed-on: https://gerrit.libreoffice.org/51623Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

looks like an obvious typo

Change-Id: Icea0952ec8203725cf5ba1ec90bdddd82eca7b3c
Reviewed-on: https://gerrit.libreoffice.org/51562Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I5110ef58302323a59b52cc5451ddba4caa00b6d9
Reviewed-on: https://gerrit.libreoffice.org/51553Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

During calculation of the quality index of the image, we should
take into account also SVM vector image type.
Its mime type is image/x-vclgraphic.

Change-Id: I7c723e99995f73258bb59d976a6c7670c51f7a25
Reviewed-on: https://gerrit.libreoffice.org/51599Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: I6ce10a74ed9c665ff20d6408fe2f6b31faf46bcc
Reviewed-on: https://gerrit.libreoffice.org/51552Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I55eb8f931cdfd1898ff5a74868dc97f31ce1ae7c
Reviewed-on: https://gerrit.libreoffice.org/51551Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

and fix leak in RemoveImage in the process

Change-Id: I20e395178f92f7127e99011aebbe97246f255d1d
Reviewed-on: https://gerrit.libreoffice.org/51550Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

update the table to use a template, which gets rid of lots of casting

Change-Id: Ic9ed3901a33e1cd1a1d4335a704d0dd91a5c2f8a
Reviewed-on: https://gerrit.libreoffice.org/51414Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I771428a37a624f80dba2db9a10297d3a1624f215
Reviewed-on: https://gerrit.libreoffice.org/51546Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: I6a92246161be34bc6ecea8f1c04229a5dd593deb
Reviewed-on: https://gerrit.libreoffice.org/51535Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: I80eca35b03be2a7f288705295a355f08fbc757be
Reviewed-on: https://gerrit.libreoffice.org/51542Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: Iaa16f4cc70ae705f18e1b43b0bf7f8c7f1500277
Reviewed-on: https://gerrit.libreoffice.org/51600Reviewed-by: andreas_kainz <kainz.a@gmail.com>
Tested-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I13aa38fa5a08b6bd4ef1c66e03622a3a64615a08
Reviewed-on: https://gerrit.libreoffice.org/51604Reviewed-by: andreas_kainz <kainz.a@gmail.com>
Tested-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I6f4d61682182d44bea4194f66fe1c9c0bcf8a13a
Reviewed-on: https://gerrit.libreoffice.org/51606Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I54b2140d965fc9c7dddfdcbddd9602ede800c3f7
Reviewed-on: https://gerrit.libreoffice.org/51566Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I89aaf8aab9e4f5230feb4c398fa4ebe9dc5e0add
Reviewed-on: https://gerrit.libreoffice.org/51563Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I7d4aecf09e34e6202efcc9bab3a41726c2f3ca3e
Reviewed-on: https://gerrit.libreoffice.org/51592Reviewed-by: andreas_kainz <kainz.a@gmail.com>
Tested-by: andreas_kainz <kainz.a@gmail.com>

and

coverity#1430066 Uncaught exception
coverity#1430095 Uncaught exception

Change-Id: Idca2e12d3911e3ea768a2a9fb8e7f3b03a2c887f
Reviewed-on: https://gerrit.libreoffice.org/51567Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Similar to how <u> for underline is avoided, the spec explicitly forbids
this.

Change-Id: I314a49df496d7b02049154564884e296b9633576
Reviewed-on: https://gerrit.libreoffice.org/51578Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

* ooo50432-1.sxw has a move from a page with columns to a page without
columns
* kde327565-1.odt has a move from a page without columns to a page with
columns
* novell348228-1.odt has a section inside a fly frame that has no
mpUpper

Change-Id: I65afbbad7bb1b7aa3bf7cac8ff78e864adf66c3c
Reviewed-on: https://gerrit.libreoffice.org/51572Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: I76288e6c7907487efb986f9367c640257f47deb1
Reviewed-on: https://gerrit.libreoffice.org/51559Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I71d5fedb8753d41effa3ebf41811f81f369dae54
Reviewed-on: https://gerrit.libreoffice.org/51564Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I1cba6a67c2b94b5906c017960e5636d5e7b87dd2
Reviewed-on: https://gerrit.libreoffice.org/51565Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I58bf1a204393ea95c85f51cf9ef3387db1565a4e
Reviewed-on: https://gerrit.libreoffice.org/51558Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>