1. 05 Haz, 2019 26 kayıt (commit)
    • Arkadiy Illarionov's avatar
      Use hasElements to check Sequence emptiness in cppcanvas..desktop · 2ed3d691
      Arkadiy Illarionov yazdı
      Similar to clang-tidy readability-container-size-empty
      
      Change-Id: I81c0ff78d2ecc7d984e3ed5e5ce60efe327fc162
      Reviewed-on: https://gerrit.libreoffice.org/71799
      Tested-by: Jenkins
      Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
      2ed3d691
    • Xisco Fauli's avatar
      tdf#125062: distort hairline borders only if selection is used · 6c31c2b0
      Xisco Fauli yazdı
      Regression from 046df0a8
      
      Use the fix for tdf#105998 only when 'selection' option is checked
      in the save dialog
      
      Change-Id: I8c4127c780736408e905ead48e0d3ee6ae149197
      Reviewed-on: https://gerrit.libreoffice.org/73391Reviewed-by: 's avatarXisco Faulí <xiscofauli@libreoffice.org>
      Tested-by: 's avatarXisco Faulí <xiscofauli@libreoffice.org>
      6c31c2b0
    • Olivier Hallot's avatar
      Update git submodules · 65610498
      Olivier Hallot yazdı
      * Update helpcontent2 from branch 'master'
        - Prevent L10n issue when building Help
          
          Pootle does not convert back &lt; and &gt; into the same entities, thus
          disturbing XML parsing of string. Changed to ().
          
          Change-Id: I4e754313a2c51c6b5b190a7e236768fe84ec8672
          Reviewed-on: https://gerrit.libreoffice.org/73444
          Tested-by: Jenkins
      Reviewed-by: 's avatarOlivier Hallot <olivier.hallot@libreoffice.org>
          
      65610498
    • Olivier Hallot's avatar
      Update git submodules · 3e337f91
      Olivier Hallot yazdı
      * Update helpcontent2 from branch 'master'
        - tdf#124582 Change Outline to Chapter in Help page
          
          Change-Id: Ica5e33aa11da21b1194710a46b60663421222bf8
          Reviewed-on: https://gerrit.libreoffice.org/73442
          Tested-by: Jenkins
      Reviewed-by: 's avatarOlivier Hallot <olivier.hallot@libreoffice.org>
          
      3e337f91
    • Olivier R's avatar
      Linguistic: new underlining styles for grammar checkers · cdd69ce7
      Olivier R yazdı
      This patch adds two new underlining styles:
      - BOLDWAVE: a thicker version of the default WAVE style
      - BOLD: a thick straight line
      
      No default setting changed. It's up to the grammar checkers to specify
      the underlining style they want.
      
      This contribution to LibreOffice is licensed under the MPLv2/LGPLv3+ dual license.
      
      modified :         include/vcl/outdev.hxx
      modified :         offapi/com/sun/star/text/TextMarkupDescriptor.idl
      modified :         sw/source/core/inc/wrong.hxx
      modified :         sw/source/core/txtnode/fntcache.cxx
      modified :         vcl/source/outdev/textline.cxx
      modified :         vcl/workben/outdevgrind.cxx
      
      Change-Id: I5629253905ba40c51cc748a7ceeb84170ef5d94c
      Reviewed-on: https://gerrit.libreoffice.org/73412
      Tested-by: Jenkins
      Reviewed-by: 's avatarMichael Stahl <Michael.Stahl@cib.de>
      cdd69ce7
    • Jan-Marek Glogowski's avatar
      Qt5 workaround modal change after show bug · e770bacc
      Jan-Marek Glogowski yazdı
      The presentation minimizer dialog calls setVisible before execute.
      This results in the dialog being shown before setting the modality
      in execute. And this triggers a bug in the Qt / Xcb stack (gtk is
      fine because it directly uses XSendEvent to change the state).
      
      The result is an unmapped, modal dialog window: it's invisible and
      blocks the GUI. Qt believes it's show; isVisible() returns true.
      
      And my ~/.xsession-errors shows a "qt.qpa.xcb: QXcbConnection: XCB
      error: 3 (BadWindow) ... major code: 18 (ChangeProperty)" with an
      invalid resource id, according to 'xwininfo -tree -root'.
      You can find the window resource of the minimizer by its name in
      the full root tree and its unmapped state with 'xwininfo -id'.
      
      I originally thought of a Scheduler bug so enabled debug output
      for it. This is already responsible for a delay long enough to
      prevent the bug often. Same for doing an additional hide() and
      show() sequence. In the end I went with a fixed delay, but that
      is just a guess. In theory we could check the mapped state via
      Xlib in Qt's show event and manually map it using XMapWindow and
      the winId...
      
      I also noted that the minimizer leaks, as there are multiple new
      presenter resources after each show and hide...
      
      Change-Id: I2060918aa9c63d385ebb2ffee9e7a3e4196ea766
      Reviewed-on: https://gerrit.libreoffice.org/73462
      Tested-by: Jenkins
      Reviewed-by: 's avatarMichael Weghorn <m.weghorn@posteo.de>
      Reviewed-by: 's avatarJan-Marek Glogowski <glogow@fbihome.de>
      e770bacc
    • Jan-Marek Glogowski's avatar
      Qt5/KDE5 always use either Qt5 or KDE5 pickers · ca69a1e1
      Jan-Marek Glogowski yazdı
      And use RunInMain for both SalInstances and for both picker types,
      as there is no reason to assume just the file and not the folder
      picker can be called from the non-GUI thread.
      
      Little drawback is the inclusion of Qt5FilePicker header in the
      Qt5Instance header, as Qt's enums aren't forward-declarable.
      
      Change-Id: Ie170d247a76134df9aff835393c71c9d6e907d32
      Reviewed-on: https://gerrit.libreoffice.org/73416Reviewed-by: 's avatarMichael Weghorn <m.weghorn@posteo.de>
      Tested-by: Jenkins
      Reviewed-by: 's avatarJan-Marek Glogowski <glogow@fbihome.de>
      ca69a1e1
    • Christian Lohmaier's avatar
      baseline is CentOS/RHEL 7 (glibc 2.14 or later) · b1a17c2d
      Christian Lohmaier yazdı
      Change-Id: Ie796a5c8f36b33c61eb69b6b68f7439f9359526f
      b1a17c2d
    • Andrea Gelmini's avatar
      Fix typo · 0ca1f44e
      Andrea Gelmini yazdı
      Change-Id: Id77320481846d20fd3f2a8dbdb845a19411baa1d
      Reviewed-on: https://gerrit.libreoffice.org/71817
      Tested-by: Jenkins
      Reviewed-by: 's avatarJulien Nabet <serval2412@yahoo.fr>
      Reviewed-by: 's avatarandreas_kainz <kainz.a@gmail.com>
      0ca1f44e
    • Ashod Nakashian's avatar
      Link: support tracing link source and target · 7b3d401f
      Ashod Nakashian yazdı
      By adding a couple of members to Link, we are
      now able to trace the target function name and
      the file:line where the Link instance in question
      was created (provided the LINK macro is used).
      
      This gives the invaluable ability to track down the
      source of a Link instance in the debugger, provided
      we have enabled this feature, which is enabled in
      DBG_UTIL automatically, unless explicitly enabled.
      
      Of course it is also possible to judiciously add
      LOG/fprintf statements to chase this info, if not
      outright track all links, if so we wish, by dumping
      from Link::Call, or at construction time of Link.
      
      Change-Id: Iab1dce31a179d28aaa1f20228e9e0405973b5e9b
      Reviewed-on: https://gerrit.libreoffice.org/73478
      Tested-by: Jenkins
      Reviewed-by: 's avatarJan Holesovsky <kendy@collabora.com>
      7b3d401f
    • Ashod Nakashian's avatar
      python: add sample python script to insert/replace text · c7c188c7
      Ashod Nakashian yazdı
      Change-Id: Idde3cd22ecc1f1bd34f7519acedc85584ed2deaf
      Reviewed-on: https://gerrit.libreoffice.org/58160Reviewed-by: 's avatarJan Holesovsky <kendy@collabora.com>
      Tested-by: 's avatarJan Holesovsky <kendy@collabora.com>
      Reviewed-on: https://gerrit.libreoffice.org/73477
      Tested-by: Jenkins
      c7c188c7
    • Michael Stahl's avatar
      tdf#125685 sw: disregard footnotes in follow table on table split · e37ffdd1
      Michael Stahl yazdı
      The first problem here is that the table isn't fully formatted; it fails
      with:
      
      warn:legacy.osl:22975:22975:sw/source/core/layout/tabfrm.cxx:2639: debug assertion: <SwTabFrame::MakeAll()> - format of table lowers suppressed by fix i44910
      
      The situation is that there is a big table split across pages; the first
      line of the table would fit onto the previous page so its follow frame
      moves backward and then the table frame tries to split again.
      
      During SwTabFrame::Split(), all the frames in the table are formatted,
      and at that point a footnote that was on the next page is moved to this
      page.
      
      A nested table frame also splits, such that it fits inside the page...
      but then the split of the outer table fails by 5 twips, because the
      moved footnote has reduced the space available for the outer table.
      
      The footnote is anchored in the inner table's follow frame, which would
      be moved to the next page anyway, taking the footnote with it.
      
      Fix this in lcl_RecalcSplitLine() by checking for footnotes that are
      anchored in the follow frame of the top-level table being split, and
      adding their height to the available space on the page.
      
      Fixing the first problem avoids the crash as well; the crash happens
      since 18765b9f and it's rather hard to
      avoid it in a situation where formatting starts at the end and recurses
      into an unformatted table preceding it, which isn't supposed to happen.
      
      Change-Id: I85286583c1c4930468a1c283afc98504cd35bb71
      Reviewed-on: https://gerrit.libreoffice.org/73465
      Tested-by: Jenkins
      Reviewed-by: 's avatarMichael Stahl <Michael.Stahl@cib.de>
      e37ffdd1
    • Jim Raykowski's avatar
      tdf#124152 Broadcast StyleSheetModified to update style tree list box · 0d6ec494
      Jim Raykowski yazdı
      ...and also make undo redo update
      
      Change-Id: I49d62d487bed27d9dbe2ab813d992d02ecaeb77a
      Reviewed-on: https://gerrit.libreoffice.org/72826
      Tested-by: Jenkins
      Tested-by: 's avatarXisco Faulí <xiscofauli@libreoffice.org>
      Reviewed-by: 's avatarKatarina Behrens <Katarina.Behrens@cib.de>
      0d6ec494
    • Mike Kaganski's avatar
      Add GtkImage ids · ada2b5be
      Mike Kaganski yazdı
      An assert is failing without this:
      
          ucrtbased.dll!abort() Line 61
          	at minkernel\crts\ucrt\src\appcrt\startup\abort.cpp(61)
          ucrtbased.dll!common_assert_to_stderr<wchar_t>(const wchar_t * const expression, const wchar_t * const file_name, const unsigned int line_number) Line 187
          	at minkernel\crts\ucrt\src\appcrt\startup\assert.cpp(187)
          ucrtbased.dll!common_assert<wchar_t>(const wchar_t * const expression, const wchar_t * const file_name, const unsigned int line_number, void * const return_address) Line 420
          	at minkernel\crts\ucrt\src\appcrt\startup\assert.cpp(420)
          ucrtbased.dll!_wassert(const wchar_t * expression, const wchar_t * file_name, unsigned int line_number) Line 444
          	at minkernel\crts\ucrt\src\appcrt\startup\assert.cpp(444)
          vcllo.dll!VclBuilder::get<FixedImage>(const rtl::OString & sID) Line 446
          	at C:\cygwin\home\user\lode\dev\core\include\vcl\builder.hxx(446)
          vcllo.dll!VclBuilder::VclBuilder(vcl::Window * pParent, const rtl::OUString & sUIDir, const rtl::OUString & sUIFile, const rtl::OString & sID, const com::sun::star::uno::Reference<com::sun::star::frame::XFrame> & rFrame, bool bLegacy) Line 698
          	at C:\cygwin\home\user\lode\dev\core\vcl\source\window\builder.cxx(698)
          vcllo.dll!SalInstanceBuilder::SalInstanceBuilder(vcl::Window * pParent, const rtl::OUString & rUIRoot, const rtl::OUString & rUIFile) Line 4995
          	at C:\cygwin\home\user\lode\dev\core\vcl\source\app\salvtables.cxx(4995)
          vcllo.dll!SalInstance::CreateBuilder(weld::Widget * pParent, const rtl::OUString & rUIRoot, const rtl::OUString & rUIFile) Line 5260
          	at C:\cygwin\home\user\lode\dev\core\vcl\source\app\salvtables.cxx(5260)
          vcllo.dll!Application::CreateBuilder(weld::Widget * pParent, const rtl::OUString & rUIFile) Line 146
          	at C:\cygwin\home\user\lode\dev\core\vcl\source\window\builder.cxx(146)
          vcllo.dll!weld::GenericDialogController::GenericDialogController(weld::Widget * pParent, const rtl::OUString & rUIFile, const rtl::OString & rDialogId) Line 5347
          	at C:\cygwin\home\user\lode\dev\core\vcl\source\app\salvtables.cxx(5347)
          sduilo.dll!SvxBulletAndPositionDlg::SvxBulletAndPositionDlg(weld::Window * pWindow, const SfxItemSet & rSet, sd::View * pView) Line 117
          	at C:\cygwin\home\user\lode\dev\core\sd\source\ui\dlg\BulletAndPositionDlg.cxx(117)
          sduilo.dll!std::make_unique<SvxBulletAndPositionDlg,weld::Window * &,SfxItemSet const &,sd::View * &,0>(weld::Window * & <_Args_0>, const SfxItemSet & <_Args_1>, sd::View * & <_Args_2>) Line 2042
          	at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.21.27702\include\memory(2042)
          sduilo.dll!SdAbstractDialogFactory_Impl::CreateSvxBulletAndPositionDlg(weld::Window * pParent, const SfxItemSet * pAttr, sd::View * pView) Line 387
          	at C:\cygwin\home\user\lode\dev\core\sd\source\ui\dlg\sddlgfact.cxx(387)
          sdlo.dll!sd::FuBulletAndPosition::DoExecute(SfxRequest & rReq) Line 92
          	at C:\cygwin\home\user\lode\dev\core\sd\source\ui\func\fuolbull.cxx(92)
          sdlo.dll!sd::FuBulletAndPosition::Create(sd::ViewShell * pViewSh, sd::Window * pWin, sd::View * pView, SdDrawDocument * pDoc, SfxRequest & rReq) Line 57
          	at C:\cygwin\home\user\lode\dev\core\sd\source\ui\func\fuolbull.cxx(57)
          sdlo.dll!sd::DrawViewShell::FuTemporary(SfxRequest & rReq) Line 1447
          	at C:\cygwin\home\user\lode\dev\core\sd\source\ui\view\drviews2.cxx(1447)
          sdlo.dll!SfxStubDrawViewShellFuTemporary(SfxShell * pShell, SfxRequest & rReq) Line 1514
          	at C:\cygwin\home\user\lode\dev\core\workdir\SdiTarget\sd\sdi\sdslots.hxx(1514)
          sfxlo.dll!SfxShell::CallExec(void(*)(SfxShell *, SfxRequest &) pFunc, SfxRequest & rReq) Line 197
          	at C:\cygwin\home\user\lode\dev\core\include\sfx2\shell.hxx(197)
          sfxlo.dll!SfxDispatcher::Call_Impl(SfxShell & rShell, const SfxSlot & rSlot, SfxRequest & rReq, bool bRecord) Line 360
          	at C:\cygwin\home\user\lode\dev\core\sfx2\source\control\dispatch.cxx(360)
          sfxlo.dll!SfxDispatcher::Execute_(SfxShell & rShell, const SfxSlot & rSlot, SfxRequest & rReq, SfxCallMode eCallMode) Line 857
          	at C:\cygwin\home\user\lode\dev\core\sfx2\source\control\dispatch.cxx(857)
          sfxlo.dll!SfxBindings::Execute_Impl(SfxRequest & aReq, const SfxSlot * pSlot, SfxShell * pShell) Line 1066
          	at C:\cygwin\home\user\lode\dev\core\sfx2\source\control\bindings.cxx(1066)
          sfxlo.dll!SfxDispatchController_Impl::dispatch(const com::sun::star::util::URL & aURL, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & aArgs, const com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> & rListener) Line 757
          	at C:\cygwin\home\user\lode\dev\core\sfx2\source\control\unoctitm.cxx(757)
          sfxlo.dll!SfxOfficeDispatch::dispatch(const com::sun::star::util::URL & aURL, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & aArgs) Line 226
          	at C:\cygwin\home\user\lode\dev\core\sfx2\source\control\unoctitm.cxx(226)
          fwklo.dll!framework::MenuBarManager::Select(Menu * pMenu) Line 896
          	at C:\cygwin\home\user\lode\dev\core\framework\source\uielement\menubarmanager.cxx(896)
          fwklo.dll!framework::MenuBarManager::LinkStubSelect(void * instance, Menu * data) Line 832
          	at C:\cygwin\home\user\lode\dev\core\framework\source\uielement\menubarmanager.cxx(832)
          vcllo.dll!Link<Menu *,bool>::Call(Menu * data) Line 84
          	at C:\cygwin\home\user\lode\dev\core\include\tools\link.hxx(84)
          vcllo.dll!Menu::Select() Line 362
          	at C:\cygwin\home\user\lode\dev\core\vcl\source\window\menu.cxx(362)
          vcllo.dll!Menu::ImplCallSelect(void * __formal) Line 2150
          	at C:\cygwin\home\user\lode\dev\core\vcl\source\window\menu.cxx(2150)
          vcllo.dll!Menu::LinkStubImplCallSelect(void * instance, void * data) Line 2146
          	at C:\cygwin\home\user\lode\dev\core\vcl\source\window\menu.cxx(2146)
          vcllo.dll!Link<void *,void>::Call(void * data) Line 84
          	at C:\cygwin\home\user\lode\dev\core\include\tools\link.hxx(84)
          vcllo.dll!ImplHandleUserEvent(ImplSVEvent * pSVEvent) Line 1961
          	at C:\cygwin\home\user\lode\dev\core\vcl\source\window\winproc.cxx(1961)
          vcllo.dll!ImplWindowFrameProc(vcl::Window * _pWindow, SalEvent nEvent, const void * pEvent) Line 2512
          	at C:\cygwin\home\user\lode\dev\core\vcl\source\window\winproc.cxx(2512)
          vcllo.dll!SalFrame::CallCallback(SalEvent nEvent, const void * pEvent) Line 294
          	at C:\cygwin\home\user\lode\dev\core\vcl\inc\salframe.hxx(294)
          vclplug_winlo.dll!ImplHandleUserEvent(HWND__ * hWnd, __int64 lParam) Line 4080
          	at C:\cygwin\home\user\lode\dev\core\vcl\win\window\salframe.cxx(4080)
          vclplug_winlo.dll!SalFrameWndProc(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam, bool & rDef) Line 5733
          	at C:\cygwin\home\user\lode\dev\core\vcl\win\window\salframe.cxx(5733)
          vclplug_winlo.dll!SalFrameWndProcW(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam) Line 5840
          	at C:\cygwin\home\user\lode\dev\core\vcl\win\window\salframe.cxx(5840)
          user32.dll!UserCallWinProcCheckWow()
          user32.dll!CallWindowProcW()
          opengl32.dll!wglWndProc()
          user32.dll!UserCallWinProcCheckWow()
          user32.dll!DispatchMessageWorker()
          vclplug_winlo.dll!ImplSalDispatchMessage(const tagMSG * pMsg) Line 410
          	at C:\cygwin\home\user\lode\dev\core\vcl\win\app\salinst.cxx(410)
          vclplug_winlo.dll!ImplSalYield(bool bWait, bool bHandleAllCurrentEvents) Line 441
          	at C:\cygwin\home\user\lode\dev\core\vcl\win\app\salinst.cxx(441)
          vclplug_winlo.dll!WinSalInstance::DoYield(bool bWait, bool bHandleAllCurrentEvents) Line 512
          	at C:\cygwin\home\user\lode\dev\core\vcl\win\app\salinst.cxx(512)
          vcllo.dll!ImplYield(bool i_bWait, bool i_bAllEvents) Line 457
          	at C:\cygwin\home\user\lode\dev\core\vcl\source\app\svapp.cxx(457)
          vcllo.dll!Application::Yield() Line 522
          	at C:\cygwin\home\user\lode\dev\core\vcl\source\app\svapp.cxx(522)
          vcllo.dll!Application::Execute() Line 438
          	at C:\cygwin\home\user\lode\dev\core\vcl\source\app\svapp.cxx(438)
          sofficeapp.dll!desktop::Desktop::Main() Line 1621
          	at C:\cygwin\home\user\lode\dev\core\desktop\source\app\app.cxx(1621)
          vcllo.dll!ImplSVMain() Line 203
          	at C:\cygwin\home\user\lode\dev\core\vcl\source\app\svmain.cxx(203)
          vcllo.dll!SVMain() Line 238
          	at C:\cygwin\home\user\lode\dev\core\vcl\source\app\svmain.cxx(238)
          sofficeapp.dll!soffice_main() Line 170
          	at C:\cygwin\home\user\lode\dev\core\desktop\source\app\sofficemain.cxx(170)
          soffice.bin!sal_main() Line 48
          	at C:\cygwin\home\user\lode\dev\core\desktop\source\app\main.c(48)
          soffice.bin!main(int argc, char * * argv) Line 47
          	at C:\cygwin\home\user\lode\dev\core\desktop\source\app\main.c(47)
          soffice.bin!invoke_main() Line 79
          	at d:\agent\_work\2\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl(79)
          soffice.bin!__scrt_common_main_seh() Line 288
          	at d:\agent\_work\2\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl(288)
          soffice.bin!__scrt_common_main() Line 331
          	at d:\agent\_work\2\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl(331)
          soffice.bin!mainCRTStartup() Line 17
          	at d:\agent\_work\2\s\src\vctools\crt\vcstartup\src\startup\exe_main.cpp(17)
          kernel32.dll!BaseThreadInitThunk()
          ntdll.dll!RtlUserThreadStart()
      
      because the images are added with empty ids, get into the same slot of
      m_pParserState->m_aStockMap, and then in VclBuilder::VclBuilder's block
      labeled "fill in any stock icons in surviving images", get<FixedImage>
      is called with that empty id, finding another control not having an id,
      then failing dynamic_cast it to FixedImage.
      
      Change-Id: Ie2f48ea0753998e8ed6590c45a3d916339c1fc13
      Reviewed-on: https://gerrit.libreoffice.org/73531Reviewed-by: 's avatarMike Kaganski <mike.kaganski@collabora.com>
      Tested-by: 's avatarMike Kaganski <mike.kaganski@collabora.com>
      ada2b5be
    • Miklos Vajna's avatar
      editeng: consider btlr in SvxFrameDirectionItem::GetValueCount() · f9c6f40e
      Miklos Vajna yazdı
      Change-Id: Ib5e24d096075a0dde7c718930ea12fb1fd046ffe
      Reviewed-on: https://gerrit.libreoffice.org/73467
      Tested-by: Jenkins
      Reviewed-by: 's avatarMiklos Vajna <vmiklos@collabora.com>
      f9c6f40e
    • Tor Lillqvist's avatar
      Accept also iOS SDK 13.0 · 3ced4cd5
      Tor Lillqvist yazdı
      Change-Id: Ibbc731f998b00a0ea1235a961290746a849f81cf
      3ced4cd5
    • Andrea Gelmini's avatar
      Fix typo · ff228347
      Andrea Gelmini yazdı
      Change-Id: I2d361544b571144e7f0f2c4190ec3e578427ec7c
      Reviewed-on: https://gerrit.libreoffice.org/73475Reviewed-by: 's avatarJulien Nabet <serval2412@yahoo.fr>
      Tested-by: 's avatarJulien Nabet <serval2412@yahoo.fr>
      ff228347
    • Andrea Gelmini's avatar
      Fix typo · 0f97f545
      Andrea Gelmini yazdı
      Change-Id: Ib92c1a4b60e46019b4c6f89f88b9e99e5b2d497a
      Reviewed-on: https://gerrit.libreoffice.org/73473
      Tested-by: Jenkins
      Reviewed-by: 's avatarJulien Nabet <serval2412@yahoo.fr>
      0f97f545
    • Andrea Gelmini's avatar
      Fix typo · 5f264198
      Andrea Gelmini yazdı
      Change-Id: Ie8b8aeb1ebcb78cca73c6c2bc0512b2f30d245ae
      Reviewed-on: https://gerrit.libreoffice.org/73474Reviewed-by: 's avatarJulien Nabet <serval2412@yahoo.fr>
      Tested-by: 's avatarJulien Nabet <serval2412@yahoo.fr>
      5f264198
    • Andrea Gelmini's avatar
      Fix typo · b89a6da2
      Andrea Gelmini yazdı
      Change-Id: Ied69455eb0a048a9d20d72cb017fa9ba0cd655fb
      Reviewed-on: https://gerrit.libreoffice.org/73472
      Tested-by: Jenkins
      Reviewed-by: 's avatarJulien Nabet <serval2412@yahoo.fr>
      b89a6da2
    • Andrea Gelmini's avatar
      Removed executable permission on file · 0ec8233f
      Andrea Gelmini yazdı
      Change-Id: I671e4936e06a29214c65abfb402f0b3b45246f00
      Reviewed-on: https://gerrit.libreoffice.org/73471
      Tested-by: Jenkins
      Reviewed-by: 's avatarJulien Nabet <serval2412@yahoo.fr>
      0ec8233f
    • Tor Lillqvist's avatar
      CppunitTest_sw_uiwriter always fails on my Retina iMac, so skip on macOS · 1d47a33d
      Tor Lillqvist yazdı
      Change-Id: I95ee6786a7a7ac0e8c62b634c8de3c25bd68bb70
      1d47a33d
    • Tor Lillqvist's avatar
      The Bluetooth code doesn't compile with macOS SDK 10.15 · 1e95c8dd
      Tor Lillqvist yazdı
      Change-Id: I8fffa4cef9628e6872c881cd0cbdfe85495fa324
      1e95c8dd
    • Tor Lillqvist's avatar
      -[NSWindow setRestorable:] is present since 10.7 · c6ab40a2
      Tor Lillqvist yazdı
      No need to use objc_msgSend().
      
      Change-Id: I56c824e3206c37be4b60fb7d82b65c9d5e89958b
      c6ab40a2
    • Tor Lillqvist's avatar
      The macOS SDK 10.15 has a tighter declaration of objc_msgSend() · 4d3628ca
      Tor Lillqvist yazdı
      Change-Id: I51734b92965a9fa1f06aa18017d39b4b0d532456
      4d3628ca
    • Tor Lillqvist's avatar
      Accept also macOS SDK 10.15 · 4378eae8
      Tor Lillqvist yazdı
      Change-Id: I2369db6b76af67d71146903c081ce6427d45c211
      4378eae8
  2. 04 Haz, 2019 14 kayıt (commit)
    • Jay Bingham's avatar
      Update git submodules · c30ea50d
      Jay Bingham yazdı
      * Update helpcontent2 from branch 'master'
        - Refactor RegExp Help page with improved contents
          
          1) Mute some l10n strings
          
          Change-Id: Ia7a2c1898491c0f0352c9c8df519bba057b3bab6
          Reviewed-on: https://gerrit.libreoffice.org/73408
          Tested-by: Jenkins
      Reviewed-by: 's avatarOlivier Hallot <olivier.hallot@libreoffice.org>
          
      c30ea50d
    • Tor Lillqvist's avatar
      tdf#122221: Bin apparently unnecessary early return · 9c8478d4
      Tor Lillqvist yazdı
      Removing these few lines of code fixes the problem on iOS, and has no
      apparent ill effect on macOS. But sure, I didn't check that thoroughly
      on macOS, so in case this has a bad effect on macOS after all, need to
      reinstate the few lines but make them #ifndef IOS.
      
      (Still passes make check.)
      
      Change-Id: I2380d010ba223a698acfe916fca4580a1502be98
      9c8478d4
    • László Németh's avatar
      tdf#70234 DOCX export: fix only expanded fields · 222f6a1c
      László Németh yazdı
      The commit caf2f5ff
      "tdf#70234 DOCX: export tracked deletion of fields"
      must handle only the fields with multiple runs
      (expanded fields).
      
      Change-Id: I2303bade75401e07accf3f0a874f093458fe7efa
      Reviewed-on: https://gerrit.libreoffice.org/73453
      Tested-by: Jenkins
      Reviewed-by: 's avatarLászló Németh <nemeth@numbertext.org>
      222f6a1c
    • Grzegorz Araminowicz's avatar
      SmartArt: bullet list improvements · 1e1535d4
      Grzegorz Araminowicz yazdı
      by default start bullet list at second level
      use stBulletLvl parameter to change this behaviour
      
      Change-Id: I5084e7bf1902fdca83bea6d57a8c1f37dd2e65be
      Reviewed-on: https://gerrit.libreoffice.org/73440
      Tested-by: Jenkins
      Reviewed-by: 's avatarMiklos Vajna <vmiklos@collabora.com>
      1e1535d4
    • Caolán McNamara's avatar
      weld SvxEditModulesDlg · 8caa7d18
      Caolán McNamara yazdı
      Change-Id: I802d4c92924b379f11c73ddfe758f4c6a63feb37
      Reviewed-on: https://gerrit.libreoffice.org/73354
      Tested-by: Jenkins
      Reviewed-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      Tested-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      8caa7d18
    • Olivier Hallot's avatar
      TOTD: Fix tip contents · ef2a96fb
      Olivier Hallot yazdı
      Draw and Impress have different menus names
      
      Change-Id: I8e0dec96e3b52f87bb5e7430f21c96f3b4a681a5
      Reviewed-on: https://gerrit.libreoffice.org/73117Reviewed-by: 's avatarHeiko Tietze <tietze.heiko@gmail.com>
      Tested-by: Jenkins
      ef2a96fb
    • Zdeněk Crhonek's avatar
      uitest for bug tdf#44837 · 5c964216
      Zdeněk Crhonek yazdı
      Change-Id: I194553a6afbcfc17e40ef28627a2806806b69289
      Reviewed-on: https://gerrit.libreoffice.org/73409
      Tested-by: Jenkins
      Reviewed-by: 's avatarZdenek Crhonek <zcrhonek@gmail.com>
      5c964216
    • Miklos Vajna's avatar
      tdf#101086 sc autofilter popup: avoid flicker · 4dadbff7
      Miklos Vajna yazdı
      Regression from commit a4cb27f6
      (refactor ScMenuFloatingWindow to use RenderContext, 2015-05-14), the
      problem was that the change had two effects:
      
      1) It removed incremental rendering that now causes flicker.
      
      2) It added support for painting into a rendercontext, not on the window
      itself.
      
      Given that here a hierarchy of widgets have to be painted at once (to
      avoid flicker), use vcl::Window::RequestDoubleBuffering() instead of the
      much simpler vcl::BufferDevice.
      
      This improves the situation on Windows, but explicitly blacklist the
      focus rectangle case (gtk3) which is currently not compatible with this
      higher level double-buffering (and there we already have lower-level
      double-buffering anyway, similar to OpenGL).
      
      Change-Id: I77aa951e14db668166dc8757e36c037ee98243bf
      Reviewed-on: https://gerrit.libreoffice.org/73441Reviewed-by: 's avatarMiklos Vajna <vmiklos@collabora.com>
      Tested-by: Jenkins
      4dadbff7
    • Stephan Bergmann's avatar
      Avoid truncation of ±1E20 to long · ee6dd4d3
      Stephan Bergmann yazdı
      With -fsanitize=float-cast-overflow, opening doc/abi5309-1.doc as obtained by
      bin/get-bugzilla-attachments-by-mimetype (i.e., the attachment at
      <https://bugzilla.abisource.com/show_bug.cgi?id=5309#c3>) fails with
      
      > include/tools/helpers.hxx:76:79: runtime error: 1e+20 is outside the range of representable values of type 'long'
      >  #0 in FRound(double) at include/tools/helpers.hxx:76:79 (instdir/program/libtllo.so +0x3c13dd)
      >  #1 in ImplPolygon::ImplPolygon(basegfx::B2DPolygon const&) at tools/source/generic/poly.cxx:474:30 (instdir/program/libtllo.so +0x40f35f)
      >  #2 in tools::Polygon::Polygon(basegfx::B2DPolygon const&) at tools/source/generic/poly.cxx:1849:72 (instdir/program/libtllo.so +0x42c9ff)
      >  #3 in ImplPolyPolygon::ImplPolyPolygon(basegfx::B2DPolyPolygon const&) at tools/source/generic/poly2.cxx:482:28 (instdir/program/libtllo.so +0x45561e)
      >  #4 in tools::PolyPolygon::PolyPolygon(basegfx::B2DPolyPolygon const&) at tools/source/generic/poly2.cxx:463:25 (instdir/program/libtllo.so +0x45512d)
      >  #5 in emfio::MtfTools::DrawPolygon(tools::Polygon, bool) at emfio/source/reader/mtftools.cxx:1287:17 (instdir/program/../program/libemfiolo.so +0x1828d3)
      >  #6 in emfio::WmfReader::ReadRecordParams(unsigned short) at emfio/source/reader/wmfreader.cxx:367:21 (instdir/program/../program/libemfiolo.so +0x1cffde)
      >  #7 in emfio::WmfReader::ReadWMF() at emfio/source/reader/wmfreader.cxx:1425:29 (instdir/program/../program/libemfiolo.so +0x1f7567)
      >  #8 in emfio::emfreader::XEmfParser::getDecomposition(com::sun::star::uno::Reference<com::sun::star::io::XInputStream> const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at emfio/source/emfuno/xemfparser.cxx:152:108 (instdir/program/../program/libemfiolo.so +0x13795a)
      >  #9 in non-virtual thunk to emfio::emfreader::XEmfParser::getDecomposition(com::sun::star::uno::Reference<com::sun::star::io::XInputStream> const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at emfio/source/emfuno/xemfparser.cxx (instdir/program/../program/libemfiolo.so +0x138735)
      >  #10 in VectorGraphicData::ensureSequenceAndRange() at vcl/source/gdi/vectorgraphicdata.cxx:172:137 (instdir/program/libvcllo.so +0x86bdadf)
      >  #11 in VectorGraphicData::ensureReplacement() at vcl/source/gdi/vectorgraphicdata.cxx:138:5 (instdir/program/libvcllo.so +0x86bcb94)
      >  #12 in VectorGraphicData::getReplacement() const at vcl/source/gdi/vectorgraphicdata.cxx:286:45 (instdir/program/libvcllo.so +0x86c0a04)
      >  #13 in ImpGraphic::ImplSetPrefSize(Size const&) at vcl/source/gdi/impgraph.cxx:956:45 (instdir/program/libvcllo.so +0x7d05433)
      >  #14 in Graphic::SetPrefSize(Size const&) at vcl/source/gdi/graph.cxx:388:19 (instdir/program/libvcllo.so +0x7ca7e26)
      >  #15 in SvxMSDffManager::GetBLIPDirect(SvStream&, Graphic&, tools::Rectangle*) at filter/source/msfilter/msdffimp.cxx:6616:26 (instdir/program/../program/libmsfilterlo.so +0x9617bc)
      >  #16 in SvxMSDffManager::GetBLIP(unsigned long, Graphic&, tools::Rectangle*) at filter/source/msfilter/msdffimp.cxx:6453:23 (instdir/program/../program/libmsfilterlo.so +0x95f368)
      >  #17 in SvxMSDffManager::ImportGraphic(SvStream&, SfxItemSet&, DffObjData const&) at filter/source/msfilter/msdffimp.cxx:3821:24 (instdir/program/../program/libmsfilterlo.so +0x990678)
      >  #18 in SvxMSDffManager::ImportShape(DffRecordHeader const&, SvStream&, SvxMSDffClientData&, tools::Rectangle&, tools::Rectangle const&, int, int*) at filter/source/msfilter/msdffimp.cxx:4368:28 (instdir/program/../program/libmsfilterlo.so +0x9a221a)
      >  #19 in SvxMSDffManager::ImportObj(SvStream&, SvxMSDffClientData&, tools::Rectangle&, tools::Rectangle const&, int, int*) at filter/source/msfilter/msdffimp.cxx:4073:16 (instdir/program/../program/libmsfilterlo.so +0x9972d8)
      >  #20 in SvxMSDffManager::GetShape(unsigned long, SdrObject*&, SvxMSDffImportData&) at filter/source/msfilter/msdffimp.cxx:6377:23 (instdir/program/../program/libmsfilterlo.so +0x9dde0c)
      >  #21 in SwWW8ImplReader::Read_GrafLayer(long) at sw/source/filter/ww8/ww8graf.cxx:2567:34 (instdir/program/../program/libmswordlo.so +0x2c51a1f)
      >  #22 in SwWW8ImplReader::ReadChar(long, long) at sw/source/filter/ww8/ww8par.cxx:3697:17 (instdir/program/../program/libmswordlo.so +0x2db3a07)
      >  #23 in SwWW8ImplReader::ReadChars(int&, int, long, long) at sw/source/filter/ww8/ww8par.cxx:3484:27 (instdir/program/../program/libmswordlo.so +0x2dafba2)
      >  #24 in SwWW8ImplReader::ReadText(int, int, ManTypes) at sw/source/filter/ww8/ww8par.cxx:4045:22 (instdir/program/../program/libmswordlo.so +0x2d85c3e)
      >  #25 in SwWW8ImplReader::CoreLoad(WW8Glossary const*) at sw/source/filter/ww8/ww8par.cxx:5227:9 (instdir/program/../program/libmswordlo.so +0x2de3314)
      >  #26 in SwWW8ImplReader::LoadThroughDecryption(WW8Glossary*) at sw/source/filter/ww8/ww8par.cxx:5892:19 (instdir/program/../program/libmswordlo.so +0x2df31ad)
      >  #27 in SwWW8ImplReader::LoadDoc(WW8Glossary*) at sw/source/filter/ww8/ww8par.cxx:6196:19 (instdir/program/../program/libmswordlo.so +0x2dfe1ed)
      >  #28 in WW8Reader::Read(SwDoc&, rtl::OUString const&, SwPaM&, rtl::OUString const&) at sw/source/filter/ww8/ww8par.cxx:6347:26 (instdir/program/../program/libmswordlo.so +0x2e0301a)
      >  #29 in SwReader::Read(Reader const&) at sw/source/filter/basflt/shellio.cxx:188:22 (instdir/program/../program/libswlo.so +0x1041d2be)
      >  #30 in SwDocShell::ConvertFrom(SfxMedium&) at sw/source/uibase/app/docsh.cxx:261:26 (instdir/program/../program/libswlo.so +0x10fc4d98)
      >  #31 in SfxObjectShell::DoLoad(SfxMedium*) at sfx2/source/doc/objstor.cxx:768:23 (instdir/program/libsfxlo.so +0x49d934a)
      [...]
      
      To represent "negative" clip regions, basegfx/source/tools/b2dclipstate.cxx uses
      an ugly hack of subtracting the region from a ±1E20 bounding box.  This document
      uses such a negative clip region with a 4504x633@(11301,38) rectangular hole.
      (Though I don't know whether that's the real intention, or caused by LO
      misparsing the input file format.)
      
      So to avoid converting the ±1E20 bounding box from double to long, do the
      intersection here with basegfx double values, and only convert the result to
      tools long values.  (There appears to be no implemenation of intersection with
      a polypolygon for B2DPolyPolyon, just B2DClipState::intersectPolyPolygon.)  (In
      principle there could be loss of precision when aPolyPoly is converted to a
      B2DPolyPolygon now, but that's unlikely with a typical IEEE 754 double with
      52 bit mantissa.)
      
      Change-Id: I82a9941b43d90153d63612147b2ca33fbca5f179
      Reviewed-on: https://gerrit.libreoffice.org/73386
      Tested-by: Jenkins
      Reviewed-by: 's avatarThorsten Behrens <Thorsten.Behrens@CIB.de>
      ee6dd4d3
    • Tor Lillqvist's avatar
      Add css_comp_Impress_oox_PowerPointExport · 80457313
      Tor Lillqvist yazdı
      Change-Id: I17d95cce0dd69e2ba8b4ebc7045544fc5659a249
      80457313
    • Tor Lillqvist's avatar
      Fix "external" graphic filter code for the DISABLE_DYNLOADING case · a4807544
      Tor Lillqvist yazdı
      The DISABLE_DYNLOADING case in ImpFilterLibCacheEntry::GetImportFunction()
      had apparently been broken from the start, but nobody never noticed as
      the common formats (PNG, JPEG, GIF etc) use a more "internal"code
      path. The problem was noticed now with a TIFF image in a presentation.
      
      The fix for the import case seems to work, but I could not test the
      fix for the export case.
      
      Change-Id: Icbd33c7cb654136a562f18b06d5b0896e701bf3d
      a4807544
    • Olivier Hallot's avatar
      TOTD Specify that tip is for Calc · 27cd31a7
      Olivier Hallot yazdı
      Change-Id: Ia77b5a407693802f408cd7d28d50962ae1c746e7
      Reviewed-on: https://gerrit.libreoffice.org/73308
      Tested-by: Jenkins
      Reviewed-by: 's avatarHeiko Tietze <tietze.heiko@gmail.com>
      27cd31a7
    • Khaled Hosny's avatar
      Use ICU UCHAR_VERTICAL_ORIENTATION when available · 8736cc0f
      Khaled Hosny yazdı
      Starting from ICU 63, the vertical orientation property is provided by ICU so
      we use it instead of our inyternal, and potentially outdated data file. Old
      code is kept until support for ICU < 63 is dropped.
      
      Change-Id: I0df1f3f5e853ca90945a36a8123bec9ae7f691cc
      Reviewed-on: https://gerrit.libreoffice.org/73425
      Tested-by: Jenkins
      Reviewed-by: 's avatarMark Hung <marklh9@gmail.com>
      8736cc0f
    • wishawa's avatar
      Update git submodules · fce79b23
      wishawa yazdı
      * Update dictionaries from branch 'master'
        - Remove abbreviations from Thai hunspell dictionary.
          
          Reasons:
          1. They are not present in other spellcheck dictionaries (such as en).
          2. To add all abreviations would not be much different from adding all
          possible combinations of 2-3 Thai consonants. This would make misspelled
          abbreviations come as correct to the spellcheck anyway.
          3. Adding only the most common ones can cause confusion to those using
          less common ones, as the spellchecker will suggest the more common
          abbreviation. It is also nearly impossible to determine if an abbreviation
          is common that it should be added or not.
          Change-Id: I8b7bce70f552ab3b356e1ab2c101e9e31a8ec271
          Reviewed-on: https://gerrit.libreoffice.org/73216Reviewed-by: 's avatarAndras Timar <andras.timar@collabora.com>
      Tested-by: 's avatarAndras Timar <andras.timar@collabora.com>
          
      fce79b23