1. 10 May, 2019 1 kayıt (commit)
  2. 02 Kas, 2018 1 kayıt (commit)
  3. 12 Eki, 2018 1 kayıt (commit)
  4. 10 Eki, 2018 1 kayıt (commit)
    • Armin Le Grand's avatar
      tdf#119067 DefaultLabel only for interactively created OBJs · ad1b8880
      Armin Le Grand yazdı
      Both have to work - the Wizard-created report which this report
      defines and the interactively created ones (see tdf#118730). The
      second was moved to OUnoObject::CreateMediator and by error
      sets the default text (e.g. 'Label') now all the time. This
      was wrong.
      To solve, remember if the Object was created interactively
      (which is the case when ::EndCreate was called which is needed
      again) and set the default only when that is the case.
      
      Change-Id: Id26e701d863b098a77db5f6419bcabf1f2ec5017
      Reviewed-on: https://gerrit.libreoffice.org/61620
      Tested-by: Jenkins
      Reviewed-by: 's avatarArmin Le Grand <Armin.Le.Grand@cib.de>
      ad1b8880
  5. 25 Tem, 2018 1 kayıt (commit)
    • Armin Le Grand's avatar
      tdf#118730 Correct ReportDesigner Object creation · 96b338e6
      Armin Le Grand yazdı
      This is a follow up problem to removing the old stuff
      that first a SdrPage* at the SdrObjects was set *without*
      the SdrObject being inserted to any SdrObjList. It works
      no longer - the SdrPage which you can get now is the one
      the SdrObject *is* inserted at.
      Solution is to move that stuff - plus other initializations
      which were done in OUnoObject::EndCreate before - to where
      it belongs. This gets rid of OUnoObject::EndCreate
      completely.
      It makes OUnoObject::impl_setReportComponent_nothrow no
      longer needed due to being used only in one place. All
      initializations move to OUnoObject::CreateMediator which
      anyways needs to be done when a OUnoObject got created.
      
      Change-Id: I86f968dc6e867c5752d3c8cee1b3b2af57e467c8
      Reviewed-on: https://gerrit.libreoffice.org/57976
      Tested-by: Jenkins
      Reviewed-by: 's avatarArmin Le Grand <Armin.Le.Grand@cib.de>
      96b338e6
  6. 07 May, 2018 1 kayıt (commit)
  7. 06 Nis, 2018 3 kayıt (commit)
    • Armin Le Grand's avatar
      SOSAW080: Added first bunch of basic changes to helpers · dfefe448
      Armin Le Grand yazdı
      SOSAW080: Make SdrModel& prerequisite to SdrObjects
      
      Added need for SdrModel& in constructors of SdrModel,
      SdrPage, SdrView and SdrObjList. Builds, not finished.
      
      SOSAW080: removed and replaced old SdrModel
      
      Removed and replaced GetModel()/SetModel() in all using
      classes (SdrObject, SdrPage, SdrView), added accessors
      to new referenced SdrModel, adapted all accessing places.
      Refactored/Extended ::Clone and ::operator== for these
      classes to allow cloning objects to a target SdrModel.
      Adapted places where this is done AFAP. Added quite some
      comments (tagged with 'TTTT') where possible further work
      is needed. Builds completely, thus checking in. This does
      not mean that this change is done yet.
      
      SOSAW080: Adapted SdrPage/SdrModel relationship
      
      Also needed to work on copy-construction of SdrPage and hierarchy,
      quite some stuff removed, no copy-constructor anymore, no
      MigrateItemPool stuff. Builds well, test stuck, will need
      some cleanup/finetunung
      
      SOSAW080: Smaller corrections/includes adapted
      
      SOSAW080: Smaller corrections/includes adapted
      
      SOSAW080: Debugging/Stabilizing/MakeUnitTestWork
      
      SOSAW080: Stabilized for UnitTests, cleanups
      
      SOSAW080: Adapted GetObjGraphic to just take a const SdrObject&
      
      SOSAW080: Removed ChangeModel from classes
      
      Classes SvxTextEditSource and SvxDrawPage (including
      TextEditSource stuff) do not need change of SdrModel
      anymore.
      
      SOSAW080: Adapted some comments to make more readable
      
      SOSAW080: Corrected constructor
      
      SOSAW080: getSdrModelFromUnoModel added override marks
      
      SOSAW080: Added missing includes
      
      SOSAW080: Corrected SdrPage constructor
      
      SOSAW080: Corrected some SdrObject::Clone scenarios
      
      Especially when cloning to another SdrModel and taking
      the sdr::properties into account.
      
      SOSAW080: Added include for Mac-Build
      
      SOSAW080: Added Scale to DefaultProperties
      
      If a SdrModel change happens in DefaultProperties copy
      constructor (used from Clone()), potentially a Scale
      for the SfxItems has to be done.
      
      SOSAW080: Added missing include for MacBuild
      
      SOSAW080: Corrected CppunitTest_sc_anchor_test
      
      An adaption of a SdrPathObj instantiation was missing,
      added that. Seems as if that test is no tpart of the
      usual 'make' scenario, but used/executed in gerrit builds
      
      SOSAW080: Reworked SvxShape to use SdrObject's SdrModel
      
      SOSAW080: Reworked SvxShape to use SdrObject's SdrModel
      
      SOSAW080: Free SdrObjects when SdrModel goes down
      
      In an UNO API test problem is that SvxShapes reference
      SdrShapes, but these are not added to a SdrPage and not
      'owned' by the SvxShape. Thus these do not get deleted
      at all (same in master, memory leak). I extended
      SvxShape::Notify the case for ModelCleared to also
      Free the SdrObject when not owner and it's not added to
      a SdrPage (in that case it gets deleted with deleting
      the SdrModel)
      
      SOSAW080: Solve UNO API calls that move SvxShapes to other Model
      
      Due to UNO API tests I got a call to insert an xShape to a
      xDrawPage which was constructed in another Model, this has now to
      be done by Cloning the SdrObject to the new SdrModel, getting
      rid of the old one and getting all the UNO implementation
      stuff right (referemces SdrObject <-> xShape).
      
      1cb7d573d323e98a89761fe662c10c4a654fdec0
      24617494a0ef79f6e33dfcb02782a833a81c6434
      763f39094b6a48b529a6952d01468f8776c97679
      242b9e228a9a042c3a5bdd38b1ea6600144276d5
      242b9e228a9a042c3a5bdd38b1ea6600144276d5
      33a6f3f306b70c223171aef796dd5ee041ad14df
      6878b33f8b05738a44c0910e40a60a0f0d1d58ed
      0a636caf3cb36c2f9c6cd11aa22cb9bc435dc8f2
      8c4626274a5cc531dad27f27c0c45d4c528fb2fb
      446685a49a6d67aedd01cfbbd5e87b07f97a4d7b
      c1b5ed3c99bc7219a0061e4ece24ea42afd2889a
      22de9a1c8af7c25be5c108671ddc548ba323ed47
      4caf6b6fbbe6e8130741d793dffb560fd01d4ed5
      488b9601735ec1822433f82f633990063951fe08
      c366d60299f239e3df856ddffedb19e743e4be0c
      c5137ba8c597c7b5f90318df50e87b93a39a28dc
      f9e646242cf89f6fde1315046952252a2c429779
      f830fbc5fadd89d04be5edd2a5abf9b0d4bf0410
      1694b54903df784385abaa8452e1201e12344238
      17bcb44d2e29920c0c74430c2d9c703b36cfa0ad
      17bcb44d2e29920c0c74430c2d9c703b36cfa0ad
      7b5c241faec7488924e5935ae8b19f785846b5e4
      bf097ee7467895823fbd158a2a9543da3b5a5078
      
      Change-Id: Iaf53535de0502a481466be74a1768bbb39f0e78c
      Reviewed-on: https://gerrit.libreoffice.org/52526Tested-by: 's avatarJenkins <ci@libreoffice.org>
      Reviewed-by: 's avatarArmin Le Grand <Armin.Le.Grand@cib.de>
      dfefe448
    • Armin Le Grand's avatar
      eba4d5b2
    • Armin Le Grand's avatar
      SOSAW080: Added first bunch of basic changes to helpers · 6c14c27c
      Armin Le Grand yazdı
      SOSAW080: Make SdrModel& prerequisite to SdrObjects
      
      Added need for SdrModel& in constructors of SdrModel,
      SdrPage, SdrView and SdrObjList. Builds, not finished.
      
      SOSAW080: removed and replaced old SdrModel
      
      Removed and replaced GetModel()/SetModel() in all using
      classes (SdrObject, SdrPage, SdrView), added accessors
      to new referenced SdrModel, adapted all accessing places.
      Refactored/Extended ::Clone and ::operator== for these
      classes to allow cloning objects to a target SdrModel.
      Adapted places where this is done AFAP. Added quite some
      comments (tagged with 'TTTT') where possible further work
      is needed. Builds completely, thus checking in. This does
      not mean that this change is done yet.
      
      SOSAW080: Adapted SdrPage/SdrModel relationship
      
      Also needed to work on copy-construction of SdrPage and hierarchy,
      quite some stuff removed, no copy-constructor anymore, no
      MigrateItemPool stuff. Builds well, test stuck, will need
      some cleanup/finetunung
      
      SOSAW080: Smaller corrections/includes adapted
      
      SOSAW080: Smaller corrections/includes adapted
      
      SOSAW080: Debugging/Stabilizing/MakeUnitTestWork
      
      SOSAW080: Stabilized for UnitTests, cleanups
      
      SOSAW080: Adapted GetObjGraphic to just take a const SdrObject&
      
      SOSAW080: Removed ChangeModel from classes
      
      Classes SvxTextEditSource and SvxDrawPage (including
      TextEditSource stuff) do not need change of SdrModel
      anymore.
      
      SOSAW080: Adapted some comments to make more readable
      
      SOSAW080: Corrected constructor
      
      SOSAW080: getSdrModelFromUnoModel added override marks
      
      SOSAW080: Added missing includes
      
      SOSAW080: Corrected SdrPage constructor
      
      SOSAW080: Corrected some SdrObject::Clone scenarios
      
      Especially when cloning to another SdrModel and taking
      the sdr::properties into account.
      
      SOSAW080: Added include for Mac-Build
      
      SOSAW080: Added Scale to DefaultProperties
      
      If a SdrModel change happens in DefaultProperties copy
      constructor (used from Clone()), potentially a Scale
      for the SfxItems has to be done.
      
      SOSAW080: Added missing include for MacBuild
      
      SOSAW080: Corrected CppunitTest_sc_anchor_test
      
      An adaption of a SdrPathObj instantiation was missing,
      added that. Seems as if that test is no tpart of the
      usual 'make' scenario, but used/executed in gerrit builds
      
      SOSAW080: Reworked SvxShape to use SdrObject's SdrModel
      
      SOSAW080: Reworked SvxShape to use SdrObject's SdrModel
      
      SOSAW080: Free SdrObjects when SdrModel goes down
      
      In an UNO API test problem is that SvxShapes reference
      SdrShapes, but these are not added to a SdrPage and not
      'owned' by the SvxShape. Thus these do not get deleted
      at all (same in master, memory leak). I extended
      SvxShape::Notify the case for ModelCleared to also
      Free the SdrObject when not owner and it's not added to
      a SdrPage (in that case it gets deleted with deleting
      the SdrModel)
      
      SOSAW080: Solve UNO API calls that move SvxShapes to other Model
      
      Due to UNO API tests I got a call to insert an xShape to a
      xDrawPage which was constructed in another Model, this has now to
      be done by Cloning the SdrObject to the new SdrModel, getting
      rid of the old one and getting all the UNO implementation
      stuff right (referemces SdrObject <-> xShape).
      
      Change-Id: Iaf53535de0502a481466be74a1768bbb39f0e78c
      1cb7d573d323e98a89761fe662c10c4a654fdec0
      24617494a0ef79f6e33dfcb02782a833a81c6434
      763f39094b6a48b529a6952d01468f8776c97679
      242b9e228a9a042c3a5bdd38b1ea6600144276d5
      242b9e228a9a042c3a5bdd38b1ea6600144276d5
      33a6f3f306b70c223171aef796dd5ee041ad14df
      6878b33f8b05738a44c0910e40a60a0f0d1d58ed
      0a636caf3cb36c2f9c6cd11aa22cb9bc435dc8f2
      8c4626274a5cc531dad27f27c0c45d4c528fb2fb
      446685a49a6d67aedd01cfbbd5e87b07f97a4d7b
      c1b5ed3c99bc7219a0061e4ece24ea42afd2889a
      22de9a1c8af7c25be5c108671ddc548ba323ed47
      4caf6b6fbbe6e8130741d793dffb560fd01d4ed5
      488b9601735ec1822433f82f633990063951fe08
      c366d60299f239e3df856ddffedb19e743e4be0c
      c5137ba8c597c7b5f90318df50e87b93a39a28dc
      f9e646242cf89f6fde1315046952252a2c429779
      f830fbc5fadd89d04be5edd2a5abf9b0d4bf0410
      1694b54903df784385abaa8452e1201e12344238
      17bcb44d2e29920c0c74430c2d9c703b36cfa0ad
      17bcb44d2e29920c0c74430c2d9c703b36cfa0ad
      7b5c241faec7488924e5935ae8b19f785846b5e4
      bf097ee7467895823fbd158a2a9543da3b5a5078
      6c14c27c
  8. 01 Nis, 2018 1 kayıt (commit)
  9. 19 Ara, 2017 1 kayıt (commit)
  10. 31 Eki, 2017 1 kayıt (commit)
  11. 03 May, 2017 1 kayıt (commit)
  12. 31 Mar, 2017 1 kayıt (commit)
  13. 03 Mar, 2017 1 kayıt (commit)
  14. 26 Ock, 2017 1 kayıt (commit)
    • Stephan Bergmann's avatar
      Remove dynamic exception specifications · e57ca028
      Stephan Bergmann yazdı
      ...(for now, from LIBO_INTERNAL_CODE only).  See the mail thread starting at
      <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html>
      "Dynamic Exception Specifications" for details.
      
      Most changes have been done automatically by the rewriting loplugin:dynexcspec
      (after enabling the rewriting mode, to be committed shortly).  The way it only
      removes exception specs from declarations if it also sees a definition, it
      identified some dead declarations-w/o-definitions (that have been removed
      manually) and some cases where a definition appeared in multiple include files
      (which have also been cleaned up manually).  There's also been cases of macro
      paramters (that were used to abstract over exception specs) that have become
      unused now (and been removed).
      
      Furthermore, some code needed to be cleaned up manually
      (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no
      configurations available that would actually build that code.  Missing @throws
      documentation has not been applied in such manual clean-up.
      
      Change-Id: I3408691256c9b0c12bc5332de976743626e13960
      Reviewed-on: https://gerrit.libreoffice.org/33574Tested-by: 's avatarJenkins <ci@libreoffice.org>
      Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      e57ca028
  15. 19 Ock, 2017 1 kayıt (commit)
  16. 21 Kas, 2016 1 kayıt (commit)
  17. 01 Kas, 2016 1 kayıt (commit)
  18. 13 Eyl, 2016 1 kayıt (commit)
    • Stephan Bergmann's avatar
      loplugin:override: No more need for the "MSVC dtor override" workaround · 91dd2db1
      Stephan Bergmann yazdı
      The issue of 362d4f0c "Explicitly mark
      overriding destructors as 'virtual'" appears to no longer be a problem with
      MSVC 2013.
      
      (The little change in the rewriting code of compilerplugins/clang/override.cxx
      was necessary to prevent an endless loop when adding "override" to
      
        OOO_DLLPUBLIC_CHARTTOOLS    virtual ~CloseableLifeTimeManager();
      
      in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
      OOO_DLLPUBLIC_CHARTTOOLS macro.  Can't remember what that
      isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)
      
      Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
      91dd2db1
  19. 12 Agu, 2016 1 kayıt (commit)
  20. 14 Nis, 2016 1 kayıt (commit)
  21. 11 Nis, 2016 1 kayıt (commit)
  22. 22 Ara, 2015 1 kayıt (commit)
  23. 11 Kas, 2015 1 kayıt (commit)
  24. 26 Eki, 2015 1 kayıt (commit)
  25. 12 Eki, 2015 2 kayıt (commit)
  26. 21 Tem, 2015 1 kayıt (commit)
  27. 29 Haz, 2015 1 kayıt (commit)
  28. 07 Şub, 2015 1 kayıt (commit)
  29. 30 Ock, 2015 1 kayıt (commit)
  30. 26 Ock, 2015 1 kayıt (commit)
    • Noel Grandin's avatar
      new loplugin: change virtual methods to non-virtual · b44cbb26
      Noel Grandin yazdı
      Where we can prove that the virtual method is never overriden.
      
      In the case of pure-virtual methods, we remove the method entirely.
      Sometimes this leads to entire methods and fields being
      eliminated.
      
      Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
      b44cbb26
  31. 08 Ock, 2015 1 kayıt (commit)
  32. 23 Eki, 2014 2 kayıt (commit)
  33. 16 Eki, 2014 1 kayıt (commit)
  34. 09 Eki, 2014 1 kayıt (commit)
  35. 06 Eyl, 2014 1 kayıt (commit)
  36. 18 Haz, 2014 1 kayıt (commit)