Skip to content

C
core
Dal (branch)/etiket değiştir
  1. 30 May, 2019 1 kayıt (commit)
  3. 07 Nis, 2019 1 kayıt (commit)
  5. 29 Kas, 2018 1 kayıt (commit)
  7. 17 Eyl, 2018 1 kayıt (commit)
    • Stephan Bergmann's avatar
      New loplugin:external · 206b5b26
      Stephan Bergmann yazdı 
      ...warning about (for now only) functions and variables with external linkage
that likely don't need it.

The problems with moving entities into unnamed namespacs and breaking ADL
(as alluded to in comments in compilerplugins/clang/external.cxx) are
illustrated by the fact that while

  struct S1 { int f() { return 0; } };
  int f(S1 s) { return s.f(); }
  namespace N {
    struct S2: S1 { int f() { return 1; } };
    int f(S2 s) { return s.f(); }
  }
  int main() { return f(N::S2()); }

returns 1, both moving just the struct S2 into an nunnamed namespace,

  struct S1 { int f() { return 0; } };
  int f(S1 s) { return s.f(); }
  namespace N {
    namespace { struct S2: S1 { int f() { return 1; } }; }
    int f(S2 s) { return s.f(); }
  }
  int main() { return f(N::S2()); }

as well as moving just the function f overload into an unnamed namespace,

  struct S1 { int f() { return 0; } };
  int f(S1 s) { return s.f(); }
  namespace N {
    struct S2: S1 { int f() { return 1; } };
    namespace { int f(S2 s) { return s.f(); } }
  }
  int main() { return f(N::S2()); }

would each change the program to return 0 instead.

Change-Id: I4d09f7ac5e8f9bcd6e6bde4712608444b642265c
Reviewed-on: https://gerrit.libreoffice.org/60539
Tested-by: Jenkins
Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      206b5b26
  9. 30 Tem, 2018 1 kayıt (commit)
    • Gabor Kelemen's avatar
      Add missing sal/log.hxx headers · bdb0775a
      Gabor Kelemen yazdı 
      rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it.
This is a continuation of commit 6ff2d84a to be able to remove those unneeded includes.

This commit adds missing headers to every file found by:
grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG')
to directories from filter to jvmfwk

Change-Id: I2a73d63f2aaef5f26d7d08957daaa8a30b412ac5
Reviewed-on: https://gerrit.libreoffice.org/58204
Tested-by: Jenkins
Reviewed-by: 's avatarMiklos Vajna <vmiklos@collabora.co.uk>
      bdb0775a
  11. 27 Tem, 2018 1 kayıt (commit)
  13. 11 Haz, 2018 1 kayıt (commit)
  15. 07 Haz, 2018 1 kayıt (commit)
  17. 16 Nis, 2018 1 kayıt (commit)
  19. 18 Mar, 2018 1 kayıt (commit)
  21. 05 Eki, 2017 1 kayıt (commit)
  23. 03 Eki, 2017 1 kayıt (commit)
  25. 06 Agu, 2017 1 kayıt (commit)
  27. 18 Tem, 2017 1 kayıt (commit)
  29. 02 Tem, 2017 1 kayıt (commit)
  31. 25 Haz, 2017 1 kayıt (commit)
  33. 03 May, 2017 1 kayıt (commit)
  35. 22 Mar, 2017 1 kayıt (commit)
  37. 16 Şub, 2017 1 kayıt (commit)
  39. 26 Ock, 2017 1 kayıt (commit)
    • Stephan Bergmann's avatar
      Remove dynamic exception specifications · e57ca028
      Stephan Bergmann yazdı 
      ...(for now, from LIBO_INTERNAL_CODE only).  See the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html>
"Dynamic Exception Specifications" for details.

Most changes have been done automatically by the rewriting loplugin:dynexcspec
(after enabling the rewriting mode, to be committed shortly).  The way it only
removes exception specs from declarations if it also sees a definition, it
identified some dead declarations-w/o-definitions (that have been removed
manually) and some cases where a definition appeared in multiple include files
(which have also been cleaned up manually).  There's also been cases of macro
paramters (that were used to abstract over exception specs) that have become
unused now (and been removed).

Furthermore, some code needed to be cleaned up manually
(avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no
configurations available that would actually build that code.  Missing @throws
documentation has not been applied in such manual clean-up.

Change-Id: I3408691256c9b0c12bc5332de976743626e13960
Reviewed-on: https://gerrit.libreoffice.org/33574Tested-by: 's avatarJenkins <ci@libreoffice.org>
Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      e57ca028
  41. 17 Ock, 2017 1 kayıt (commit)
  43. 10 Ock, 2017 1 kayıt (commit)
  45. 06 Ock, 2017 1 kayıt (commit)
  47. 16 Eyl, 2016 1 kayıt (commit)
  49. 28 Nis, 2016 1 kayıt (commit)
  51. 17 Şub, 2016 1 kayıt (commit)
  53. 10 Ock, 2016 1 kayıt (commit)
  55. 08 Ara, 2015 1 kayıt (commit)
  57. 30 Kas, 2015 1 kayıt (commit)
  59. 20 Kas, 2015 1 kayıt (commit)
  61. 15 Kas, 2015 1 kayıt (commit)
  63. 10 Kas, 2015 1 kayıt (commit)
  65. 06 Kas, 2015 1 kayıt (commit)
  67. 30 Eyl, 2015 1 kayıt (commit)
  69. 19 Eyl, 2015 1 kayıt (commit)
  71. 28 Haz, 2015 1 kayıt (commit)
  73. 17 Haz, 2015 1 kayıt (commit)
  75. 15 Haz, 2015 1 kayıt (commit)
  77. 08 Haz, 2015 1 kayıt (commit)
  79. 20 Ock, 2015 1 kayıt (commit)