1. 31 May, 2019 19 kayıt (commit)
  2. 30 May, 2019 21 kayıt (commit)
    • Andrea Gelmini's avatar
      Fix typo · 3a0ca1bf
      Andrea Gelmini yazdı
      I don't understand if the right one is:
      raising is greater, then 100%
      or
      raising is greater than 100%
      
      Change-Id: I0bd4b297214f423ce0e3bb5223e0e2edee2a30e9
      Reviewed-on: https://gerrit.libreoffice.org/73222
      Tested-by: Jenkins
      Reviewed-by: 's avatarJens Carl <j.carl43@gmx.de>
      3a0ca1bf
    • Eike Rathke's avatar
      Resolves: tdf#125279 do not double _x005F_ escapement · f677885f
      Eike Rathke yazdı
      Reading OOXML _x005F_ escaped content may not get unescaped, so
      when writing back to OOXML do not attempt to escape it again, i.e.
      write _x005F_xHHHH_ as is and not as _x005F_x005F_xHHHH_.
      
      This is more a workaround, the proper fix would be to unescape
      _x005F_ content upon read. But then the entire "invalid XML
      character" escapement and handling control characters rat tail
      would come into play.
      
      Change-Id: I3d31dc84a362753c23a8c89f7a5d7bfd06e4367b
      Reviewed-on: https://gerrit.libreoffice.org/73187
      Tested-by: Jenkins
      Reviewed-by: 's avatarEike Rathke <erack@redhat.com>
      f677885f
    • Eike Rathke's avatar
      Reintroduce mbXescape that got overaggressively removed · 63c4e82c
      Eike Rathke yazdı
      with
      
          commit d4d37662
          CommitDate: Fri Oct 12 12:46:45 2018 +0200
      
      	loplugin:constfields in reportdesign,sal,sax
      
      which killed also the bGood checking and later because that wasn't
      used anymore also the SAL_WARN_IF() was eliminated with
      
          commit 41eeaace
          CommitDate: Mon Oct 29 15:12:26 2018 +0100
      
      	loplugin:oncevar
      
      The mbXescape variable will be used, as the TODO said..
      
      Change-Id: I11091379c27cf0222677595eb723b61ad3ebe4e8
      Reviewed-on: https://gerrit.libreoffice.org/72302
      Tested-by: Jenkins
      Reviewed-by: 's avatarEike Rathke <erack@redhat.com>
      63c4e82c
    • Miklos Vajna's avatar
      ODT export: remove leftover debug include · 1376bb3e
      Miklos Vajna yazdı
      And if I'm at it, IWYU pointed one more unused one.
      
      Change-Id: I978e0bbf281bebc3da574a8a857167b18a540f0a
      Reviewed-on: https://gerrit.libreoffice.org/73215Reviewed-by: 's avatarMiklos Vajna <vmiklos@collabora.com>
      Tested-by: Jenkins
      1376bb3e
    • Noel Grandin's avatar
      GetAnyEnd does not need to return a pointer · 2eebd911
      Noel Grandin yazdı
      Change-Id: I1350a340eddad180447c46175b6b21ce787802f3
      Reviewed-on: https://gerrit.libreoffice.org/72952
      Tested-by: Jenkins
      Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
      2eebd911
    • Noel Grandin's avatar
      "more than USHRT_MAX marks" seems to be fine now · 79b233be
      Noel Grandin yazdı
      Change-Id: Iccd87324b56fb7ff003f028330758024e47f3f26
      Reviewed-on: https://gerrit.libreoffice.org/73207
      Tested-by: Jenkins
      Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
      79b233be
    • Miklos Vajna's avatar
      ODT export: fix lost <text:user-field-decl> for fields in frames in headers · 6f179ce5
      Miklos Vajna yazdı
      This is similar to commit 6bb241cc (ODT
      export: fix lost <text:user-field-decl> for fields in tables in headers,
      2019-05-29), but here the container we want to ignore (between the
      header and the field) is a text frame, not a table cell.
      
      Change-Id: I6e8006fbd666802070cfeb88ca4528c66cc6d559
      Reviewed-on: https://gerrit.libreoffice.org/73205Reviewed-by: 's avatarMiklos Vajna <vmiklos@collabora.com>
      Tested-by: Jenkins
      6f179ce5
    • Mike Kaganski's avatar
      Unconst members of ControlTypeAndPart · 831de14f
      Mike Kaganski yazdı
      ... which need to be assignable in auto-generated operator= in VS2019
      toolset v142. Without that, a compile-time error is generated:
      
      [CXX] vcl/source/gdi/WidgetDefinitionReader.cxx
      [CXX] vcl/source/gdi/WidgetDefinition.cxx
      [CXX] vcl/source/gdi/gdimetafiletools.cxx
      C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.21.27702\Include\list(1076): error C2220: warning treated as error - no 'object' file generated
      C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.21.27702\Include\list(1076): warning C4239: nonstandard extension used: 'argument': conversion from 'const std::pair<const _Kty,_Ty>' to 'volatile const std::pair<_Kty,_Ty> &'
      with
      [
      _Kty=vcl::ControlTypeAndPart,
      _Ty=std::shared_ptr<vcl::WidgetDefinitionPart>
      ]
      C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.21.27702\Include\list(1076): note: A non-const reference may only be bound to an lvalue; assignment operator takes a reference to non-const
      C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.21.27702\Include\xhash(486): note: see reference to function template instantiation 'void std::list<std::pair<const _Kty,_Ty>,std::allocator<std::pair<const _Kty,_Ty>>>::_Assign_cast<std::pair<_Kty,_Ty>&,std::_List_unchecked_const_iterator<std::_List_val<std::_List_simple_types<std::pair<const _Kty,_Ty>>>,std::_Iterator_base0>>(_UIter,const _UIter)' being compiled
      with
      [
      _Kty=vcl::ControlTypeAndPart,
      _Ty=std::shared_ptr<vcl::WidgetDefinitionPart>,
      _UIter=std::_List_unchecked_const_iterator<std::_List_val<std::_List_simple_types<std::pair<const vcl::ControlTypeAndPart,std::shared_ptr<vcl::WidgetDefinitionPart>>>>,std::_Iterator_base0>
      ]
      C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.21.27702\Include\xhash(485): note: see reference to function template instantiation 'void std::list<std::pair<const _Kty,_Ty>,std::allocator<std::pair<const _Kty,_Ty>>>::_Assign_cast<std::pair<_Kty,_Ty>&,std::_List_unchecked_const_iterator<std::_List_val<std::_List_simple_types<std::pair<const _Kty,_Ty>>>,std::_Iterator_base0>>(_UIter,const _UIter)' being compiled
      with
      [
      _Kty=vcl::ControlTypeAndPart,
      _Ty=std::shared_ptr<vcl::WidgetDefinitionPart>,
      _UIter=std::_List_unchecked_const_iterator<std::_List_val<std::_List_simple_types<std::pair<const vcl::ControlTypeAndPart,std::shared_ptr<vcl::WidgetDefinitionPart>>>>,std::_Iterator_base0>
      ]
      C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.21.27702\Include\xhash(481): note: while compiling class template member function 'void std::_Hash<std::_Umap_traits<_Kty,_Ty,std::_Uhash_compare<_Kty,_Hasher,_Keyeq>,_Alloc,false>>::_Copy_assign(const std::_Hash<std::_Umap_traits<_Kty,_Ty,std::_Uhash_compare<_Kty,_Hasher,_Keyeq>,_Alloc,false>> &,std::false_type)'
      with
      [
      _Kty=vcl::ControlTypeAndPart,
      _Ty=std::shared_ptr<vcl::WidgetDefinitionPart>,
      _Hasher=std::hash<vcl::ControlTypeAndPart>,
      _Keyeq=std::equal_to<vcl::ControlTypeAndPart>,
      _Alloc=std::allocator<std::pair<const vcl::ControlTypeAndPart,std::shared_ptr<vcl::WidgetDefinitionPart>>>
      ]
      C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.21.27702\Include\xhash(516): note: see reference to function template instantiation 'void std::_Hash<std::_Umap_traits<_Kty,_Ty,std::_Uhash_compare<_Kty,_Hasher,_Keyeq>,_Alloc,false>>::_Copy_assign(const std::_Hash<std::_Umap_traits<_Kty,_Ty,std::_Uhash_compare<_Kty,_Hasher,_Keyeq>,_Alloc,false>> &,std::false_type)' being compiled
      with
      [
      _Kty=vcl::ControlTypeAndPart,
      _Ty=std::shared_ptr<vcl::WidgetDefinitionPart>,
      _Hasher=std::hash<vcl::ControlTypeAndPart>,
      _Keyeq=std::equal_to<vcl::ControlTypeAndPart>,
      _Alloc=std::allocator<std::pair<const vcl::ControlTypeAndPart,std::shared_ptr<vcl::WidgetDefinitionPart>>>
      ]
      C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.21.27702\Include\unordered_map(77): note: see reference to class template instantiation 'std::_Hash<std::_Umap_traits<_Kty,_Ty,std::_Uhash_compare<_Kty,_Hasher,_Keyeq>,_Alloc,false>>' being compiled
      with
      [
      _Kty=vcl::ControlTypeAndPart,
      _Ty=std::shared_ptr<vcl::WidgetDefinitionPart>,
      _Hasher=std::hash<vcl::ControlTypeAndPart>,
      _Keyeq=std::equal_to<vcl::ControlTypeAndPart>,
      _Alloc=std::allocator<std::pair<const vcl::ControlTypeAndPart,std::shared_ptr<vcl::WidgetDefinitionPart>>>
      ]
      C:\cygwin\home\user\lode\dev\core\vcl\inc\widgetdraw/WidgetDefinition.hxx(260): note: see reference to class template instantiation 'std::unordered_map<vcl::ControlTypeAndPart,std::shared_ptr<vcl::WidgetDefinitionPart>,std::hash<vcl::ControlTypeAndPart>,std::equal_to<_Kty>,std::allocator<std::pair<const _Kty,_Ty>>>' being compiled
      with
      [
      _Kty=vcl::ControlTypeAndPart,
      _Ty=std::shared_ptr<vcl::WidgetDefinitionPart>
      ]
      C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.21.27702\Include\list(1076): error C2280: 'std::pair<_Kty,_Ty> &std::pair<_Kty,_Ty>::operator =(volatile const std::pair<_Kty,_Ty> &)': attempting to reference a deleted function
      with
      [
      _Kty=vcl::ControlTypeAndPart,
      _Ty=std::shared_ptr<vcl::WidgetDefinitionPart>
      ]
      C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.21.27702\Include\utility(177): note: see declaration of 'std::pair<_Kty,_Ty>::operator ='
      with
      [
      _Kty=vcl::ControlTypeAndPart,
      _Ty=std::shared_ptr<vcl::WidgetDefinitionPart>
      ]
      C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.21.27702\Include\utility(177): note: 'std::pair<_Kty,_Ty> &std::pair<_Kty,_Ty>::operator =(volatile const std::pair<_Kty,_Ty> &)': function was explicitly deleted
      with
      [
      _Kty=vcl::ControlTypeAndPart,
      _Ty=std::shared_ptr<vcl::WidgetDefinitionPart>
      ]
      C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.21.27702\Include\list(1076): error C2220: warning treated as error - no 'object' file generated
      C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.21.27702\Include\list(1076): warning C4239: nonstandard extension used: 'argument': conversion from 'const std::pair<const _Kty,_Ty>' to 'volatile const std::pair<_Kty,_Ty> &'
      with
      [
      _Kty=vcl::ControlTypeAndPart,
      _Ty=std::shared_ptr<vcl::WidgetDefinitionPart>
      ]
      C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.21.27702\Include\list(1076): note: A non-const reference may only be bound to an lvalue; assignment operator takes a reference to non-const
      C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.21.27702\Include\xhash(486): note: see reference to function template instantiation 'void std::list<std::pair<const _Kty,_Ty>,std::allocator<std::pair<const _Kty,_Ty>>>::_Assign_cast<std::pair<_Kty,_Ty>&,std::_List_unchecked_const_iterator<std::_List_val<std::_List_simple_types<std::pair<const _Kty,_Ty>>>,std::_Iterator_base0>>(_UIter,const _UIter)' being compiled
      with
      [
      _Kty=vcl::ControlTypeAndPart,
      _Ty=std::shared_ptr<vcl::WidgetDefinitionPart>,
      _UIter=std::_List_unchecked_const_iterator<std::_List_val<std::_List_simple_types<std::pair<const vcl::ControlTypeAndPart,std::shared_ptr<vcl::WidgetDefinitionPart>>>>,std::_Iterator_base0>
      ]
      C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.21.27702\Include\xhash(485): note: see reference to function template instantiation 'void std::list<std::pair<const _Kty,_Ty>,std::allocator<std::pair<const _Kty,_Ty>>>::_Assign_cast<std::pair<_Kty,_Ty>&,std::_List_unchecked_const_iterator<std::_List_val<std::_List_simple_types<std::pair<const _Kty,_Ty>>>,std::_Iterator_base0>>(_UIter,const _UIter)' being compiled
      with
      [
      _Kty=vcl::ControlTypeAndPart,
      _Ty=std::shared_ptr<vcl::WidgetDefinitionPart>,
      _UIter=std::_List_unchecked_const_iterator<std::_List_val<std::_List_simple_types<std::pair<const vcl::ControlTypeAndPart,std::shared_ptr<vcl::WidgetDefinitionPart>>>>,std::_Iterator_base0>
      ]
      C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.21.27702\Include\xhash(481): note: while compiling class template member function 'void std::_Hash<std::_Umap_traits<_Kty,_Ty,std::_Uhash_compare<_Kty,_Hasher,_Keyeq>,_Alloc,false>>::_Copy_assign(const std::_Hash<std::_Umap_traits<_Kty,_Ty,std::_Uhash_compare<_Kty,_Hasher,_Keyeq>,_Alloc,false>> &,std::false_type)'
      with
      [
      _Kty=vcl::ControlTypeAndPart,
      _Ty=std::shared_ptr<vcl::WidgetDefinitionPart>,
      _Hasher=std::hash<vcl::ControlTypeAndPart>,
      _Keyeq=std::equal_to<vcl::ControlTypeAndPart>,
      _Alloc=std::allocator<std::pair<const vcl::ControlTypeAndPart,std::shared_ptr<vcl::WidgetDefinitionPart>>>
      ]
      C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.21.27702\Include\xhash(516): note: see reference to function template instantiation 'void std::_Hash<std::_Umap_traits<_Kty,_Ty,std::_Uhash_compare<_Kty,_Hasher,_Keyeq>,_Alloc,false>>::_Copy_assign(const std::_Hash<std::_Umap_traits<_Kty,_Ty,std::_Uhash_compare<_Kty,_Hasher,_Keyeq>,_Alloc,false>> &,std::false_type)' being compiled
      with
      [
      _Kty=vcl::ControlTypeAndPart,
      _Ty=std::shared_ptr<vcl::WidgetDefinitionPart>,
      _Hasher=std::hash<vcl::ControlTypeAndPart>,
      _Keyeq=std::equal_to<vcl::ControlTypeAndPart>,
      _Alloc=std::allocator<std::pair<const vcl::ControlTypeAndPart,std::shared_ptr<vcl::WidgetDefinitionPart>>>
      ]
      C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.21.27702\Include\unordered_map(77): note: see reference to class template instantiation 'std::_Hash<std::_Umap_traits<_Kty,_Ty,std::_Uhash_compare<_Kty,_Hasher,_Keyeq>,_Alloc,false>>' being compiled
      with
      [
      _Kty=vcl::ControlTypeAndPart,
      _Ty=std::shared_ptr<vcl::WidgetDefinitionPart>,
      _Hasher=std::hash<vcl::ControlTypeAndPart>,
      _Keyeq=std::equal_to<vcl::ControlTypeAndPart>,
      _Alloc=std::allocator<std::pair<const vcl::ControlTypeAndPart,std::shared_ptr<vcl::WidgetDefinitionPart>>>
      ]
      C:\cygwin\home\user\lode\dev\core\vcl\inc\widgetdraw/WidgetDefinition.hxx(260): note: see reference to class template instantiation 'std::unordered_map<vcl::ControlTypeAndPart,std::shared_ptr<vcl::WidgetDefinitionPart>,std::hash<vcl::ControlTypeAndPart>,std::equal_to<_Kty>,std::allocator<std::pair<const _Kty,_Ty>>>' being compiled
      with
      [
      _Kty=vcl::ControlTypeAndPart,
      _Ty=std::shared_ptr<vcl::WidgetDefinitionPart>
      ]
      C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.21.27702\Include\list(1076): error C2280: 'std::pair<_Kty,_Ty> &std::pair<_Kty,_Ty>::operator =(volatile const std::pair<_Kty,_Ty> &)': attempting to reference a deleted function
      with
      [
      _Kty=vcl::ControlTypeAndPart,
      _Ty=std::shared_ptr<vcl::WidgetDefinitionPart>
      ]
      C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.21.27702\Include\utility(177): note: see declaration of 'std::pair<_Kty,_Ty>::operator ='
      with
      [
      _Kty=vcl::ControlTypeAndPart,
      _Ty=std::shared_ptr<vcl::WidgetDefinitionPart>
      ]
      C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.21.27702\Include\utility(177): note: 'std::pair<_Kty,_Ty> &std::pair<_Kty,_Ty>::operator =(volatile const std::pair<_Kty,_Ty> &)': function was explicitly deleted
      with
      [
      _Kty=vcl::ControlTypeAndPart,
      _Ty=std::shared_ptr<vcl::WidgetDefinitionPart>
      ]
      C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.21.27702\Include\list(1076): error C2220: warning treated as error - no 'object' file generated
      C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.21.27702\Include\list(1076): warning C4239: nonstandard extension used: 'argument': conversion from 'const std::pair<const _Kty,_Ty>' to 'volatile const std::pair<_Kty,_Ty> &'
      with
      [
      _Kty=vcl::ControlTypeAndPart,
      _Ty=std::shared_ptr<vcl::WidgetDefinitionPart>
      ]
      C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.21.27702\Include\list(1076): note: A non-const reference may only be bound to an lvalue; assignment operator takes a reference to non-const
      C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.21.27702\Include\xhash(486): note: see reference to function template instantiation 'void std::list<std::pair<const _Kty,_Ty>,std::allocator<std::pair<const _Kty,_Ty>>>::_Assign_cast<std::pair<_Kty,_Ty>&,std::_List_unchecked_const_iterator<std::_List_val<std::_List_simple_types<std::pair<const _Kty,_Ty>>>,std::_Iterator_base0>>(_UIter,const _UIter)' being compiled
      with
      [
      _Kty=vcl::ControlTypeAndPart,
      _Ty=std::shared_ptr<vcl::WidgetDefinitionPart>,
      _UIter=std::_List_unchecked_const_iterator<std::_List_val<std::_List_simple_types<std::pair<const vcl::ControlTypeAndPart,std::shared_ptr<vcl::WidgetDefinitionPart>>>>,std::_Iterator_base0>
      ]
      C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.21.27702\Include\xhash(485): note: see reference to function template instantiation 'void std::list<std::pair<const _Kty,_Ty>,std::allocator<std::pair<const _Kty,_Ty>>>::_Assign_cast<std::pair<_Kty,_Ty>&,std::_List_unchecked_const_iterator<std::_List_val<std::_List_simple_types<std::pair<const _Kty,_Ty>>>,std::_Iterator_base0>>(_UIter,const _UIter)' being compiled
      with
      [
      _Kty=vcl::ControlTypeAndPart,
      _Ty=std::shared_ptr<vcl::WidgetDefinitionPart>,
      _UIter=std::_List_unchecked_const_iterator<std::_List_val<std::_List_simple_types<std::pair<const vcl::ControlTypeAndPart,std::shared_ptr<vcl::WidgetDefinitionPart>>>>,std::_Iterator_base0>
      ]
      C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.21.27702\Include\xhash(481): note: while compiling class template member function 'void std::_Hash<std::_Umap_traits<_Kty,_Ty,std::_Uhash_compare<_Kty,_Hasher,_Keyeq>,_Alloc,false>>::_Copy_assign(const std::_Hash<std::_Umap_traits<_Kty,_Ty,std::_Uhash_compare<_Kty,_Hasher,_Keyeq>,_Alloc,false>> &,std::false_type)'
      with
      [
      _Kty=vcl::ControlTypeAndPart,
      _Ty=std::shared_ptr<vcl::WidgetDefinitionPart>,
      _Hasher=std::hash<vcl::ControlTypeAndPart>,
      _Keyeq=std::equal_to<vcl::ControlTypeAndPart>,
      _Alloc=std::allocator<std::pair<const vcl::ControlTypeAndPart,std::shared_ptr<vcl::WidgetDefinitionPart>>>
      ]
      C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.21.27702\Include\xhash(516): note: see reference to function template instantiation 'void std::_Hash<std::_Umap_traits<_Kty,_Ty,std::_Uhash_compare<_Kty,_Hasher,_Keyeq>,_Alloc,false>>::_Copy_assign(const std::_Hash<std::_Umap_traits<_Kty,_Ty,std::_Uhash_compare<_Kty,_Hasher,_Keyeq>,_Alloc,false>> &,std::false_type)' being compiled
      with
      [
      _Kty=vcl::ControlTypeAndPart,
      _Ty=std::shared_ptr<vcl::WidgetDefinitionPart>,
      _Hasher=std::hash<vcl::ControlTypeAndPart>,
      _Keyeq=std::equal_to<vcl::ControlTypeAndPart>,
      _Alloc=std::allocator<std::pair<const vcl::ControlTypeAndPart,std::shared_ptr<vcl::WidgetDefinitionPart>>>
      ]
      C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.21.27702\Include\unordered_map(77): note: see reference to class template instantiation 'std::_Hash<std::_Umap_traits<_Kty,_Ty,std::_Uhash_compare<_Kty,_Hasher,_Keyeq>,_Alloc,false>>' being compiled
      with
      [
      _Kty=vcl::ControlTypeAndPart,
      _Ty=std::shared_ptr<vcl::WidgetDefinitionPart>,
      _Hasher=std::hash<vcl::ControlTypeAndPart>,
      _Keyeq=std::equal_to<vcl::ControlTypeAndPart>,
      _Alloc=std::allocator<std::pair<const vcl::ControlTypeAndPart,std::shared_ptr<vcl::WidgetDefinitionPart>>>
      ]
      C:\cygwin\home\user\lode\dev\core\vcl\inc\widgetdraw/WidgetDefinition.hxx(260): note: see reference to class template instantiation 'std::unordered_map<vcl::ControlTypeAndPart,std::shared_ptr<vcl::WidgetDefinitionPart>,std::hash<vcl::ControlTypeAndPart>,std::equal_to<_Kty>,std::allocator<std::pair<const _Kty,_Ty>>>' being compiled
      with
      [
      _Kty=vcl::ControlTypeAndPart,
      _Ty=std::shared_ptr<vcl::WidgetDefinitionPart>
      ]
      C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.21.27702\Include\list(1076): error C2280: 'std::pair<_Kty,_Ty> &std::pair<_Kty,_Ty>::operator =(volatile const std::pair<_Kty,_Ty> &)': attempting to reference a deleted function
      with
      [
      _Kty=vcl::ControlTypeAndPart,
      _Ty=std::shared_ptr<vcl::WidgetDefinitionPart>
      ]
      C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.21.27702\Include\utility(177): note: see declaration of 'std::pair<_Kty,_Ty>::operator ='
      with
      [
      _Kty=vcl::ControlTypeAndPart,
      _Ty=std::shared_ptr<vcl::WidgetDefinitionPart>
      ]
      C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\14.21.27702\Include\utility(177): note: 'std::pair<_Kty,_Ty> &std::pair<_Kty,_Ty>::operator =(volatile const std::pair<_Kty,_Ty> &)': function was explicitly deleted
      with
      [
      _Kty=vcl::ControlTypeAndPart,
      _Ty=std::shared_ptr<vcl::WidgetDefinitionPart>
      ]
      make[1]: *** [C:/cygwin/home/user/lode/dev/core/solenv/gbuild/LinkTarget.mk:293: C:/cygwin/home/user/lode/dev/core/workdir/CxxObject/vcl/source/gdi/FileDefinitionWidgetDraw.o] Error 2
      make[1]: *** Waiting for unfinished jobs....
      make[1]: *** [C:/cygwin/home/user/lode/dev/core/solenv/gbuild/LinkTarget.mk:293: C:/cygwin/home/user/lode/dev/core/workdir/CxxObject/vcl/source/gdi/WidgetDefinition.o] Error 2
      make[1]: *** [C:/cygwin/home/user/lode/dev/core/solenv/gbuild/LinkTarget.mk:293: C:/cygwin/home/user/lode/dev/core/workdir/CxxObject/vcl/source/gdi/WidgetDefinitionReader.o] Error 2
      make: *** [Makefile:282: build] Error 2
      
      Change-Id: I9273bf7bfd78848918c783b8237e76b59e2043cf
      Reviewed-on: https://gerrit.libreoffice.org/73196
      Tested-by: Jenkins
      Reviewed-by: 's avatarMike Kaganski <mike.kaganski@collabora.com>
      831de14f
    • Grzegorz Araminowicz's avatar
      SmartArt: keep parent constraints instead of merging every time · 0873151d
      Grzegorz Araminowicz yazdı
      currently for every node we were additionaly loading constraints from
      parent node, merging them and then deleting
      it makes more sense just to keep already loaded constraints from parent node
      
      Change-Id: I3fcd669547f24eeeac0b77876950ff7436bd5cb3
      Reviewed-on: https://gerrit.libreoffice.org/73116
      Tested-by: Jenkins
      Reviewed-by: 's avatarMiklos Vajna <vmiklos@collabora.com>
      0873151d
    • Mike Kaganski's avatar
      Support VC++ 2019 tools v142 · ad7dfdef
      Mike Kaganski yazdı
      Change-Id: I765ff8a80ac37b09e16bb16652f28534d1e575eb
      Reviewed-on: https://gerrit.libreoffice.org/73161
      Tested-by: Jenkins
      Reviewed-by: 's avatarMike Kaganski <mike.kaganski@collabora.com>
      ad7dfdef
    • Noel Grandin's avatar
      tdf#125372 writer, file with lots of hints very slow to open, part7 · 5a74ef3d
      Noel Grandin yazdı
      Takes load time from 1m45 to 22s
      
      Instead of (1) taking a list of SwTextAttrs (2) invoking a method that
      inserts a new one (3) taking a new list and doing a delta on the list,
      just the information about the new SwTextAttr up the stack and avoid all
      that work.
      
      Change-Id: Iec88618af696299aaba65f43bc33b1a5f030fac0
      Reviewed-on: https://gerrit.libreoffice.org/73195
      Tested-by: Jenkins
      Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
      5a74ef3d
    • Caolán McNamara's avatar
      Resolves; ofz#14803 build failure · 460cf721
      Caolán McNamara yazdı
      Change-Id: If94f77e8414ee83f49ae4dc05d26d7670524b75a
      Reviewed-on: https://gerrit.libreoffice.org/73197Reviewed-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      Tested-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      460cf721
    • Olivier Hallot's avatar
      Update git submodules · a458b68e
      Olivier Hallot yazdı
      * Update helpcontent2 from branch 'master'
        - WIP: refactor some Python/Basic pages
          
          Change-Id: I3590e7a6e0cf62d9f9e33e8081be50ab4d0ae769
          Reviewed-on: https://gerrit.libreoffice.org/73175
          Tested-by: Jenkins
      Reviewed-by: 's avatarOlivier Hallot <olivier.hallot@libreoffice.org>
          
      a458b68e
    • Noel Grandin's avatar
      tdf#125372 writer, file with lots of hints very slow to open, part6 · b32a9628
      Noel Grandin yazdı
      Takes load time from 2m11 to 1m45
      
      Since we're only interested in hints with end <= nIdx,
      GetLastPosSortedByEnd to avoid scanning some of the list
      
      Change-Id: Ibd80cb247176419aac5b6956593e5b7807c23cbf
      Reviewed-on: https://gerrit.libreoffice.org/73194
      Tested-by: Jenkins
      Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
      b32a9628
    • Mark Hung's avatar
      tdf#125497 allow backspace to remove CJK IVS. · 6a7db071
      Mark Hung yazdı
      Japanese users prefer to remove a CJK IVS character
      when pressing the backspace instead of removing
      the selector part of IVS.
      
      Change-Id: I4313d69ed52d82c5a7e4e4823b1da06f1d90bdad
      Reviewed-on: https://gerrit.libreoffice.org/72971
      Tested-by: Jenkins
      Reviewed-by: 's avatarMark Hung <marklh9@gmail.com>
      6a7db071
    • Noel Grandin's avatar
      tdf#125372 writer, file with lots of hints very slow to open, part5 · 799dac2e
      Noel Grandin yazdı
      Takes load time from 3m to 2m11
      
      (*) Add a list sorted by which/start
      (*) Use it in lcl_GetTextAttrs
      (*) Fix GetLastPosSortedByEnd, previously we could potentially
      static_cast the search item to something it is not
      (*) Add assert to SwpHints::DeleteAtPos to verify that we don't need
      sorting of the main list when deleting.
      
      Change-Id: If82ea650172ca88486507f31b45cac8d22682451
      Reviewed-on: https://gerrit.libreoffice.org/73152
      Tested-by: Jenkins
      Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
      799dac2e
    • Gabor Kelemen's avatar
      tdf#42949 Fix IWYU warnings in helpcompiler/ · c329a1c1
      Gabor Kelemen yazdı
      Found with bin/find-unneeded-includes
      Only removal proposals are dealt with here.
      
      Change-Id: Ie7e20c77a8035c0ee4f0316966d163b9cd7d11f2
      Reviewed-on: https://gerrit.libreoffice.org/73006
      Tested-by: Jenkins
      Reviewed-by: 's avatarMiklos Vajna <vmiklos@collabora.com>
      c329a1c1
    • Miklos Vajna's avatar
      xmloff: create XMLDrawContentImportOasis instances with an uno constructor · 69236a7a
      Miklos Vajna yazdı
      Change-Id: I2d0bcc8d48ce0a4253b5deff11736b292e4f9e69
      Reviewed-on: https://gerrit.libreoffice.org/73188
      Tested-by: Jenkins
      Reviewed-by: 's avatarMiklos Vajna <vmiklos@collabora.com>
      69236a7a
    • Miklos Vajna's avatar
      ODT export: fix lost <text:user-field-decl> for fields in tables in headers · 6bb241cc
      Miklos Vajna yazdı
      The problem was that XMLTextFieldExport::ExportFieldAutoStyle() assumed
      that the text of a field anchor is always the toplevel XText, which is
      true in case of body vs header text, but false in case header text vs
      text-in-table-in-header.
      
      So add an UNO property which exposes the parent of a table cell, this
      way text in header (regardless of it's in a table or not) will have the
      same XText, leading to writing the necessary <text:user-field-decl>
      element for the matching <text:user-field-get> definition.
      
      Change-Id: I077b8d7e9dfae4062539894318637e266b925382
      Reviewed-on: https://gerrit.libreoffice.org/73176
      Tested-by: Jenkins
      Reviewed-by: 's avatarMiklos Vajna <vmiklos@collabora.com>
      6bb241cc
    • Zdeněk Crhonek's avatar
      uitest for bug tdf#120731 · 18d0d854
      Zdeněk Crhonek yazdı
      Change-Id: I85952c011e0f49e0fa8613910c993c919aa2b413
      Reviewed-on: https://gerrit.libreoffice.org/73189
      Tested-by: Jenkins
      Reviewed-by: 's avatarZdenek Crhonek <zcrhonek@gmail.com>
      18d0d854
    • Jim Raykowski's avatar
      Don't pass escape key event to SfxDockingWindow from sidebar · 8234b277
      Jim Raykowski yazdı
      ...docking window
      
      Missed this in recent rework concerning key input events in
      SidebarDockingWindow, tdf#125525 Allow shortcut keys from sidebar
      docking window.
      
      Change-Id: I53906251918874d2613795cb06a3e6ef07509bd8
      Reviewed-on: https://gerrit.libreoffice.org/73192
      Tested-by: Jenkins
      Reviewed-by: 's avatarJim Raykowski <raykowj@gmail.com>
      8234b277