Change-Id: I1d394e914c4791a2bc3a8f3dbb1cf200e7d528fe
Reviewed-on: https://gerrit.libreoffice.org/44691Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I707631718c30d4503ae675f3679038705371f969
Reviewed-on: https://gerrit.libreoffice.org/44672Reviewed-by: Jens Carl <j.carl43@gmx.de>
Tested-by: Jens Carl <j.carl43@gmx.de>

...after 945c10f4 "upload harfbuzz 1.6.3" had
dropped it completely.  Still necessary to e.g. avoid "runtime error: index 3
out of bounds for type 'OT::LongMetric const[1]'" during CppunitTest_emfio_wmf.

Change-Id: Idd93f6224f7e43016a71678bcaf5cc0527f95cee

Project: help  ac105fe860f05e66f574e135fa6fcb738db9347f

Fix script for online version of new help

Change-Id: I9a395dbc88b6c2606b2a7fca1d829b10922e4674
Reviewed-on: https://gerrit.libreoffice.org/44630Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>

For intra-Calc on-cell pastes using the paste special toolbar
button the SotClipboardFormatId::STRING_TSVC format can be used,
which preserves embedded line breaks and tabs by enclosing such
content in double quotes and escaping quotes by doubling them,
similar to CSV. This differs from the IANA
text/tab-separated-values MIME type (see
https://www.iana.org/assignments/media-types/text/tab-separated-values)
that does not allow quoted fields or embedded line breaks or tabs.

The text/plain "Unformatted text" format now again (after the
change with commit cdcd262ea4aa3c3e407b14ed533e514f75de2d3a for
tdf#32213) results in unquoted/unescaped content as expected for
external pastes.

A follow-up commit probably should distinguish whether the source
is one single cell or multiple cells and for multiple cells use a
strict TSV (with embedded line breaks and tabs changed to spaces)
if a simple "Unformatted text" is requested, which always uses
tabs as field separators anyway.

Further enhancement could be to offer strict
text/tab-separated-values and also text/csv at the clipboard if
there are applications that actually handle these MIME types.

Change-Id: Ica60f256e26867d854639823c62eedbf13eb4d4b
Reviewed-on: https://gerrit.libreoffice.org/44686Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>

This follows up on https://gerrit.libreoffice.org/44295

Change-Id: Iac8351161a5e0d79a61fbb06d96985f92db68e3c
Reviewed-on: https://gerrit.libreoffice.org/44626Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>

Also, use self-explaining variable name for argument NoSwitch.
Added use of argument NoSwitch to unit test document.

Change-Id: I801d4dbd489898b28543e0eb46f74717671ea03a
Reviewed-on: https://gerrit.libreoffice.org/44647Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>

See commit bff8d843
The SwUiWriterTest::testEmbeddedDataSource unit test is adjusted to
test the paths with "#".

Change-Id: I8d85147128915c7100ab9cc2888eb73c94fe6486
Reviewed-on: https://gerrit.libreoffice.org/44678Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

if, before lcl_UnicodeStrNCpy is called, aSymbol contains embedded
nulls then the aSymbol.getLength() and the mnRangeOpPosInSymbol value
derived from an earlier aSymbol.getLength() include the range after
the embedded null, while lcl_UnicodeStrNCpy stops at the first
embedded null leaving cSymbol with uninitialized value that
are later read from it.

Conditional jump or move depends on uninitialised value(s)
   at 0x23BFBCA0: ScCompiler::IsReference(rtl::OUString const&, rtl::OUString const*) (compiler.cxx:3275)
   by 0x23BFFF4C: ScCompiler::NextNewToken(bool) (compiler.cxx:4248)
   by 0x23C00D20: ScCompiler::CompileString(rtl::OUString const&) (compiler.cxx:4419)
   by 0x23A29FAF: ScFormulaCell::Compile(rtl::OUString const&, bool, formula::FormulaGrammar::Grammar) (formulacell.cxx:1118)
   by 0x23A278B7: ScFormulaCell::ScFormulaCell(ScDocument*, ScAddress const&, rtl::OUString const&, formula::FormulaGrammar::Grammar, ScMatrixMode) (formulacell.cxx:656)
   by 0x23772EC3: ScColumn::ParseString(ScCellValue&, int, short, rtl::OUString const&, formula::FormulaGrammar::AddressConvention, ScSetStringParam const*) (column3.cxx:1729)
   by 0x2377354B: ScColumn::SetString(int, short, rtl::OUString const&, formula::FormulaGrammar::AddressConvention, ScSetStringParam*) (column3.cxx:1851)
   by 0x23AE2B97: ScTable::SetString(short, int, short, rtl::OUString const&, ScSetStringParam*) (table2.cxx:1369)
   by 0x23897045: ScDocument::SetString(short, int, short, rtl::OUString const&, ScSetStringParam*) (document.cxx:3377)
   by 0x1F35F41C: ScEEImport::WriteToDocument(bool, double, SvNumberFormatter*, bool) (eeimpars.cxx:400)
   by 0x1F366F3B: ScFormatFilterPluginImpl::ScImportRTF(SvStream&, rtl::OUString const&, ScDocument*, ScRange&) (rtfimp.cxx:34)

Change-Id: Iefc6be6c3a383bd9b3cdeaa896c07e24e5100dc7
Reviewed-on: https://gerrit.libreoffice.org/44658Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>

reportedly

This reverts commit 15869ea2.

Change-Id: I930567f8dd9701a14ab02f42f89a629949453f22
Reviewed-on: https://gerrit.libreoffice.org/44671Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

OffsetClip record applies a translation transform
on the current clipping region for the world space.

Change-Id: Iac024a3c2eaba58edc5bb59d817796b6022f559f
Reviewed-on: https://gerrit.libreoffice.org/44597Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mark Page <aptitude@btconnect.com>

Wuthout this fix, it had always tried to replace in original path,
thus second occurence of double path delimiter, like in
C:\dir1\\dir2\dir3\\file
would result in invalid path reported.

Change-Id: I63ce97b620229601e18f10016a759275aceeec4d
Reviewed-on: https://gerrit.libreoffice.org/44675Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: Ic0797a988b7135927a53ca9f16c8bc30d24feef5
Reviewed-on: https://gerrit.libreoffice.org/44673Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Change-Id: I49387d2b6ec1893bf721e3289f2f620a4ce71fb3
Reviewed-on: https://gerrit.libreoffice.org/44668Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

In preparation to solve tdf#113571 *AND* keeping tdf#32213 fixed
we need two separate unformatted text formats to distinguish
between in-Calc on-cell paste and external or in-cell paste.

Change-Id: Ic81a0c17d0643af2f5f4be50e67b690fd8846388

Change-Id: I08752c66fd2680aa5f2eb2968d7e23cf797090f9
Reviewed-on: https://gerrit.libreoffice.org/44667Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I5a2f882a51c60229414bc29522d27adbbe37fd62
Reviewed-on: https://gerrit.libreoffice.org/44663Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: I5de5c6f3e8be1d40c03cbddb9d2f4414b9a5791b

Change-Id: I55f8f0ca9478e676832ebbb08e98dbd1cf0fa4fc
Reviewed-on: https://gerrit.libreoffice.org/44666Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Change-Id: I32d07ba85f4a37a10eaf03d251d41b9e71d34c93
Reviewed-on: https://gerrit.libreoffice.org/44660Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Restrict the git hook further to only enforce style in case the found
clang-format binary's version matches to avoid output differences with
different clang-format version.

While at it, move the blacklist reading after the version check to speed
up committing a bit when no local enforcement happens.

Also add a simple script to list formatted files, since the blacklist is
large enough that doing it naively from the shell is too slow.

Change-Id: I0bc05961d262cc6bc91c6efdd1b91994ecfc6940
Reviewed-on: https://gerrit.libreoffice.org/44662Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

asan reports that the strdups leak and __si_class_type_info takes a
const char* arg

Change-Id: Ie0ee94554689d9246981cb7d6ce0f23917c2d333
Reviewed-on: https://gerrit.libreoffice.org/44641Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

(in 5f27a686.) Whether this has
anything to do with tdf#92190 is unclear. (I am not able to reproduce
that bug.)

Thanks to Telesto for noticing this copy-paste issue.

Change-Id: Iab47db59dc2af76adf70d92ab8333e06cd40e0d6

Similar to sw modules we have mostly filters tests here which
takes a bigger amount of time.

Change-Id: I1305fa7904b74f849762ce4e4d7a005680b3a055
Reviewed-on: https://gerrit.libreoffice.org/44656Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Change-Id: I802d9aae2220ae6b8f67e3387c3b329f6b02163c

<unx/gtk/gtksalmenu.hxx> is already included at the beginning of
the file.
So no need to check to include it.

Change-Id: I66988734271fa8fe8434e8090337f0ab14a8b994
Reviewed-on: https://gerrit.libreoffice.org/44646Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mark Page <aptitude@btconnect.com>

...in d71bcc4d "Fix typos"

Change-Id: I74e73e99ad9ca3caa4abb40f8eed4648418b3a0a

Change-Id: I2a10e087a776ac96b3193226610577227d2492a8
Reviewed-on: https://gerrit.libreoffice.org/44655Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mark Page <aptitude@btconnect.com>

Change-Id: Ia544298334364ece3b3963a4adc00c5e01189b91
Reviewed-on: https://gerrit.libreoffice.org/44654Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mark Page <aptitude@btconnect.com>

Change-Id: I3e477162468ad7386d83480ce8ae1da9536465b0

Change-Id: Id76cf021658936301dd6b9685cafe7ece7ffa228
Reviewed-on: https://gerrit.libreoffice.org/44589Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ib32e3ca6ba55ab99820a54023041247cea96ab0c
Reviewed-on: https://gerrit.libreoffice.org/44652Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

remove default-able copy constructors/assignments
and a non-virtual default dtor.

Change-Id: I3fcc23a480031a9ede00ea22ae8f5ac5e892fd9c
Reviewed-on: https://gerrit.libreoffice.org/44657Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

No need to create helper for those methods.

Change-Id: I0505fe8141b1bad852b7f30aeb69628fb6a90071
Reviewed-on: https://gerrit.libreoffice.org/44649Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I4c5ca9dc59a08343fdbd2c2237f8346572f26011
Reviewed-on: https://gerrit.libreoffice.org/44659Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Slide is now the left-most item in Impress/Draw's status bar and layout status comes after context

Change-Id: If79bd7839d7241fe58e923e189fd33a48bfe275b
Reviewed-on: https://gerrit.libreoffice.org/44604Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

Change-Id: I29593b20d7053bf51b1ef2aee295e73c6f3b858b
Reviewed-on: https://gerrit.libreoffice.org/44650Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Do like ScDataTableView::MouseButtonDown
    188 void ScDataTableView::MouseButtonDown(const MouseEvent& rMEvt)
    189 {
    190     if (!rMEvt.IsLeft())
    191         return;
...

See bt:
0  0x00007fffc971096c in Point::X() const (this=0x0) at /home/julien/lo/libreoffice/include/tools/gen.hxx:77
1  0x00007fffc9c67f92 in Point::getX() const (this=0x0) at /home/julien/lo/libreoffice/include/tools/gen.hxx:98
2  0x00007fffca04ca9f in ScDataTableView::MouseButtonUp(MouseEvent const&) (this=0x555558afbed0, rMEvt=...)
    at /home/julien/lo/libreoffice/sc/source/ui/miscdlgs/datatableview.cxx:242

Change-Id: Ia124dcec698438b51072956949e3274a8e3f77c5
Reviewed-on: https://gerrit.libreoffice.org/44651Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I2a45a62fd56cc5a768406c7a6e4c72456f962367
Reviewed-on: https://gerrit.libreoffice.org/44648Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

added -ggdb2 to final linking

Added extra folder to include some LO files needing debug

Change-Id: Ieed2ff630b67df358dc47e2b27a51e8c692308b5