largely based on the relevant portion of the unusedfields loplugin, but
adapted for local vars

Change-Id: Ic522a941573940e8f75c88f90ba5f37508ca49b1
Reviewed-on: https://gerrit.libreoffice.org/66835
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I4446858ed30df4adffbf18ab609c95690cff99c0
Reviewed-on: https://gerrit.libreoffice.org/67668
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>

Change-Id: I4783cd877925f797af7851670d4ea5d091b1c935
Reviewed-on: https://gerrit.libreoffice.org/67618
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

...from <https://github.com/flathub/org.libreoffice.LibreOffice/>:

commit 35de93fdcbfc7c7f6972812535e832f1405658cb
Merge: b397586 06020ec
Author: stbergmann <sbergman@redhat.com>
Date:   Mon Feb 11 10:18:24 2019 +0100

    Merge pull request #70 from Erick555/patch-1

    Update gvfs to 1.38.1; apache-ant to 1.10.5

commit 06020ec8be69c8c2d22265c7066c2b838d231400
Author: Erick555 <37542552+Erick555@users.noreply.github.com>
Date:   Sat Feb 9 21:24:57 2019 +0100

    Update apache-ant to 1.10.5

commit 7c0a9d3fcd5988bc955bf5d67aa3249d45727bb4
Author: Erick555 <37542552+Erick555@users.noreply.github.com>
Date:   Sat Feb 9 21:19:16 2019 +0100

    Update gvfs to 1.38.1

    * use meson as autotools support was removed.

    * use same config options as gnome runtime does:
    https://gitlab.gnome.org/GNOME/gnome-build-meta/blob/gnome-3-30/elements/sdk/gvfs.bst#L17

Change-Id: Ib4314ea49220bcac01fafb600065e41b434c395b
Reviewed-on: https://gerrit.libreoffice.org/67672
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I539e6aedad61d80b6ebe80104b77d720072395bd

Change-Id: Id2704c2ac38125dd6449496c0967eadc3679fdbc

IFS/SWITCH if the call did not originate from
ScDocShell::DoRecalc()/ScDocShell::DoHardRecalc()

Change-Id: Ifdb3a496276dc841fc42a1bad1876cfb1057baf6
Reviewed-on: https://gerrit.libreoffice.org/67414
Tested-by: Jenkins
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

Change-Id: Ibb6f3a1c711959cb4f32541dba96f005e51c9040

we can use the nice new C++14 compare methods to do this properly

Change-Id: Ic2a8e46747c4a105d93d32b5f58a061a2e0d4e26
Reviewed-on: https://gerrit.libreoffice.org/67666Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I36c02de94bd7fcbf06e53ce930b6b0e850f2ae31
Reviewed-on: https://gerrit.libreoffice.org/67667Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

Change-Id: I17bb0b462bb4ce7e8128c9ad33491aa8b691e566

Change-Id: I7a14995e99a92bd6c36ccc8a17f8ae99a9a5887b
Reviewed-on: https://gerrit.libreoffice.org/67662
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: Ibaeac1ddfbe34a11d3205abc6257367497dc855e
Reviewed-on: https://gerrit.libreoffice.org/67581Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
Tested-by: Heiko Tietze <tietze.heiko@gmail.com>

As proposed in https://gerrit.libreoffice.org/#/c/67473/

Change-Id: Ibbc2d32dde2363502915cfeb036fa6f4ba568932
Reviewed-on: https://gerrit.libreoffice.org/67574
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: I2a2a189ee727a51aeef5601b39bb288d813fc8f3
Reviewed-on: https://gerrit.libreoffice.org/52610
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: I9221608db417217dd7c97c0300ecedb67fa74132
Reviewed-on: https://gerrit.libreoffice.org/67603
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Iba19864313dc5039f5ca27be3d0c68785612346a
Reviewed-on: https://gerrit.libreoffice.org/67602
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>

Change-Id: Iacc398b4195b742ca453a2480e78bbf0e25909e8
Reviewed-on: https://gerrit.libreoffice.org/67663
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Icfedb77943721f0ed7504ec68c3b63c4709352bc
Reviewed-on: https://gerrit.libreoffice.org/67615
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>

look for mixed indentation in compound statements, which makes them hard
to read, and sometimes makes it look like a statement is associated with
a nearby if/for

Change-Id: Ic8429cee1f9a86d938097a4a8769a2bce97b3361
Reviewed-on: https://gerrit.libreoffice.org/63283
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ib9ad5b874a210ef3862c668158fcc5d18eeab363
Reviewed-on: https://gerrit.libreoffice.org/67579
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

V560 A part of conditional expression is always false:
     !pPrevActContent.

Change-Id: Ief1b560ea8a4e1d85a693909b6a6a80566fa2f34
Reviewed-on: https://gerrit.libreoffice.org/67547
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I4449fead67459bdcbdc0e9320129e7a5b36aecd9
Reviewed-on: https://gerrit.libreoffice.org/67545
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I598ba9c49e919c3a521b3062c83b72a1c7949b9e
Reviewed-on: https://gerrit.libreoffice.org/67540
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

V560 A part of conditional expression is always true: !pSymbolList.

In commit a2cd17d1, pSymbolList and
xSymbols were made non-static. The check below was left though.

Actually, I don't know if that was a safe move, since it's unclear
how the lifetime of the returned pointer is managed now to prevent
use-after-free.

Change-Id: Ia51a9790503694f909ce7953337d3caaebfabfc1
Reviewed-on: https://gerrit.libreoffice.org/67512
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I62cb3b8927d664b3d5359ee6ac7db30d354f4821
Reviewed-on: https://gerrit.libreoffice.org/67496
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

V560 A part of conditional expression is always false:
     nType != m_nDialogType.

Change-Id: I9182ec170aa41516208f97bb8543d348990f046d
Reviewed-on: https://gerrit.libreoffice.org/67488
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I67462369d93e9d9ff3c056800947c4b75f71ba5f
Reviewed-on: https://gerrit.libreoffice.org/67486
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Which doesn't actually make much of a difference in this case because
this is a welded dialog, which currently does not preserve a VclPtr
owner of such dialogs.

Perhaps we should rather fix the
   SfxTabDialogController::runAsync
infrastructure to temporarily
(a) preserve an owner for such dialogs
(b) disposeAndClear such dialogs
at least until we are done with welding?

Otherwise this is very confusing.

Change-Id: I568eb6813925299663ac3f90749b64076d404d19
Reviewed-on: https://gerrit.libreoffice.org/65708
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ibda157508e92ab5fb222daf79a38941c30a8057e
Reviewed-on: https://gerrit.libreoffice.org/67611
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Idd7166833764fdf1d9c42a050490572a8b330199
Reviewed-on: https://gerrit.libreoffice.org/67610
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I76de5678dd21f207e9e9c2a0c446f2c0b9be974e
Reviewed-on: https://gerrit.libreoffice.org/67609
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ifa4b34065dacf9e144f076631c57f1d01aedaeeb
Reviewed-on: https://gerrit.libreoffice.org/67608
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I96ed4c51ce3fe45c1cb69a7d7ff917f1e152462e
Reviewed-on: https://gerrit.libreoffice.org/67607
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

and just use our normal handlers, instead of this weird magic

Change-Id: I8245787bec2a755ce6aba31ed681577771537ca1
Reviewed-on: https://gerrit.libreoffice.org/67534
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Patch by: me

(cherry picked from commit 7595a809)

Change-Id: I59a561aad16073fec1567e1873842a2b11dff4df
Reviewed-on: https://gerrit.libreoffice.org/67594
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ib88e6582676c78853e37d7e903d565160972af64
Reviewed-on: https://gerrit.libreoffice.org/67596
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: If7e87f725ea44732080fc0c57e4503c82b0cf4a0
Reviewed-on: https://gerrit.libreoffice.org/67595
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

(cherry picked from commit 85e84306)

Change-Id: I7c686e11a9449d0107b821e42feb3b360b42b50a
Reviewed-on: https://gerrit.libreoffice.org/67593
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

(cherry picked from commit e98508d6)

Change-Id: I990b1be02b2f9cf47a7587982f7a28159ad2f139
Reviewed-on: https://gerrit.libreoffice.org/67592
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>