- 16 Ara, 2018 4 kayıt (commit)
-
-
Mike Kaganski yazdı
This replaces commit 53058090. Now not only failure to start WU service, but also other errors during MSU installation won't break installation. E.g., running WU service as Guest does not prevent the service from starting; but installing updates fail, which makes previous solution incomplete. Instead, show a warning in those rare cases when an error happens, and continue. It will allow users to see the reason if they see "api-ms-win-*.dll missing" message later after installation. Of course, some small percentage of these warnings will be false, e.g. those on Windows 10. But those false messages must be really small minority, because only when (1) the installation fails (2) on a system with the component already present, such a message would be false. And it will not prevent the installation. This will not block unattended installations, since in those cases, MsiProcessMessage() will do nothing. Change-Id: I3a9e681e9d6701d092bd5c18bb4b68b4f77170f3 Reviewed-on: https://gerrit.libreoffice.org/64874 Tested-by: Jenkins Reviewed-by:
Mike Kaganski <mike.kaganski@collabora.com>
-
Zdeněk Crhonek yazdı
Change-Id: Id9dbd53f2902f484f9d1209953ff2ad58d77936c Reviewed-on: https://gerrit.libreoffice.org/65199 Tested-by: Jenkins Reviewed-by:
Zdenek Crhonek <zcrhonek@gmail.com>
-
Stanislav Horacek yazdı
* Update helpcontent2 from branch 'master' - fix small typo Change-Id: Ice019261f62cc4ade55ede48f492373877954d06 Reviewed-on: https://gerrit.libreoffice.org/65215 Tested-by: Jenkins Reviewed-by:Julien Nabet <serval2412@yahoo.fr>
-
Michael Weghorn yazdı
Since 'XComponentContext' and 'DECL_STATIC_LINK' are used, add the corresponding includes. Otherwise a successful build depends on the header being included after other headers that make sure that compilation still works. An error could be provoked e.g. by moving the '#include <gtk/fpicker/SalGtkFilePicker.hxx>' in 'vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx' above all other existing includes. Change-Id: Ib23f8b714fb971238eab28a8d4d02414a0b13812 Reviewed-on: https://gerrit.libreoffice.org/65208 Tested-by: Jenkins Reviewed-by:
Michael Weghorn <m.weghorn@posteo.de>
-
- 15 Ara, 2018 10 kayıt (commit)
-
-
Andrea Gelmini yazdı
Change-Id: I846df107b450c966725bc1e516cec5989b8f4b08 Reviewed-on: https://gerrit.libreoffice.org/65193 Tested-by: Jenkins Reviewed-by:
-
Mike Kaganski yazdı
Previously, it used to use FindFirstFile on initial parts of UNC paths, and failed, failing the whole path. Change-Id: Ibc4442e28da17625676695070ed7ddba619f9082 Reviewed-on: https://gerrit.libreoffice.org/65191 Tested-by: Jenkins Reviewed-by:
-
sabri unal yazdı
* Update helpcontent2 from branch 'master' - Correct Image - Compress context menu reference. Calc does not have "Image - Compress..." context menu entry anymore. It uses "Compress..." content menu entry as default. Change-Id: I4c30616361973dff60d8bd8eca320f08241ee11c Reviewed-on: https://gerrit.libreoffice.org/65198 Tested-by: Jenkins Reviewed-by:Olivier Hallot <olivier.hallot@libreoffice.org>
-
Samuel Mehrbrodt yazdı
Change-Id: Ic4a49494652dab416ddb1545da02eb8a7f533828 Reviewed-on: https://gerrit.libreoffice.org/65126 Tested-by: Jenkins Reviewed-by:
Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
-
Xisco Fauli yazdı
Only reproducible with GTK3 (maybe KDE5?). This way we ensure a uniformed behavior across vclplugins anyway Change-Id: I6edd6a426cb206d797b504ddcdcef999f79fa3c8 Reviewed-on: https://gerrit.libreoffice.org/65189 Tested-by: Jenkins Reviewed-by:
Xisco Faulí <xiscofauli@libreoffice.org>
-
Caolán McNamara yazdı
Change-Id: Ib91b3f204d847cbe96750b4c080e958597bb3b9b Reviewed-on: https://gerrit.libreoffice.org/65110 Tested-by: Jenkins Reviewed-by:
Heiko Tietze <tietze.heiko@gmail.com> Tested-by:
-
Jens Carl yazdı
Move XEnumerationAccess Java test to C++ for ScHeaderFieldsObj. Change-Id: Ibead91f6c4369bb75e218eadb99776b0d1fb7cf4 Reviewed-on: https://gerrit.libreoffice.org/64799 Tested-by: Jenkins Reviewed-by:
Jens Carl <j.carl43@gmx.de>
-
Jens Carl yazdı
Move XRefreshable Java tests to C++ for ScHeaderFieldsObj. Change-Id: Ia922b11e93f38bfc56795cc34c150b3429fd5447 Reviewed-on: https://gerrit.libreoffice.org/64798 Tested-by: Jenkins Reviewed-by:
-
Caolán McNamara yazdı
with a scrolledwindow with a horizontal external policy which doesn't show a scrollbar, but allows the scrolledwindow to shrink past its child size Change-Id: Ia73fc819a16bef49008e7e41bcc2d523c28268b0 Reviewed-on: https://gerrit.libreoffice.org/65171 Tested-by: Jenkins Reviewed-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
-
Tamás Zolnai yazdı
A Writer image does not behave similar to other shapes, so we need to generate a shape to get the export code working. Change-Id: Icfb25ceb40f73f1018d379863b836d8303e539f3 Reviewed-on: https://gerrit.libreoffice.org/65176 Tested-by: Jenkins Reviewed-by:
Tamás Zolnai <tamas.zolnai@collabora.com>
-
- 14 Ara, 2018 26 kayıt (commit)
-
-
Tamás Zolnai yazdı
Change-Id: Ic305e5305890fd1efa3a3130e5216f9c672870e5 Reviewed-on: https://gerrit.libreoffice.org/65175 Tested-by: Jenkins Reviewed-by:
-
Balazs Varga yazdı
Modify the chart data label rendering in case of Column/Bar chart only if the datapoint value is 0. This patch fix in case of NEAR_ORIGIN and CENTER DataLabelPlacement. Change-Id: Ia9857b5ac0cc5feaf2e1fd08e98c9f8534e5af04 Reviewed-on: https://gerrit.libreoffice.org/65082 Tested-by: Jenkins Reviewed-by:
László Németh <nemeth@numbertext.org> Tested-by:
-
Tamás Zolnai yazdı
Change-Id: Iaa962fe5a590ef16e710fdd49d02d564f10f0f9f Reviewed-on: https://gerrit.libreoffice.org/65188 Tested-by: Jenkins Reviewed-by:
-
Tamás Zolnai yazdı
Calculation of the visible area is not working correctly in online case which leads to positioning of the shape outisde of the view. Instead of that calculation use the selected cell's position to insert the shape at, similar how image insertion works. Change-Id: I5c887261556c491962ed19f416ce480a63c24a9a Reviewed-on: https://gerrit.libreoffice.org/65177 Tested-by: Jenkins Reviewed-by:
-
Tamás Zolnai yazdı
Separate generic code from Impress / Draw specific code and implement shape selection handling in case of Writer. This is an internal filter, so it can be called only from the code. Change-Id: I807e04a0949530d6029037bb964c10c80197ff33 Reviewed-on: https://gerrit.libreoffice.org/65174 Tested-by: Jenkins Reviewed-by:
-
Olivier Hallot yazdı
* Update helpcontent2 from branch 'master' - Adjust bookmarks for python place bookmarks at the right page Change-Id: Ia5ce242ab9d21be2ca1b7b4f078af0b824d00c3a Reviewed-on: https://gerrit.libreoffice.org/65187 Tested-by: Jenkins Reviewed-by: -
Miklos Vajna yazdı
Bulleted paragraphs had a large left indent because we assumed the bullet levels are inherited from the normal master page styles. But that's not true, as <https://support.office.com/en-us/article/add-bullets-to-a-shape-in-a-smartart-graphic-47edc03d-a2f8-4b54-acfd-ca103c515ab4> points out: "It is not possible to change the bullet style for text in a SmartArt graphic." This explains why the margin and bullet char info is missing from the file format, and hints that just hardcoding these to the importer is correct. The result is less linebreaks in the shape text and the lost bullets are also fixed. Change-Id: I60bbee75f3e834551ebb1963a2f42101f3bd91d4 Reviewed-on: https://gerrit.libreoffice.org/65168Reviewed-by:
Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
-
Stephan Bergmann yazdı
...by reverting part of 6f50961e "remove more rtl::OUString and OString prefixes" Change-Id: I50d37f437bb6f760c0d3990faaf71084913520f0 Reviewed-on: https://gerrit.libreoffice.org/65169 Tested-by: Jenkins Reviewed-by:
Stephan Bergmann <sbergman@redhat.com>
-
Caolán McNamara yazdı
Change-Id: I5fcab474b517a0482bd04dedd0fcee6a817dd3b0 Reviewed-on: https://gerrit.libreoffice.org/65164 Tested-by: Jenkins Reviewed-by:
-
Olivier Hallot yazdı
* Update helpcontent2 from branch 'master' - Fix missing entry in makefile + bookmarks Change-Id: I836964a1ec29485ee05617cce486dadd5b009591 Reviewed-on: https://gerrit.libreoffice.org/65161 Tested-by: Jenkins Reviewed-by: -
Luboš Luňák yazdı
The testcase from tdf#102364 is actually a rather pathological case, the document having a full 1M cells column with the same formula, and doing undo in this case essentially pastes the column over itself (I think a column is first deleted, which moves this column, and then ScUndoInsertCells will trigger ScMoveUndo::UndoRef(), which will paste the column in that place again. And since this is done cell by cell, removing old cell first splits the large formula group and then adding a new cell with the same formula rejoins the formula group, and setting these formula group changes for all the cells over and over actually takes a long time. Avoid that by delaying the formula grouping operation and do it just once at the end. I'm not sure if this is that good way of handling this, given the testcase is very specific, but I can imagine something similar happening in other possible cases (manual copy&paste of a large column over itself or moving it slightly up or down). Change-Id: Ie4241197103a039c232150333250f78175b1c2c7 Reviewed-on: https://gerrit.libreoffice.org/64782 Tested-by: Jenkins Reviewed-by:
Kohei Yoshida <libreoffice@kohei.us> Reviewed-by:
Eike Rathke <erack@redhat.com>
-
Luboš Luňák yazdı
The document has a large (1M cells) column, and when replacing old cells with new cells during undo as described in the bugreport the repeated calls to EndListener() from ScColumn::DetachFormulaCell() get quite costly. Optimize this by doing a single EndListeningFormulaCells() call. Change-Id: If51dacdfbe876134de956dbc6bbd73e97d9686ff Reviewed-on: https://gerrit.libreoffice.org/64781 Tested-by: Jenkins Reviewed-by:
-
Eike Rathke yazdı
Change-Id: I83972b07dafadf87f7322897332bbdf0cf58afd3 Reviewed-on: https://gerrit.libreoffice.org/65162Reviewed-by:
-
Patrick Jaap yazdı
The anchor can move to other pages if the frame is moved. To avoid removing the contents of the frame, exclude this case. This resolves a regression introduced by 8d62b79f Change-Id: Ie7acd3c58ef9055cbe449ec15d337f03a02e0edd Reviewed-on: https://gerrit.libreoffice.org/62987 Tested-by: Jenkins Reviewed-by:
-
Caolán McNamara yazdı
Change-Id: If17d2984831b0881d39101648206accdadde12aa Reviewed-on: https://gerrit.libreoffice.org/65163 Tested-by: Jenkins Reviewed-by:
-
Mike Kaganski yazdı
PathRemoveFileSpec is used exclusively in GetCaseCorrectPathName(Ex). The GetCaseCorrectPathName function is only called for absolute or relative paths, not some arbitrary that chunks. So initial double backslashes are only possible for UNC paths. This change fixes handling of UNC paths by the functions. Previously, the UNC path was recursively shortened until it only consisted of a single "\"; then, if bCheckExistence was requested, testing this path failed, which resulted in the whole recursion to return empty result; else when returning from the recursion, original path components were appended, but initial double backslashes were never restored. This led to transformation "\\SERVER\Path\file.ext" to "\SERVER\Path\file.ext". The GetCaseCorrectPathName itself is only used in two places: osl_getSystemPathFromFileURL_() and osl_getFileStatus(). osl_getSystemPathFromFileURL_ only calls GetCaseCorrectPathName for paths longer than 248 characters; bCheckExistence is false. In that case, the resulting wrong path (missing one initial backslash) was then processed in /* it should be an UNC path, use the according prefix */ branch, where two initial characters of it were stripped, one of which being the first character of SERVER name. So, all the following manipulations with resulting path were incorrect. This code path was the reason for the bug. osl_getFileStatus calls GetCaseCorrectPathName always; it requires to check existence. This led to 0 returned from GetCaseCorrectPathName, then osl_getFileStatus continued with copying the original string, thus ignoring the error. Change-Id: If7409afa2c0dd6dd001c79e719acbfd271a6ab72 Reviewed-on: https://gerrit.libreoffice.org/65158 Tested-by: Jenkins Reviewed-by:
-
Caolán McNamara yazdı
race in SwDoc::CreateNumberFormatter on thread unsafe mpNumberFormatter. thread 1: SwDoc::CreateNumberFormatter SwDoc::GetNumberFormatter ... sw::DocumentTimerManager::DoIdleJobs Timer::Invoke thread 2: SwDoc::CreateNumberFormatter SwDoc::GetNumberFormatter SwXTextDocument::GetNumberFormatter(); SwXTextDocument::queryInterface ... SvXMLExport::setSourceDocument SvXMLNumFmtExport::SvXMLNumFmtExport Change-Id: Iad9aa9514c9de61eb40256b954d0444d9fc9d81e Reviewed-on: https://gerrit.libreoffice.org/65034 Tested-by: Jenkins Reviewed-by:
-
Justin Luth yazdı
In LO 4.3, Feb 2014 commit a31fbb53 totally changed the logic of the FormatBreak function, affecting doc and rtf even though the focus was only on docx. This was quickly patched for some specific cases, but the careless changes weren't fully reversed. Doing that now, because reading the code it just seems all wrong. As I understand it, there seems to typically be two passes - a valid pass for bBreakBefore and then a separate PageAfter pass. When DOC changed to prefer a breakBefore sprm, it removed the bBefore flag, did nothing on the bBreakBefore pass, and on the after pass, nC wasn't defined, so it did nothing extra. Dropping the bBefore flag probably broke the docx case. Docx commit a31fbb53 just blew that all away, and swapped when SectionBreak was called. Another 2014 patch restored the DOC PageBefore behaviour (nC not defined, so nothing happens), but didn't restore the PageAfter behaviour so SectionBreak was still swapped. So what logically seems to be needed is to restore the bBefore flag (prior to DOC's preference for breakBefore sprm), restore writing PageBreak_After in after pass, and ignore the FollowPageDesc (because it didn't seem to be included purposefully). PageAfter only seems to be UI possible in a table's text flow. So it is VERY uncommon (no instance at all in existing unit tests.) And, not surprisingly, it doesn't export a page break after the table in doc or docx format anyway. At least now it won't put the break BEFORE the table in docx. This will restore these previous behaviours: -doc/rtf: PageAfter no longer written in bBreakBefore stage -docx: -PageAfter no longer written in bBreakBefore stage -PageBefore not affected by FollowPageDesc. PageBefore is generally unaffected by this change, and now the test for page/column break matches again, as would be expected. Change-Id: I265541a04be49e6b60bfbd84c33ab5783b454058 Reviewed-on: https://gerrit.libreoffice.org/64983Reviewed-by:
Justin Luth <justin_luth@sil.org> Tested-by:
-
Xisco Fauli yazdı
This reverts commit c9493b34. According to https://bugs.documentfoundation.org/show_bug.cgi?id=96248#c15 the asert was gone even before the patch... Anyway, better to have an assert than a crash Change-Id: I84389bf2e8e604f6967923c0eedaae3aec3455e6 Reviewed-on: https://gerrit.libreoffice.org/65115 Tested-by: Jenkins Reviewed-by:
Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by:
-
Caolán McNamara yazdı
Change-Id: Id27609a86558094e6b53c763aebe77c97cc11672 Reviewed-on: https://gerrit.libreoffice.org/65147 Tested-by: Jenkins Reviewed-by:
-
Vasily Melenchuk yazdı
Template format now supported not only for import, but for export too. Change-Id: I9fb9da14c4d6466b6979fa37fb2c0359ce5 Reviewed-on: https://gerrit.libreoffice.org/64947 Tested-by: Jenkins Reviewed-by:
Katarina Behrens <Katarina.Behrens@cib.de>
-
Tamas Bunth yazdı
Result set field information should be stored correctly. It is queried from database on demand and stored locally. Change-Id: Ia62c62e6db32b45640b9fcd5f48c6249aecc41a2 Reviewed-on: https://gerrit.libreoffice.org/64861 Tested-by: Jenkins Reviewed-by:
Tamás Bunth <btomi96@gmail.com>
-
Katarina Behrens yazdı
Change-Id: I0e975bb73211b1d4ddb2e721659f64b361d11322 Reviewed-on: https://gerrit.libreoffice.org/65121 Tested-by: Jenkins Reviewed-by:
-
Gabor Kelemen yazdı
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Cleaned directories are: accessibility, drawinglayer, itemsetwrapper, main, sidebar Change-Id: I612eae9dec636d57a3a3a00102d74b964da5b54c Reviewed-on: https://gerrit.libreoffice.org/64307 Tested-by: Jenkins Reviewed-by:
-
Andrea Gelmini yazdı
Change-Id: I09775c92f7c5b5e0f554a2822d243a230a06f626 Reviewed-on: https://gerrit.libreoffice.org/65136 Tested-by: Jenkins Reviewed-by:
-
Miklos Vajna yazdı
Martin Hosken thinks all patches are redundant now, so drop them. Change-Id: I062168416a1289b7f4dd42d8ae58b7df56a37712 Reviewed-on: https://gerrit.libreoffice.org/65074 Tested-by: Jenkins Reviewed-by:
-
