1. 14 May, 2019 1 kayıt (commit)
  2. 13 May, 2019 1 kayıt (commit)
    • Jan-Marek Glogowski's avatar
      Make BitmapColor inherit from / merge into Color · c34bb163
      Jan-Marek Glogowski yazdı
      BitmapColor itself is kept to distingish the Color usage as part
      of a color palette, which continues to store the offset in the
      blue value. The original special mbIndex handling is long gone
      since commit 1fefdd6f ("Alpha channel in BitmapColor - change
      bIndex to alpha"), so there is no data difference.
      
      This also results in the following changes:
      
      * now has a basic_ostream<charT, traits>& operator<<
        (that was my actual starting point... for an other bug fix)
      * there is a minimal difference for GetLiminance
        BGR(29,151,76) => BGR(28,151,77)
      * no more return values for Merge and Invert
        (previously returning *this)
      * replaces all GetBlueOrIndex with GetIndex
      
      This leaves one "problematic" part: the GetColorError handling.
      At first glance it should probably be virtual. The Color variant
      is less strict then the BitmapColor one - for whatever reason.
      BitmapColor is always used to search for the best match in a
      Palette. Currently I'm simply leaving both variants. Would be
      nice to have an explict for functions here.
      
      Change-Id: I251ba3024a1d60f2a9d9fde9cd0a60f08e8322a7
      Reviewed-on: https://gerrit.libreoffice.org/72181
      Tested-by: Jenkins
      Reviewed-by: 's avatarTomaž Vajngerl <quikee@gmail.com>
      Reviewed-by: 's avatarJan-Marek Glogowski <glogow@fbihome.de>
      c34bb163
  3. 12 May, 2019 1 kayıt (commit)
  4. 10 May, 2019 1 kayıt (commit)
  5. 09 May, 2019 1 kayıt (commit)
  6. 08 May, 2019 1 kayıt (commit)
  7. 07 May, 2019 1 kayıt (commit)
  8. 30 Nis, 2019 2 kayıt (commit)
  9. 27 Nis, 2019 1 kayıt (commit)
  10. 22 Nis, 2019 2 kayıt (commit)
  11. 21 Nis, 2019 1 kayıt (commit)
    • Tomaž Vajngerl's avatar
      rework Color to have R,G,B,A public variables · d487d6e0
      Tomaž Vajngerl yazdı
      Color is a wrapper around a sal_uInt32 variable. With a union,
      separate channels R, G, B, A sal_uInt8 variables can be added
      that occupy the same memory. This makes it much easier to access
      each color component separately, which is used quite a lot by
      various algorithms. This also adds the variables to public so
      everyone can enjoy the benefits.
      
      Tests have been extended to make sure this doesn't break the
      existing algroithms.
      
      Change-Id: I2e78e12df68e8c7f0f49420eef5e659b335ee397
      Reviewed-on: https://gerrit.libreoffice.org/71002
      Tested-by: Jenkins
      Reviewed-by: 's avatarTomaž Vajngerl <quikee@gmail.com>
      d487d6e0
  12. 17 Nis, 2019 1 kayıt (commit)
  13. 15 Nis, 2019 2 kayıt (commit)
  14. 03 Nis, 2019 2 kayıt (commit)
  15. 06 Mar, 2019 1 kayıt (commit)
  16. 21 Şub, 2019 1 kayıt (commit)
    • Stephan Bergmann's avatar
      loplugin:indentation (macOS) · 6333dcf6
      Stephan Bergmann yazdı
      * Some .m/.mm files that still contained tabs instead of spaces have been
        cleaned up with Emacs' untabify (and
        apple_remote/source/HIDRemoteControlDevice.m needed further manual adaptions):
      
        apple_remote/source/GlobalKeyboardDevice.m
        apple_remote/source/HIDRemoteControlDevice.m
        apple_remote/source/KeyspanFrontRowControl.m
        apple_remote/source/RemoteControl.m
        vcl/osx/a11yrolehelper.mm
      
      * Some of the changes predate 0626e66d "Avoid
        loplugin:indentation after preproc conditional inclusion lines" and would
        likely have no longer been flagged since.
      
      Change-Id: Ibf5faffa743c7f79b36109d9879eb79d63c8c40f
      Reviewed-on: https://gerrit.libreoffice.org/68090
      Tested-by: Jenkins
      Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      6333dcf6
  17. 19 Şub, 2019 1 kayıt (commit)
  18. 11 Şub, 2019 1 kayıt (commit)
  19. 09 Şub, 2019 1 kayıt (commit)
  20. 08 Şub, 2019 1 kayıt (commit)
  21. 05 Şub, 2019 1 kayıt (commit)
    • Stephan Bergmann's avatar
      Move dubious file: -> smb: conversion from INetURLObject to file UCP · 46c645bf
      Stephan Bergmann yazdı
      The Linux-only conversion of file URLs with a non-empty (other than "localhost")
      authority to smb URLs had been added in 2010 with
      0b9ef81b "tools-urlobj-smb-scheme-patch.diff:
      migrated" (applying a Go-oo patch?) but giving no rationale beyond "process
      relative SMB paths (in hyperlinks) correctly".  That makes it hard to tell
      whether that patch is (still) actively useful for anything, or was just a
      misguided hack from the beginning:
      
      * Why make this Linux only?  What about other non-Windows OSs?  (On Windows,
        such URLs can be resolved as UNC pathnames.)  If the reason for Linux-only was
        that it is the only OS where LO can handle smb URLs via GIO, why not make it
        conditional on ENABLE_GIO?
      
      * Why map to smb?  There are various remote file access protocols.  Hardcoding
        smb looks arbitrary here.
      
      Anyway, INetURLObject is arguably at a wrong level for such a patch.  To not
      drop the hack wholesale, reimplement it in the file UCP, forwarding to a
      potential other UCP that can handle smb URLs any file://<host>/... URLs
      (rewritten as smb URLs) that the file UCP cannot handle itself.
      (file://localhost/... URLs will already have been normalized to file:///... by
      INetURLObject when they reach the file UCP, and even if they were not, the
      osl/file.hxx functionality underlying fileaccess::TaskManager::getUnqFromUrl
      knows how to handle them, so they will not take the forward-to-smb code branch.)
      
      (The corresponding #ifdef WIN code from 0b9ef81b
      has already been removed with 82034b04
      "tdf#119326 crash when adding "Windows Share" File resource".)
      
      (I came across that 2010 patch while looking into
      <https://bugs.documentfoundation.org/show_bug.cgi?id=107461> "Does not support
      'file://' scheme with actual hostname".  A next step would be to make the file
      UCP actually handle any file://<host>/... URLs that denote the local host.)
      
      Change-Id: I77242705dc4c6c1e9cb3a4f32253224ac6cb13cb
      Reviewed-on: https://gerrit.libreoffice.org/67372
      Tested-by: Jenkins
      Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      46c645bf
  22. 02 Şub, 2019 1 kayıt (commit)
  23. 31 Ock, 2019 1 kayıt (commit)
  24. 25 Ock, 2019 1 kayıt (commit)
  25. 23 Ock, 2019 1 kayıt (commit)
  26. 11 Ock, 2019 2 kayıt (commit)
  27. 08 Ara, 2018 4 kayıt (commit)
  28. 05 Ara, 2018 1 kayıt (commit)
  29. 03 Ara, 2018 1 kayıt (commit)
  30. 29 Kas, 2018 2 kayıt (commit)
  31. 27 Kas, 2018 1 kayıt (commit)