1. 16 May, 2019 1 kayıt (commit)
  2. 12 May, 2019 1 kayıt (commit)
  3. 10 May, 2019 1 kayıt (commit)
  4. 09 May, 2019 1 kayıt (commit)
  5. 30 Nis, 2019 1 kayıt (commit)
  6. 28 Nis, 2019 1 kayıt (commit)
  7. 25 Nis, 2019 1 kayıt (commit)
    • Stephan Bergmann's avatar
      Cut down on -pthread/-lpthread proliferation · b1141fa6
      Stephan Bergmann yazdı
      Building against libstdc++ effectively always requires -pthread anyway (as
      various standard C++ headers require it, see the comment added to
      solenv/gbuild/platform/unxgcc.mk), so many explicit uses of -pthread/-lpthread
      can be removed.
      Doing a (partial) test build on Linux with Clang -stdlib=libc++ suggests that
      libc++ indeed doesn't need -pthread as libstdc++ does.
      The remaining uses of -pthread/-lpthread are mostly in configure.ac for the
      various BSDs (which somebody else might want to clean up now), and related to
      external projects.  I tried to be careful to remove -pthread/-lpthread from
      makefiles only when C++ object files are involved (so -pthread will now be
      included on the link command line by default).
      Change-Id: I936e082839cb9a434bd273ce5a1f187a4245dfa1
      Reviewed-on: https://gerrit.libreoffice.org/71291
      Tested-by: Jenkins
      Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
  8. 18 Nis, 2019 1 kayıt (commit)
    • Stephan Bergmann's avatar
      Don't set locale env vars on macOS · 56bc0b1a
      Stephan Bergmann yazdı
      macosx_getLocale (via getProcessLocale, both sal/osl/unx/osxlocale.cxx) obtains
      from the system a locale string like "en-DE".  (Whether that is even a sane and
      recommended way to obtain the system locale on macOS I don't know; but lets
      leave it at that for now.)
      However, setting a locale env var (LANG, LC_ALL) to such a value causes a
      constructor call std::locale("") to throw a std::runtime_error
      "collate_byname<char>::collate_byname failed to construct for ", at least on
      macOS 10.14.4.  And libdivvun (which might be bundled with a LO extension) is
      known to be hit by that, see <https://github.com/divvun/libdivvun/issues/28>
      "locale("") gives 'collate_byname<char>::collate_byname failed to construct
      for ' on LO on mac".
      The code setting LC_ALL/LC_CTYPE/LANG was there ever since
      8737d183 "INTEGRATION:
      CWS geordi2q14: #111934#: merge CWS ooo111fix2", but for unclear reasons.  Lets
      assume that it had no purpose (any longer).
      Change-Id: I0b519ad567a713d61f662aa984791db1a91c708c
      Reviewed-on: https://gerrit.libreoffice.org/70918
      Tested-by: Jenkins
      Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
  9. 17 Nis, 2019 1 kayıt (commit)
    • Mike Kaganski's avatar
      tdf#124776: don't use SearchPathW to get full path of executable · c650217c
      Mike Kaganski yazdı
      ... use GetModuleFileNameW() for that.
      We call SetDllDirectoryW and SetSearchPathMode to improve security of
      the process, and exclude some paths (including current directory) from
      search when using API that looks for binaries whose names are not fully
      So the sequence is this:
      1. Program is started using relative executable path like
      2. sal_detail_initialize is called, which calls the two mentioned
         hardening functions;
      3. sal_detail_initialize calls osl_setCommandArgs, which in turn calls
      4. The latter uses SearchPathW with empty path and first program arg
         "instdir\program\soffice" to find fully qualified program path.
      That now naturally fails, because current path is not searched.
      But to find the process name, we need no search: we can simply use
      GetModuleFileNameW() with NULL passed as module handle. Let's use that.
      Note that we can't use _wpgmptr/_get_wpgmptr, because we don't use wide
      entry point like wmain.
      Change-Id: I7a0013a0505f7bdd38164b09b045bfade9686664
      Reviewed-on: https://gerrit.libreoffice.org/70844Reviewed-by: 's avatarMike Kaganski <mike.kaganski@collabora.com>
      Tested-by: 's avatarMike Kaganski <mike.kaganski@collabora.com>
  10. 15 Nis, 2019 1 kayıt (commit)
  11. 13 Nis, 2019 3 kayıt (commit)
  12. 05 Nis, 2019 1 kayıt (commit)
  13. 03 Nis, 2019 1 kayıt (commit)
  14. 31 Mar, 2019 2 kayıt (commit)
  15. 27 Mar, 2019 3 kayıt (commit)
  16. 19 Mar, 2019 1 kayıt (commit)
    • Caolán McNamara's avatar
      hang in crashtesting, would be nice to know what failed to exec here · 474786c9
      Caolán McNamara yazdı
       #0  0x00007f8dc781e4dc in __lll_lock_wait () from /lib64/libpthread.so.0
       #1  0x00007f8dc781a1b8 in _L_lock_820 () from /lib64/libpthread.so.0
       #2  0x00007f8dc781a088 in pthread_mutex_lock () from /lib64/libpthread.so.0
       #3  0x00007f8dc81d57d1 in lookupThreadId (hThread=140246229497600) at sal/osl/unx/thread.cxx:585
       #4  0x00007f8dc81d5aa4 in osl_getThreadIdentifier (Thread=0x0) at sal/osl/unx/thread.cxx:701
       #5  0x00007f8dc8173fa0 in osl::Thread::getCurrentIdentifier () at include/osl/thread.hxx:138
       #6  0x00007f8dc81736ba in sal_detail_log (level=SAL_DETAIL_LOG_LEVEL_WARN, area=0x7f8dc81f2e53 "sal.osl",
           where=0x7f8dc81f3130 "sal/osl/unx/process.cxx:238: ", message=0x5bd5b90 "Failed to exec: ENOENT", backtraceDepth=0)
           at sal/osl/all/log.cxx:279
       #7  0x00007f8dc816d166 in sal::detail::log (level=SAL_DETAIL_LOG_LEVEL_WARN, area=0x7f8dc81f2e53 "sal.osl",
           where=0x7f8dc81f3130 "sal/osl/unx/process.cxx:238: ", stream=..., backtraceDepth=0)
           at include/sal/log.hxx:50
       #8  0x00007f8dc81c1ddc in ChildStatusProc (pData=0x7f8d9e302a90) at sal/osl/unx/process.cxx:238
       #9  0x00007f8dc81d49a6 in osl_thread_start_Impl (pData=0x6757780) at sal/osl/unx/thread.cxx:235
       #10 0x00007f8dc7817f6b in start_thread () from /lib64/libpthread.so.0
       #11 0x00007f8dc7b227ed in clone () from /lib64/libc.so.6
      Change-Id: I611cf907f89c7a1d8cdc3a9c42f449e8daaa2614
      Reviewed-on: https://gerrit.libreoffice.org/69363
      Tested-by: Jenkins
      Reviewed-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      Tested-by: 's avatarCaolán McNamara <caolanm@redhat.com>
  17. 18 Mar, 2019 1 kayıt (commit)
    • Roland Baudin's avatar
      tdf#96038 Make shell function work with paths containing spaces · cf89d6db
      Roland Baudin yazdı
      Explanation of the patch: in the Windows version of LibreOffice,
      when calling the basic Shell(...) function (located in
      basic/source/runtime/methods.cxx), a function is_batch_file()
      is called in turn, to check if the program file path to execute
      is a batch or an executable.
      The function is_batch_file() is located in sal/osl/w32/procimpl.cxx
      and simply checks if the file extension is equal to bat (or cmd or
      This works as expected, except when the file path contains space
      characters. In that case, the file path is *quoted* before the
      call to is_batch_file() and for a batch file the file extension
      becomes bat" (note the quote) instead of bat, and thus the call
      to is_batch_file() wrongly returns false in that case.
      In this patch, the issue is fixed by changing the function
      get_file_extension() to make it return the correct extension
      (i.e. without the '"' character) when the file name is quoted.
      Change-Id: Ib6e74da87b23d64db925c17f8a26617f1a86a83d
      Reviewed-on: https://gerrit.libreoffice.org/69230
      Tested-by: Jenkins
      Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
  18. 12 Mar, 2019 1 kayıt (commit)
  19. 11 Mar, 2019 3 kayıt (commit)
  20. 08 Mar, 2019 1 kayıt (commit)
    • Noel Grandin's avatar
      new loplugin constvars · 5c234592
      Noel Grandin yazdı
      detect static variables that can be made const.
      Thanks to mike kaganski for suggesting this.
      Here I introduce a new plugin feature - using markers
      in nearby comments to disable the plugin for specific
      Some of this stuff was old debugging code. I removed the stuff
      that was older than 5 years.
      Change-Id: I6ec7742a7fdadf28fd128b592fcdf6da8257585c
      Reviewed-on: https://gerrit.libreoffice.org/68807
      Tested-by: Jenkins
      Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
  21. 06 Mar, 2019 1 kayıt (commit)
  22. 05 Mar, 2019 1 kayıt (commit)
  23. 04 Mar, 2019 3 kayıt (commit)
  24. 01 Mar, 2019 1 kayıt (commit)
  25. 26 Şub, 2019 2 kayıt (commit)
  26. 22 Şub, 2019 3 kayıt (commit)
  27. 21 Şub, 2019 1 kayıt (commit)
    • Stephan Bergmann's avatar
      loplugin:indentation (macOS) · 6333dcf6
      Stephan Bergmann yazdı
      * Some .m/.mm files that still contained tabs instead of spaces have been
        cleaned up with Emacs' untabify (and
        apple_remote/source/HIDRemoteControlDevice.m needed further manual adaptions):
      * Some of the changes predate 0626e66d "Avoid
        loplugin:indentation after preproc conditional inclusion lines" and would
        likely have no longer been flagged since.
      Change-Id: Ibf5faffa743c7f79b36109d9879eb79d63c8c40f
      Reviewed-on: https://gerrit.libreoffice.org/68090
      Tested-by: Jenkins
      Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
  28. 12 Şub, 2019 1 kayıt (commit)