1. 17 May, 2019 1 kayıt (commit)
  2. 24 Nis, 2019 2 kayıt (commit)
  3. 27 Mar, 2019 1 kayıt (commit)
  4. 25 Mar, 2019 1 kayıt (commit)
  5. 17 Mar, 2019 1 kayıt (commit)
  6. 12 Mar, 2019 1 kayıt (commit)
  7. 05 Mar, 2019 1 kayıt (commit)
  8. 04 Mar, 2019 1 kayıt (commit)
  9. 21 Şub, 2019 1 kayıt (commit)
    • Stephan Bergmann's avatar
      loplugin:indentation (macOS) · 6333dcf6
      Stephan Bergmann yazdı
      * Some .m/.mm files that still contained tabs instead of spaces have been
        cleaned up with Emacs' untabify (and
        apple_remote/source/HIDRemoteControlDevice.m needed further manual adaptions):
      
        apple_remote/source/GlobalKeyboardDevice.m
        apple_remote/source/HIDRemoteControlDevice.m
        apple_remote/source/KeyspanFrontRowControl.m
        apple_remote/source/RemoteControl.m
        vcl/osx/a11yrolehelper.mm
      
      * Some of the changes predate 0626e66d "Avoid
        loplugin:indentation after preproc conditional inclusion lines" and would
        likely have no longer been flagged since.
      
      Change-Id: Ibf5faffa743c7f79b36109d9879eb79d63c8c40f
      Reviewed-on: https://gerrit.libreoffice.org/68090
      Tested-by: Jenkins
      Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      6333dcf6
  10. 11 Şub, 2019 1 kayıt (commit)
  11. 22 Ock, 2019 1 kayıt (commit)
  12. 29 Kas, 2018 1 kayıt (commit)
  13. 25 Kas, 2018 1 kayıt (commit)
  14. 18 Kas, 2018 1 kayıt (commit)
  15. 26 Eki, 2018 1 kayıt (commit)
    • Stephan Bergmann's avatar
      Don't read past end of string in Guess ctor · 31a8d9c7
      Stephan Bergmann yazdı
      <https://ci.libreoffice.org//job/lo_ubsan/1082/>:
      > ==26422==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x604000accc72 at pc 0x2ae43e63f4b6 bp 0x2ae43e600510 sp 0x2ae43e600508
      > READ of size 1 at 0x604000accc72 thread T70 (cppu_threadpool)
      >     #0 0x2ae43e63f4b5 in Guess::Guess(char const*) /lingucomponent/source/languageguessing/guess.cxx:95:28
      >     #1 0x2ae43e667f2f in SimpleGuesser::GetManagedLanguages(char) /lingucomponent/source/languageguessing/simpleguesser.cxx:169:19
      >     #2 0x2ae43e668420 in SimpleGuesser::GetAvailableLanguages() /lingucomponent/source/languageguessing/simpleguesser.cxx:179:12
      >     #3 0x2ae43e64a18e in LangGuess_Impl::getEnabledLanguages() /lingucomponent/source/languageguessing/guesslang.cxx:229:24
      [...]
      > 0x604000accc72 is located 0 bytes to the right of 34-byte region [0x604000accc50,0x604000accc72)
      > allocated by thread T70 (cppu_threadpool) here:
      [...]
      >     #7 0x2ae43e65350a in std::string::operator+=(char const*) /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/bits/basic_string.h:3355:16
      >     #8 0x2ae43e667e6e in SimpleGuesser::GetManagedLanguages(char) /lingucomponent/source/languageguessing/simpleguesser.cxx:168:21
      >     #9 0x2ae43e668420 in SimpleGuesser::GetAvailableLanguages() /lingucomponent/source/languageguessing/simpleguesser.cxx:179:12
      >     #10 0x2ae43e64a18e in LangGuess_Impl::getEnabledLanguages() /lingucomponent/source/languageguessing/guesslang.cxx:229:24
      [...]
      
      shows, during UITest_librelogo, the Guess ctor making wrong assumptions about
      the structure of guess_str and skipping over the terminating NUL.  Locally I
      could see that while most inputs do have the expected syntax of starting with
      "[" and containing two "-", one input is indeed just "[haw-utf8" without a
      second "-".
      
      I don't know where the strings passed into the Guess ctor in the two places in
      lingucomponent/source/languageguessing/simpleguesser.cxx ultimately come from,
      and what their guaranteed syntax and their semantics is.  So from the existing
      code and the non--well-formed "[haw-utf8" sample (where the second segment shall
      apparently designate an encoding, not a country), construct rules how to
      robustly parse any input into potential language/country/encoding parts.  (What
      is obvious from the call sites is that for one each input will start with "[",
      and for another the item to parse need neither be "]"- nor NUL-terminated.)
      
      (Guess::encoding_str and the local enc variable have effectively been unused
      ever since the code's introduction in 07628119
      "INTEGRATION: CWS languageguessing".  Guess::encoding_str, but not the local
      enc variable, got later removed with b275246c
      "loplugin:unusedfields in formula..registry".)
      
      Change-Id: Icbedc05ed5b119ee4efbc3118cc17076a4d80c74
      Reviewed-on: https://gerrit.libreoffice.org/62390
      Tested-by: Jenkins
      Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      31a8d9c7
  16. 24 Eki, 2018 1 kayıt (commit)
  17. 23 Eki, 2018 1 kayıt (commit)
  18. 19 Eki, 2018 1 kayıt (commit)
  19. 09 Eki, 2018 1 kayıt (commit)
  20. 18 Eyl, 2018 1 kayıt (commit)
  21. 17 Eyl, 2018 1 kayıt (commit)
    • Stephan Bergmann's avatar
      New loplugin:external · 206b5b26
      Stephan Bergmann yazdı
      ...warning about (for now only) functions and variables with external linkage
      that likely don't need it.
      
      The problems with moving entities into unnamed namespacs and breaking ADL
      (as alluded to in comments in compilerplugins/clang/external.cxx) are
      illustrated by the fact that while
      
        struct S1 { int f() { return 0; } };
        int f(S1 s) { return s.f(); }
        namespace N {
          struct S2: S1 { int f() { return 1; } };
          int f(S2 s) { return s.f(); }
        }
        int main() { return f(N::S2()); }
      
      returns 1, both moving just the struct S2 into an nunnamed namespace,
      
        struct S1 { int f() { return 0; } };
        int f(S1 s) { return s.f(); }
        namespace N {
          namespace { struct S2: S1 { int f() { return 1; } }; }
          int f(S2 s) { return s.f(); }
        }
        int main() { return f(N::S2()); }
      
      as well as moving just the function f overload into an unnamed namespace,
      
        struct S1 { int f() { return 0; } };
        int f(S1 s) { return s.f(); }
        namespace N {
          struct S2: S1 { int f() { return 1; } };
          namespace { int f(S2 s) { return s.f(); } }
        }
        int main() { return f(N::S2()); }
      
      would each change the program to return 0 instead.
      
      Change-Id: I4d09f7ac5e8f9bcd6e6bde4712608444b642265c
      Reviewed-on: https://gerrit.libreoffice.org/60539
      Tested-by: Jenkins
      Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      206b5b26
  22. 10 Eyl, 2018 1 kayıt (commit)
  23. 06 Eyl, 2018 1 kayıt (commit)
  24. 30 Tem, 2018 1 kayıt (commit)
    • Gabor Kelemen's avatar
      Add missing sal/log.hxx headers · c6e5d551
      Gabor Kelemen yazdı
      rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it.
      This is a continuation of commit 6ff2d84a to be able to remove those unneeded includes.
      
      This commit adds missing headers to every file found by:
      grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG')
      to directories from l10ntools to reportdesign
      
      Change-Id: Ia2dc93dd848c2dc0b6a8cb6e19849c614ec55198
      Reviewed-on: https://gerrit.libreoffice.org/58205
      Tested-by: Jenkins
      Reviewed-by: 's avatarMiklos Vajna <vmiklos@collabora.co.uk>
      c6e5d551
  25. 26 Tem, 2018 1 kayıt (commit)
  26. 10 Tem, 2018 1 kayıt (commit)
  27. 18 May, 2018 1 kayıt (commit)
  28. 17 May, 2018 1 kayıt (commit)
  29. 12 May, 2018 1 kayıt (commit)
  30. 07 May, 2018 1 kayıt (commit)
    • Noel Grandin's avatar
      configure option to disable libnumbertext · 24d59c9e
      Noel Grandin yazdı
      Because we get a crash in CppunitTest_sw_odfexport when compiling with
      clang >= 6.0.0
      
      Also had to fix the ENABLE_LIBNUMBERTEXT being propogated, and the
      way the code checked it.
      
      Change-Id: I68e4a0078016d176f478ca4c1110fc296b6ca921
      24d59c9e
  31. 04 May, 2018 1 kayıt (commit)
    • Rene Engelhard's avatar
      set -DENABLE_LIBNJUMBERTEXT after pkg-config · 672501c9
      Rene Engelhard yazdı
      so that we don't "loose" the pkg-config --cflags info. That also makes the
       #ifdef in lingucomponent/source/numbertext/numbertext.cxx not needed anymore
      
      Change-Id: Ia5771859a4a181f1a8a450d9ad4130b1e53abf8e
      672501c9
  32. 03 May, 2018 2 kayıt (commit)
  33. 19 Mar, 2018 1 kayıt (commit)
  34. 17 Şub, 2018 3 kayıt (commit)
  35. 05 Şub, 2018 1 kayıt (commit)
  36. 27 Ock, 2018 1 kayıt (commit)