Skip to content

C
core
Dal (branch)/etiket değiştir
  1. 17 Eyl, 2018 1 kayıt (commit)
    • Stephan Bergmann's avatar
      New loplugin:external · 206b5b26
      Stephan Bergmann yazdı 
      ...warning about (for now only) functions and variables with external linkage
that likely don't need it.

The problems with moving entities into unnamed namespacs and breaking ADL
(as alluded to in comments in compilerplugins/clang/external.cxx) are
illustrated by the fact that while

  struct S1 { int f() { return 0; } };
  int f(S1 s) { return s.f(); }
  namespace N {
    struct S2: S1 { int f() { return 1; } };
    int f(S2 s) { return s.f(); }
  }
  int main() { return f(N::S2()); }

returns 1, both moving just the struct S2 into an nunnamed namespace,

  struct S1 { int f() { return 0; } };
  int f(S1 s) { return s.f(); }
  namespace N {
    namespace { struct S2: S1 { int f() { return 1; } }; }
    int f(S2 s) { return s.f(); }
  }
  int main() { return f(N::S2()); }

as well as moving just the function f overload into an unnamed namespace,

  struct S1 { int f() { return 0; } };
  int f(S1 s) { return s.f(); }
  namespace N {
    struct S2: S1 { int f() { return 1; } };
    namespace { int f(S2 s) { return s.f(); } }
  }
  int main() { return f(N::S2()); }

would each change the program to return 0 instead.

Change-Id: I4d09f7ac5e8f9bcd6e6bde4712608444b642265c
Reviewed-on: https://gerrit.libreoffice.org/60539
Tested-by: Jenkins
Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      206b5b26
  3. 16 Tem, 2018 1 kayıt (commit)
  5. 15 Ock, 2018 1 kayıt (commit)
  7. 12 Ock, 2018 1 kayıt (commit)
  9. 19 Ara, 2017 1 kayıt (commit)
  11. 13 Ara, 2017 1 kayıt (commit)
  13. 07 Ara, 2017 1 kayıt (commit)
  15. 20 Kas, 2017 1 kayıt (commit)
  17. 17 Kas, 2017 1 kayıt (commit)
  19. 16 Kas, 2017 1 kayıt (commit)
  21. 20 Nis, 2017 1 kayıt (commit)
  23. 13 Nis, 2017 1 kayıt (commit)
  25. 31 Mar, 2017 1 kayıt (commit)
  27. 22 Mar, 2017 1 kayıt (commit)
  29. 08 Şub, 2017 1 kayıt (commit)
  31. 14 Ock, 2017 1 kayıt (commit)
  33. 02 Kas, 2016 1 kayıt (commit)
  35. 25 Eyl, 2016 1 kayıt (commit)
  37. 20 Eyl, 2016 2 kayıt (commit)
  39. 15 Şub, 2016 1 kayıt (commit)
  41. 05 Kas, 2015 1 kayıt (commit)
  43. 28 Eki, 2015 1 kayıt (commit)
  45. 20 Eki, 2015 1 kayıt (commit)
  47. 18 Eyl, 2015 1 kayıt (commit)
  49. 21 Agu, 2015 1 kayıt (commit)
  51. 12 Agu, 2015 1 kayıt (commit)
  53. 22 Nis, 2015 1 kayıt (commit)
    • Stephan Bergmann's avatar
      Various #include <sal/log.hxx> fixups · 6ff2d84a
      Stephan Bergmann yazdı 
      rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx>
(and don't make use of it themselves), but many other files happen to depend on
it.  Cleaned up some, but something like

  grep -FwL sal/log.hxx $(git grep -Elw \
    'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF') -- \*.cxx)

shows lots more files that potentially need fixing before the include can be
removed from rtl/string.hxx and rtl/ustring.hxx.

Change-Id: Ibf033363e83d37851776f392dc0b077381cd8b90
      6ff2d84a
  55. 19 Ara, 2014 1 kayıt (commit)
  57. 18 Şub, 2014 1 kayıt (commit)
  59. 22 Ock, 2014 1 kayıt (commit)
  61. 21 Ock, 2014 1 kayıt (commit)
  63. 20 Ock, 2014 2 kayıt (commit)
  65. 14 Kas, 2013 1 kayıt (commit)
  67. 21 Eki, 2013 2 kayıt (commit)
  69. 09 Agu, 2013 1 kayıt (commit)
  71. 29 Tem, 2013 1 kayıt (commit)
    • Takeshi Abe's avatar
      Mark as const · 57931a7c
      Takeshi Abe yazdı 
      Change-Id: Ib78b25641ae20a3eb23545649f08b963e34c74ff
      57931a7c
  73. 03 Haz, 2013 1 kayıt (commit)
    • Mark Wielaard's avatar
      Fix icu version checks. · addc7916
      Mark Wielaard yazdı 
      commit 30c303 "Make charmap.cxx compile with icu >= 4.4." was incomplete
and had wrong version checks. After ICU 4.8 (4.8.1.1) the next version
of ICU was 49 (49.1) so U_ICU_VERSION_MAJOR_NUM contains two digets (49),
earlier that it was just one digit (4). The correct header to include to
do version checks is unicode/uversion.h. USCRIPT_MANDAEAN is the old
alias of USCRIPT_MANDAIC (same numeric value). U_JG_FARSI_YEH is only
available since ICU 4.4. Note that on older icu versions (4.2.1) the
200B (ZWSP) Zero Width Space breakiterator testcase fails (others
succeed).

Change-Id: If73c1402239a28546077437e9382f0bd38642bad
Reviewed-on: https://gerrit.libreoffice.org/4139Reviewed-by: 's avatarLuboš Luňák <l.lunak@suse.cz>
Tested-by: 's avatarLuboš Luňák <l.lunak@suse.cz>
      addc7916