- 13 May, 2019 1 kayıt (commit)
-
-
Noel Grandin yazdı
By creating deleted methods for the wrong calls. Avoids the compiler needing to construct a temporary Change-Id: I3b8c648d6bb22d22827bf74f21ea5a2a17fc0f6a Reviewed-on: https://gerrit.libreoffice.org/72103 Tested-by: Jenkins Reviewed-by:
Noel Grandin <noel.grandin@collabora.co.uk>
-
- 04 May, 2019 1 kayıt (commit)
-
-
Andrea Gelmini yazdı
Change-Id: Id7303279e86f5c5303bfe32bc843c59a9d7e2813 Reviewed-on: https://gerrit.libreoffice.org/71778 Tested-by: Jenkins Reviewed-by:
Julien Nabet <serval2412@yahoo.fr>
-
- 27 Mar, 2019 1 kayıt (commit)
-
-
Gabor Kelemen yazdı
Found with: run-clang-tidy-7 -checks=-*,misc-unused-using-decls Change-Id: I50f6dfa881ac4e752668e762ade0943aaf28ab96 Reviewed-on: https://gerrit.libreoffice.org/69601 Tested-by: Jenkins Reviewed-by:
Miklos Vajna <vmiklos@collabora.com>
-
- 12 Mar, 2019 1 kayıt (commit)
-
-
Gabor Kelemen yazdı
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I02f75be483529ba1f7a6e460e34c4752b4265221 Reviewed-on: https://gerrit.libreoffice.org/68893 Tested-by: Jenkins Reviewed-by:
Miklos Vajna <vmiklos@collabora.com>
-
- 21 Kas, 2018 1 kayıt (commit)
-
-
Noel Grandin yazdı
check for calls to constructors, and extend the list of types we check for unnecessary temporary creation Change-Id: Ia2c1f202b41ed6866779fff5343c821128033eec Reviewed-on: https://gerrit.libreoffice.org/63472 Tested-by: Jenkins Reviewed-by:
Noel Grandin <noel.grandin@collabora.co.uk>
-
- 17 Eki, 2018 1 kayıt (commit)
-
-
Noel Grandin yazdı
Change-Id: I21cf6bafab6e865b90b29caa73183a8e00b538d1 Reviewed-on: https://gerrit.libreoffice.org/61865 Tested-by: Jenkins Reviewed-by:
Noel Grandin <noel.grandin@collabora.co.uk>
-
- 15 Nis, 2018 1 kayıt (commit)
-
-
Jochen Nitschke yazdı
and fix the fallout Change-Id: I5d0c2040f57a3ac354a7e277592da31d09a5f359 Reviewed-on: https://gerrit.libreoffice.org/52894Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Jochen Nitschke <j.nitschke+logerrit@ok.de>
-
- 03 Nis, 2018 1 kayıt (commit)
-
-
Noel Grandin yazdı
and update sallogareas plugin to enforce this Change-Id: Id0782c8a1f619372e10d931aec3c6a4743a4c86a Reviewed-on: https://gerrit.libreoffice.org/52249Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Noel Grandin <noel.grandin@collabora.co.uk>
-
- 14 Ara, 2017 1 kayıt (commit)
-
-
Stephan Bergmann yazdı
The only effect SAL_CALL effectively has on LO-internal code is to change non- static member functions from __thiscall to __cdecl in MSVC (where all other functions are __cdecl by default, anyway). (For 3rd-party code, it could be argued that SAL_CALL is useful on function declarations in the URE stable interface other than non-static member functions, too, in case 3rd-party code uses a compiler switch to change the default calling convention to something other than __cdecl. But loplugin:salcall exempts the URE stable interface, anyway.) One could argue that SAL_CALL, even if today it effectively only affects non- static member functions in MSVC, could be extended in the future to affect more functions on more platforms. However, the current code would already not support that. For example, 3af50058 "loplugin:salcall fix functions" changed FrameControl_createInstance in UnoControls/source/base/registercontrols.cxx to no longer be SAL_CALL, even though its address (in ctl_component_getFacrory, in the same file) is passed to cppuhelper::createSingleFactory as an argument of type cppu::ComponentInstantiation, which is a pointer to SAL_CALL function. Change-Id: I3acbf7314a3d7868ed70e35bb5c47bc11a0b7ff6 Reviewed-on: https://gerrit.libreoffice.org/46436Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Stephan Bergmann <sbergman@redhat.com>
-
- 11 Ara, 2017 1 kayıt (commit)
-
-
Noel Grandin yazdı
since cdecl is the default calling convention on Windows for such functions, the annotation is redundant. Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d Reviewed-on: https://gerrit.libreoffice.org/46164Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Noel Grandin <noel.grandin@collabora.co.uk>
-
- 23 Eki, 2017 1 kayıt (commit)
-
-
Stephan Bergmann yazdı
Change-Id: I15aee966012612033ab7e2ee03ac1a553802f540
-
- 26 Tem, 2017 1 kayıt (commit)
-
-
Noel Grandin yazdı
Change-Id: I21e538b8e9c7a5f0fb233019efac37a3555e3c93 Reviewed-on: https://gerrit.libreoffice.org/40438Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Noel Grandin <noel.grandin@collabora.co.uk>
-
- 24 Tem, 2017 1 kayıt (commit)
-
-
Noel Grandin yazdı
which lead to a whole bunch of dead code in vcl/.../i18n_status.cxx Change-Id: Id8eeadeb9cbc6107e1a0dac5801ce20b2b9ae6dc Reviewed-on: https://gerrit.libreoffice.org/40355Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Noel Grandin <noel.grandin@collabora.co.uk>
-
- 21 Tem, 2017 1 kayıt (commit)
-
-
Caolán McNamara yazdı
* all .ui files go from <interface> to <interface domain="MODULE"> e.g. vcl * all .src files go away and the english source strings folded into the .hrc as NC_("context", "source string") * ResMgr is dropped in favour of std::locale imbued by boost::locale::generator pointed at matching MODULE .mo files * UIConfig translations are folded into the module .mo, so e.g. UIConfig_cui goes from l10n target to normal one, so the res/lang.zips of UI files go away * translation via Translation::get(hrc-define-key, imbued-std::locale) * python can now be translated with its inbuilt gettext support (we keep the name strings.hrc there to keep finding the .hrc file uniform) so magic numbers can go away there * java and starbasic components can be translated via the pre-existing css.resource.StringResourceWithLocation mechanism * en-US res files go away, their strings are now the .hrc keys in the source code * remaining .res files are replaced by .mo files * in .res/.ui-lang-zip files, the old scheme missing translations of strings results in inserting the english original so something can be found, now the standard fallback of using the english original from the source key is used, so partial translations shrink dramatically in size * extract .hrc strings with hrcex which backs onto xgettext -C --add-comments --keyword=NC_:1c,2 --from-code=UTF-8 --no-wrap * extract .ui strings with uiex which backs onto xgettext --add-comments --no-wrap * qtz for gettext translations is generated at runtime as ascii-ified crc32 of content + "|" + msgid * [API CHANGE] remove deprecated binary .res resouce loader related uno apis com::sun::star::resource::OfficeResourceLoader com::sun::star::resource::XResourceBundleLoader com::sun::star::resource::XResourceBundle when translating strings via uno apis com.sun.star.resource.StringResourceWithLocation can continue to be used Change-Id: Ia2594a2672b7301d9c3421fdf31b6cfe7f3f8d0a
-
- 28 Nis, 2017 1 kayıt (commit)
-
-
Stephan Bergmann yazdı
Change-Id: I294909d2596283a3249cd77c03c8e5518fdf32fb
-
- 19 Nis, 2017 1 kayıt (commit)
-
-
Noel Grandin yazdı
Change-Id: I96e1bd4000f4ade6ccfac53c57653772b249df99 Reviewed-on: https://gerrit.libreoffice.org/36678Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Noel Grandin <noel.grandin@collabora.co.uk>
-
- 03 Mar, 2017 1 kayıt (commit)
-
-
Stephan Bergmann yazdı
...from function definitions occurring within class definitions. Done with a rewriting Clang plugin (to be pushed later). Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8 Reviewed-on: https://gerrit.libreoffice.org/34874Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Stephan Bergmann <sbergman@redhat.com>
-
- 17 Şub, 2017 1 kayıt (commit)
-
-
Tor Lillqvist yazdı
Change-Id: I3247894fe022dce7f0aa351bd85fefcd7c545dd4 Reviewed-on: https://gerrit.libreoffice.org/34377Reviewed-by:
Tor Lillqvist <tml@collabora.com> Tested-by:
Tor Lillqvist <tml@collabora.com>
-
- 06 Şub, 2017 1 kayıt (commit)
-
-
Stephan Bergmann yazdı
...and remove some unncessary using directives/declarations, in preparation of removing now-unnecessary #includes from cppumaker-generated files, post e57ca028 "Remove dynamic exception specifications". Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
-
- 28 Ock, 2017 1 kayıt (commit)
-
-
Noel Grandin yazdı
..calls when creating exceptions Change-Id: I3bc58a5aa4dc6f0508ecb88b3a843b96b8c7ebfe Reviewed-on: https://gerrit.libreoffice.org/33617Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Noel Grandin <noel.grandin@collabora.co.uk>
-
- 26 Ock, 2017 1 kayıt (commit)
-
-
Stephan Bergmann yazdı
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Stephan Bergmann <sbergman@redhat.com>
-
- 13 Eyl, 2016 1 kayıt (commit)
-
-
Stephan Bergmann yazdı
The issue of 362d4f0c "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
-
- 18 Agu, 2016 1 kayıt (commit)
-
-
Caolán McNamara yazdı
Change-Id: I3ffcfe1294a1cbb06aadd3a1a79e9259876e38cc
-
- 02 Haz, 2016 1 kayıt (commit)
-
-
Noel Grandin yazdı
Change-Id: Ieed5f4d9411478d2568b8e5f4bbe0782bd1d309d Reviewed-on: https://gerrit.libreoffice.org/25724Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Noel Grandin <noelgrandin@gmail.com>
-
- 20 Nis, 2016 1 kayıt (commit)
-
-
Stephan Bergmann yazdı
Change-Id: I5cd8fd979fd4caa3d7cde599096627bfdd0dec7e
-
- 18 Nis, 2016 2 kayıt (commit)
-
-
Stephan Bergmann yazdı
Change-Id: I2b0fe700057fea790e8b5d651770b27f0a553fbf
-
Jochen Nitschke yazdı
Searched source for using declarations. Checked if those symbols reappear in the source file, even in comments or dead code but not in #include statements. If they don't reappear, remove the declaration. Remove includes whose symbol got removed. Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0 Reviewed-on: https://gerrit.libreoffice.org/24148Reviewed-by:
Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by:
Noel Grandin <noelgrandin@gmail.com> Tested-by:
Noel Grandin <noelgrandin@gmail.com>
-
- 12 Nis, 2016 1 kayıt (commit)
-
-
Jochen Nitschke yazdı
Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Noel Grandin <noelgrandin@gmail.com>
-
- 08 Nis, 2016 1 kayıt (commit)
-
-
Jochen Nitschke yazdı
dbaccess, desktop and drawinglayer. Replace with C++11 delete copy-constructur and copy-assignment. Nothing special, only one unused include in dbaccess/source/filter/xml/xmlfilter.cxx. Change-Id: Iebabbc658215162450d4caf08d4fb2f116c456d9 Reviewed-on: https://gerrit.libreoffice.org/23918Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
David Tardon <dtardon@redhat.com>
-
- 31 Mar, 2016 1 kayıt (commit)
-
-
Noel Grandin yazdı
for with git grep -n 'for.*sizeof' Change-Id: I6211024385e03ac5eeeb38690d2c1c699e015c2f Reviewed-on: https://gerrit.libreoffice.org/23569Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Noel Grandin <noelgrandin@gmail.com>
-
- 25 Şub, 2016 1 kayıt (commit)
-
-
Noel Grandin yazdı
Change-Id: I5a2e4f6f6f0f353c75dff85e865608b12c2104f9
-
- 24 Ara, 2015 1 kayıt (commit)
-
-
Noel Grandin yazdı
Change-Id: I979592adb978c3757a1e54615021ee424a2e02bf Reviewed-on: https://gerrit.libreoffice.org/20892Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Noel Grandin <noelgrandin@gmail.com>
-
- 15 Kas, 2015 1 kayıt (commit)
-
-
Noel Grandin yazdı
replaced using: git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)' | xargs perl -0777 -pi -e "s/Sequence<\s*OUString\s*> (\w+)\(\s*1\s*\); .*\[0\] = (\S+);/Sequence<OUString> \1 { \2 };/g" Change-Id: I20ad0489da887a9712982531c3b127339bb8b3b9 Reviewed-on: https://gerrit.libreoffice.org/19969Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Noel Grandin <noelgrandin@gmail.com>
-
- 10 Kas, 2015 1 kayıt (commit)
-
-
Stephan Bergmann yazdı
Change-Id: I2bba104b1bff30910864e45b5b032533099742ff
-
- 30 Eki, 2015 1 kayıt (commit)
-
-
Noel Grandin yazdı
Change-Id: I3d45914e349a4268204af84b95b53ccce7b9d544
-
- 12 Eki, 2015 2 kayıt (commit)
-
-
Stephan Bergmann yazdı
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
-
Stephan Bergmann yazdı
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
-
- 17 Eyl, 2015 1 kayıt (commit)
-
-
Caolán McNamara yazdı
Change-Id: Idfbcfa1e5ba7bff92e98693c33c4b33a6beda08f
-
- 03 Agu, 2015 1 kayıt (commit)
-
-
Noel Grandin yazdı
Change-Id: I4fbdd3fb7d1e0ad4423148aaaed3a15aebb26d14
-
- 20 Tem, 2015 1 kayıt (commit)
-
-
Caolán McNamara yazdı
Change-Id: Ib9373a5a75eea998a86156ff742e7950369ddc88
-