Skip to content

C
core
Dal (branch)/etiket değiştir
  1. 10 May, 2019 1 kayıt (commit)
  3. 08 Ara, 2018 1 kayıt (commit)
  5. 02 Kas, 2018 1 kayıt (commit)
  7. 09 Eki, 2018 1 kayıt (commit)
  9. 17 Eyl, 2018 1 kayıt (commit)
    • Stephan Bergmann's avatar
      New loplugin:external · 206b5b26
      Stephan Bergmann yazdı 
      ...warning about (for now only) functions and variables with external linkage
that likely don't need it.

The problems with moving entities into unnamed namespacs and breaking ADL
(as alluded to in comments in compilerplugins/clang/external.cxx) are
illustrated by the fact that while

  struct S1 { int f() { return 0; } };
  int f(S1 s) { return s.f(); }
  namespace N {
    struct S2: S1 { int f() { return 1; } };
    int f(S2 s) { return s.f(); }
  }
  int main() { return f(N::S2()); }

returns 1, both moving just the struct S2 into an nunnamed namespace,

  struct S1 { int f() { return 0; } };
  int f(S1 s) { return s.f(); }
  namespace N {
    namespace { struct S2: S1 { int f() { return 1; } }; }
    int f(S2 s) { return s.f(); }
  }
  int main() { return f(N::S2()); }

as well as moving just the function f overload into an unnamed namespace,

  struct S1 { int f() { return 0; } };
  int f(S1 s) { return s.f(); }
  namespace N {
    struct S2: S1 { int f() { return 1; } };
    namespace { int f(S2 s) { return s.f(); } }
  }
  int main() { return f(N::S2()); }

would each change the program to return 0 instead.

Change-Id: I4d09f7ac5e8f9bcd6e6bde4712608444b642265c
Reviewed-on: https://gerrit.libreoffice.org/60539
Tested-by: Jenkins
Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      206b5b26
  11. 05 Eyl, 2018 1 kayıt (commit)
  13. 29 Agu, 2018 1 kayıt (commit)
  15. 27 Tem, 2018 1 kayıt (commit)
  17. 09 Tem, 2018 1 kayıt (commit)
    • Gabor Kelemen's avatar
      Add missing sal/log.hxx headers · 7af90cc9
      Gabor Kelemen yazdı 
      rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx>
(and don't make use of it themselves), but many other files happen to depend on it.
This is a continuation of commit 6ff2d84a
to be able to remove those unneeded includes.

This commit adds missing headers to every file found by:
grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG')
to directories from a* to configmgr

Change-Id: I6ea1a7f992b1f835f5bac7a725e1135abee3f85a
Reviewed-on: https://gerrit.libreoffice.org/57170
Tested-by: Jenkins
Reviewed-by: 's avatarMiklos Vajna <vmiklos@collabora.co.uk>
      7af90cc9
  19. 16 Nis, 2018 1 kayıt (commit)
  21. 25 Ock, 2018 1 kayıt (commit)
  23. 11 Ara, 2017 1 kayıt (commit)
  25. 23 Eki, 2017 2 kayıt (commit)
  27. 28 Agu, 2017 1 kayıt (commit)
  29. 13 Tem, 2017 1 kayıt (commit)
  31. 23 May, 2017 1 kayıt (commit)
  33. 03 Mar, 2017 1 kayıt (commit)
  35. 15 Şub, 2017 1 kayıt (commit)
  37. 10 Şub, 2017 1 kayıt (commit)
    • Stephan Bergmann's avatar
      Remove MinGW support · 8646ab97
      Stephan Bergmann yazdı 
      In OOo times, there'd originally been efforts to allow building on Windows with
MinGW.  Later, in LO times, this has been shifted to an attempt of cross-
compiling for Windows on Linux.  That attempt can be considered abandoned, and
the relevant code rotting.

Due to this heritage, there are now three kinds of MinGW-specific code in LO:

* Code from the original OOo native Windows effort that is no longer relevant
  for the LO cross-compilation effort, but has never been removed properly.

* Code from the original OOo native Windows effort that is re-purposed for the
  LO cross-compilation effort.

* Code that has been added specifially for the LO cross-compilation effort.

All three kinds of code are removed.

(An unrelated, remaining use of MinGW is for --enable-build-unowinreg, utilizing
--with-mingw-cross-compiler, MINGWCXX, and MINGWSTRIP.)

Change-Id: I49daad8669b4cbe49fa923050c4a4a6ff7dda568
Reviewed-on: https://gerrit.libreoffice.org/34127Tested-by: 's avatarJenkins <ci@libreoffice.org>
Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      8646ab97
  39. 13 Eyl, 2016 1 kayıt (commit)
    • Stephan Bergmann's avatar
      loplugin:override: No more need for the "MSVC dtor override" workaround · 91dd2db1
      Stephan Bergmann yazdı 
      The issue of 362d4f0c "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.

(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to

  OOO_DLLPUBLIC_CHARTTOOLS    virtual ~CloseableLifeTimeManager();

in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro.  Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)

Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
      91dd2db1
  41. 11 Tem, 2016 1 kayıt (commit)
  43. 10 May, 2016 1 kayıt (commit)
    • Stephan Bergmann's avatar
      Replace fallthrough comments with new SAL_FALLTHROUGH macro · 14cd5182
      Stephan Bergmann yazdı 
      ...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in
preparation of enabling -Wimplicit-fallthrough.  (This is only relevant for
C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.)

Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but
that would require adding back in dependencies on boost_headers to many
libraries where we carefully removed any remaining Boost dependencies only
recently.  (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its
future evolution will not have any impact on the stable URE interface.)  C++17
will have a proper [[fallthroug]], eventually removing the need for a macro
altogether.

Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
      14cd5182
  45. 20 Nis, 2016 1 kayıt (commit)
  47. 04 Nis, 2016 1 kayıt (commit)
  49. 10 Mar, 2016 1 kayıt (commit)
  51. 09 Şub, 2016 1 kayıt (commit)
  53. 01 Şub, 2016 2 kayıt (commit)
  55. 17 Kas, 2015 1 kayıt (commit)
  57. 10 Kas, 2015 1 kayıt (commit)
  59. 12 Eki, 2015 2 kayıt (commit)
  61. 28 Eyl, 2015 1 kayıt (commit)
  63. 17 Agu, 2015 1 kayıt (commit)
  65. 16 Tem, 2015 1 kayıt (commit)
  67. 02 Tem, 2015 1 kayıt (commit)
  69. 15 Haz, 2015 1 kayıt (commit)
  71. 02 Haz, 2015 1 kayıt (commit)
  73. 15 May, 2015 1 kayıt (commit)