This reverts commit 1cb1cc30.

Setup.ico contains of three different image sizes. Furthermore, the design is not applied to the other setup icons (partial, complete). And please discuss proposal first.

Change-Id: I3cc9ad3424f85c812ae89939cabaddf38e3c41b3
Reviewed-on: https://gerrit.libreoffice.org/32751Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>

Project: help  fce5517eb405ef8288d4d421259716d99b817eb1

Fix bookmarks on DB Wizard 'Text file connection' page

Change-Id: I6c2881bf4e33cc9f50417c685bb7c74897ac7bb3
Reviewed-on: https://gerrit.libreoffice.org/32835Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>

Project: help  6d0450c494e5d21fd79940ee9863353ecd70db50

Fix bookmarks on DB Wizard 'Spreadsheet connection' page

Sync the page title with the wizard page name too

Change-Id: I6cdbdea2325b914e61d8ab744cb489d14867d6bc
Reviewed-on: https://gerrit.libreoffice.org/32834Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>

Project: help  91536d63eed45ee12789d22b15cbfaf79135789f

Sync DB Wizard 'Authentication' page title with the UI

Change-Id: I8d00541d0d1a73cc174396a4b1c7d8a0b3c01bd6
Reviewed-on: https://gerrit.libreoffice.org/32833Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>

Project: help  fe71a0de7fa240513f58a6993d02016f1774728f

Fix bookmarks and ahelps on DB Wizard JDBC page

Change-Id: Id50171d63cadec967d31100dca940902f2a40029
Reviewed-on: https://gerrit.libreoffice.org/32832Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>

Project: help  9ce74cec5a7f95ac442c9caa22aa16839d807581

Move bookmarks and ahelps to DB Wizard Auth page

...from the ADO connection page.
Also document the 'Test Connection' button a bit.

Change-Id: I7d5b13baeb8ffb348ffea1c9a991b4498e8f5cc9
Reviewed-on: https://gerrit.libreoffice.org/32831Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>

Project: help  5e4b205a3259f265e6dddc578d16793c1a733e9e

tdf#105070 'Compare Document' menu item has moved

From 'Edit' menu to 'Edit - Track Changes' submenu

Change-Id: I02fd05e97f989369bcee5c5ab26fdd78121c2282
Reviewed-on: https://gerrit.libreoffice.org/32836Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>

Alignment fixed, 'start at' moved under number

Change-Id: Ib97243e12529bb5e667dea8224b579b91ce60a53
Reviewed-on: https://gerrit.libreoffice.org/32820Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>

Project: help  74ab5d9e81c1406229ec3075afadf2b03888f269

Do not report .pyc files in to-wiki as changed

Change-Id: Ifb052ae5b55836995bc78cab37b95476f9770a6a
Reviewed-on: https://gerrit.libreoffice.org/32837Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: I18e2094c1d28b6e0d860e474e33bbf8642ba78fd
Reviewed-on: https://gerrit.libreoffice.org/32845Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: Ic4869b58914079662b09c8ef406b4f65d21b5270
Reviewed-on: https://gerrit.libreoffice.org/32839Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Id9a37afa38a2456cb022945240586081771a5436
Reviewed-on: https://gerrit.libreoffice.org/32842Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Project: help  a4da1578e80d79e205a78cdee9e3c1dd7df82e42

Review of help page for protection in Writer

Change-Id: I7b2c15479faa585a643a33defb0484eb947b1afa
Reviewed-on: https://gerrit.libreoffice.org/32846Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br>
Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>

Change-Id: If706e57343a9c81b7d31d8e018450a151d38ad49

Change-Id: Ic1902a4160589cb9937f938f4a98484f0be487bc

Change-Id: I23d65c01bfd1ff083cda0f48c5db1636f1c6095b
Reviewed-on: https://gerrit.libreoffice.org/32821Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

...as reported e.g. during CppunitTest_sw_odfimport:

> /workdir/UnpackedTarball/boost/boost/circular_buffer/debug.hpp:37:17: runtime error: null pointer passed as argument 1, which is declared to never be null
> /usr/include/string.h:62:62: note: nonnull attribute specified here
>     #0 0x2b24bc0e6389 in void boost::cb_details::do_fill_uninitialized_memory<SwFrameFormat*>(SwFrameFormat**, unsigned long) /workdir/UnpackedTarball/boost/boost/circular_buffer/debug.hpp:37:5
>     #1 0x2b24bc0e5b48 in boost::circular_buffer<SwFrameFormat*, std::allocator<SwFrameFormat*> >::allocate(unsigned long) /workdir/UnpackedTarball/boost/boost/circular_buffer/base.hpp:2375:9
>     #2 0x2b24bc0e545a in boost::circular_buffer<SwFrameFormat*, std::allocator<SwFrameFormat*> >::initialize_buffer(unsigned long) /workdir/UnpackedTarball/boost/boost/circular_buffer/base.hpp:2482:18
>     #3 0x2b24bc0cfaa7 in boost::circular_buffer<SwFrameFormat*, std::allocator<SwFrameFormat*> >::circular_buffer(unsigned long, std::allocator<SwFrameFormat*> const&) /workdir/UnpackedTarball/boost/boost/circular_buffer/base.hpp:1036:9
>     #4 0x2b24bc068cd7 in AppendAllObjs(SwFrameFormats const*, SwFrame const*) /sw/source/core/layout/frmtool.cxx:1100:44
...

Change-Id: Id96a6127990548ab0ae2e8a02b7bec2d61094c37

...when the value is outside the range of type 'unsigned char'; hopefully it'll
always be in the range of type 'long long'

Change-Id: I8ec38727648bea20875cb488fe143b4759812b5a

Change-Id: If9fe62643ad33c2d832b146a5dc7248dbba32f1a

Change-Id: I10c31aa9c773649c99b52c2d34cb648a37bf42ac

Change-Id: I30dd797921420a4009455841052f5c5436f4a93b

Change-Id: I448d1f2f292ce379cbce0083dc2c5230a7f6ce1b

Change-Id: I1c71cdbd4cc36bd048277d9b52a7f74e709ca125

Change-Id: I1da621fa46de1ff0c268d10d46a7b5a8bd860623

Change-Id: I2db09096c2862801631c92df77001b50cc8270c5
Reviewed-on: https://gerrit.libreoffice.org/32830Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Layout dialog adds this column field by default, but it has
no actual meaning or functionality. It must be added because
of this broken logic here (adding a field only when its hidden?).
This 'Data' field must be related to OOXML format see
OOX_PT_DATALAYOUTFIELD, but might be deprecated actually.

Change-Id: I90f00ef6290b343f84e40e5c94fd0e29a328329b

Change-Id: I16aa622a526e52a0b9455cbf1eeea9991dbdd6b6
Reviewed-on: https://gerrit.libreoffice.org/32733Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: Icc592273d980c62e666a4c3b4e829d2bc35016cc
Reviewed-on: https://gerrit.libreoffice.org/32812Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: I072d8879d3af9bd59eb10871e96a67ebf1af76a6
Reviewed-on: https://gerrit.libreoffice.org/32811Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: Iaffbc03cd0c39f08d141eeae705568235902a6e4
Reviewed-on: https://gerrit.libreoffice.org/32737Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: Id588afe3c447ce938f91c51e084685493ba83fd5
Reviewed-on: https://gerrit.libreoffice.org/32813Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: I4a27412167beaddee55cdcae2724030bbc22ec04
Reviewed-on: https://gerrit.libreoffice.org/32800Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

This should also make sure we are getting it from the current font, which
the old, convoluted way does not seem to guarantee.

Change-Id: If0a4cf18e472b1489115eeb7b1b2bdbb5f13abb0
Reviewed-on: https://gerrit.libreoffice.org/32595Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>

Change-Id: Ie6123113e270e75e942716dda0ed4da71b2a2afc
Reviewed-on: https://gerrit.libreoffice.org/32824Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

And use std::unique_ptr not rtl::Reference.  This is not a UNO object
anyway...

Change-Id: If43da4f7e0f478b9ad8d62e5f43f04f035c31717
Reviewed-on: https://gerrit.libreoffice.org/32828Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>

Change-Id: I5f0c6130e5cf21f93bb1309f7bf148bd40b3821d
Reviewed-on: https://gerrit.libreoffice.org/32827Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>

This makes the code a bit easier to follow.

Change-Id: Ia55d963c97b33dd8462e6084adc4820856e126bf
Reviewed-on: https://gerrit.libreoffice.org/32825Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>

and block default move equivalents

Change-Id: Ib8a1050803446c2e099f66602fae0465bd8165cf

Change-Id: I1c4cff09a7c549e9a14886c1460a7e2c2c74f757

Change-Id: I7468fd9637421b8b854217c19969f94e9ab0cab4