Remove traces of Report Builder's former status as extension

Change-Id: I63730632933cbb1d6e655f70d222ffaaabd3fa08
Reviewed-on: https://gerrit.libreoffice.org/46361Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

dbaccess/inc/strings.hrc

@@ -349,7 +349,7 @@
 #define STR_WARNINGS_DURING_CONNECT                 NC_("STR_WARNINGS_DURING_CONNECT", "Warnings were encountered while connecting to the data source. Press \"$buttontext$\" to view them.")
 #define STR_NAMED_OBJECT_ALREADY_EXISTS             NC_("STR_NAMED_OBJECT_ALREADY_EXISTS", "The name '$#$' already exists.\nPlease enter another name." )
 // #i96130# use hard coded name
-#define RID_STR_EXTENSION_NOT_PRESENT               NC_("RID_STR_EXTENSION_NOT_PRESENT", "The report, \"$file$\", requires the Oracle Report Builder feature.")
+#define RID_STR_EXTENSION_NOT_PRESENT               NC_("RID_STR_EXTENSION_NOT_PRESENT", "The report, \"$file$\", requires the Report Builder feature.")
 
 #define STR_COULDNOTCREATE_DRIVERMANAGER            NC_("STR_COULDNOTCREATE_DRIVERMANAGER", "Cannot connect to the SDBC driver manager (#servicename#).")
 #define STR_NOREGISTEREDDRIVER                      NC_("STR_NOREGISTEREDDRIVER", "A driver is not registered for the URL #connurl#.")

dbaccess/source/ext/macromigration/migrationlog.cxx

@@ -316,7 +316,7 @@ namespace dbmm
                 break;
 
             case ERR_NEW_STYLE_REPORT:
-                pAsciiErrorDescription = "#doc# could not be processed, since you don't have the Oracle Report Builder (TM) extension installed.";
+                pAsciiErrorDescription = "#doc# could not be processed, since you don't have the Report Builder feature installed.";
                 aParameterNames.emplace_back("#doc#");
                 break;
 

officecfg/registry/data/org/openoffice/Office/ExtendedColorScheme.xcu

@@ -143,7 +143,7 @@
   <node oor:name="EntryNames">
     <node oor:name="SunReportBuilder" oor:op="replace">
       <prop oor:name="DisplayName">
-        <value xml:lang="en-US">Oracle Report Builder</value>
+        <value xml:lang="en-US">Report Builder</value>
       </prop>
       <node oor:name="Entries">
         <node oor:name="ReportHeader" oor:op="replace">

officecfg/registry/data/org/openoffice/Setup.xcu

@@ -769,7 +769,7 @@
           <value>GenericCategories</value>
         </prop>
         <prop oor:name="ooSetupFactoryUIName">
-          <value xml:lang="en-US">Base: Oracle Report Builder</value>
+          <value xml:lang="en-US">Base: Report Builder</value>
         </prop>
       </node>
     </node>

officecfg/registry/schema/org/openoffice/Office/ReportDesign.xcs

@@ -36,17 +36,11 @@
       <info>
         <desc>specifies extension settings for the report designer.</desc>
       </info>
-      <prop oor:name="DownloadURL" oor:type="xs:string">
-        <info>
-          <desc>Direct download URL to the Oracle(tm) Report Builder extension.</desc>
-        </info>
-        <value>http://extensions.go-oo.org</value>
-      </prop>
       <prop oor:name="Name" oor:type="xs:string">
         <info>
           <desc>Name of the extension.</desc>
         </info>
-        <value>Oracle(tm) Report Builder</value>
+        <value>Report Builder</value>
       </prop>
     </group>
     <group oor:name="UserData" oor:extensible="true">

reportbuilder/README

-Oracle report builder extension, from [http://extensions.services.openoffice.org/project/reportdesign].
+Report Builder, or "new style reports", replacing legacy reports (in reportdesign).
+Started as an extension called "Sun Report Builder" then "Oracle Report Builder"
+[http://extensions.services.openoffice.org/project/reportdesign],
+which got bundled with LibreOffice, then converted to an optionallly installable
+(but installed by default) part of LibreOffice proper.
+
+Uses the Pentaho Reporting Flow Engine of Pentaho BI [http://www.pentaho.com/].

reportbuilder/registry/data/org/openoffice/Setup.xcu

@@ -36,10 +36,9 @@
                     <value >GenericCategories</value>
                 </prop>
         <prop oor:name="ooSetupFactoryUIName">
-            <value >Base: Oracle Report Builder</value>
+            <value >Base: Report Builder</value>
         </prop>
             </node>
     </node>
   </node>
 </oor:component-data>
-

reportdesign/README

-Part of LibreOffice Base
+Legacy Reports for LibreOffice Base

wizards/com/sun/star/wizards/report/IReportDocument.java

@@ -26,7 +26,7 @@ import java.util.ArrayList;
 
 /**
  * New Interface which gives us the possibility to switch on the fly between the old
- * Wizard and the new Sun Report Builder Wizard, which use the same UI.
+ * Wizard and the new Report Builder Wizard, which use the same UI.
  */
 public interface IReportDocument
 {

wizards/com/sun/star/wizards/reportbuilder/ReportBuilderImplementation.java

@@ -58,7 +58,7 @@ import com.sun.star.wizards.ui.UIConsts;
 
 /**
  * This class use the IReportDocument Interface to communicate between the UI
- * and the ReportBuilderLayouter which communicates to the new Sun Report Builder.
+ * and the ReportBuilderLayouter which communicates to the new Report Builder.
  */
 @SuppressWarnings("ucd")
 public class ReportBuilderImplementation extends ReportImplementationHelper