Kaydet (Commit) fd56d5fd authored tarafından Noel Grandin's avatar Noel Grandin

loplugin:unusedfields improvemements

treat fields touched in operator== as not being important, which
finds some more stuff (but also adds some false+)

Change-Id: I3f5d504d7dec7945a917afbcd58c92df74f03645
Reviewed-on: https://gerrit.libreoffice.org/62020
Tested-by: Jenkins
Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
üst 76dd28af
......@@ -393,6 +393,11 @@ bool UnusedFields::TraverseCXXMethodDecl(CXXMethodDecl* cxxMethodDecl)
|| cxxMethodDecl->isMoveAssignmentOperator()
|| (cxxMethodDecl->getIdentifier() && (cxxMethodDecl->getName().startswith("Clone") || cxxMethodDecl->getName().startswith("clone"))))
insideMoveOrCopyOrCloneDeclParent = cxxMethodDecl->getParent();
// these are similar in that they tend to simply enumerate all the fields of an object without putting
// them to some useful purpose
auto op = cxxMethodDecl->getOverloadedOperator();
if (op == OO_EqualEqual || op == OO_ExclaimEqual)
insideMoveOrCopyOrCloneDeclParent = cxxMethodDecl->getParent();
}
insideFunctionDecl = cxxMethodDecl;
bool ret = RecursiveASTVisitor::TraverseCXXMethodDecl(cxxMethodDecl);
......@@ -405,19 +410,29 @@ bool UnusedFields::TraverseFunctionDecl(FunctionDecl* functionDecl)
{
auto copy1 = insideStreamOutputOperator;
auto copy2 = insideFunctionDecl;
auto copy3 = insideMoveOrCopyOrCloneDeclParent;
if (functionDecl->getLocation().isValid() && !ignoreLocation(functionDecl) && functionDecl->isThisDeclarationADefinition())
{
if (functionDecl->getOverloadedOperator() == OO_LessLess
auto op = functionDecl->getOverloadedOperator();
if (op == OO_LessLess
&& functionDecl->getNumParams() == 2)
{
QualType qt = functionDecl->getParamDecl(1)->getType();
insideStreamOutputOperator = qt.getNonReferenceType().getUnqualifiedType()->getAsCXXRecordDecl();
}
// these are similar in that they tend to simply enumerate all the fields of an object without putting
// them to some useful purpose
if (op == OO_EqualEqual || op == OO_ExclaimEqual)
{
QualType qt = functionDecl->getParamDecl(1)->getType();
insideMoveOrCopyOrCloneDeclParent = qt.getNonReferenceType().getUnqualifiedType()->getAsCXXRecordDecl();
}
}
insideFunctionDecl = functionDecl;
bool ret = RecursiveASTVisitor::TraverseFunctionDecl(functionDecl);
insideStreamOutputOperator = copy1;
insideFunctionDecl = copy2;
insideMoveOrCopyOrCloneDeclParent = copy3;
return ret;
}
......
......@@ -14,7 +14,7 @@ avmedia/source/vlc/wrapper/Types.hxx:47
libvlc_event_t u union (anonymous union at /media/noel/disk2/libo6/avmedia/source/vlc/wrapper/Types.hxx:41:5)
avmedia/source/vlc/wrapper/Types.hxx:53
libvlc_track_description_t psz_name char *
basegfx/source/polygon/b2dtrapezoid.cxx:201
basegfx/source/polygon/b2dtrapezoid.cxx:202
basegfx::trapezoidhelper::PointBlockAllocator maFirstStackBlock class basegfx::B2DPoint [32]
basic/qa/cppunit/basictest.hxx:27
MacroSnippet maDll class BasicDLL
......@@ -208,8 +208,6 @@ include/svl/ondemand.hxx:58
OnDemandLocaleDataWrapper aSysLocale class SvtSysLocale
include/svx/ClassificationDialog.hxx:59
svx::ClassificationDialog m_bPerParagraph const _Bool
include/svx/ClassificationDialog.hxx:63
svx::ClassificationDialog m_nInsertMarkings const sal_Int16
include/svx/itemwin.hxx:34
SvxLineBox aDelayTimer class Timer
include/vcl/font/Feature.hxx:102
......@@ -303,7 +301,7 @@ sal/qa/osl/process/osl_process.cxx:157
sal/textenc/textenc.cxx:406
(anonymous namespace)::FullTextEncodingData module_ osl::Module
sc/inc/column.hxx:128
ScColumn maCellsEvent sc::CellStoreEvent
ScColumn maCellsEvent const sc::CellStoreEvent
sc/inc/compiler.hxx:256
ScCompiler::AddInMap pODFF const char *
sc/inc/compiler.hxx:257
......@@ -311,7 +309,7 @@ sc/inc/compiler.hxx:257
sc/inc/compiler.hxx:259
ScCompiler::AddInMap pUpper const char *
sc/inc/formulalogger.hxx:42
sc::FormulaLogger maMessages std::vector<OUString>
sc::FormulaLogger maMessages const std::vector<OUString>
sc/inc/interpretercontext.hxx:32
ScInterpreterContext mrDoc const class ScDocument &
sc/inc/token.hxx:406
......@@ -319,9 +317,9 @@ sc/inc/token.hxx:406
sc/qa/unit/ucalc_column.cxx:104
aInputs aName const char *
sc/source/core/data/document.cxx:1244
(anonymous namespace)::BroadcastRecalcOnRefMoveHandler aSwitch sc::AutoCalcSwitch
(anonymous namespace)::BroadcastRecalcOnRefMoveHandler aSwitch const sc::AutoCalcSwitch
sc/source/core/data/document.cxx:1245
(anonymous namespace)::BroadcastRecalcOnRefMoveHandler aBulk class ScBulkBroadcast
(anonymous namespace)::BroadcastRecalcOnRefMoveHandler aBulk const class ScBulkBroadcast
sc/source/filter/html/htmlpars.cxx:3029
(anonymous namespace)::CSSHandler::MemStr mp const char *
sc/source/filter/html/htmlpars.cxx:3030
......@@ -329,7 +327,7 @@ sc/source/filter/html/htmlpars.cxx:3030
sc/source/filter/inc/htmlpars.hxx:614
ScHTMLQueryParser mnUnusedId ScHTMLTableId
sc/source/filter/inc/sheetdatacontext.hxx:62
oox::xls::SheetDataContext aReleaser class SolarMutexReleaser
oox::xls::SheetDataContext aReleaser const class SolarMutexReleaser
sc/source/filter/inc/xetable.hxx:1002
XclExpCellTable maArrayBfr class XclExpArrayBuffer
sc/source/filter/inc/xetable.hxx:1003
......@@ -352,9 +350,9 @@ sc/source/filter/xml/xmltransformationi.hxx:121
ScXMLColumnNumberContext aType class rtl::OUString
sc/source/filter/xml/xmltransformationi.hxx:155
ScXMLDateTimeContext aType class rtl::OUString
sc/source/ui/inc/acredlin.hxx:58
sc/source/ui/inc/acredlin.hxx:51
ScAcceptChgDlg aReOpenIdle class Idle
sc/source/ui/inc/anyrefdg.hxx:119
sc/source/ui/inc/anyrefdg.hxx:112
ScRefHandler m_aIdle class Idle
sc/source/ui/inc/msgpool.hxx:37
ScMessagePool aGlobalStringItem class SfxStringItem
......@@ -390,6 +388,8 @@ sd/source/filter/eppt/epptbase.hxx:347
PPTWriterBase maFraction const class Fraction
sd/source/filter/ppt/pptin.hxx:82
SdPPTImport maParam struct PowerPointImportParam
sd/source/ui/animations/CustomAnimationDialog.hxx:149
sd::SdPropertySubControl mnType sal_Int32
sd/source/ui/inc/AccessibleDocumentViewBase.hxx:262
accessibility::AccessibleDocumentViewBase maViewForwarder class accessibility::AccessibleViewForwarder
sd/source/ui/remotecontrol/Receiver.hxx:36
......@@ -508,17 +508,11 @@ sw/source/core/text/inftxt.hxx:686
SwTextSlot aText class rtl::OUString
sw/source/core/text/porfld.cxx:141
SwFieldSlot aText class rtl::OUString
sw/source/filter/html/htmlcss1.cxx:77
SwCSS1ItemIds nFormatBreak const sal_uInt16
sw/source/filter/html/htmlcss1.cxx:78
SwCSS1ItemIds nFormatPageDesc const sal_uInt16
sw/source/filter/html/htmlcss1.cxx:79
SwCSS1ItemIds nFormatKeep const sal_uInt16
sw/source/ui/dbui/mmaddressblockpage.hxx:212
SwCustomizeAddressBlockDialog m_aTextFilter class TextFilter
sw/source/uibase/docvw/romenu.hxx:35
SwReadOnlyPopup m_aBuilder class VclBuilder
sw/source/uibase/inc/cption.hxx:44
sw/source/uibase/inc/cption.hxx:43
SwCaptionDialog m_aTextFilter class TextFilterAutoConvert
sw/source/uibase/inc/glossary.hxx:95
SwGlossaryDlg m_aNoSpaceFilter class TextFilter
......@@ -526,11 +520,11 @@ sw/source/uibase/inc/olmenu.hxx:77
SwSpellPopup m_aBuilder class VclBuilder
sw/source/uibase/inc/olmenu.hxx:86
SwSpellPopup m_nLangParaMenuId const sal_uInt16
sw/source/uibase/inc/optload.hxx:186
sw/source/uibase/inc/optload.hxx:185
SwCaptionOptPage m_aTextFilter class TextFilterAutoConvert
sw/source/uibase/inc/regionsw.hxx:256
sw/source/uibase/inc/regionsw.hxx:255
SwInsertSectionTabDialog m_nNotePageId sal_uInt16
sw/source/uibase/inc/regionsw.hxx:276
sw/source/uibase/inc/regionsw.hxx:275
SwSectionPropertyTabDialog m_nNotePageId sal_uInt16
sw/source/uibase/inc/uivwimp.hxx:95
SwView_Impl xTmpSelDocSh const class SfxObjectShellLock
......@@ -582,13 +576,13 @@ vcl/inc/unx/i18n_ic.hxx:46
SalI18N_InputContext maSwitchIMCallback XIMCallback
vcl/inc/unx/i18n_ic.hxx:47
SalI18N_InputContext maDestroyCallback XIMCallback
vcl/source/app/salvtables.cxx:1542
vcl/source/app/salvtables.cxx:1552
SalInstanceEntry m_aTextFilter class SalInstanceEntry::WeldTextFilter
vcl/source/gdi/jobset.cxx:35
ImplOldJobSetupData cDeviceName char [32]
vcl/source/gdi/jobset.cxx:36
ImplOldJobSetupData cPortName char [32]
vcl/unx/gtk3/gtk3gtkinst.cxx:2398
vcl/unx/gtk3/gtk3gtkinst.cxx:2403
CrippledViewport viewport GtkViewport
vcl/unx/gtk/a11y/atkhypertext.cxx:29
(anonymous) atk_hyper_link const AtkHyperlink
......
......@@ -4,7 +4,7 @@ avmedia/source/vlc/wrapper/Types.hxx:52
libvlc_track_description_t i_id int
avmedia/source/vlc/wrapper/Types.hxx:54
libvlc_track_description_t p_next struct libvlc_track_description_t *
basegfx/source/polygon/b2dtrapezoid.cxx:201
basegfx/source/polygon/b2dtrapezoid.cxx:202
basegfx::trapezoidhelper::PointBlockAllocator maFirstStackBlock class basegfx::B2DPoint [32]
basic/source/inc/expr.hxx:93
SbiExprNode::(anonymous) nTypeStrId sal_uInt16
......@@ -52,8 +52,6 @@ bridges/source/jni_uno/jni_java2uno.cxx:151
jni_uno::largest p void *
bridges/source/jni_uno/jni_java2uno.cxx:152
jni_uno::largest a uno_Any
chart2/source/controller/inc/res_LegendPosition.hxx:93
chart::SchLegendPositionResources m_aChangeLink Link<class LinkParamNone *, void>
chart2/source/model/main/DataPoint.hxx:108
chart::DataPoint m_bNoParentPropAllowed _Bool
connectivity/source/drivers/evoab2/EApi.h:125
......@@ -218,7 +216,7 @@ extensions/source/update/check/updatehdl.hxx:85
UpdateHandler mbStringsLoaded _Bool
filter/source/graphicfilter/eps/eps.cxx:113
PSWriter pVDev ScopedVclPtrInstance<class VirtualDevice>
filter/source/graphicfilter/icgm/cgm.hxx:62
filter/source/graphicfilter/icgm/cgm.hxx:60
CGM mbPicture _Bool
filter/source/graphicfilter/icgm/chart.hxx:44
DataNode nBoxX1 sal_Int16
......@@ -285,19 +283,19 @@ include/filter/msfilter/svdfppt.hxx:882
include/filter/msfilter/svdfppt.hxx:883
ImplPPTParaPropSet nDontKnow2bit06 sal_uInt16
include/oox/core/contexthandler2.hxx:220
oox::core::ContextHandler2Helper mnRootStackSize size_t
oox::core::ContextHandler2Helper mnRootStackSize const size_t
include/oox/ole/axbinarywriter.hxx:151
oox::ole::AxBinaryPropertyWriter maStreamProps oox::ole::AxBinaryPropertyWriter::ComplexPropVector
include/registry/refltype.hxx:65
RTUik m_Data1 sal_uInt32
RTUik m_Data1 const sal_uInt32
include/registry/refltype.hxx:66
RTUik m_Data2 sal_uInt16
RTUik m_Data2 const sal_uInt16
include/registry/refltype.hxx:67
RTUik m_Data3 sal_uInt16
RTUik m_Data3 const sal_uInt16
include/registry/refltype.hxx:68
RTUik m_Data4 sal_uInt32
RTUik m_Data4 const sal_uInt32
include/registry/refltype.hxx:69
RTUik m_Data5 sal_uInt32
RTUik m_Data5 const sal_uInt32
include/sfx2/charmapcontrol.hxx:44
SfxCharmapCtrl m_pFavCharView VclPtr<class SvxCharViewControl> [16]
include/sfx2/msg.hxx:95
......@@ -320,18 +318,6 @@ include/svl/adrparse.hxx:52
SvAddressParser m_bHasFirst _Bool
include/svl/ondemand.hxx:58
OnDemandLocaleDataWrapper aSysLocale class SvtSysLocale
include/svtools/ctrlbox.hxx:449
FontSizeBox nRelMin sal_uInt16
include/svtools/ctrlbox.hxx:450
FontSizeBox nRelMax sal_uInt16
include/svtools/ctrlbox.hxx:451
FontSizeBox nRelStep sal_uInt16
include/svtools/ctrlbox.hxx:452
FontSizeBox nPtRelMin short
include/svtools/ctrlbox.hxx:453
FontSizeBox nPtRelMax short
include/svtools/ctrlbox.hxx:454
FontSizeBox nPtRelStep short
include/svtools/editsyntaxhighlighter.hxx:32
MultiLineEditSyntaxHighlight m_aColorConfig const svtools::ColorConfig
include/svx/sdr/overlay/overlayanimatedbitmapex.hxx:51
......@@ -378,8 +364,6 @@ include/unoidl/unoidl.hxx:454
unoidl::ConstantValue::(anonymous) doubleValue double
include/unotest/bootstrapfixturebase.hxx:37
test::BootstrapFixtureBase m_directories class test::Directories
include/vcl/filter/pdfdocument.hxx:200
vcl::filter::PDFNameElement m_nLength const sal_uInt64
include/vcl/opengl/OpenGLContext.hxx:57
OpenGLCapabilitySwitch mbLimitedShaderRegisters _Bool
include/vcl/opengl/OpenGLContext.hxx:176
......@@ -400,14 +384,16 @@ lingucomponent/source/languageguessing/simpleguesser.cxx:79
textcat_t maxsize uint4
lingucomponent/source/languageguessing/simpleguesser.cxx:81
textcat_t output char [1024]
linguistic/source/dlistimp.cxx:73
DicEvtListenerHelper aCollectDicEvt std::vector<DictionaryEvent>
linguistic/source/dlistimp.hxx:56
DicList aOpt class LinguOptions
oox/qa/token/tokenmap-test.cxx:34
oox::TokenmapTest tokenMap class oox::TokenMap
oox::TokenmapTest tokenMap const class oox::TokenMap
oox/qa/unit/vba_compression.cxx:71
TestVbaCompression m_directories test::Directories
TestVbaCompression m_directories const test::Directories
oox/source/drawingml/chart/objectformatter.cxx:708
oox::drawingml::chart::ObjectFormatterData maFromLocale struct com::sun::star::lang::Locale
oox::drawingml::chart::ObjectFormatterData maFromLocale const struct com::sun::star::lang::Locale
oox/source/drawingml/diagram/diagramlayoutatoms.hxx:208
oox::drawingml::ChooseAtom maEmptyChildren const std::vector<LayoutAtomPtr>
registry/source/reflwrit.cxx:141
......@@ -437,13 +423,13 @@ sal/rtl/uuid.cxx:64
sal/rtl/uuid.cxx:65
UUID node sal_uInt8 [6]
sc/inc/compiler.hxx:127
ScRawToken::(anonymous union)::(anonymous) eItem class ScTableRefToken::Item
ScRawToken::(anonymous union)::(anonymous) eItem const class ScTableRefToken::Item
sc/inc/compiler.hxx:128
ScRawToken::(anonymous) table struct (anonymous struct at /media/noel/disk2/libo6/sc/inc/compiler.hxx:125:9)
ScRawToken::(anonymous) table const struct (anonymous struct at /media/noel/disk2/libo6/sc/inc/compiler.hxx:125:9)
sc/inc/compiler.hxx:133
ScRawToken::(anonymous) pMat class ScMatrix *
ScRawToken::(anonymous) pMat class ScMatrix *const
sc/inc/formulagroup.hxx:39
sc::FormulaGroupEntry::(anonymous) mpCells class ScFormulaCell **
sc::FormulaGroupEntry::(anonymous) mpCells class ScFormulaCell **const
sc/inc/reordermap.hxx:21
sc::ColRowReorderMapType maData sc::ColRowReorderMapType::DataType
sc/source/core/inc/adiasync.hxx:42
......@@ -457,13 +443,13 @@ sc/source/filter/excel/xltoolbar.cxx:35
sc/source/filter/inc/autofilterbuffer.hxx:181
oox::xls::FilterColumn mxSettings std::shared_ptr<FilterSettingsBase>
sc/source/filter/inc/commentsbuffer.hxx:42
oox::xls::CommentModel maAnchor css::awt::Rectangle
oox::xls::CommentModel maAnchor const css::awt::Rectangle
sc/source/filter/inc/htmlpars.hxx:56
ScHTMLStyles maEmpty const class rtl::OUString
sc/source/filter/inc/namebuff.hxx:80
RangeNameBufferWK3::Entry nAbsInd sal_uInt16
sc/source/filter/inc/qproform.hxx:55
QProToSc mnAddToken struct TokenId
QProToSc mnAddToken const struct TokenId
sc/source/filter/inc/stylesbuffer.hxx:676
oox::xls::Dxf mxAlignment std::shared_ptr<Alignment>
sc/source/filter/inc/stylesbuffer.hxx:678
......@@ -530,11 +516,13 @@ sdext/source/pdfimport/tree/style.hxx:42
pdfi::StyleContainer::Style Contents const class rtl::OUString
sfx2/source/appl/lnkbase2.cxx:95
sfx2::ImplDdeItem pLink class sfx2::SvBaseLink *
sfx2/source/inc/appdata.hxx:103
SfxAppData_Impl nInReschedule sal_uInt16
slideshow/source/engine/slideshowimpl.cxx:153
(anonymous namespace)::FrameSynchronization maTimer const canvas::tools::ElapsedTime
sot/source/sdstor/ucbstorage.cxx:408
sot/source/sdstor/ucbstorage.cxx:403
UCBStorageStream_Impl m_aKey const class rtl::OString
starmath/source/view.cxx:856
starmath/source/view.cxx:861
SmViewShell_Impl aOpts const class SvtMiscOptions
store/source/storbios.cxx:59
OStoreSuperBlock m_aMarked OStoreSuperBlock::L
......@@ -586,8 +574,6 @@ svx/source/inc/gridcell.hxx:526
DbPatternField m_pValueFormatter ::std::unique_ptr< ::dbtools::FormattedColumnValue>
svx/source/inc/gridcell.hxx:527
DbPatternField m_pPaintFormatter ::std::unique_ptr< ::dbtools::FormattedColumnValue>
svx/source/svdraw/svdpdf.hxx:173
ImpSdrPdfImport maLineCap const css::drawing::LineCap
svx/source/svdraw/svdpdf.hxx:174
ImpSdrPdfImport maDash const class XDash
sw/inc/acmplwrd.hxx:42
......@@ -638,7 +624,7 @@ sw/source/uibase/inc/fldmgr.hxx:78
SwInsertField_Data m_aDBDataSource const css::uno::Any
sw/source/uibase/inc/labimg.hxx:50
SwLabItem m_aBin class rtl::OUString
sw/source/uibase/inc/optload.hxx:107
sw/source/uibase/inc/optload.hxx:106
CaptionComboBox aDefault const class rtl::OUString
toolkit/source/awt/vclxtoolkit.cxx:434
(anonymous namespace)::VCLXToolkit mxSelection css::uno::Reference<css::datatransfer::clipboard::XClipboard>
......@@ -730,11 +716,11 @@ vcl/source/filter/jpeg/transupp.h:148
(anonymous) crop_xoffset_set JCROP_CODE
vcl/source/filter/jpeg/transupp.h:150
(anonymous) crop_yoffset_set JCROP_CODE
vcl/source/fontsubset/sft.cxx:1049
vcl/source/fontsubset/sft.cxx:1048
vcl::_subHeader2 firstCode const sal_uInt16
vcl/source/fontsubset/sft.cxx:1050
vcl/source/fontsubset/sft.cxx:1049
vcl::_subHeader2 entryCount const sal_uInt16
vcl/source/fontsubset/sft.cxx:1051
vcl/source/fontsubset/sft.cxx:1050
vcl::_subHeader2 idDelta const sal_uInt16
vcl/source/gdi/dibtools.cxx:51
(anonymous namespace)::CIEXYZ aXyzX FXPT2DOT30
......
......@@ -20,6 +20,14 @@ canvas/source/vcl/canvasbitmap.hxx:117
vclcanvas::CanvasBitmap mxDevice css::uno::Reference<css::rendering::XGraphicDevice>
canvas/source/vcl/impltools.hxx:117
vclcanvas::tools::LocalGuard aSolarGuard class SolarMutexGuard
chart2/source/controller/dialogs/res_DataLabel.hxx:87
chart::DataLabelResources m_xDC_Dial std::unique_ptr<weld::CustomWeld>
chart2/source/controller/dialogs/tp_AxisLabel.hxx:53
chart::SchAxisLabelTabPage m_xFlOrient std::unique_ptr<weld::Label>
chart2/source/controller/dialogs/tp_RangeChooser.hxx:88
chart::RangeChooserTabPage m_xFT_Range std::unique_ptr<weld::Label>
chart2/source/controller/dialogs/tp_TitleRotation.hxx:38
chart::SchAlignmentTabPage m_xFtTextDirection std::unique_ptr<weld::Label>
chart2/source/controller/inc/RangeSelectionListener.hxx:63
chart::RangeSelectionListener m_aControllerLockGuard class chart::ControllerLockGuardUNO
comphelper/source/container/enumerablemap.cxx:298
......@@ -40,9 +48,9 @@ cui/source/dialogs/colorpicker.cxx:714
cui::ColorPickerDialog m_xColorField std::unique_ptr<weld::CustomWeld>
cui/source/dialogs/colorpicker.cxx:716
cui::ColorPickerDialog m_xColorPreview std::unique_ptr<weld::CustomWeld>
cui/source/inc/align.hxx:98
cui/source/inc/align.hxx:97
svx::AlignmentTabPage m_xBoxDirection std::unique_ptr<weld::Widget>
cui/source/inc/cfg.hxx:575
cui/source/inc/cfg.hxx:574
SvxNewToolbarDialog m_xBtnOK std::unique_ptr<weld::Button>
cui/source/inc/cuicharmap.hxx:104
SvxCharacterMap m_xShowChar std::unique_ptr<weld::CustomWeld>
......@@ -64,9 +72,9 @@ cui/source/inc/cuitabarea.hxx:710
SvxColorTabPage m_xCtlPreviewNew std::unique_ptr<weld::CustomWeld>
cui/source/inc/FontFeaturesDialog.hxx:53
cui::FontFeaturesDialog m_xPreviewWindow std::unique_ptr<weld::CustomWeld>
cui/source/inc/page.hxx:105
cui/source/inc/page.hxx:104
SvxPageDescPage m_xOrientationFT std::unique_ptr<weld::Label>
cui/source/inc/page.hxx:135
cui/source/inc/page.hxx:134
SvxPageDescPage m_xBspWin std::unique_ptr<weld::CustomWeld>
cui/source/inc/paragrph.hxx:67
SvxStdParagraphTabPage m_xRightLabel std::unique_ptr<weld::Label>
......@@ -78,7 +86,7 @@ cui/source/inc/paragrph.hxx:159
SvxParaAlignTabPage m_xPropertiesFL std::unique_ptr<weld::Widget>
cui/source/inc/swpossizetabpage.hxx:88
SvxSwPosSizeTabPage m_xExampleWN std::unique_ptr<weld::CustomWeld>
cui/source/inc/textattr.hxx:69
cui/source/inc/textattr.hxx:66
SvxTextAttrPage m_xCtlPosition std::unique_ptr<weld::CustomWeld>
cui/source/inc/transfrm.hxx:104
SvxPositionSizeTabPage m_xCtlPos std::unique_ptr<weld::CustomWeld>
......@@ -124,13 +132,13 @@ include/svtools/PlaceEditDialog.hxx:48
PlaceEditDialog m_xBTCancel std::unique_ptr<weld::Button>
include/svtools/unoevent.hxx:162
SvEventDescriptor xParentRef css::uno::Reference<css::uno::XInterface>
include/svx/ClassificationDialog.hxx:63
svx::ClassificationDialog m_nInsertMarkings const sal_Int16
include/svtools/wizardmachine.hxx:119
svt::OWizardPage m_xContainer std::unique_ptr<weld::Container>
include/svx/colorwindow.hxx:132
ColorWindow mxColorSetWin std::unique_ptr<weld::CustomWeld>
include/svx/colorwindow.hxx:133
ColorWindow mxRecentColorSetWin std::unique_ptr<weld::CustomWeld>
include/svx/hdft.hxx:87
include/svx/hdft.hxx:86
SvxHFPage m_xBspWin std::unique_ptr<weld::CustomWeld>
include/vcl/font/Feature.hxx:102
vcl::font::Feature m_eType const enum vcl::font::FeatureType
......@@ -193,47 +201,49 @@ sal/osl/unx/thread.cxx:94
sal/osl/unx/thread.cxx:112
osl_thread_global_st m_priority const struct osl_thread_priority_st
sc/inc/formulalogger.hxx:42
sc::FormulaLogger maMessages std::vector<OUString>
sc::FormulaLogger maMessages const std::vector<OUString>
sc/inc/interpretercontext.hxx:32
ScInterpreterContext mrDoc const class ScDocument &
sc/qa/unit/ucalc_column.cxx:104
aInputs aName const char *
sc/source/core/data/document.cxx:1244
(anonymous namespace)::BroadcastRecalcOnRefMoveHandler aSwitch sc::AutoCalcSwitch
(anonymous namespace)::BroadcastRecalcOnRefMoveHandler aSwitch const sc::AutoCalcSwitch
sc/source/core/data/document.cxx:1245
(anonymous namespace)::BroadcastRecalcOnRefMoveHandler aBulk class ScBulkBroadcast
(anonymous namespace)::BroadcastRecalcOnRefMoveHandler aBulk const class ScBulkBroadcast
sc/source/filter/html/htmlpars.cxx:3029
(anonymous namespace)::CSSHandler::MemStr mp const char *
sc/source/filter/html/htmlpars.cxx:3030
(anonymous namespace)::CSSHandler::MemStr mn size_t
sc/source/filter/inc/sheetdatacontext.hxx:62
oox::xls::SheetDataContext aReleaser class SolarMutexReleaser
sc/source/ui/inc/crdlg.hxx:33
oox::xls::SheetDataContext aReleaser const class SolarMutexReleaser
sc/source/ui/inc/crdlg.hxx:32
ScColOrRowDlg m_xBtnRows std::unique_ptr<weld::RadioButton>
sc/source/ui/inc/delcodlg.hxx:39
ScDeleteContentsDlg m_xBtnOk std::unique_ptr<weld::Button>
sc/source/ui/inc/docsh.hxx:462
sc/source/ui/inc/docsh.hxx:456
ScDocShellModificator mpProtector std::unique_ptr<ScRefreshTimerProtector>
sc/source/ui/inc/instbdlg.hxx:66
ScInsertTableDlg m_xBtnBehind std::unique_ptr<weld::RadioButton>
sd/source/ui/animations/CustomAnimationDialog.cxx:1743
sd/source/ui/animations/CustomAnimationDialog.cxx:1746
sd::CustomAnimationEffectTabPage mxContainer std::unique_ptr<weld::Container>
sd/source/ui/animations/CustomAnimationDialog.cxx:1749
sd::CustomAnimationEffectTabPage mxFTSound std::unique_ptr<weld::Label>
sd/source/ui/animations/CustomAnimationDialog.cxx:1752
sd::CustomAnimationEffectTabPage mxFTSound std::unique_ptr<weld::Label>
sd/source/ui/animations/CustomAnimationDialog.cxx:1755
sd::CustomAnimationEffectTabPage mxFTAfterEffect std::unique_ptr<weld::Label>
sd/source/ui/animations/CustomAnimationDialog.cxx:2273
sd/source/ui/animations/CustomAnimationDialog.cxx:2276
sd::CustomAnimationDurationTabPage mxContainer std::unique_ptr<weld::Container>
sd/source/ui/animations/CustomAnimationDialog.cxx:2274
sd/source/ui/animations/CustomAnimationDialog.cxx:2277
sd::CustomAnimationDurationTabPage mxFTStart std::unique_ptr<weld::Label>
sd/source/ui/animations/CustomAnimationDialog.cxx:2276
sd/source/ui/animations/CustomAnimationDialog.cxx:2279
sd::CustomAnimationDurationTabPage mxFTStartDelay std::unique_ptr<weld::Label>
sd/source/ui/animations/CustomAnimationDialog.cxx:2639
sd/source/ui/animations/CustomAnimationDialog.cxx:2642
sd::CustomAnimationTextAnimTabPage mxContainer std::unique_ptr<weld::Container>
sd/source/ui/animations/CustomAnimationDialog.cxx:2640
sd/source/ui/animations/CustomAnimationDialog.cxx:2643
sd::CustomAnimationTextAnimTabPage mxFTGroupText std::unique_ptr<weld::Label>
sd/source/ui/animations/CustomAnimationDialog.hxx:150
sd/source/ui/animations/CustomAnimationDialog.hxx:148
sd::SdPropertySubControl mxContainer std::unique_ptr<weld::Container>
sd/source/ui/animations/CustomAnimationDialog.hxx:149
sd::SdPropertySubControl mnType sal_Int32
sd/source/ui/dlg/PhotoAlbumDialog.hxx:60
sd::SdPhotoAlbumDialog m_xImg std::unique_ptr<weld::CustomWeld>
sd/source/ui/inc/custsdlg.hxx:43
......@@ -328,6 +338,14 @@ sw/source/uibase/inc/dbui.hxx:31
PrintMonitor m_xDocName std::unique_ptr<weld::Label>
sw/source/uibase/inc/drpcps.hxx:141
SwDropCapsPage m_xPict std::unique_ptr<weld::CustomWeld>
sw/source/uibase/inc/frmpage.hxx:227
SwGrfExtPage m_xFlAngle std::unique_ptr<weld::Frame>
sw/source/uibase/inc/frmpage.hxx:296
SwFrameAddPage m_xDescriptionFT std::unique_ptr<weld::Label>
sw/source/uibase/inc/frmpage.hxx:298
SwFrameAddPage m_xPrevFT std::unique_ptr<weld::Label>
sw/source/uibase/inc/frmpage.hxx:300
SwFrameAddPage m_xNextFT std::unique_ptr<weld::Label>
sw/source/uibase/inc/insfnote.hxx:38
SwInsFootNoteDlg m_xNumberFrame std::unique_ptr<weld::Widget>
sw/source/uibase/inc/num.hxx:55
......@@ -338,7 +356,7 @@ sw/source/uibase/inc/outline.hxx:98
SwOutlineSettingsTabPage m_xPreviewWIN std::unique_ptr<weld::CustomWeld>
sw/source/uibase/inc/pggrid.hxx:44
SwTextGridPage m_xExampleWN std::unique_ptr<weld::CustomWeld>
sw/source/uibase/inc/regionsw.hxx:233
sw/source/uibase/inc/regionsw.hxx:232
SwSectionIndentTabPage m_xPreviewWin std::unique_ptr<weld::CustomWeld>
sw/source/uibase/inc/splittbl.hxx:30
SwSplitTableDlg m_xHorzBox std::unique_ptr<weld::RadioButton>
......@@ -372,7 +390,7 @@ vcl/unx/generic/print/prtsetup.hxx:73
RTSPaperPage m_xContainer std::unique_ptr<weld::Widget>
vcl/unx/generic/print/prtsetup.hxx:108
RTSDevicePage m_xContainer std::unique_ptr<weld::Widget>
vcl/unx/gtk3/gtk3gtkinst.cxx:2398
vcl/unx/gtk3/gtk3gtkinst.cxx:2403
CrippledViewport viewport GtkViewport
vcl/unx/gtk/a11y/atkhypertext.cxx:29
(anonymous) atk_hyper_link const AtkHyperlink
......
......@@ -445,9 +445,7 @@ private:
class SVT_DLLPUBLIC FontSizeBox : public MetricBox
{
FontMetric aFontMetric;
const FontList* pFontList;
bool bRelative:1,
bPtRelative:1,
bStdSize:1;
using Window::ImplInit;
......
......@@ -70,7 +70,6 @@ class DicEvtListenerHelper :
>
{
comphelper::OInterfaceContainerHelper2 aDicListEvtListeners;
std::vector< DictionaryEvent > aCollectDicEvt;
uno::Reference< XDictionaryList > xMyDicList;
sal_Int16 nCondensedEvt;
......@@ -242,7 +241,6 @@ sal_Int16 DicEvtListenerHelper::FlushEvents()
// clear "list" of events
nCondensedEvt = 0;
aCollectDicEvt.clear();
}
return nNumCollectEvtListeners;
......
......@@ -122,10 +122,9 @@ protected:
class SdPropertySubControl
{
public:
explicit SdPropertySubControl(weld::Container* pParent, sal_Int32 nType)
explicit SdPropertySubControl(weld::Container* pParent)
: mxBuilder(Application::CreateBuilder(pParent, "modules/simpress/ui/customanimationfragment.ui"))
, mxContainer(mxBuilder->weld_container("EffectFragment"))
, mnType( nType )
{
}
......@@ -146,7 +145,6 @@ public:
protected:
std::unique_ptr<weld::Builder> mxBuilder;
std::unique_ptr<weld::Container> mxContainer;
sal_Int32 mnType;
};
class PropertyControl : public ListBox
......
......@@ -93,7 +93,6 @@ SfxAppData_Impl::SfxAppData_Impl()
, pProgress(nullptr)
, nDocModalMode(0)
, nRescheduleLocks(0)
, nInReschedule(0)
, m_xImeStatusWindow(new sfx2::appl::ImeStatusWindow(comphelper::getProcessComponentContext()))
, pTbxCtrlFac(nullptr)
, pStbCtrlFac(nullptr)
......
......@@ -1269,7 +1269,7 @@ bool SfxBindings::NextJob_Impl(Timer const * pTimer)
pImpl->aAutoTimer.SetTimeout(TIMEOUT_UPDATING);
// at least 10 loops and further if more jobs are available but no input
bool bPreEmptive = pTimer && !pSfxApp->Get_Impl()->nInReschedule;
bool bPreEmptive = pTimer;
sal_uInt16 nLoops = 10;
pImpl->bInNextJob = true;
const std::size_t nCount = pImpl->pCaches.size();
......
......@@ -97,9 +97,8 @@ struct SfxObjectBars_Impl
ToolbarId eId; // ConfigId of the Toolbox
sal_uInt16 nPos;
SfxVisibilityFlags nFlags; // special visibility flags
SfxInterface* pIFace;
SfxObjectBars_Impl() : eId(ToolbarId::None), nPos(0), nFlags(SfxVisibilityFlags::Invisible), pIFace(nullptr) {}
SfxObjectBars_Impl() : eId(ToolbarId::None), nPos(0), nFlags(SfxVisibilityFlags::Invisible) {}
};
struct SfxDispatcher_Impl
......@@ -1294,7 +1293,6 @@ void SfxDispatcher::Update_Impl_( bool bUIActive, bool bIsMDIApp, bool bIsIPOwne
rBar.nPos = nPos;
rBar.nFlags = nFlags;
rBar.eId = pIFace->GetObjectBarId(nNo);
rBar.pIFace = pIFace;
if ( bUIActive || bIsActive )
{
......
......@@ -100,7 +100,6 @@ public:
sal_uInt16 nDocModalMode; // counts documents in modal mode
sal_uInt16 nRescheduleLocks;
sal_uInt16 nInReschedule;
rtl::Reference< sfx2::appl::ImeStatusWindow > m_xImeStatusWindow;
......
......@@ -1262,10 +1262,8 @@ void FontSizeBox::ImplInit()
{
EnableAutocomplete( false );
bPtRelative = false;
bRelative = false;
bStdSize = false;
pFontList = nullptr;
SetShowTrailingZeros( false );
SetDecimalDigits( 1 );
......@@ -1289,9 +1287,6 @@ void FontSizeBox::Reformat()
void FontSizeBox::Fill( const FontMetric* pFontMetric, const FontList* pList )
{
// remember for relative mode
pFontList = pList;
// no font sizes need to be set for relative mode
if ( bRelative )
return;
......
......@@ -34,10 +34,8 @@ constexpr sal_uInt32 getSwDefaultTextFormat() { return NF_STANDARD_FORMAT_TEXT;
class SW_DLLPUBLIC SwTableBoxNumFormat : public SfxUInt32Item
{
bool m_bAuto; ///< automatically given flag
public:
SwTableBoxNumFormat( sal_uInt32 nFormat = getSwDefaultTextFormat(),
bool bAuto = false );
SwTableBoxNumFormat( sal_uInt32 nFormat = getSwDefaultTextFormat() );
// "pure virtual methods" of SfxPoolItem
virtual bool operator==( const SfxPoolItem& ) const override;
......@@ -46,7 +44,6 @@ public:
SwTableBoxNumFormat& operator=( const SwTableBoxNumFormat& rAttr )
{
SetValue( rAttr.GetValue() );
m_bAuto = rAttr.m_bAuto;
return *this;
}
};
......
......@@ -37,24 +37,22 @@
// The advantage is that this is the pool's default item value and some places
// benefit from this special treatment in that they don't have to handle/store
// attribute specifics, especially when writing a document.
SwTableBoxNumFormat::SwTableBoxNumFormat( sal_uInt32 nFormat, bool bFlag )
SwTableBoxNumFormat::SwTableBoxNumFormat( sal_uInt32 nFormat )
: SfxUInt32Item( RES_BOXATR_FORMAT,
(((nFormat % SV_COUNTRY_LANGUAGE_OFFSET) == getSwDefaultTextFormat()) ?
getSwDefaultTextFormat() : nFormat))
, m_bAuto( bFlag )
{
}
bool SwTableBoxNumFormat::operator==( const SfxPoolItem& rAttr ) const
{
assert(SfxPoolItem::operator==(rAttr));
return GetValue() == static_cast<const SwTableBoxNumFormat&>(rAttr).GetValue() &&
m_bAuto == static_cast<const SwTableBoxNumFormat&>(rAttr).m_bAuto;
return GetValue() == static_cast<const SwTableBoxNumFormat&>(rAttr).GetValue();
}
SfxPoolItem* SwTableBoxNumFormat::Clone( SfxItemPool* ) const
{
return new SwTableBoxNumFormat( GetValue(), m_bAuto );
return new SwTableBoxNumFormat( GetValue() );
}
SwTableBoxFormula::SwTableBoxFormula( const OUString& rFormula )
......
......@@ -67,7 +67,6 @@ SwLabItem& SwLabItem::operator =(const SwLabItem& rItem)
m_aType = rItem.m_aType;
m_bPage = rItem.m_bPage;
m_bSynchron = rItem.m_bSynchron;
m_aBin = rItem.m_aBin;
m_nCol = rItem.m_nCol;
m_nRow = rItem.m_nRow;
m_lHDist = rItem.m_lHDist;
......@@ -125,7 +124,6 @@ bool SwLabItem::operator ==(const SfxPoolItem& rItem) const
m_bCont == rLab.m_bCont &&
m_bPage == rLab.m_bPage &&
m_bSynchron == rLab.m_bSynchron &&
m_aBin == rLab.m_aBin &&
m_nCol == rLab.m_nCol &&
m_nRow == rLab.m_nRow &&
m_lHDist == rLab.m_lHDist &&
......
......@@ -47,7 +47,6 @@ public:
OUString m_aWriting; // label
OUString m_aMake; // label mark
OUString m_aType; // label type
OUString m_aBin; // printer shaft
sal_Int32 m_lHDist; // horizontal distance (user)
sal_Int32 m_lVDist; // vertical distance (user)
sal_Int32 m_lWidth; // width (user)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment