loplugin:countusersofdefaultparams in sot..svtools

Change-Id: Ifce19de3518f3eaf5a1b6439f9053feee4a33c14

sot/source/sdstor/ucbstorage.cxx

@@ -436,8 +436,8 @@ public:
                                                 // reference is destroyed
     bool                        m_bIsOLEStorage;// an OLEStorage on a UCBStorageStream makes this an Autocommit-stream
 
-                                UCBStorageStream_Impl( const OUString&, StreamMode, UCBStorageStream*, bool, const OString* pKey=nullptr,
-                                                       bool bRepair = false, Reference< XProgressHandler > const & xProgress = Reference< XProgressHandler >() );
+                                UCBStorageStream_Impl( const OUString&, StreamMode, UCBStorageStream*, bool, const OString* pKey,
+                                                       bool bRepair, Reference< XProgressHandler > const & xProgress );
 
     void                        Free();
     bool                        Init();
@@ -500,7 +500,7 @@ public:
                                 UCBStorage_Impl( const ::ucbhelper::Content&, const OUString&, StreamMode, UCBStorage*, bool,
                                                  bool, bool = false, Reference< XProgressHandler > const & = Reference< XProgressHandler >() );
                                 UCBStorage_Impl( const OUString&, StreamMode, UCBStorage*, bool, bool,
-                                                 bool = false, Reference< XProgressHandler > const & = Reference< XProgressHandler >() );
+                                                 bool, Reference< XProgressHandler > const & );
                                 UCBStorage_Impl( SvStream&, UCBStorage*, bool );
     void                        Init();
     sal_Int16                   Commit();

starmath/inc/caret.hxx

@@ -99,9 +99,9 @@ private:
 
 /** An entry in SmCaretPosGraph */
 struct SmCaretPosGraphEntry{
-    SmCaretPosGraphEntry(SmCaretPos pos = SmCaretPos(),
-                       SmCaretPosGraphEntry* left = nullptr,
-                       SmCaretPosGraphEntry* right = nullptr){
+    SmCaretPosGraphEntry(SmCaretPos pos,
+                         SmCaretPosGraphEntry* left,
+                         SmCaretPosGraphEntry* right) {
         CaretPos = pos;
         Left = left;
         Right = right;

starmath/inc/unomodel.hxx

@@ -59,7 +59,7 @@ protected:
     virtual void _getPropertyValues( const comphelper::PropertyMapEntry** ppEntries, css::uno::Any* pValue )
         throw (css::uno::RuntimeException, css::beans::UnknownPropertyException, css::lang::WrappedTargetException, std::exception) override;
 public:
-    explicit SmModel( SfxObjectShell *pObjSh = nullptr );
+    explicit SmModel( SfxObjectShell *pObjSh );
     virtual ~SmModel() throw () override;
 
     //XInterface

stoc/source/security/permissions.h

@@ -39,7 +39,7 @@ public:
 
     inline Permission(
         t_type type,
-        ::rtl::Reference< Permission > const & next = ::rtl::Reference< Permission >() )
+        ::rtl::Reference< Permission > const & next )
         : m_next( next )
         , m_type( type )
         {}

store/source/storbase.hxx

@@ -140,9 +140,9 @@ struct OStorePageDescriptor
     /** Construction.
      */
     explicit OStorePageDescriptor (
-        sal_uInt32 nAddr = STORE_PAGE_NULL,
-        sal_uInt16 nSize = 0,
-        sal_uInt16 nUsed = 0)
+        sal_uInt32 nAddr,
+        sal_uInt16 nSize,
+        sal_uInt16 nUsed)
         : m_nAddr (store::htonl(nAddr)),
           m_nSize (store::htons(nSize)),
           m_nUsed (store::htons(nUsed))

store/source/storcach.cxx

@@ -51,7 +51,7 @@ struct Entry
     static void   operator delete (void *, void *) {}
 
     // Construction
-    explicit Entry (std::shared_ptr<PageData> const & rxPage = std::shared_ptr<PageData>(), sal_uInt32 nOffset = STORE_PAGE_NULL)
+    explicit Entry (std::shared_ptr<PageData> const & rxPage, sal_uInt32 nOffset)
         : m_xPage(rxPage), m_nOffset(nOffset), m_pNext(nullptr)
     {}
 

store/source/stordata.hxx

@@ -75,7 +75,7 @@ struct OStoreDataPageData : public store::PageData
 
     /** Construction.
     */
-    explicit OStoreDataPageData (sal_uInt16 nPageSize = self::thePageSize)
+    explicit OStoreDataPageData (sal_uInt16 nPageSize)
         : base (nPageSize)
     {
         base::m_aGuard.m_nMagic = store::htonl(self::theTypeId);

store/source/stortree.hxx

@@ -160,7 +160,7 @@ struct OStoreBTreeNodeData : public store::PageData
 
     /** Construction.
     */
-    explicit OStoreBTreeNodeData (sal_uInt16 nPageSize = self::thePageSize);
+    explicit OStoreBTreeNodeData (sal_uInt16 nPageSize);
 
     /** guard (external representation).
     */

svl/source/items/stylepool.cxx

@@ -351,7 +351,7 @@ private:
     SfxItemSet* mpIgnorableItems;
 public:
     // #i86923#
-    explicit StylePoolImpl( SfxItemSet* pIgnorableItems = nullptr )
+    explicit StylePoolImpl( SfxItemSet* pIgnorableItems )
         : maRoot(),
           mpIgnorableItems( pIgnorableItems != nullptr
                             ? pIgnorableItems->Clone( false )

svtools/inc/roadmap.hxx

@@ -50,7 +50,7 @@ protected:
     void            implInit(vcl::RenderContext& rRenderContext);
 
 public:
-    ORoadmap( vcl::Window* _pParent, WinBits _nWinStyle = 0 );
+    ORoadmap( vcl::Window* _pParent, WinBits _nWinStyle );
     virtual ~ORoadmap( ) override;
     virtual void dispose() override;
 

svtools/source/control/ctrlbox.cxx

@@ -444,8 +444,10 @@ private:
 
 public:
     ImpLineListData( BorderWidthImpl aWidthImpl, sal_uInt16 nStyle,
-            long nMinWidth=0, Color ( *pColor1Fn ) ( Color ) = &sameColor,
-            Color ( *pColor2Fn ) ( Color ) = &sameColor, Color ( *pColorDistFn ) ( Color, Color ) = &sameDistColor );
+            long nMinWidth,
+            Color ( *pColor1Fn ) ( Color ),
+            Color ( *pColor2Fn ) ( Color ),
+            Color ( *pColorDistFn ) ( Color, Color ) );
 
     /** Returns the computed width of the line 1 in twips. */
     long GetLine1ForWidth( long nWidth ) { return m_aWidthImpl.GetLine1( nWidth ); }

svtools/source/control/roadmap.cxx

@@ -40,7 +40,7 @@ typedef std::vector< RoadmapItem* > HL_Vector;
 class IDLabel :  public FixedText
 {
 public:
-    IDLabel( vcl::Window* _pParent, WinBits _nWinStyle = 0 );
+    IDLabel( vcl::Window* _pParent, WinBits _nWinStyle );
     virtual void    DataChanged( const DataChangedEvent& rDCEvt ) override;
 };
 

svtools/source/control/tabbar.cxx

@@ -311,7 +311,7 @@ bool ImplTabButton::PreNotify(NotifyEvent& rNotifyEvent)
 class ImplTabSizer : public vcl::Window
 {
 public:
-                    ImplTabSizer( TabBar* pParent, WinBits nWinStyle = 0 );
+                    ImplTabSizer( TabBar* pParent, WinBits nWinStyle );
 
     TabBar*         GetParent() const { return static_cast<TabBar*>(Window::GetParent()); }
 
@@ -392,7 +392,7 @@ private:
                     DECL_LINK( ImplEndTimerHdl, Idle*, void );
 
 public:
-                    TabBarEdit( TabBar* pParent, WinBits nWinStyle = 0 );
+                    TabBarEdit( TabBar* pParent, WinBits nWinStyle );
 
     TabBar*         GetParent() const { return static_cast<TabBar*>(Window::GetParent()); }
 

svtools/source/graphic/grfcache.hxx

@@ -53,8 +53,8 @@ private:
 public:
 
                             GraphicCache(
-                                sal_uLong nDisplayCacheSize = 10000000UL,
-                                sal_uLong nMaxObjDisplayCacheSize = 2400000UL
+                                sal_uLong nDisplayCacheSize,
+                                sal_uLong nMaxObjDisplayCacheSize
                             );
 
                             ~GraphicCache();