Kaydet (Commit) f657ab7b authored tarafından Noel Grandin's avatar Noel Grandin

loplugin:virtualdown in various

Change-Id: I4db71fda953ea1d20712ae8033f6fc09b3b2855d
Reviewed-on: https://gerrit.libreoffice.org/52068Tested-by: 's avatarJenkins <ci@libreoffice.org>
Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
üst 2340536c
......@@ -101,8 +101,6 @@ protected:
void DeSelectAll();
bool IsChildSelected( sal_Int32 i );
virtual void Select();
virtual void DeSelect();
virtual void Click();
virtual bool IsPopupMenuOpen();
......
......@@ -38,8 +38,8 @@ protected:
virtual bool IsEnabled() override;
virtual bool IsVisible() override;
virtual void Select() override;
virtual void DeSelect() override;
virtual void Select();
virtual void DeSelect();
virtual void Click() override;
void SetItemPos( sal_uInt16 nItemPos );
......
......@@ -501,16 +501,6 @@ bool OAccessibleMenuBaseComponent::IsChildSelected( sal_Int32 i )
}
void OAccessibleMenuBaseComponent::Select()
{
}
void OAccessibleMenuBaseComponent::DeSelect()
{
}
void OAccessibleMenuBaseComponent::Click()
{
}
......
......@@ -132,10 +132,6 @@ void TickFactory::getAllTicksShifted( TickInfoArraysType& rAllTickInfos ) const
EquidistantTickFactory( m_rScale, m_rIncrement ).getAllTicksShifted( rAllTickInfos );
}
void TickFactory::updateScreenValues( TickInfoArraysType& /*rAllTickInfos*/ ) const
{
}
// ___TickFactory_2D___
TickFactory2D::TickFactory2D(
const ExplicitScaleData& rScale, const ExplicitIncrementData& rIncrement
......
......@@ -92,11 +92,6 @@ public:
void getAllTicks( TickInfoArraysType& rAllTickInfos ) const;
void getAllTicksShifted( TickInfoArraysType& rAllTickInfos ) const;
/**
* Determine the screen positions of all ticks based on their numeric values.
*/
virtual void updateScreenValues( TickInfoArraysType& rAllTickInfos ) const;
private: //methods
bool isDateAxis() const;
......@@ -132,7 +127,10 @@ public:
, bool bIncludeFarAwayDistanceIfSo = false
, bool bIncludeSpaceBetweenTickAndText = true ) const;
virtual void updateScreenValues( TickInfoArraysType& rAllTickInfos ) const override;
/**
* Determine the screen positions of all ticks based on their numeric values.
*/
virtual void updateScreenValues( TickInfoArraysType& rAllTickInfos ) const;
bool isHorizontalAxis() const;
bool isVerticalAxis() const;
......
......@@ -70,7 +70,7 @@ namespace dbaccess
virtual void SAL_CALL getFastPropertyValue( css::uno::Any& rValue, sal_Int32 nHandle ) const override;
virtual void SAL_CALL setFastPropertyValue_NoBroadcast(sal_Int32 nHandle,const css::uno::Any& rValue ) override;
virtual void fireValueChange(const ::connectivity::ORowSetValue& _rOldValue) override;
virtual void fireValueChange(const ::connectivity::ORowSetValue& _rOldValue);
protected:
using ODataColumn::getFastPropertyValue;
};
......
......@@ -498,16 +498,6 @@ bool OCacheSet::next()
return m_xDriverSet->next();
}
bool OCacheSet::isBeforeFirst( )
{
return m_xDriverSet->isBeforeFirst();
}
bool OCacheSet::isAfterLast( )
{
return m_xDriverSet->isAfterLast();
}
void OCacheSet::beforeFirst( )
{
m_bInserted = m_bUpdated = m_bDeleted = false;
......
......@@ -107,12 +107,6 @@ namespace dbaccess
virtual bool next();
/// @throws css::sdbc::SQLException
/// @throws css::uno::RuntimeException
virtual bool isBeforeFirst( );
/// @throws css::sdbc::SQLException
/// @throws css::uno::RuntimeException
virtual bool isAfterLast( );
/// @throws css::sdbc::SQLException
/// @throws css::uno::RuntimeException
virtual void beforeFirst( );
/// @throws css::sdbc::SQLException
/// @throws css::uno::RuntimeException
......
......@@ -187,8 +187,8 @@ namespace dbaccess
virtual bool rowDeleted( ) override;
// css::sdbc::XResultSet
virtual bool next() override;
virtual bool isBeforeFirst( ) override;
virtual bool isAfterLast( ) override;
virtual bool isBeforeFirst( );
virtual bool isAfterLast( );
virtual void beforeFirst( ) override;
virtual void afterLast( ) override;
virtual bool first() override;
......
......@@ -234,7 +234,8 @@ namespace dbaccess
void notifyAllListenersRowChanged(::osl::ResettableMutexGuard& _rGuard,const css::sdb::RowsChangeEvent& rEvt);
virtual bool notifyAllListenersCursorBeforeMove(::osl::ResettableMutexGuard& _rGuard) override;
virtual void notifyAllListenersCursorMoved(::osl::ResettableMutexGuard& _rGuard) override;
virtual void notifyAllListeners(::osl::ResettableMutexGuard& _rGuard) override;
// notify all that rowset changed
virtual void notifyAllListeners(::osl::ResettableMutexGuard& _rGuard);
virtual void doCancelModification( ) override;
virtual bool isModification( ) override;
......
......@@ -1201,10 +1201,6 @@ void ORowSetBase::notifyAllListenersCursorMoved(::osl::ResettableMutexGuard& /*_
{
}
void ORowSetBase::notifyAllListeners(::osl::ResettableMutexGuard& /*_rGuard*/)
{
}
bool ORowSetBase::isPropertyChangeNotificationEnabled() const
{
return true;
......
......@@ -126,8 +126,6 @@ namespace dbaccess
virtual bool notifyAllListenersCursorBeforeMove(::osl::ResettableMutexGuard& _rGuard);
// notify cursor moved
virtual void notifyAllListenersCursorMoved(::osl::ResettableMutexGuard& _rGuard);
// notify all that rowset changed
virtual void notifyAllListeners(::osl::ResettableMutexGuard& _rGuard);
// cancel the insertion, if necessary (means if we're on the insert row)
virtual void doCancelModification( ) = 0;
......
......@@ -53,8 +53,8 @@ namespace dbaccess
// css::sdbc::XResultSet
virtual bool next() override;
virtual bool isBeforeFirst( ) override;
virtual bool isAfterLast( ) override;
virtual bool isBeforeFirst( );
virtual bool isAfterLast( );
virtual void beforeFirst( ) override;
virtual void afterLast( ) override;
virtual bool first() override;
......
......@@ -125,11 +125,6 @@ void SAL_CALL OColumn::setName( const OUString& _rName )
m_sName = _rName;
}
void OColumn::fireValueChange(const ::connectivity::ORowSetValue& /*_rOldValue*/)
{
OSL_FAIL( "OColumn::fireValueChange: not implemented!" );
}
void OColumn::registerProperty( const OUString& _rName, sal_Int32 _nHandle, sal_Int32 _nAttributes, void* _pPointerToMember, const Type& _rMemberType )
{
::comphelper::OPropertyContainer::registerProperty( _rName, _nHandle, _nAttributes, _pPointerToMember, _rMemberType );
......
......@@ -103,8 +103,6 @@ namespace dbaccess
virtual OUString SAL_CALL getName( ) override;
virtual void SAL_CALL setName( const OUString& _rName ) override;
virtual void fireValueChange( const ::connectivity::ORowSetValue& _rOldValue );
protected:
// IPropertyContainer
virtual void registerProperty( const OUString& _rName, sal_Int32 _nHandle, sal_Int32 _nAttributes, void* _pPointerToMember, const css::uno::Type& _rMemberType ) override;
......
......@@ -50,17 +50,6 @@ namespace dbaccess
{
}
void StorageOutputStream::close()
{
ENSURE_OR_RETURN_VOID( m_xOutputStream.is(), "already closed" );
m_xOutputStream->closeOutput();
m_xOutputStream.clear();
// if you add additional functionality here, be aware that there are derived classes which
// (legitimately) do not call this method here.
}
} // namespace dbaccess
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
......@@ -40,10 +40,6 @@ namespace dbaccess
);
virtual ~StorageOutputStream();
/** simply calls closeOutput on our output stream, override to extend/modify this behavior
*/
virtual void close();
protected:
const css::uno::Reference< css::io::XOutputStream >&
getOutputStream() const { return m_xOutputStream; }
......
......@@ -43,8 +43,7 @@ namespace dbaccess
);
virtual ~StorageXMLOutputStream() override;
// StorageOutputStream overridables
virtual void close() override;
virtual void close();
void addAttribute( const OUString& i_rName, const OUString& i_rValue ) const;
......
......@@ -2607,10 +2607,6 @@ void SbaXDataBrowserController::addColumnListeners(const Reference< css::awt::XC
}
}
void SbaXDataBrowserController::InitializeGridModel(const Reference< css::form::XFormComponent > & /*xGrid*/)
{
}
} // namespace dbaui
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
......@@ -46,7 +46,7 @@ namespace dbaui
bool IsSourcePrimKey() const { return checkPrimaryKey(getReferencingTable()->getTable(),JTCS_FROM); }
bool IsDestPrimKey() const { return checkPrimaryKey(getReferencedTable()->getTable(),JTCS_TO); }
virtual OConnectionLineDataRef CreateLineDataObj() override;
virtual OConnectionLineDataRef CreateLineDataObj();
ORelationTableConnectionData& operator=( const ORelationTableConnectionData& rConnData );
public:
......
......@@ -45,8 +45,6 @@ namespace dbaui
void Init();
virtual OConnectionLineDataRef CreateLineDataObj();
OTableConnectionData& operator=( const OTableConnectionData& rConnData );
public:
OTableConnectionData();
......
......@@ -236,8 +236,6 @@ namespace dbaui
// do any initialization (data source etc.) here. the form should be fully functional after that.
// return sal_False if you didn't succeed (don't throw exceptions, they won't be caught)
virtual void InitializeGridModel(const css::uno::Reference< css::form::XFormComponent > & xGrid);
css::uno::Reference< css::form::XFormComponent > CreateGridModel();
// our default implementation simply instantiates a stardiv.one.form.component.Grid service
// you most probably don't want to override this behavior
......
......@@ -205,7 +205,7 @@ namespace dbaui
private:
// SbaXDataBrowserController overridables
virtual bool InitializeForm( const css::uno::Reference< css::beans::XPropertySet >& i_formProperties ) override;
virtual void InitializeGridModel(const css::uno::Reference< css::form::XFormComponent > & xGrid) override;
virtual void InitializeGridModel(const css::uno::Reference< css::form::XFormComponent > & xGrid);
virtual bool preReloadForm() override;
virtual void postReloadForm() override;
......
......@@ -33,7 +33,7 @@ namespace dbaui
bool m_bNatural;
// for creation and duplication of lines of own type
virtual OConnectionLineDataRef CreateLineDataObj() override;
virtual OConnectionLineDataRef CreateLineDataObj();
OQueryTableConnectionData& operator=( const OQueryTableConnectionData& rConnData );
public:
......
......@@ -120,11 +120,6 @@ void OTableConnectionData::ResetConnLines()
OConnectionLineDataVec().swap(m_vConnLineData);
}
OConnectionLineDataRef OTableConnectionData::CreateLineDataObj()
{
return new OConnectionLineData();
}
OTableConnectionData* OTableConnectionData::NewInstance() const
{
return new OTableConnectionData();
......
......@@ -63,14 +63,6 @@ int HBox::WSize()
}
hchar_string HBox::GetString()
{
hchar_string ret;
ret.push_back(hh);
return ret;
}
// skip block
SkipData::SkipData(hchar hch)
: HBox(hch)
......
......@@ -63,7 +63,6 @@ struct HBox
*/
virtual bool Read(HWPFile &hwpf);
virtual hchar_string GetString();
private:
static int boxCount;
};
......@@ -157,7 +156,7 @@ struct DateCode: public HBox
DateCode();
virtual bool Read(HWPFile &hwpf) override;
virtual hchar_string GetString() override;
virtual hchar_string GetString();
};
/**
......@@ -832,7 +831,7 @@ struct MailMerge: public HBox
MailMerge();
virtual bool Read(HWPFile &hwpf) override;
virtual hchar_string GetString() override;
virtual hchar_string GetString();
};
// char composition(23)
......
......@@ -102,7 +102,6 @@ public:
void SetName( const OString& rName );
virtual const OString & GetName() const { return aName; }
virtual bool Test( SvTokenStream & rInStm );
virtual bool ReadSvIdl( SvIdlDataBase &, SvTokenStream & rInStm );
};
......
......@@ -41,7 +41,7 @@ public:
const SvIdentifier& GetSlotId() const;
SvMetaType * GetType() const;
virtual bool Test( SvTokenStream & rInStm ) override;
virtual bool Test( SvTokenStream & rInStm );
virtual bool ReadSvIdl( SvIdlDataBase &, SvTokenStream & rInStm ) override;
sal_uLong MakeSfx( OStringBuffer& rAtrrArray ) const;
virtual void Insert( SvSlotElementList& );
......
......@@ -107,11 +107,6 @@ void SvMetaObject::ReadContextSvIdl( SvIdlDataBase &, SvTokenStream & )
{
}
bool SvMetaObject::Test( SvTokenStream & )
{
return true;
}
bool SvMetaObject::ReadSvIdl( SvIdlDataBase & rBase, SvTokenStream & rInStm )
{
sal_uInt32 nTokPos = rInStm.Tell();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment