loplugin:countusersofdefaultparams in oox..sd

Change-Id: I4504939a3957606979c6ac36af6611e1fe072d01
Reviewed-on: https://gerrit.libreoffice.org/27902Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

oox/inc/drawingml/chart/converterbase.hxx

@@ -88,7 +88,7 @@ protected:
     void                registerTitleLayout(
                             const css::uno::Reference< css::chart2::XTitle >& rxTitle,
                             const ModelRef< LayoutModel >& rxLayout, ObjectType eObjType,
-                            sal_Int32 nMainIdx = -1, sal_Int32 nSubIdx = -1 );
+                            sal_Int32 nMainIdx, sal_Int32 nSubIdx );
     /** Converts the positions of the main title and all axis titles. */
     void                convertTitlePositions();
 

oox/inc/drawingml/chart/objectformatter.hxx

@@ -139,7 +139,7 @@ public:
     void                convertAutomaticFill(
                             PropertySet& rPropSet,
                             ObjectType eObjType,
-                            sal_Int32 nSeriesIdx = -1 );
+                            sal_Int32 nSeriesIdx );
 
     /** Returns true, if the passed shape properties have automatic fill mode. */
     static bool         isAutomaticFill( const ModelRef< Shape >& rxShapeProp );

oox/inc/drawingml/shape3dproperties.hxx

@@ -78,7 +78,7 @@ struct Shape3DProperties
     css::uno::Sequence< css::beans::PropertyValue > getCameraAttributes();
     css::uno::Sequence< css::beans::PropertyValue > getLightRigAttributes();
     css::uno::Sequence< css::beans::PropertyValue > getShape3DAttributes(
-            const GraphicHelper& rGraphicHelper, sal_Int32 rPhClr = API_RGB_TRANSPARENT );
+            const GraphicHelper& rGraphicHelper, sal_Int32 rPhClr );
     static css::uno::Sequence< css::beans::PropertyValue > getBevelAttributes( BevelProperties rProps );
     static css::uno::Sequence< css::beans::PropertyValue > getColorAttributes(
             const Color& rColor, const GraphicHelper& rGraphicHelper, sal_Int32 rPhClr );

oox/inc/drawingml/textparagraph.hxx

@@ -59,8 +59,8 @@ public:
                                     const css::uno::Reference < css::text::XTextCursor > &xAt,
                                     const TextCharacterProperties& rTextStyleProperties,
                                     const TextListStyle& rTextListStyle,
-                                    bool bFirst = false,
-                                    float nDefaultCharHeight = 0) const;
+                                    bool bFirst,
+                                    float nDefaultCharHeight) const;
 
     bool HasMathXml() const
     {

oox/source/helper/propertymap.cxx

@@ -553,7 +553,7 @@ static void printParameterPairData(int level, EnhancedCustomShapeParameterPair &
     fprintf (stderr, "}");
 }
 
-static const char* lclDumpAnyValueCode( const Any& value, int level = 0)
+static const char* lclDumpAnyValueCode( const Any& value, int level)
 {
     OUString strValue;
     Sequence< OUString > strArray;

opencl/inc/opencl_device.hxx

@@ -14,7 +14,7 @@
 
 namespace opencl {
 
-ds_device const & getDeviceSelection(OUString const & pFileName, bool bForceSelection = false);
+ds_device const & getDeviceSelection(OUString const & pFileName, bool bForceSelection);
 
 struct GPUEnv;
 void releaseOpenCLEnv( GPUEnv *gpuInfo );

package/source/xstor/ohierarchyholder.hxx

@@ -87,7 +87,7 @@ public:
         GetStreamHierarchically( sal_Int32 nStorageMode,
                                 OStringList_Impl& aPath,
                                 sal_Int32 nStreamMode,
-                                const ::comphelper::SequenceAsHashMap& aEncryptionData = ::comphelper::SequenceAsHashMap() );
+                                const ::comphelper::SequenceAsHashMap& aEncryptionData );
 
     void RemoveStreamHierarchically( OStringList_Impl& aListPath );
 

registry/source/reflwrit.hxx

@@ -76,7 +76,7 @@ public:
                               const rtl::OUString&    doku,
                               const rtl::OUString&    fileName,
                               RTFieldAccess           access,
-                              const RTConstValue&     constValue = RTConstValue());
+                              const RTConstValue&     constValue);
 
     /** returns a pointer to the new type blob.
 

registry/source/regimpl.hxx

@@ -77,8 +77,8 @@ public:
 
     RegError    loadKey(RegKeyHandle hKey,
                         const OUString& regFileName,
-                        bool bWarings=false,
-                        bool bReport=false);
+                        bool bWarings,
+                        bool bReport);
 
     RegError    dumpRegistry(RegKeyHandle hKey) const;
 
@@ -109,14 +109,14 @@ private:
                                  ORegKey* pSourceKey,
                                  const OUString& valueName,
                                  sal_uInt32 nCut,
-                                 bool bWarnings=false,
-                                 bool bReport=false);
+                                 bool bWarnings,
+                                 bool bReport);
 
     static RegError checkBlop(store::OStoreStream& rValue,
                           const OUString& sTargetPath,
                           sal_uInt32 srcValueSize,
                           sal_uInt8* pSrcBuffer,
-                          bool bReport=false);
+                          bool bReport);
 
     static RegError mergeModuleValue(store::OStoreStream& rTargetValue,
                                  RegistryTypeReader& reader,
@@ -126,8 +126,8 @@ private:
                                 ORegKey* pSourceKey,
                                 const OUString& keyName,
                                 sal_uInt32 nCut,
-                                bool bWarnings=false,
-                                bool bReport=false);
+                                bool bWarnings,
+                                bool bReport);
 
     RegError    dumpValue(const OUString& sPath,
                           const OUString& sName,

reportdesign/source/core/inc/Section.hxx

@@ -139,7 +139,7 @@ namespace reportdesign
                 ,const css::uno::Reference< css::uno::XComponentContext >& context,bool _bPageSection=false);
         static css::uno::Reference< css::report::XSection>
         createOSection(const css::uno::Reference< css::report::XGroup >& _xParent
-                ,const css::uno::Reference< css::uno::XComponentContext >& context,bool _bPageSection=false);
+                ,const css::uno::Reference< css::uno::XComponentContext >& context, bool _bPageSection);
 
         DECLARE_XINTERFACE( )
 

reportdesign/source/ui/inc/ReportWindow.hxx

@@ -75,7 +75,7 @@ namespace rptui
         inline OScrollWindowHelper* getScrollWindow() const { return m_pParent; }
 
         void            SetMode( DlgEdMode m_eMode );
-        void            SetInsertObj( sal_uInt16 eObj,const OUString& _sShapeType = OUString());
+        void            SetInsertObj( sal_uInt16 eObj, const OUString& _sShapeType);
         OUString        GetInsertObjString() const;
         void            setGridSnap(bool bOn);
         void            setDragStripes(bool bOn);
@@ -121,7 +121,7 @@ namespace rptui
         */
         void            addSection(const css::uno::Reference< css::report::XSection >& _xSection
                                     ,const OUString& _sColorEntry
-                                    ,sal_uInt16 _nPosition = USHRT_MAX);
+                                    ,sal_uInt16 _nPosition);
 
         sal_uInt16          getSectionCount() const;
 

reportdesign/source/ui/inc/ScrollHelper.hxx

@@ -87,7 +87,7 @@ namespace rptui
 
         // forwards
         void                    SetMode( DlgEdMode _eMode );
-        void                    SetInsertObj( sal_uInt16 eObj,const OUString& _sShapeType = OUString());
+        void                    SetInsertObj( sal_uInt16 eObj,const OUString& _sShapeType);
         OUString                GetInsertObjString() const;
         void                    setGridSnap(bool bOn);
         void                    setDragStripes(bool bOn);
@@ -130,7 +130,7 @@ namespace rptui
         */
         void                    addSection(const css::uno::Reference< css::report::XSection >& _xSection
                                     ,const OUString& _sColorEntry
-                                    ,sal_uInt16 _nPosition = USHRT_MAX);
+                                    ,sal_uInt16 _nPosition);
 
         sal_uInt16                  getSectionCount() const;
 

reportdesign/source/ui/inc/ViewsWindow.hxx

@@ -129,7 +129,7 @@ namespace rptui
         */
         void            addSection(const css::uno::Reference< css::report::XSection >& _xSection
                                     ,const OUString& _sColorEntry
-                                    ,sal_uInt16 _nPosition = USHRT_MAX);
+                                    ,sal_uInt16 _nPosition);
 
         sal_uInt16          getSectionCount() const;
         /** return the section at the given position
@@ -153,7 +153,7 @@ namespace rptui
 
         inline bool     empty() const { return m_aSections.empty(); }
         void            SetMode( DlgEdMode m_eMode );
-        void            SetInsertObj( sal_uInt16 eObj,const OUString& _sShapeType = OUString());
+        void            SetInsertObj( sal_uInt16 eObj,const OUString& _sShapeType);
         const OUString& GetInsertObjString() const { return m_sShapeType;}
         /** copies the current selection in this section
         */
@@ -232,7 +232,7 @@ namespace rptui
 
         /** returns the current position in the list
         */
-        sal_uInt16 getPosition(const OSectionWindow* _pSectionWindow = nullptr) const;
+        sal_uInt16 getPosition(const OSectionWindow* _pSectionWindow) const;
 
         /** calls on every section BrkAction
         *

sal/osl/unx/file_stat.cxx

@@ -155,7 +155,7 @@ namespace
 
     /* we only need to call stat or lstat if one of the
        following flags is set */
-    inline bool is_stat_call_necessary(sal_uInt32 field_mask, oslFileType file_type = osl_File_Type_Unknown)
+    inline bool is_stat_call_necessary(sal_uInt32 field_mask, oslFileType file_type)
     {
         return (
                 ((field_mask & osl_FileStatus_Mask_Type) && (file_type == osl_File_Type_Unknown)) ||

sal/qa/rtl/process/rtl_Process.cxx

@@ -42,7 +42,7 @@ using ::rtl::OUStringToOString;
 
 /** print a UNI_CODE String. And also print some comments of the string.
 */
-inline void printUString( const ::rtl::OUString & str, const sal_Char * msg = nullptr )
+inline void printUString( const ::rtl::OUString & str, const sal_Char * msg )
 {
     if ( msg != nullptr )
     {

sax/source/tools/fastserializer.hxx

@@ -130,7 +130,7 @@ public:
 
         @param nTag debugging aid to ensure mark and merge match in LIFO order
      */
-    void mark(sal_Int32 nTag, const Int32Sequence& rOrder = Int32Sequence());
+    void mark(sal_Int32 nTag, const Int32Sequence& rOrder);
 
     /** Merge 2 topmost marks.
 
@@ -150,7 +150,7 @@ public:
         @see mark()
      */
     void mergeTopMarks(sal_Int32 nTag,
-        sax_fastparser::MergeMarks eMergeType = sax_fastparser::MergeMarks::APPEND);
+        sax_fastparser::MergeMarks eMergeType);
 
 private:
     /** Helper class to cache data and write in chunks to XOutputStream or ForMerge::append.

scaddins/source/analysis/analysishelper.cxx

@@ -1754,7 +1754,7 @@ OUString Complex::GetString() const throw( uno::RuntimeException, lang::IllegalA
     bool bHasReal = !bHasImag || (r != 0.0);
 
     if( bHasReal )
-        aRet.append(::GetString( r ));
+        aRet.append(::GetString( r, false ));
     if( bHasImag )
     {
         if( i == 1.0 )

scaddins/source/analysis/analysishelper.hxx

@@ -83,7 +83,7 @@ sal_Int32           GetDiffDate360( sal_Int32 nNullDate, sal_Int32 nDate1, sal_I
 sal_Int32           GetDaysInYears( sal_uInt16 nYear1, sal_uInt16 nYear2 );
 inline sal_Int16    GetDayOfWeek( sal_Int32 nDate );
 sal_Int32           GetDiffDate( sal_Int32 nNullDate, sal_Int32 nStartDate, sal_Int32 nEndDate, sal_Int32 nMode,
-                                sal_Int32* pOptDaysIn1stYear = nullptr ) throw( css::uno::RuntimeException, css::lang::IllegalArgumentException );
+                                sal_Int32* pOptDaysIn1stYear ) throw( css::uno::RuntimeException, css::lang::IllegalArgumentException );
 double              GetYearDiff( sal_Int32 nNullDate, sal_Int32 nStartDate, sal_Int32 nEndDate, sal_Int32 nMode )
                                 throw( css::uno::RuntimeException, css::lang::IllegalArgumentException );
 sal_Int32           GetDaysInYear( sal_Int32 nNullDate, sal_Int32 nDate, sal_Int32 nMode ) throw( css::uno::RuntimeException, css::lang::IllegalArgumentException );
@@ -101,7 +101,7 @@ OUString              ConvertFromDec(
 double              Erf( double fX );
 double              Erfc( double fX );
 bool                ParseDouble( const sal_Unicode*& rpDoubleAsString, double& rReturn );
-OUString            GetString( double fNumber, bool bLeadingSign = false, sal_uInt16 nMaxNumOfDigits = 15 );
+OUString            GetString( double fNumber, bool bLeadingSign, sal_uInt16 nMaxNumOfDigits = 15 );
 
 double              GetAmordegrc( sal_Int32 nNullDate, double fCost, sal_Int32 nDate, sal_Int32 nFirstPer,
                                 double fRestVal, double fPer, double fRate, sal_Int32 nBase ) throw( css::uno::RuntimeException, css::lang::IllegalArgumentException );
@@ -424,8 +424,8 @@ public:
                                 { return maVector.size(); }
 
     inline void             Append( Complex* pNew );
-    void                    Append( const css::uno::Sequence< css::uno::Sequence< OUString > >& rComplexNumList, ComplListAppendHandl eAH = AH_EmpyAs0 ) throw( css::uno::RuntimeException, css::lang::IllegalArgumentException );
-    void                    Append( const css::uno::Sequence< css::uno::Any >& aMultPars,ComplListAppendHandl eAH = AH_EmpyAs0 ) throw( css::uno::RuntimeException, css::lang::IllegalArgumentException );
+    void                    Append( const css::uno::Sequence< css::uno::Sequence< OUString > >& rComplexNumList, ComplListAppendHandl eAH ) throw( css::uno::RuntimeException, css::lang::IllegalArgumentException );
+    void                    Append( const css::uno::Sequence< css::uno::Any >& aMultPars,ComplListAppendHandl eAH ) throw( css::uno::RuntimeException, css::lang::IllegalArgumentException );
 };
 
 

scripting/source/vbaevents/eventhelper.cxx

@@ -620,7 +620,7 @@ protected:
 
 private:
     void setShellFromModel();
-    void firing_Impl( const  ScriptEvent& evt, Any *pSyncRet=nullptr ) throw( RuntimeException, std::exception );
+    void firing_Impl( const  ScriptEvent& evt, Any *pSyncRet ) throw( RuntimeException, std::exception );
 
     Reference< frame::XModel > m_xModel;
     bool m_bDocClosed;
@@ -672,7 +672,7 @@ EventListener::disposing(const lang::EventObject&)  throw( RuntimeException, std
 void SAL_CALL
 EventListener::firing(const ScriptEvent& evt) throw(RuntimeException, std::exception)
 {
-    firing_Impl( evt );
+    firing_Impl( evt, nullptr );
 }
 
 Any SAL_CALL

sd/inc/OutlinerIterator.hxx

@@ -235,7 +235,7 @@ private:
         SdDrawDocument* pDocument,
         const std::shared_ptr<ViewShell>& rpViewShell,
         bool bDirectionIsForward,
-        IteratorLocation aLocation=BEGIN);
+        IteratorLocation aLocation);
 
     /** Create an iterator that iterates over all <type>SdrObjects</type>
         objects of the <member>mpOutliner</member> outliner.
@@ -252,7 +252,7 @@ private:
         SdDrawDocument* pDocument,
         const std::shared_ptr<ViewShell>& rpViewShell,
         bool bDirectionIsForward,
-        IteratorLocation aLocation=BEGIN);
+        IteratorLocation aLocation);
 
     /** Return the index of a page that contains an object that a new
         iterator shall point to.  This page index depends primarily on the

sd/qa/unit/sdmodeltestbase.hxx

@@ -224,7 +224,7 @@ protected:
 
         @param bCreate Instead of comparing to the reference file(s), create it/them.
     */
-    void compareWithShapesDump( ::sd::DrawDocShellRef xDocShRef, const OUString &rShapesDumpFileNameBase, bool bCreate = false )
+    void compareWithShapesDump( ::sd::DrawDocShellRef xDocShRef, const OUString &rShapesDumpFileNameBase, bool bCreate )
     {
         CPPUNIT_ASSERT_MESSAGE( "failed to load", xDocShRef.Is() );
         CPPUNIT_ASSERT_MESSAGE( "not in destruction", !xDocShRef->IsInDestruction() );

sd/source/filter/eppt/eppt.hxx

@@ -198,7 +198,7 @@ class PPTWriter : public PPTWriterBase, public PPTExBulletProvider
         void                ImplWriteExtParaHeader( SvMemoryStream& rSt, sal_uInt32 nRef, sal_uInt32 nInstance, sal_uInt32 nSlideId );
 
         sal_uInt32          ImplProgBinaryTag( SvStream* pOutStrm );
-        sal_uInt32          ImplProgBinaryTagContainer( SvStream* pOutStrm, SvMemoryStream* pBinTag = nullptr );
+        sal_uInt32          ImplProgBinaryTagContainer( SvStream* pOutStrm, SvMemoryStream* pBinTag );
         sal_uInt32          ImplProgTagContainer( SvStream* pOutStrm, SvMemoryStream* pBinTag = nullptr );
         static sal_uInt32   ImplOutlineViewInfoContainer( SvStream* pOutStrm );
         static sal_uInt32   ImplSlideViewInfoContainer( sal_uInt32 nInstance, SvStream* pOutStrm );

sd/source/ui/inc/OutlineView.hxx

@@ -126,12 +126,12 @@ public:
         const AcceptDropEvent& rEvt,
         DropTargetHelper& rTargetHelper,
         ::sd::Window* pTargetWindow,
-        sal_uInt16 nPage = SDRPAGE_NOTFOUND,
+        sal_uInt16 nPage,
         sal_uInt16 nLayer = SDRPAGE_NOTFOUND) override;
     virtual sal_Int8 ExecuteDrop (
         const ExecuteDropEvent& rEvt,
         ::sd::Window* pTargetWindow,
-        sal_uInt16 nPage = SDRPAGE_NOTFOUND,
+        sal_uInt16 nPage,
         sal_uInt16 nLayer = SDRPAGE_NOTFOUND) override;
 
     // Re-implement GetScriptType for this view to get correct results

sd/source/ui/inc/View.hxx

@@ -101,12 +101,12 @@ public:
         const AcceptDropEvent& rEvt,
         DropTargetHelper& rTargetHelper,
         ::sd::Window* pTargetWindow,
-        sal_uInt16 nPage = SDRPAGE_NOTFOUND,
+        sal_uInt16 nPage,
         sal_uInt16 nLayer = SDRPAGE_NOTFOUND);
     virtual sal_Int8 ExecuteDrop (
         const ExecuteDropEvent& rEvt,
         ::sd::Window* pTargetWindow,
-        sal_uInt16 nPage = SDRPAGE_NOTFOUND,
+        sal_uInt16 nPage,
         sal_uInt16 nLayer = SDRPAGE_NOTFOUND);
 
     css::uno::Reference<css::datatransfer::XTransferable>

sd/source/ui/inc/optsitem.hxx

@@ -276,7 +276,7 @@ public:
     bool    IsPreviewTransitions() const { Init(); return bPreviewTransitions; }
 
     sal_Int32   GetDisplay() const;
-    void        SetDisplay( sal_Int32 nDisplay = 0 );
+    void        SetDisplay( sal_Int32 nDisplay );
 
     sal_Int32 GetPresentationPenColor() const { Init(); return mnPenColor; }
     void      SetPresentationPenColor( sal_Int32 nPenColor ) { if( mnPenColor != nPenColor ) { OptionsChanged(); mnPenColor = nPenColor; } }
@@ -304,7 +304,7 @@ public:
             hence the parameters name.  Use 0 for turning it off.  Other
             values are reserved for future use.
     */
-    void    SetPrinterIndependentLayout (sal_uInt16 nOn = 1 ){ if ( nOn != mnPrinterIndependentLayout ) { OptionsChanged(); mnPrinterIndependentLayout = nOn; } }
+    void    SetPrinterIndependentLayout (sal_uInt16 nOn ){ if ( nOn != mnPrinterIndependentLayout ) { OptionsChanged(); mnPrinterIndependentLayout = nOn; } }
     void    SetSolidDragging( bool bOn ) { if( bSolidDragging != bOn ) { OptionsChanged(); bSolidDragging = bOn; } }
     void    SetShowUndoDeleteWarning( bool bOn ) { if( bShowUndoDeleteWarning != bOn ) { OptionsChanged(); bShowUndoDeleteWarning = bOn; } }
     void    SetSlideshowRespectZOrder( bool bOn ) { if( bSlideshowRespectZOrder != bOn ) { OptionsChanged(); bSlideshowRespectZOrder = bOn; } }
@@ -376,13 +376,13 @@ public:
     sal_Int16   GetAngle() const { Init(); return nAngle; }
     sal_Int16   GetEliminatePolyPointLimitAngle() const { Init(); return nBezAngle; }
 
-    void    SetSnapHelplines( bool bOn = true ) { if( bSnapHelplines != bOn ) { OptionsChanged(); bSnapHelplines = bOn; } }
-    void    SetSnapBorder( bool bOn = true ) { if( bSnapBorder != bOn ) { OptionsChanged(); bSnapBorder = bOn; } }
-    void    SetSnapFrame( bool bOn = true ) { if( bSnapFrame != bOn ) { OptionsChanged(); bSnapFrame = bOn; } }
-    void    SetSnapPoints( bool bOn = true ) { if( bSnapPoints != bOn ) { OptionsChanged(); bSnapPoints = bOn; } }
-    void    SetOrtho( bool bOn = true ) { if( bOrtho != bOn ) { OptionsChanged(); bOrtho = bOn; } }
-    void    SetBigOrtho( bool bOn = true ) { if( bBigOrtho != bOn ) { OptionsChanged(); bBigOrtho = bOn; } }
-    void    SetRotate( bool bOn = true ) { if( bRotate != bOn ) { OptionsChanged(); bRotate = bOn; } }
+    void    SetSnapHelplines( bool bOn ) { if( bSnapHelplines != bOn ) { OptionsChanged(); bSnapHelplines = bOn; } }
+    void    SetSnapBorder( bool bOn ) { if( bSnapBorder != bOn ) { OptionsChanged(); bSnapBorder = bOn; } }
+    void    SetSnapFrame( bool bOn ) { if( bSnapFrame != bOn ) { OptionsChanged(); bSnapFrame = bOn; } }
+    void    SetSnapPoints( bool bOn ) { if( bSnapPoints != bOn ) { OptionsChanged(); bSnapPoints = bOn; } }
+    void    SetOrtho( bool bOn ) { if( bOrtho != bOn ) { OptionsChanged(); bOrtho = bOn; } }
+    void    SetBigOrtho( bool bOn ) { if( bBigOrtho != bOn ) { OptionsChanged(); bBigOrtho = bOn; } }
+    void    SetRotate( bool bOn ) { if( bRotate != bOn ) { OptionsChanged(); bRotate = bOn; } }
     void    SetSnapArea( sal_Int16 nIn ) { if( nSnapArea != nIn ) { OptionsChanged(); nSnapArea = nIn; } }
     void    SetAngle( sal_Int16 nIn ) { if( nAngle != nIn ) { OptionsChanged(); nAngle = nIn; } }
     void    SetEliminatePolyPointLimitAngle( sal_Int16 nIn ) { if( nBezAngle != nIn ) { OptionsChanged(); nBezAngle = nIn; } }

sd/source/ui/slidesorter/inc/controller/SlsClipboard.hxx

@@ -90,14 +90,14 @@ public:
         const AcceptDropEvent& rEvt,
         DropTargetHelper& rTargetHelper,
         ::sd::Window* pTargetWindow,
-        sal_uInt16 nPage = SDRPAGE_NOTFOUND,
+        sal_uInt16 nPage,
         sal_uInt16 nLayer = SDRPAGE_NOTFOUND );
 
     sal_Int8 ExecuteDrop (
         const ExecuteDropEvent& rEvt,
         DropTargetHelper& rTargetHelper,
         ::sd::Window* pTargetWindow,
-        sal_uInt16 nPage = SDRPAGE_NOTFOUND,
+        sal_uInt16 nPage,
         sal_uInt16 nLayer = SDRPAGE_NOTFOUND);
 
     void Abort();