loplugin:unusedfields

Change-Id: Iacce8e12a85f857192dc0520b795e1990a3612db
Reviewed-on: https://gerrit.libreoffice.org/61575
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

compilerplugins/clang/unusedfields.untouched.results

@@ -5,9 +5,9 @@ avmedia/source/vlc/wrapper/Types.hxx:44
 avmedia/source/vlc/wrapper/Types.hxx:45
     libvlc_event_t::(anonymous union)::(anonymous) dummy2 const char *
 avmedia/source/vlc/wrapper/Types.hxx:46
-    libvlc_event_t::(anonymous) padding struct (anonymous struct at /media/noel/disk2/libo6/avmedia/source/vlc/wrapper/Types.hxx:43:7)
+    libvlc_event_t::(anonymous) padding struct (anonymous struct at /media/noel/disk2/libo5/avmedia/source/vlc/wrapper/Types.hxx:43:7)
 avmedia/source/vlc/wrapper/Types.hxx:47
-    libvlc_event_t u union (anonymous union at /media/noel/disk2/libo6/avmedia/source/vlc/wrapper/Types.hxx:41:5)
+    libvlc_event_t u union (anonymous union at /media/noel/disk2/libo5/avmedia/source/vlc/wrapper/Types.hxx:41:5)
 avmedia/source/vlc/wrapper/Types.hxx:53
     libvlc_track_description_t psz_name char *
 basctl/source/inc/dlged.hxx:122
@@ -36,12 +36,10 @@ cppu/source/threadpool/threadpool.cxx:355
     _uno_ThreadPool dummy sal_Int32
 cppu/source/typelib/typelib.cxx:63
     AlignSize_Impl nInt16 sal_Int16
-cui/source/dialogs/colorpicker.cxx:721
+cui/source/dialogs/colorpicker.cxx:714
     cui::ColorPickerDialog m_xColorField std::unique_ptr<weld::CustomWeld>
-cui/source/dialogs/colorpicker.cxx:723
+cui/source/dialogs/colorpicker.cxx:716
     cui::ColorPickerDialog m_xColorPreview std::unique_ptr<weld::CustomWeld>
-cui/source/inc/align.hxx:89
-    svx::AlignmentTabPage m_xFtVerAlign std::unique_ptr<weld::Label>
 cui/source/inc/align.hxx:98
     svx::AlignmentTabPage m_xBoxDirection std::unique_ptr<weld::Widget>
 cui/source/inc/cfg.hxx:575
@@ -56,9 +54,9 @@ cui/source/inc/cuicharmap.hxx:108
     SvxCharacterMap m_xShowSetArea std::unique_ptr<weld::CustomWeld>
 cui/source/inc/cuicharmap.hxx:110
     SvxCharacterMap m_xSearchSetArea std::unique_ptr<weld::CustomWeld>
-cui/source/inc/cuigrfflt.hxx:84
+cui/source/inc/cuigrfflt.hxx:79
     GraphicFilterDialog mxPreview std::unique_ptr<weld::CustomWeld>
-cui/source/inc/cuigrfflt.hxx:180
+cui/source/inc/cuigrfflt.hxx:175
     GraphicFilterEmboss mxCtlLight std::unique_ptr<weld::CustomWeld>
 cui/source/inc/cuitabarea.hxx:709
     SvxColorTabPage m_xCtlPreviewOld std::unique_ptr<weld::CustomWeld>
@@ -88,13 +86,17 @@ cui/source/inc/transfrm.hxx:190
     SvxAngleTabPage m_xCtlRect std::unique_ptr<weld::CustomWeld>
 cui/source/inc/transfrm.hxx:193
     SvxAngleTabPage m_xCtlAngle std::unique_ptr<weld::CustomWeld>
+cui/source/tabpages/backgrnd.cxx:72
+    SvxBackgroundPage_Impl pLoadIdle std::unique_ptr<Idle>
+cui/source/tabpages/backgrnd.cxx:73
+    SvxBackgroundPage_Impl bIsImportDlgInExecute _Bool
 dbaccess/source/sdbtools/inc/connectiondependent.hxx:116
     sdbtools::ConnectionDependentComponent::EntryGuard m_aMutexGuard ::osl::MutexGuard
 emfio/source/emfuno/xemfparser.cxx:60
     emfio::emfreader::XEmfParser context_ uno::Reference<uno::XComponentContext>
 extensions/source/scanner/scanner.hxx:44
     ScannerManager maProtector osl::Mutex
-filter/source/pdf/impdialog.hxx:186
+filter/source/pdf/impdialog.hxx:178
     ImpPDFTabGeneralPage mxSelectedSheets std::unique_ptr<weld::Label>
 filter/source/xsltdialog/xmlfiltertabpagebasic.hxx:36
     XMLFilterTabPageBasic m_xContainer std::unique_ptr<weld::Widget>
@@ -118,8 +120,6 @@ include/sfx2/msg.hxx:117
     SfxType0 createSfxPoolItemFunc std::function<SfxPoolItem *(void)>
 include/sfx2/msg.hxx:119
     SfxType0 nAttribs sal_uInt16
-include/svl/broadcast.hxx:85
-    SvtBroadcaster mbDisposing _Bool
 include/svtools/ctrlbox.hxx:353
     SvtLineListBox m_xLineSetWin std::unique_ptr<weld::CustomWeld>
 include/svtools/genericunodialog.hxx:218
@@ -129,7 +129,7 @@ include/svtools/PlaceEditDialog.hxx:48
 include/svtools/unoevent.hxx:162
     SvEventDescriptor xParentRef css::uno::Reference<css::uno::XInterface>
 include/svx/ClassificationDialog.hxx:63
-    svx::ClassificationDialog m_nInsertMarkings sal_Int16
+    svx::ClassificationDialog m_nInsertMarkings const sal_Int16
 include/svx/colorwindow.hxx:132
     ColorWindow mxColorSetWin std::unique_ptr<weld::CustomWeld>
 include/svx/colorwindow.hxx:133
@@ -178,6 +178,10 @@ pyuno/source/module/pyuno_impl.hxx:224
     pyuno::(anonymous) ob_base PyObject
 pyuno/source/module/pyuno_impl.hxx:324
     pyuno::stRuntimeImpl ob_base PyObject
+reportdesign/source/ui/inc/PageNumber.hxx:38
+    rptui::OPageNumberDialog m_xPageN std::unique_ptr<weld::RadioButton>
+reportdesign/source/ui/inc/PageNumber.hxx:41
+    rptui::OPageNumberDialog m_xBottomPage std::unique_ptr<weld::RadioButton>
 reportdesign/source/ui/inc/ReportWindow.hxx:54
     rptui::OReportWindow m_pObjFac std::unique_ptr<DlgEdFactory, o3tl::default_delete<DlgEdFactory> >
 sal/osl/unx/thread.cxx:90
@@ -208,8 +212,6 @@ sc/source/filter/html/htmlpars.cxx:3030
     (anonymous namespace)::CSSHandler::MemStr mn size_t
 sc/source/filter/inc/sheetdatacontext.hxx:62
     oox::xls::SheetDataContext aReleaser class SolarMutexReleaser
-sc/source/ui/dataprovider/sqldataprovider.cxx:41
-    sc::SQLFetchThread maURL class rtl::OUString
 sc/source/ui/inc/crdlg.hxx:33
     ScColOrRowDlg m_xBtnRows std::unique_ptr<weld::RadioButton>
 sc/source/ui/inc/delcodlg.hxx:39
@@ -232,7 +234,7 @@ sd/source/ui/remotecontrol/ZeroconfService.hxx:36
     sd::ZeroconfService port uint
 sd/source/ui/slidesorter/view/SlsLayouter.cxx:61
     sd::slidesorter::view::Layouter::Implementation mpTheme std::shared_ptr<view::Theme>
-sd/source/ui/table/TableDesignPane.hxx:106
+sd/source/ui/table/TableDesignPane.hxx:104
     sd::TableDesignPane aImpl class sd::TableDesignWidget
 sd/source/ui/view/DocumentRenderer.cxx:1319
     sd::DocumentRenderer::Implementation mxObjectShell SfxObjectShellRef
@@ -269,33 +271,35 @@ starmath/inc/dialog.hxx:413
 starmath/inc/smmod.hxx:69
     SmModule mpLocSymbolData std::unique_ptr<SmLocalizedSymbolData>
 starmath/inc/view.hxx:218
-    SmViewShell maGraphicController class SmGraphicController
+    SmViewShell maGraphicController const class SmGraphicController
 starmath/source/accessibility.hxx:271
     SmEditSource rEditAcc class SmEditAccessible &
 svl/source/crypto/cryptosign.cxx:121
-    (anonymous namespace)::(anonymous) extnID SECItem
+    (anonymous namespace)::(anonymous) extnID const SECItem
 svl/source/crypto/cryptosign.cxx:122
-    (anonymous namespace)::(anonymous) critical SECItem
+    (anonymous namespace)::(anonymous) critical const SECItem
 svl/source/crypto/cryptosign.cxx:123
-    (anonymous namespace)::(anonymous) extnValue SECItem
+    (anonymous namespace)::(anonymous) extnValue const SECItem
 svl/source/crypto/cryptosign.cxx:281
     (anonymous namespace)::(anonymous) statusString SECItem
 svl/source/crypto/cryptosign.cxx:282
     (anonymous namespace)::(anonymous) failInfo SECItem
+svtools/source/filter/exportdialog.hxx:124
+    ExportDialog mxEncoding std::unique_ptr<weld::Widget>
 svtools/source/svhtml/htmlkywd.cxx:558
-    HTML_OptionEntry  union HTML_OptionEntry::(anonymous at /media/noel/disk2/libo6/svtools/source/svhtml/htmlkywd.cxx:558:5)
+    HTML_OptionEntry  union HTML_OptionEntry::(anonymous at /media/noel/disk2/libo5/svtools/source/svhtml/htmlkywd.cxx:558:5)
 svtools/source/svhtml/htmlkywd.cxx:560
     HTML_OptionEntry::(anonymous) sToken const sal_Char *
 svtools/source/svhtml/htmlkywd.cxx:561
     HTML_OptionEntry::(anonymous) pUToken const class rtl::OUString *
-svx/source/inc/datanavi.hxx:610
+svx/source/inc/datanavi.hxx:604
     svxform::AddInstanceDialog m_xURLFT std::unique_ptr<weld::Label>
 sw/source/core/crsr/crbm.cxx:64
-    (anonymous namespace)::CursorStateHelper m_aSaveState class SwCursorSaveState
+    (anonymous namespace)::CursorStateHelper m_aSaveState const class SwCursorSaveState
 sw/source/core/frmedt/fetab.cxx:79
     TableWait m_pWait const std::unique_ptr<SwWait>
 sw/source/core/layout/dbg_lay.cxx:170
-    SwImplEnterLeave nAction enum DbgAction
+    SwImplEnterLeave nAction const enum DbgAction
 sw/source/ui/config/mailconfigpage.cxx:56
     SwTestAccountSettingsDialog m_xEstablish std::unique_ptr<weld::Label>
 sw/source/ui/config/mailconfigpage.cxx:57
@@ -327,9 +331,9 @@ sw/source/uibase/inc/splittbl.hxx:30
 sw/source/uibase/inc/splittbl.hxx:31
     SwSplitTableDlg m_xContentCopyRB std::unique_ptr<weld::RadioButton>
 sw/source/uibase/inc/uivwimp.hxx:95
-    SwView_Impl xTmpSelDocSh class SfxObjectShellLock
+    SwView_Impl xTmpSelDocSh const class SfxObjectShellLock
 sw/source/uibase/inc/unodispatch.hxx:46
-    SwXDispatchProviderInterceptor::DispatchMutexLock_Impl aGuard class SolarMutexGuard
+    SwXDispatchProviderInterceptor::DispatchMutexLock_Impl aGuard const class SolarMutexGuard
 toolkit/source/awt/stylesettings.cxx:90
     toolkit::StyleMethodGuard m_aGuard const class SolarMutexGuard
 unoidl/source/unoidlprovider.cxx:672
@@ -354,7 +358,7 @@ vcl/unx/generic/print/prtsetup.hxx:73
     RTSPaperPage m_xContainer std::unique_ptr<weld::Widget>
 vcl/unx/generic/print/prtsetup.hxx:108
     RTSDevicePage m_xContainer std::unique_ptr<weld::Widget>
-vcl/unx/gtk3/gtk3gtkinst.cxx:2267
+vcl/unx/gtk3/gtk3gtkinst.cxx:2346
     CrippledViewport viewport GtkViewport
 vcl/unx/gtk/a11y/atkhypertext.cxx:29
     (anonymous) atk_hyper_link const AtkHyperlink

compilerplugins/clang/unusedfields.writeonly.results

@@ -56,9 +56,9 @@ canvas/source/cairo/cairo_spritehelper.hxx:103
     cairocanvas::SpriteHelper mbTextureDirty _Bool
 canvas/source/opengl/ogl_spritedevicehelper.hxx:124
     oglcanvas::SpriteDeviceHelper mpDevice css::rendering::XGraphicDevice *
-chart2/inc/ChartModel.hxx:472
+chart2/inc/ChartModel.hxx:470
     chart::ChartModel mnStart sal_Int32
-chart2/inc/ChartModel.hxx:473
+chart2/inc/ChartModel.hxx:471
     chart::ChartModel mnEnd sal_Int32
 chart2/source/controller/main/ElementSelector.hxx:37
     chart::ListBoxEntryData nHierarchyDepth sal_Int32
@@ -146,7 +146,7 @@ cui/source/inc/cuihyperdlg.hxx:57
     SvxHlinkCtrl aRdOnlyForwarder class SfxStatusForwarder
 cui/source/inc/cuihyperdlg.hxx:77
     SvxHpLinkDlg maCtrl class SvxHlinkCtrl
-dbaccess/source/core/dataaccess/documentdefinition.cxx:287
+dbaccess/source/core/dataaccess/documentdefinition.cxx:288
     dbaccess::LifetimeCoupler m_xClient Reference<class com::sun::star::uno::XInterface>
 desktop/qa/desktop_lib/test_desktop_lib.cxx:178
     DesktopLOKTest m_bModified _Bool
@@ -308,7 +308,7 @@ sc/inc/pivot.hxx:78
     ScDPLabelData mbIsValue _Bool
 sc/source/core/data/cellvalues.cxx:25
     sc::(anonymous namespace)::BlockPos mnEnd size_t
-sc/source/core/data/column4.cxx:1315
+sc/source/core/data/column4.cxx:1316
     (anonymous namespace)::StartListeningFormulaCellsHandler mnStartRow SCROW
 sc/source/filter/excel/xltoolbar.hxx:23
     TBCCmd cmdID sal_uInt16
@@ -414,6 +414,8 @@ svx/source/dialog/contimp.hxx:56
     SvxSuperContourDlg aContourItem class SvxContourDlgItem
 svx/source/form/dataaccessdescriptor.cxx:44
     svx::ODADescriptorImpl m_bSetOutOfDate _Bool
+svx/source/form/formcontroller.cxx:211
+    svxform::ColumnInfo nNullable sal_Int32
 svx/source/sidebar/line/LinePropertyPanel.hxx:97
     svx::sidebar::LinePropertyPanel maStyleControl sfx2::sidebar::ControllerItem
 svx/source/sidebar/line/LinePropertyPanel.hxx:98
@@ -432,12 +434,12 @@ svx/source/sidebar/line/LinePropertyPanel.hxx:105
     svx::sidebar::LinePropertyPanel maEdgeStyle sfx2::sidebar::ControllerItem
 svx/source/sidebar/line/LinePropertyPanel.hxx:106
     svx::sidebar::LinePropertyPanel maCapStyle sfx2::sidebar::ControllerItem
-svx/source/svdraw/svdpdf.hxx:197
+svx/source/svdraw/svdpdf.hxx:196
     ImpSdrPdfImport mdPageWidthPts double
 svx/source/table/tablertfimporter.cxx:54
     sdr::table::RTFCellDefault maItemSet class SfxItemSet
 sw/inc/shellio.hxx:147
-    SwReader aFileName class rtl::OUString
+    SwReader aFileName const class rtl::OUString
 sw/source/core/doc/tblafmt.cxx:186
     SwAfVersions m_nVerticalAlignmentVersion sal_uInt16
 sw/source/core/inc/swfont.hxx:973
@@ -451,11 +453,11 @@ sw/source/core/inc/swfont.hxx:976
 sw/source/core/inc/swfont.hxx:977
     SvStatistics nChangeFont sal_uInt16
 sw/source/filter/html/htmlcss1.cxx:77
-    SwCSS1ItemIds nFormatBreak sal_uInt16
+    SwCSS1ItemIds nFormatBreak const sal_uInt16
 sw/source/filter/html/htmlcss1.cxx:78
-    SwCSS1ItemIds nFormatPageDesc sal_uInt16
+    SwCSS1ItemIds nFormatPageDesc const sal_uInt16
 sw/source/filter/html/htmlcss1.cxx:79
-    SwCSS1ItemIds nFormatKeep sal_uInt16
+    SwCSS1ItemIds nFormatKeep const sal_uInt16
 sw/source/filter/inc/rtf.hxx:28
     RTFSurround::(anonymous union)::(anonymous) nGoldCut sal_uInt8
 sw/source/filter/inc/rtf.hxx:29
@@ -463,7 +465,7 @@ sw/source/filter/inc/rtf.hxx:29
 sw/source/filter/inc/rtf.hxx:30
     RTFSurround::(anonymous union)::(anonymous) nJunk sal_uInt8
 sw/source/filter/inc/rtf.hxx:31
-    RTFSurround::(anonymous) Flags struct (anonymous struct at /media/noel/disk2/libo6/sw/source/filter/inc/rtf.hxx:27:9)
+    RTFSurround::(anonymous) Flags struct (anonymous struct at /media/noel/disk2/libo5/sw/source/filter/inc/rtf.hxx:27:9)
 ucb/source/ucp/gio/gio_mount.hxx:46
     OOoMountOperationClass parent_class GMountOperationClass
 ucb/source/ucp/gio/gio_mount.hxx:49

cui/source/tabpages/backgrnd.cxx

@@ -67,12 +67,6 @@ const sal_uInt16 SvxBackgroundTabPage::pPageRanges[] =
     0
 };
 
-struct SvxBackgroundPage_Impl
-{
-    std::unique_ptr<Idle> pLoadIdle;
-    bool        bIsImportDlgInExecute = false;
-};
-
 /// Returns the fill style of the currently selected entry.
 static drawing::FillStyle lcl_getFillStyle(const weld::ComboBox& rLbSelect)
 {