tdf#116240: Include --with-help=html in installation sets

...by extending the hackery in helpcontent2/CustomTarget_html.mk (see comment
there).  (Ultimately, the gbuild HelpTarget machinery should probably be adapted
to the needs of this new help format, once the old help format is no longer
supported?)

The Perl packaging code finds source files through the "include" paths specified
in instsetoo_native/util/openoffice.lst.in.  To avoid potential name clashes,
put the new .filelist files into
workdir/CustomTarget/helpcontent2/help3xsl/filelists/html-help/ sub-directories.

read_filelist in solenv/bin/modules/installer/filelists.pm does not strip white
space following the last item in a file list, but (with HAVE_GNUMAKE_FILE_FUNC)
the gb_HelpTarget_get_translation_target .filelist files (which are then
transformed with sed into the .html .filelist files read by the Perl packaging
code) may contain such trailing white space.  So $(strip ...) their content in
solenv/gbuild/HelpTarget.mk.

This is the core part of a change spanning core and helpcontent2.

Change-Id: I82e0093ea2064725327330c5485f8e581573e1f2

Repository.mk

@@ -954,8 +954,6 @@ $(eval $(call gb_Helper_register_packages_for_install,ooo,\
     $(if $(and $(filter WNT,$(OS)), $(filter X86_64,$(CPUNAME))),twain_dsm) \
 	$(if $(ENABLE_HTMLHELP),\
 		helpcontent2_html_dynamic \
-		helpcontent2_html_lang \
-		helpcontent2_html_lang_generated \
 		helpcontent2_html_media \
 		helpcontent2_html_static \
 	) \

configure.ac

@@ -4715,6 +4715,7 @@ if test -n "$with_help" -a "$with_help" != "no" -a $_os != iOS -a $_os != Androi
         ;;
     "html")
         ENABLE_HTMLHELP=TRUE
+        SCPDEFS="$SCPDEFS -DWITH_HELP"
         AC_MSG_RESULT([HTML])
         ;;
     "online")

instsetoo_native/util/openoffice.lst.in

@@ -80,7 +80,7 @@ LibreOffice
         downloadname    LibreOffice_{productversion}_{os}_install_{languages}
         langpackdownloadname    LibreOffice_{productversion}_languagepack_{os}_install_{languages}
         helppackdownloadname    LibreOffice_{productversion}_helppack_{os}_install_{languages}
-        include         {installscriptdir},{customtargetpath}/readlicense_oo/readme,{customtargetpath}/sysui/{pkgtype},{customtargetpath}/setup_native,{filelistpath}/PackageSet,{filelistpath}/GeneratedPackage,{filelistpath}/Package,{filelistpath}/ExtensionPackage,{extensionsdir},{licensepath},{packinfopath}
+        include         {installscriptdir},{customtargetpath}/readlicense_oo/readme,{customtargetpath}/sysui/{pkgtype},{customtargetpath}/setup_native,{filelistpath}/PackageSet,{filelistpath}/GeneratedPackage,{filelistpath}/Package,{filelistpath}/ExtensionPackage,{filelistpath}/CustomTarget/helpcontent2/help3xsl/filelists,{extensionsdir},{licensepath},{packinfopath}
     }
 }
 
@@ -133,7 +133,7 @@ LibreOfficeDev
         downloadname    LibreOfficeDev_{productversion}_{os}_install_{languages}
         langpackdownloadname    LibreOfficeDev_{productversion}_languagepack_{os}_install_{languages}
         helppackdownloadname    LibreOfficeDev_{productversion}_helppack_{os}_install_{languages}
-        include         {installscriptdir},{customtargetpath}/readlicense_oo/readme,{customtargetpath}/sysui/{pkgtype},{customtargetpath}/setup_native,{filelistpath}/PackageSet,{filelistpath}/GeneratedPackage,{filelistpath}/Package,{filelistpath}/ExtensionPackage,{extensionsdir},{licensepath},{packinfopath}
+        include         {installscriptdir},{customtargetpath}/readlicense_oo/readme,{customtargetpath}/sysui/{pkgtype},{customtargetpath}/setup_native,{filelistpath}/PackageSet,{filelistpath}/GeneratedPackage,{filelistpath}/Package,{filelistpath}/ExtensionPackage,{filelistpath}/CustomTarget/helpcontent2/help3xsl/filelists,{extensionsdir},{licensepath},{packinfopath}
     }
 }
 

scp2/macros/macro.pl

@@ -188,11 +188,17 @@ sub write_MO_ALL_LANG_EXCEPT_EN_US_AND_QTZ
 sub write_EXTRA_ALL_GOOD_HELP_LOCALIZATIONS_LANG
 {
     my $first = 1;
+    my $source;
+    if ($ENV{'ENABLE_HTMLHELP'} eq 'TRUE') {
+        $source = 'html-help'; # found in instsetoo_native/util/openoffice.lst.in's {filelistpath}/CustomTarget/helpcontent2/help3xsl/filelists
+    } else {
+        $source = 'HelpTarget';
+    }
     print OUTFILE "#define EXTRA_ALL_GOOD_HELP_LOCALIZATIONS_LANG(name) ";
     foreach $lang (@helplangs) {
         print OUTFILE ";" unless $first;
         $first = 0;
-        print OUTFILE "\\\n\tName ($lang) = EXTRAFILELISTNAME(HelpTarget/,name,/$lang)";
+        print OUTFILE "\\\n\tName ($lang) = EXTRAFILELISTNAME($source/,name,/$lang)";
     }
     print OUTFILE "\n\n";
 }

solenv/gbuild/AllLangPackage.mk

@@ -108,4 +108,9 @@ $(foreach lang,$(gb_AllLangPackage_LANGS),$(call gb_Package_use_unpacked,$(1)_$(
 
 endef
 
+define gb_AllLangPackage_use_customtarget
+$(foreach lang,$(gb_AllLangPackage_LANGS),$(call gb_Package_use_customtarget,$(1)_$(lang),$(2)))
+
+endef
+
 # vim: set noet sw=4 ts=4:

solenv/gbuild/HelpTarget.mk

@@ -555,7 +555,7 @@ $(dir $(call gb_HelpTarget_get_target,%))%/.dir :
 # Translation of the module's .xhp files and all used modules is done.
 # Also creates the list for gb_HelpTarget_get_filelist.
 $(call gb_HelpTarget_get_translation_target,%) :
-	rm -f $@ && mv $(call var2file,$@.tmp,100,$(HELP_FILES)) $@
+	rm -f $@ && mv $(call var2file,$@.tmp,100,$(strip $(HELP_FILES))) $@
 
 # Translation of the module's .xhp files and all used and linked modules
 # is done.