loplugin:unusedfields

Change-Id: Idd0cdd38718c3822db4d4b94ca2315a416bc27bb
Reviewed-on: https://gerrit.libreoffice.org/50997Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

compilerplugins/clang/unusedfields.readonly.results

@@ -514,15 +514,13 @@ svx/source/inc/gridcell.hxx:525
     DbPatternField m_pValueFormatter ::std::unique_ptr< ::dbtools::FormattedColumnValue>
 svx/source/inc/gridcell.hxx:526
     DbPatternField m_pPaintFormatter ::std::unique_ptr< ::dbtools::FormattedColumnValue>
-svx/source/sidebar/possize/PosSizePropertyPanel.hxx:116
-    svx::sidebar::PosSizePropertyPanel maAnchorPos class Point
 sw/inc/acmplwrd.hxx:43
     SwAutoCompleteWord m_LookupTree editeng::Trie
 sw/inc/calc.hxx:162
     SwCalc m_aSysLocale class SvtSysLocale
 sw/inc/hints.hxx:188
     SwAttrSetChg m_bDelSet _Bool
-sw/inc/shellio.hxx:142
+sw/inc/shellio.hxx:140
     SwReader pStg tools::SvRef<SotStorage>
 sw/inc/swevent.hxx:74
     SwCallMouseEvent::(anonymous union)::(anonymous) pFormat const class SwFrameFormat *
@@ -548,8 +546,6 @@ sw/source/uibase/dbui/mmconfigitem.cxx:108
     SwMailMergeConfigItem_Impl m_aMaleGreetingLines std::vector<OUString>
 sw/source/uibase/dbui/mmconfigitem.cxx:110
     SwMailMergeConfigItem_Impl m_aNeutralGreetingLines std::vector<OUString>
-sw/source/uibase/inc/break.hxx:46
-    SwBreakDlg aTemplate class rtl::OUString
 sw/source/uibase/inc/fldmgr.hxx:77
     SwInsertField_Data m_aDBDataSource css::uno::Any
 sw/source/uibase/inc/labimg.hxx:49
@@ -604,8 +600,6 @@ unotools/source/config/saveopt.cxx:78
     SvtSaveOptions_Impl bROUserAutoSave _Bool
 vcl/inc/printerinfomanager.hxx:73
     psp::PrinterInfoManager::SystemPrintQueue m_aComment class rtl::OUString
-vcl/inc/sallayout.hxx:344
-    GenericSalLayout maBasePoint class Point
 vcl/inc/salwtype.hxx:153
     SalWheelMouseEvent mbDeltaIsPixel _Bool
 vcl/inc/salwtype.hxx:189
@@ -632,8 +626,6 @@ vcl/inc/unx/i18n_status.hxx:56
     vcl::I18NStatus m_aCurrentIM class rtl::OUString
 vcl/inc/unx/saldisp.hxx:266
     SalDisplay m_aInvalidScreenData struct SalDisplay::ScreenData
-vcl/source/edit/vclmedit.cxx:45
-    ImpVclMEdit maTextWindowOffset class Point
 vcl/source/filter/jpeg/Exif.hxx:62
     Exif::TiffHeader byteOrder sal_uInt16
 vcl/source/filter/jpeg/transupp.h:132

compilerplugins/clang/unusedfields.untouched.results

@@ -22,8 +22,6 @@ canvas/source/vcl/impltools.hxx:117
     vclcanvas::tools::LocalGuard aSolarGuard class SolarMutexGuard
 chart2/source/controller/inc/RangeSelectionListener.hxx:62
     chart::RangeSelectionListener m_aControllerLockGuard class chart::ControllerLockGuardUNO
-chart2/source/model/template/ChartType.hxx:127
-    chart::ChartType m_xContext const css::uno::Reference<css::uno::XComponentContext>
 chart2/source/view/inc/GL3DRenderer.hxx:54
     chart::opengl3D::MaterialParameters pad float
 chart2/source/view/inc/GL3DRenderer.hxx:55
@@ -78,6 +76,8 @@ include/svtools/unoevent.hxx:162
     SvEventDescriptor xParentRef css::uno::Reference<css::uno::XInterface>
 include/svx/ClassificationDialog.hxx:63
     svx::ClassificationDialog m_nInsertMarkings sal_Int16
+include/svx/unoshape.hxx:676
+    SvxGraphicObject referer_ class rtl::OUString
 include/vcl/pdfwriter.hxx:549
     vcl::PDFWriter::PDFSignContext m_pDerEncoded sal_Int8 *
 include/vcl/pdfwriter.hxx:551

compilerplugins/clang/unusedfields.writeonly.results

@@ -84,8 +84,6 @@ codemaker/source/cppumaker/dependencies.hxx:115
     codemaker::cppumaker::Dependencies m_doubleDependency _Bool
 configmgr/source/components.cxx:162
     configmgr::Components::WriteThread reference_ rtl::Reference<WriteThread> *
-connectivity/source/drivers/firebird/Connection.hxx:77
-    connectivity::firebird::Connection m_xDriver ::rtl::Reference<FirebirdDriver>
 connectivity/source/drivers/mork/MorkParser.hxx:133
     MorkParser error_ enum MorkErrors
 connectivity/source/inc/dbase/DTable.hxx:62
@@ -262,6 +260,8 @@ include/xmloff/shapeimport.hxx:181
     SdXML3DSceneAttributesHelper mbVPNUsed _Bool
 include/xmloff/shapeimport.hxx:182
     SdXML3DSceneAttributesHelper mbVUPUsed _Bool
+include/xmloff/xmlimp.hxx:241
+    SvXMLImport mbIsGraphicLoadOnDemandSupported _Bool
 l10ntools/inc/common.hxx:31
     common::HandledArgs m_bUTF8BOM _Bool
 libreofficekit/qa/gtktiledviewer/gtv-application-window.hxx:61
@@ -466,7 +466,7 @@ svx/source/sidebar/line/LinePropertyPanel.hxx:106
     svx::sidebar::LinePropertyPanel maCapStyle sfx2::sidebar::ControllerItem
 svx/source/table/tablertfimporter.cxx:53
     sdr::table::RTFCellDefault maItemSet class SfxItemSet
-sw/inc/shellio.hxx:147
+sw/inc/shellio.hxx:145
     SwReader aFileName class rtl::OUString
 sw/source/core/doc/tblafmt.cxx:184
     SwAfVersions m_nVerticalAlignmentVersion sal_uInt16
@@ -538,7 +538,7 @@ vcl/inc/salwtype.hxx:242
     SalInputContext mpFont class FontSelectPattern *
 vcl/inc/salwtype.hxx:250
     SalSwipeEvent mnVelocityY double
-vcl/inc/sft.hxx:468
+vcl/inc/sft.hxx:463
     vcl::TrueTypeFont mapper sal_uInt32 (*)(const sal_uInt8 *, sal_uInt32, sal_uInt32)
 vcl/opengl/salbmp.cxx:426
     (anonymous namespace)::ScanlineWriter mpCurrentScanline sal_uInt8 *

include/xmloff/xmlimp.hxx

@@ -238,7 +238,6 @@ class XMLOFF_DLLPUBLIC SvXMLImport : public cppu::WeakImplHelper<
 protected:
     bool                        mbIsFormsSupported;
     bool                        mbIsTableShapeSupported;
-    bool                        mbIsGraphicLoadOnDemandSupported;
 
     // Create top-level element context.
     // This method is called after the namespace map has been updated, but

xmloff/source/chart/SchXMLImport.cxx

@@ -497,8 +497,6 @@ SchXMLImport::SchXMLImport(
 {
     GetNamespaceMap().Add( GetXMLToken(XML_NP_XLINK), GetXMLToken(XML_N_XLINK), XML_NAMESPACE_XLINK );
     GetNamespaceMap().Add( GetXMLToken(XML_NP_CHART_EXT), GetXMLToken(XML_N_CHART_EXT), XML_NAMESPACE_CHART_EXT);
-
-    mbIsGraphicLoadOnDemandSupported = false;
 }
 
 SchXMLImport::~SchXMLImport() throw ()

xmloff/source/core/xmlimp.cxx

@@ -399,8 +399,7 @@ SvXMLImport::SvXMLImport(
     maNamespaceHandler( new SvXMLImportFastNamespaceHandler() ),
     mxFastDocumentHandler( nullptr ),
     mbIsFormsSupported( true ),
-    mbIsTableShapeSupported( false ),
-    mbIsGraphicLoadOnDemandSupported( true )
+    mbIsTableShapeSupported( false )
 {
     SAL_WARN_IF( !xContext.is(), "xmloff.core", "got no service manager" );
     InitCtor_();