loplugin:simplifyconstruct in stoc..svl

Change-Id: I81d465d66a979e9a1e092e5d23ed339840d1fb2d
Reviewed-on: https://gerrit.libreoffice.org/60315
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

include/svl/ondemand.hxx

@@ -213,7 +213,6 @@ public:
                                 OnDemandTransliterationWrapper()
                                     : eLanguage( LANGUAGE_SYSTEM )
                                     , nType(TransliterationFlags::NONE)
-                                    , pPtr(nullptr)
                                     , bValid(false)
                                     , bInitialized(false)
                                     {}
@@ -268,7 +267,6 @@ class OnDemandNativeNumberWrapper
 
 public:
                                 OnDemandNativeNumberWrapper()
-                                    : pPtr(nullptr)
                                     {}
 
             void                init(

stoc/source/corereflection/base.hxx

@@ -213,7 +213,6 @@ public:
                            const OUString & rName, typelib_TypeClass eTypeClass,
                            typelib_TypeDescription * pTypeDescr )
         : IdlClassImpl( pReflection, rName, eTypeClass, pTypeDescr )
-        , _pSortedMemberInit( nullptr )
         , _nMethods( 0 )
         , _nAttributes( 0 )
         {}
@@ -249,7 +248,6 @@ public:
                           const OUString & rName, typelib_TypeClass eTypeClass,
                           typelib_TypeDescription * pTypeDescr )
         : IdlClassImpl( pReflection, rName, eTypeClass, pTypeDescr )
-        , _pFields( nullptr )
         {}
     virtual ~CompoundIdlClassImpl() override;
 
@@ -312,7 +310,6 @@ public:
                       const OUString & rName, typelib_TypeClass eTypeClass,
                       typelib_TypeDescription * pTypeDescr )
         : IdlClassImpl( pReflection, rName, eTypeClass, pTypeDescr )
-        , _pFields( nullptr )
         {}
     virtual ~EnumIdlClassImpl() override;
 

store/source/storbios.cxx

@@ -531,9 +531,7 @@ OStorePageBIOS::AceCache::destroy (OStorePageBIOS::Ace * ace)
  * OStorePageBIOS.
  */
 OStorePageBIOS::OStorePageBIOS()
-    : m_xLockBytes (nullptr),
-      m_pSuper     (nullptr),
-      m_bWriteable (false)
+    : m_bWriteable (false)
 {
 }
 

svgio/source/svgreader/svganode.cxx

@@ -27,8 +27,7 @@ namespace svgio
             SvgDocument& rDocument,
             SvgNode* pParent)
         :   SvgNode(SVGTokenA, rDocument, pParent),
-            maSvgStyleAttributes(*this),
-            mpaTransform(nullptr)
+            maSvgStyleAttributes(*this)
         {
         }
 

svgio/source/svgreader/svgcirclenode.cxx

@@ -32,8 +32,7 @@ namespace svgio
             maSvgStyleAttributes(*this),
             maCx(0),
             maCy(0),
-            maR(0),
-            mpaTransform(nullptr)
+            maR(0)
         {
         }
 

svgio/source/svgreader/svgclippathnode.cxx

@@ -35,7 +35,6 @@ namespace svgio
             SvgNode* pParent)
         :   SvgNode(SVGTokenClipPathNode, rDocument, pParent),
             maSvgStyleAttributes(*this),
-            mpaTransform(nullptr),
             maClipPathUnits(userSpaceOnUse)
         {
         }

svgio/source/svgreader/svgellipsenode.cxx

@@ -33,8 +33,7 @@ namespace svgio
             maCx(0),
             maCy(0),
             maRx(0),
-            maRy(0),
-            mpaTransform(nullptr)
+            maRy(0)
         {
         }
 

svgio/source/svgreader/svggnode.cxx

@@ -28,8 +28,7 @@ namespace svgio
             SvgDocument& rDocument,
             SvgNode* pParent)
         :   SvgNode(aType, rDocument, pParent),
-            maSvgStyleAttributes(*this),
-            mpaTransform(nullptr)
+            maSvgStyleAttributes(*this)
         {
             OSL_ENSURE(aType == SVGTokenDefs || aType == SVGTokenG, "SvgGNode should only be used for Group and Defs (!)");
         }

svgio/source/svgreader/svggradientnode.cxx

@@ -50,7 +50,6 @@ namespace svgio
             maFy(),
             maGradientUnits(objectBoundingBox),
             maSpreadMethod(drawinglayer::primitive2d::SpreadMethod::Pad),
-            mpaGradientTransform(nullptr),
             mbResolvingLink(false),
             maXLink(),
             mpXLink(nullptr)

svgio/source/svgreader/svgimagenode.cxx

@@ -45,7 +45,6 @@ namespace svgio
         :   SvgNode(SVGTokenRect, rDocument, pParent),
             maSvgStyleAttributes(*this),
             maSvgAspectRatio(),
-            mpaTransform(nullptr),
             maX(0),
             maY(0),
             maWidth(0),

svgio/source/svgreader/svglinenode.cxx

@@ -33,8 +33,7 @@ namespace svgio
             maX1(0),
             maY1(0),
             maX2(0),
-            maY2(0),
-            mpaTransform(nullptr)
+            maY2(0)
         {
         }
 

svgio/source/svgreader/svgmarkernode.cxx

@@ -29,7 +29,6 @@ namespace svgio
         :   SvgNode(SVGTokenMarker, rDocument, pParent),
             aPrimitives(),
             maSvgStyleAttributes(*this),
-            mpViewBox(nullptr),
             maSvgAspectRatio(),
             maRefX(0),
             maRefY(0),

svgio/source/svgreader/svgmasknode.cxx

@@ -40,7 +40,6 @@ namespace svgio
             maY(SvgNumber(-10.0, Unit_percent, true)),
             maWidth(SvgNumber(120.0, Unit_percent, true)),
             maHeight(SvgNumber(120.0, Unit_percent, true)),
-            mpaTransform(nullptr),
             maMaskUnits(objectBoundingBox),
             maMaskContentUnits(userSpaceOnUse)
         {

svgio/source/svgreader/svgnode.cxx

@@ -266,7 +266,6 @@ namespace svgio
             maXmlSpace(XmlSpace_notset),
             maDisplay(Display_inline),
             maCssStyleVector(),
-            mpLocalCssStyle(nullptr),
             mbDecomposing(false),
             mbCssStyleVectorBuilt(false)
         {

svgio/source/svgreader/svgpathnode.cxx

@@ -29,8 +29,6 @@ namespace svgio
             SvgNode* pParent)
         :   SvgNode(SVGTokenPath, rDocument, pParent),
             maSvgStyleAttributes(*this),
-            mpPolyPolygon(nullptr),
-            mpaTransform(nullptr),
             maPathLength()
         {
         }

svgio/source/svgreader/svgpatternnode.cxx

@@ -38,15 +38,11 @@ namespace svgio
         :   SvgNode(SVGTokenPattern, rDocument, pParent),
             aPrimitives(),
             maSvgStyleAttributes(*this),
-            mpViewBox(nullptr),
             maSvgAspectRatio(),
             maX(),
             maY(),
             maWidth(),
             maHeight(),
-            mpPatternUnits(nullptr),
-            mpPatternContentUnits(nullptr),
-            mpaPatternTransform(nullptr),
             mbResolvingLink(false),
             maXLink(),
             mpXLink(nullptr)

svgio/source/svgreader/svgpolynode.cxx

@@ -32,8 +32,6 @@ namespace svgio
             bool bIsPolyline)
         :   SvgNode(SVGTokenPolygon, rDocument, pParent),
             maSvgStyleAttributes(*this),
-            mpPolygon(nullptr),
-            mpaTransform(nullptr),
             mbIsPolyline(bIsPolyline)
         {
         }

svgio/source/svgreader/svgrectnode.cxx

@@ -35,8 +35,7 @@ namespace svgio
             maWidth(0),
             maHeight(0),
             maRx(0),
-            maRy(0),
-            mpaTransform(nullptr)
+            maRy(0)
         {
         }
 

svgio/source/svgreader/svgsvgnode.cxx

@@ -37,7 +37,6 @@ namespace svgio
             SvgNode* pParent)
         :   SvgNode(SVGTokenSvg, rDocument, pParent),
             maSvgStyleAttributes(*this),
-            mpViewBox(nullptr),
             maSvgAspectRatio(),
             maX(),
             maY(),

svgio/source/svgreader/svgsymbolnode.cxx

@@ -30,7 +30,6 @@ namespace svgio
             SvgNode* pParent)
         :   SvgNode(SVGTokenSvg, rDocument, pParent),
             maSvgStyleAttributes(*this),
-            mpViewBox(nullptr),
             maSvgAspectRatio()
         {
         }

svgio/source/svgreader/svgtextnode.cxx

@@ -35,7 +35,6 @@ namespace svgio
             SvgNode* pParent)
         :   SvgNode(SVGTokenText, rDocument, pParent),
             maSvgStyleAttributes(*this),
-            mpaTransform(nullptr),
             maSvgTextPositions()
         {
         }

svgio/source/svgreader/svgtextpathnode.cxx

@@ -120,7 +120,6 @@ namespace svgio
             mnMaxIndex(rPolygon.isClosed() ? rPolygon.count() : rPolygon.count() - 1),
             mnIndex(0),
             maCurrentSegment(),
-            mpB2DCubicBezierHelper(nullptr),
             mfCurrentSegmentLength(0.0),
             mfSegmentStartPosition(0.0)
         {

svgio/source/svgreader/svgusenode.cxx

@@ -30,7 +30,6 @@ namespace svgio
             SvgNode* pParent)
         :   SvgNode(SVGTokenG, rDocument, pParent),
             maSvgStyleAttributes(*this),
-            mpaTransform(nullptr),
             maX(),
             maY(),
             maWidth(),

svl/source/fsstor/fsstorage.cxx

@@ -82,8 +82,6 @@ struct FSStorage_Impl
     : m_aURL( aContent.getURL() )
     , m_aContent( aContent )
     , m_nMode( nMode )
-    , m_pListenersContainer( nullptr )
-    , m_pTypeCollection( nullptr )
     , m_xContext( xContext )
     {
         OSL_ENSURE( !m_aURL.isEmpty(), "The URL must not be empty" );

svl/source/fsstor/oinputstreamcontainer.cxx

@@ -29,7 +29,6 @@ OFSInputStreamContainer::OFSInputStreamContainer( const uno::Reference< io::XInp
 , m_xSeekable( xStream, uno::UNO_QUERY )
 , m_bSeekable( false )
 , m_bDisposed( false )
-, m_pListenersContainer( nullptr )
 {
     m_bSeekable = m_xSeekable.is();
 }

svl/source/fsstor/ostreamcontainer.cxx

@@ -28,7 +28,6 @@ OFSStreamContainer::OFSStreamContainer( const uno::Reference < io::XStream >& xS
 : m_bDisposed( false )
 , m_bInputClosed( false )
 , m_bOutputClosed( false )
-, m_pListenersContainer( nullptr )
 , m_pTypeCollection( nullptr )
 {
     try

svl/source/inc/poolio.hxx

@@ -85,7 +85,6 @@ struct SfxItemPool_Impl
         , mpStaticDefaults(nullptr)
         , mpMaster(pMaster)
         , mpSecondary(nullptr)
-        , mpPoolRanges(nullptr)
         , mnStart(nStart)
         , mnEnd(nEnd)
         , eDefMetric(MapUnit::MapCM)

svl/source/items/aeitem.cxx

@@ -33,8 +33,7 @@ class SfxAllEnumValueArr : public std::vector<SfxAllEnumValue_Impl> {};
 
 
 SfxAllEnumItem::SfxAllEnumItem(sal_uInt16 which, sal_uInt16 nVal):
-    SfxAllEnumItem_Base(which, nVal),
-    pValues( nullptr )
+    SfxAllEnumItem_Base(which, nVal)
 {
     InsertValue( nVal );
 }

svl/source/items/itemset.cxx

@@ -171,7 +171,6 @@ SfxItemSet::SfxItemSet(
 SfxItemSet::SfxItemSet( SfxItemPool& rPool, const sal_uInt16* pWhichPairTable )
     : m_pPool(&rPool)
     , m_pParent(nullptr)
-    , m_pItems(nullptr)
     , m_pWhichRanges(nullptr)
     , m_nCount(0)
 {

svl/source/items/stylepool.cxx

@@ -47,7 +47,6 @@ namespace {
         Node() // root node Ctor
             : mChildren(),
               maItemSet(),
-              mpItem( nullptr ),
               mpUpper( nullptr ),
               mbIsItemIgnorable( false )
         {}

svl/source/misc/strmadpt.cxx

@@ -319,7 +319,6 @@ void SvInputStream::SetSize(sal_uInt64)
 
 SvInputStream::SvInputStream( css::uno::Reference< css::io::XInputStream > const & rTheStream):
     m_xStream(rTheStream),
-    m_pPipe(nullptr),
     m_nSeekedFrom(STREAM_SEEK_TO_END)
 {
     SetBufferSize(0);

svl/source/numbers/supservs.cxx

@@ -39,8 +39,7 @@ using namespace ::utl;
 
 
 SvNumberFormatsSupplierServiceObject::SvNumberFormatsSupplierServiceObject(const css::uno::Reference< css::uno::XComponentContext >& _rxORB)
-    :m_pOwnFormatter(nullptr)
-    ,m_xORB(_rxORB)
+    :m_xORB(_rxORB)
 {
 }
 

svl/source/numbers/zforfind.cxx

@@ -70,14 +70,6 @@ static const sal_Int16 kDefaultEra = 1;     // Gregorian CE, positive year
 
 ImpSvNumberInputScan::ImpSvNumberInputScan( SvNumberFormatter* pFormatterP )
         :
-        pUpperMonthText( nullptr ),
-        pUpperAbbrevMonthText( nullptr ),
-        pUpperGenitiveMonthText( nullptr ),
-        pUpperGenitiveAbbrevMonthText( nullptr ),
-        pUpperPartitiveMonthText( nullptr ),
-        pUpperPartitiveAbbrevMonthText( nullptr ),
-        pUpperDayText( nullptr ),
-        pUpperAbbrevDayText( nullptr ),
         bTextInitialized( false ),
         bScanGenitiveMonths( false ),
         bScanPartitiveMonths( false ),

svl/source/passwordcontainer/passwordcontainer.cxx

@@ -369,8 +369,7 @@ void StorageItem::ImplCommit()
 }
 
 
-PasswordContainer::PasswordContainer( const Reference<XMultiServiceFactory>& xServiceFactory ):
-    m_pStorageFile( nullptr )
+PasswordContainer::PasswordContainer( const Reference<XMultiServiceFactory>& xServiceFactory )
 {
     // m_pStorageFile->Notify() can be called
     ::osl::MutexGuard aGuard( mMutex );

svl/unx/source/svdde/ddedummy.cxx

@@ -91,7 +91,6 @@ long DdeConnection::GetError()
 DdeConnection::DdeConnection( const OUString&, const OUString& )
     : pService(nullptr)
     , pTopic(nullptr)
-    , pImp(nullptr)
 {
 }