setup_native: MSVC: pragma warning: make more specific, remove obsolete

Change-Id: Ie9f63d982acf368d27bb5b97728b060a80e8bd67
Reviewed-on: https://gerrit.libreoffice.org/49047Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

setup_native/source/win32/customactions/indexingfilter/restartindexingservice.cxx

@@ -26,15 +26,9 @@
     the service we do nothing.
 */
 
-#ifdef _MSC_VER
-#pragma warning(push, 1) /* disable warnings within system headers */
-#endif
 #define WIN32_LEAN_AND_MEAN
 #include <windows.h>
 #include <msiquery.h>
-#ifdef _MSC_VER
-#pragma warning(pop)
-#endif
 
 /*
     Advapi.dll needs to be loaded dynamically because the service

setup_native/source/win32/customactions/quickstarter/quickstarter.cxx

@@ -19,13 +19,7 @@
 
 #include "quickstarter.hxx"
 
-#ifdef _MSC_VER
-#pragma warning(push, 1) /* disable warnings within system headers */
-#endif
 #include <psapi.h>
-#ifdef _MSC_VER
-#pragma warning(pop)
-#endif
 
 #include <malloc.h>
 

setup_native/source/win32/customactions/quickstarter/quickstarter.hxx

@@ -20,15 +20,9 @@
 #ifndef INCLUDED_SETUP_NATIVE_SOURCE_WIN32_CUSTOMACTIONS_QUICKSTARTER_QUICKSTARTER_HXX
 #define INCLUDED_SETUP_NATIVE_SOURCE_WIN32_CUSTOMACTIONS_QUICKSTARTER_QUICKSTARTER_HXX
 
-#ifdef _MSC_VER
-#pragma warning(push, 1) /* disable warnings within system headers */
-#endif
 #define WIN32_LEAN_AND_MEAN
 #include <windows.h>
 #include <msiquery.h>
-#ifdef _MSC_VER
-#pragma warning(pop)
-#endif
 
 #include <string>
 

setup_native/source/win32/customactions/quickstarter/remove_quickstart_link.cxx

@@ -19,14 +19,7 @@
 
 #include "quickstarter.hxx"
 
-#ifdef _MSC_VER
-#pragma warning(push, 1) /* disable warnings within system headers */
-#pragma warning(disable: 4917)
-#endif
 #include <shlobj.h>
-#ifdef _MSC_VER
-#pragma warning(pop)
-#endif
 
 extern "C" UINT __stdcall RemoveQuickstarterLink( MSIHANDLE hMSI )
 {

setup_native/source/win32/customactions/reg4allmsdoc/reg4allmsi.cxx

@@ -17,15 +17,9 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifdef _MSC_VER
-#pragma warning(push, 1) /* disable warnings within system headers */
-#endif
 #define WIN32_LEAN_AND_MEAN
 #include <windows.h>
 #include <msiquery.h>
-#ifdef _MSC_VER
-#pragma warning(pop)
-#endif
 
 #include <malloc.h>
 #include <string>

setup_native/source/win32/customactions/regactivex/regactivex.cxx

@@ -17,17 +17,11 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifdef _MSC_VER
-#pragma warning(push, 1) /* disable warnings within system headers */
-#endif
 #if !defined WIN32_LEAN_AND_MEAN
 # define WIN32_LEAN_AND_MEAN
 #endif
 #include <windows.h>
 #include <msiquery.h>
-#ifdef _MSC_VER
-#pragma warning(pop)
-#endif
 
 #include <string.h>
 #include <malloc.h>

setup_native/source/win32/customactions/sellang/sorttree.cxx

@@ -7,16 +7,10 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
-#ifdef _MSC_VER
-#pragma warning(push, 1) /* disable warnings within system headers */
-#endif
 #define WIN32_LEAN_AND_MEAN
 #include <windows.h>
 #include <msi.h>
 #include <commctrl.h>
-#ifdef _MSC_VER
-#pragma warning(pop)
-#endif
 
 extern "C" UINT __stdcall SortTree(MSIHANDLE)
 {

setup_native/source/win32/customactions/shellextensions/shlxtmsi.hxx

@@ -20,18 +20,9 @@
 #ifndef INCLUDED_SETUP_NATIVE_SOURCE_WIN32_CUSTOMACTIONS_SHELLEXTENSIONS_SHLXTMSI_HXX
 #define INCLUDED_SETUP_NATIVE_SOURCE_WIN32_CUSTOMACTIONS_SHELLEXTENSIONS_SHLXTMSI_HXX
 
-#ifdef _MSC_VER
-#pragma warning(push, 1) /* disable warnings within system headers */
-#endif
 #define WIN32_LEAN_AND_MEAN
 #include <windows.h>
 #include <msiquery.h>
-#ifdef _WIN32_WINNT_WINBLUE
-#include <VersionHelpers.h>
-#endif
-#ifdef _MSC_VER
-#pragma warning(pop)
-#endif
 
 #include <string>
 

setup_native/source/win32/customactions/tools/checkversion.cxx

@@ -17,15 +17,9 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifdef _MSC_VER
-#pragma warning(push,1) // disable warnings within system headers
-#endif
 #define WIN32_LEAN_AND_MEAN
 #include <windows.h>
 #include <msiquery.h>
-#ifdef _MSC_VER
-#pragma warning(pop)
-#endif
 
 #include <string.h>
 #include <malloc.h>

setup_native/source/win32/customactions/tools/seterror.cxx

@@ -17,14 +17,8 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifdef _MSC_VER
-#pragma warning(push,1) // disable warnings within system headers
-#endif
 #define WIN32_LEAN_AND_MEAN
 #include <windows.h>
-#ifdef _MSC_VER
-#pragma warning(pop)
-#endif
 
 #include <string.h>
 #include <malloc.h>