java: use 'Byte.valueOf' instead of 'new Byte'

Change-Id: Ia99765a6226317ee41ffb02a1b0dd7e6fd944a90

bridges/test/java_remote/PolyStructTest.java

@@ -58,16 +58,16 @@ public final class PolyStructTest extends ComplexTestCase {
                 t.transportBoolean(new TestPolyStruct(Boolean.TRUE)).member);
 
             assertEquals(
-                new Byte((byte) 0),
+                Byte.valueOf((byte) 0),
                 t.transportByte(new TestPolyStruct()).member);
             assertEquals(
-                new Byte(Byte.MIN_VALUE),
+                Byte.valueOf(Byte.MIN_VALUE),
                 t.transportByte(
-                    new TestPolyStruct(new Byte(Byte.MIN_VALUE))).member);
+                    new TestPolyStruct(Byte.valueOf(Byte.MIN_VALUE))).member);
             assertEquals(
-                new Byte(Byte.MAX_VALUE),
+                Byte.valueOf(Byte.MAX_VALUE),
                 t.transportByte(
-                    new TestPolyStruct(new Byte(Byte.MAX_VALUE))).member);
+                    new TestPolyStruct(Byte.valueOf(Byte.MAX_VALUE))).member);
 
             assertEquals(
                 Short.valueOf((short) 0),

bridges/test/java_uno/any/TestAny.java

@@ -123,20 +123,20 @@ final class TestAny {
                               new CompareUnboxed());
 
         // BYTE:
-        success &= testMapAny(transport, new Byte((byte) -128),
+        success &= testMapAny(transport, Byte.valueOf((byte) -128),
                               new CompareBoxed());
-        success &= testMapAny(transport, new Byte((byte) 0),
+        success &= testMapAny(transport, Byte.valueOf((byte) 0),
                               new CompareBoxed());
-        success &= testMapAny(transport, new Byte((byte) 127),
+        success &= testMapAny(transport, Byte.valueOf((byte) 127),
                               new CompareBoxed());
         success &= testMapAny(transport,
-                              new Any(Type.BYTE, new Byte((byte) -128)),
+                              new Any(Type.BYTE, Byte.valueOf((byte) -128)),
                               new CompareUnboxed());
         success &= testMapAny(transport,
-                              new Any(Type.BYTE, new Byte((byte) 0)),
+                              new Any(Type.BYTE, Byte.valueOf((byte) 0)),
                               new CompareUnboxed());
         success &= testMapAny(transport,
-                              new Any(Type.BYTE, new Byte((byte) 127)),
+                              new Any(Type.BYTE, Byte.valueOf((byte) 127)),
                               new CompareUnboxed());
 
         // SHORT:

javaunohelper/com/sun/star/lib/uno/helper/PropertySet.java

@@ -576,7 +576,7 @@ XMultiPropertySet
      *  value of the property is to be stored in a member variable of type int with name intProp. Then setPropertyValue is
      *  called:
      *  <pre>
-     *  set.setPropertyValue( "PropA", new Byte( (byte)111));
+     *  set.setPropertyValue( "PropA", Byte.valueOf( (byte)111));
      *  </pre>
      *  At some point setPropertyValue will call convertPropertyValue and pass in the Byte object. Since we allow
      *  that Byte values can be used with the property and know that the value is to be stored in intProp (type int)
@@ -735,7 +735,7 @@ XMultiPropertySet
         else if (cl.equals(char.class))
             retVal= new Character(AnyConverter.toChar(obj));
         else if (cl.equals(byte.class))
-            retVal= new Byte(AnyConverter.toByte(obj));
+            retVal= Byte.valueOf(AnyConverter.toByte(obj));
         else if (cl.equals(short.class))
             retVal= Short.valueOf(AnyConverter.toShort(obj));
         else if (cl.equals(int.class))
@@ -757,7 +757,7 @@ XMultiPropertySet
         else if (cl.equals(Character.class))
             retVal= new Character(AnyConverter.toChar(obj));
         else if (cl.equals(Byte.class))
-            retVal= new Byte(AnyConverter.toByte(obj));
+            retVal= Byte.valueOf(AnyConverter.toByte(obj));
         else if (cl.equals(Short.class))
             retVal= Short.valueOf(AnyConverter.toShort(obj));
         else if (cl.equals(Integer.class))

jurt/com/sun/star/lib/uno/protocols/urp/Unmarshal.java

@@ -210,7 +210,7 @@ final class Unmarshal {
 
     private Byte readByteValue() {
         try {
-            return new Byte(input.readByte());
+            return Byte.valueOf(input.readByte());
         } catch (IOException e) {
             throw new RuntimeException(e.toString());
         }

jurt/test/com/sun/star/lib/uno/protocols/urp/Marshaling_Test.java

@@ -44,7 +44,7 @@ public final class Marshaling_Test {
             new com.sun.star.uno.RuntimeException("testRuntimeException"),
             new com.sun.star.uno.Exception("testException"),
             Boolean.TRUE,
-            new Byte((byte)47),
+            Byte.valueOf((byte)47),
             new Character('k'),
             new Double(0.12345),
             TestEnum.B,

jurt/test/com/sun/star/uno/AnyConverter_Test.java

@@ -39,7 +39,7 @@ public final class AnyConverter_Test {
 
     Boolean aBool= Boolean.TRUE;
     Character aChar= new Character('A');
-    Byte aByte= new Byte((byte) 111);
+    Byte aByte= Byte.valueOf((byte) 111);
     Short aShort= Short.valueOf((short) 11111);
     Integer aInt= Integer.valueOf( 1111111);
     Long aLong= Long.valueOf( 0xffffffff);

qadevOOo/runner/util/ValueChanger.java

@@ -70,7 +70,7 @@ public class ValueChanger {
 
    if (oldValue instanceof Byte) {
      byte oldbyte = ((Byte) oldValue).byteValue();
-     newValue = new Byte((byte) (oldbyte + 1));
+     newValue = Byte.valueOf((byte) (oldbyte + 1));
    } else
 
    if (oldValue instanceof Float) {

qadevOOo/testdocs/qadevlibs/source/com/sun/star/cmp/MyPersistObject.java

@@ -206,7 +206,7 @@ public class MyPersistObject implements XPersistObject, XTypeProvider,
      */
     public Object getPropertyValue(String property) {
         if ( property.equals(props[0].Name))
-            return new Byte(by);
+            return Byte.valueOf(by);
         if ( property.equals(props[1].Name))
             return Integer.valueOf(i);
         if ( property.equals(props[2].Name))

qadevOOo/tests/java/ifc/style/_CharacterProperties.java

@@ -313,8 +313,8 @@ public class _CharacterProperties extends MultiPropertyTest {
     * so ist must be treated special
     */
     public void _CharEscapementHeight() {
-        Byte aByte = new Byte((byte)75);
-        Byte max = new Byte((byte)100);
+        Byte aByte = Byte.valueOf((byte)75);
+        Byte max = Byte.valueOf((byte)100);
         testProperty("CharEscapementHeight", aByte, max) ;
     }
 

qadevOOo/tests/java/mod/_forms/ODatabaseForm.java

@@ -621,7 +621,7 @@ public class ODatabaseForm extends TestCase {
                 values must be added here as relation. */
         params.add("SAU99") ;
         params.add(Boolean.FALSE) ;
-        params.add(new Byte((byte) 123)) ;
+        params.add(Byte.valueOf((byte) 123)) ;
         params.add(Short.valueOf((short) 234)) ;
         params.add(Integer.valueOf(12345)) ;
         params.add(Long.valueOf(23456)) ;

qadevOOo/tests/java/mod/_stm/DataInputStream.java

@@ -129,7 +129,7 @@ public class DataInputStream extends TestCase {
         // all data types for writing to an XDataInputStream
         ArrayList<Object> data = new ArrayList<Object>();
         data.add(Boolean.TRUE) ;
-        data.add(new Byte((byte)123)) ;
+        data.add(Byte.valueOf((byte)123)) ;
         data.add(new Character((char)1234)) ;
         data.add(Short.valueOf((short)1234)) ;
         data.add(Integer.valueOf(123456)) ;

qadevOOo/tests/java/mod/_stm/DataOutputStream.java

@@ -106,7 +106,7 @@ public class DataOutputStream extends TestCase {
         // all data types for writing to an XDataInputStream
         ArrayList<Object> data = new ArrayList<Object>() ;
         data.add(Boolean.TRUE) ;
-        data.add(new Byte((byte)123)) ;
+        data.add(Byte.valueOf((byte)123)) ;
         data.add(new Character((char)1234)) ;
         data.add(Short.valueOf((short)1234)) ;
         data.add(Integer.valueOf(123456)) ;

qadevOOo/tests/java/mod/_stm/MarkableOutputStream.java

@@ -129,7 +129,7 @@ public class MarkableOutputStream extends TestCase {
         // all data types for writing to an XDataInputStream
         ArrayList<Object> data = new ArrayList<Object>() ;
         data.add(Boolean.TRUE) ;
-        data.add(new Byte((byte)123)) ;
+        data.add(Byte.valueOf((byte)123)) ;
         data.add(new Character((char)1234)) ;
         data.add(Short.valueOf((short)1234)) ;
         data.add(Integer.valueOf(123456)) ;

qadevOOo/tests/java/mod/_stm/ObjectInputStream.java

@@ -243,7 +243,7 @@ public class ObjectInputStream extends TestCase {
         // all data types for writing to an XDataInputStream
         ArrayList<Object> data = new ArrayList<Object>() ;
         data.add(Boolean.TRUE) ;
-        data.add(new Byte((byte)123)) ;
+        data.add(Byte.valueOf((byte)123)) ;
         data.add(new Character((char)1234)) ;
         data.add(Short.valueOf((short)1234)) ;
         data.add(Integer.valueOf(123456)) ;

qadevOOo/tests/java/mod/_stm/ObjectOutputStream.java

@@ -232,7 +232,7 @@ public class ObjectOutputStream extends TestCase {
         // all data types for writing to an XDataInputStream
         ArrayList<Object> data = new ArrayList<Object>() ;
         data.add(Boolean.TRUE) ;
-        data.add(new Byte((byte)123)) ;
+        data.add(Byte.valueOf((byte)123)) ;
         data.add(new Character((char)1234)) ;
         data.add(Short.valueOf((short)1234)) ;
         data.add(Integer.valueOf(123456)) ;

qadevOOo/tests/java/mod/_streams/uno/DataInputStream.java

@@ -126,7 +126,7 @@ public class DataInputStream extends TestCase {
         // all data types for writing to an XDataInputStream
         ArrayList<Object> data = new ArrayList<Object>() ;
         data.add(Boolean.TRUE) ;
-        data.add(new Byte((byte)123)) ;
+        data.add(Byte.valueOf((byte)123)) ;
         data.add(new Character((char)1234)) ;
         data.add(Short.valueOf((short)1234)) ;
         data.add(Integer.valueOf(123456)) ;

qadevOOo/tests/java/mod/_streams/uno/DataOutputStream.java

@@ -103,7 +103,7 @@ public class DataOutputStream extends TestCase {
         // all data types for writing to an XDataInputStream
         ArrayList<Object> data = new ArrayList<Object>() ;
         data.add(Boolean.TRUE) ;
-        data.add(new Byte((byte)123)) ;
+        data.add(Byte.valueOf((byte)123)) ;
         data.add(new Character((char)1234)) ;
         data.add(Short.valueOf((short)1234)) ;
         data.add(Integer.valueOf(123456)) ;

qadevOOo/tests/java/mod/_streams/uno/MarkableOutputStream.java

@@ -126,7 +126,7 @@ public class MarkableOutputStream extends TestCase {
         // all data types for writing to an XDataInputStream
         ArrayList<Object> data = new ArrayList<Object>() ;
         data.add(Boolean.TRUE) ;
-        data.add(new Byte((byte)123)) ;
+        data.add(Byte.valueOf((byte)123)) ;
         data.add(new Character((char)1234)) ;
         data.add(Short.valueOf((short)1234)) ;
         data.add(Integer.valueOf(123456)) ;

qadevOOo/tests/java/mod/_streams/uno/ObjectInputStream.java

@@ -240,7 +240,7 @@ public class ObjectInputStream extends TestCase {
         // all data types for writing to an XDataInputStream
         ArrayList<Object> data = new ArrayList<Object>() ;
         data.add(Boolean.TRUE) ;
-        data.add(new Byte((byte)123)) ;
+        data.add(Byte.valueOf((byte)123)) ;
         data.add(new Character((char)1234)) ;
         data.add(Short.valueOf((short)1234)) ;
         data.add(Integer.valueOf(123456)) ;

qadevOOo/tests/java/mod/_streams/uno/ObjectOutputStream.java

@@ -229,7 +229,7 @@ public class ObjectOutputStream extends TestCase {
         // all data types for writing to an XDataInputStream
         ArrayList<Object> data = new ArrayList<Object>() ;
         data.add(Boolean.TRUE) ;
-        data.add(new Byte((byte)123)) ;
+        data.add(Byte.valueOf((byte)123)) ;
         data.add(new Character((char)1234)) ;
         data.add(Short.valueOf((short)1234)) ;
         data.add(Integer.valueOf(123456)) ;

ridljar/com/sun/star/uno/UnoRuntime.java

@@ -306,7 +306,7 @@ public class UnoRuntime {
         case TypeClass.BOOLEAN_value:
             return Boolean.FALSE;
         case TypeClass.BYTE_value:
-            return new Byte((byte) 0);
+            return Byte.valueOf((byte) 0);
         case TypeClass.SHORT_value:
         case TypeClass.UNSIGNED_SHORT_value:
             return Short.valueOf((short) 0);

testtools/com/sun/star/comp/bridge/TestComponent.java

@@ -1165,7 +1165,7 @@ public class TestComponent {
                 null);
             Constructors.create2(context, new Object[] {
                 Boolean.TRUE,
-                new Byte(Byte.MIN_VALUE),
+                Byte.valueOf(Byte.MIN_VALUE),
                 Short.valueOf(Short.MIN_VALUE),
                 new Any(Type.UNSIGNED_SHORT, Short.valueOf((short) -1)),
                 Integer.valueOf(Integer.MIN_VALUE),
@@ -1223,7 +1223,7 @@ public class TestComponent {
                 new TestPolyStruct(Type.LONG),
                 new TestPolyStruct(new Any(Type.BOOLEAN, Boolean.TRUE)),
                 new TestPolyStruct(Boolean.TRUE),
-                new TestPolyStruct(new Byte(Byte.MIN_VALUE)),
+                new TestPolyStruct(Byte.valueOf(Byte.MIN_VALUE)),
                 new TestPolyStruct(Short.valueOf(Short.MIN_VALUE)),
                 new TestPolyStruct(Integer.valueOf(Integer.MIN_VALUE)),
                 new TestPolyStruct(Long.valueOf(Long.MIN_VALUE)),

wizards/com/sun/star/wizards/common/NumericalHelper.java

@@ -249,7 +249,7 @@ public class NumericalHelper
                 break;
             case TypeClass.BYTE_value:
                 aTypeObject.iType = BYTE_TYPE;
-                aTypeObject.aValue = new Byte(AnyConverter.toByte(aValue));
+                aTypeObject.aValue = Byte.valueOf(AnyConverter.toByte(aValue));
                 break;
             case TypeClass.SHORT_value:
                 aTypeObject.iType = SHORT_TYPE;