Kaydet (Commit) bc28d51c authored tarafından Caolán McNamara's avatar Caolán McNamara Kaydeden (comit) Eike Rathke

ofz: make ValidNewTabName faster wrt collisions

Change-Id: Id2058719c3bc822518faa922a6cd0409b4088ac7
Reviewed-on: https://gerrit.libreoffice.org/59253
Tested-by: Jenkins
Reviewed-by: 's avatarEike Rathke <erack@redhat.com>
üst 2291c110
This diff is collapsed.
......@@ -375,13 +375,18 @@ bool ScDocument::ValidTabName( const OUString& rName )
bool ScDocument::ValidNewTabName( const OUString& rName ) const
{
bool bValid = ValidTabName(rName);
TableContainer::const_iterator it = maTabs.begin();
for (; it != maTabs.end() && bValid; ++it)
if ( *it )
{
OUString aOldName = (*it)->GetName();
bValid = !ScGlobal::GetpTransliteration()->isEqual( rName, aOldName );
}
if (!bValid)
return false;
OUString aUpperName = ScGlobal::pCharClass->uppercase(rName);
for (const auto& a : maTabs)
{
if (!a)
continue;
const OUString& rOldName = a->GetUpperName();
bValid = rOldName != aUpperName;
if (!bValid)
break;
}
return bValid;
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment