loplugin:passstuffbyref in various

Change-Id: I80070c83204e531c2f599f8a56193d6ffe0e5022

UnoControls/inc/basecontrol.hxx

@@ -361,11 +361,11 @@ public:
 protected:
     using OComponentHelper::disposing;
 
-    const css::uno::Reference< css::uno::XComponentContext > impl_getComponentContext() { return m_xComponentContext;}
+    const css::uno::Reference< css::uno::XComponentContext >& impl_getComponentContext() { return m_xComponentContext;}
 
-    const css::uno::Reference< css::awt::XWindow > impl_getPeerWindow() { return m_xPeerWindow;}
+    const css::uno::Reference< css::awt::XWindow >& impl_getPeerWindow() { return m_xPeerWindow;}
 
-    const css::uno::Reference< css::awt::XGraphics > impl_getGraphicsPeer() { return m_xGraphicsPeer;}
+    const css::uno::Reference< css::awt::XGraphics >& impl_getGraphicsPeer() { return m_xGraphicsPeer;}
 
     const sal_Int32& impl_getWidth() { return m_nWidth;}
 
@@ -381,7 +381,7 @@ protected:
 
     virtual void impl_recalcLayout( const css::awt::WindowEvent& aEvent );
 
-    css::uno::Reference< css::uno::XInterface > impl_getDelegator() { return m_xDelegator;}
+    const css::uno::Reference< css::uno::XInterface >& impl_getDelegator() { return m_xDelegator;}
 
 private:
 

accessibility/inc/accessibility/extended/textwindowaccessibility.hxx

@@ -392,7 +392,7 @@ public:
     Document(::VCLXWindow * pVclXWindow, ::TextEngine & rEngine,
              ::TextView & rView);
 
-    inline css::uno::Reference< css::accessibility::XAccessible >
+    const css::uno::Reference< css::accessibility::XAccessible >&
     getAccessible() { return m_xAccessible; }
 
     // Must be called only after init has been called.

accessibility/inc/accessibility/standard/vclxaccessibletoolboxitem.hxx

@@ -87,7 +87,7 @@ public:
     inline void         ReleaseToolBox() { m_pToolBox = nullptr; }
     void                NameChanged();
     void                SetChild( const css::uno::Reference< css::accessibility::XAccessible >& _xChild );
-    css::uno::Reference< css::accessibility::XAccessible >
+    const css::uno::Reference< css::accessibility::XAccessible >&
                         GetChild() const { return m_xChild; }
     void                NotifyChildEvent( const css::uno::Reference< css::accessibility::XAccessible >& _xChild, bool _bShow );
 

basctl/source/inc/basidesh.hxx

@@ -156,7 +156,7 @@ public:
     BaseWindow*      GetCurWindow() const    { return pCurWin; }
     ScriptDocument const& GetCurDocument() const { return m_aCurDocument; }
     OUString const&  GetCurLibName() const { return m_aCurLibName; }
-    std::shared_ptr<LocalizationMgr> GetCurLocalizationMgr() const { return m_pCurLocalizationMgr; }
+    const std::shared_ptr<LocalizationMgr>& GetCurLocalizationMgr() const { return m_pCurLocalizationMgr; }
 
     TabBar&             GetTabBar()             { return *pTabBar; }
     WindowTable&        GetWindowTable()        { return aWindowTable; }

basctl/source/inc/dlged.hxx

@@ -161,7 +161,7 @@ public:
 
     void            SetDialog (const css::uno::Reference<css::container::XNameContainer>& xUnoControlDialogModel);
     void            ResetDialog ();
-    css::uno::Reference< css::container::XNameContainer > GetDialog() const
+    const css::uno::Reference< css::container::XNameContainer >& GetDialog() const
                         {return m_xUnoControlDialogModel;}
 
     css::uno::Reference< css::util::XNumberFormatsSupplier > const & GetNumberFormatsSupplier();

basctl/source/inc/localizationmgr.hxx

@@ -72,7 +72,7 @@ public:
     LocalizationMgr(Shell*, ScriptDocument const&, OUString const& aLibName,
         const css::uno::Reference < css::resource::XStringResourceManager >& xStringResourceManager );
 
-    css::uno::Reference< css::resource::XStringResourceManager >getStringResourceManager()
+    const css::uno::Reference< css::resource::XStringResourceManager >& getStringResourceManager()
     {
         return m_xStringResourceManager;
     }

binaryurp/source/bridge.cxx

@@ -104,7 +104,7 @@ public:
 
     ~AttachThread();
 
-    rtl::ByteSequence getTid() throw () { return tid_;}
+    const rtl::ByteSequence& getTid() throw () { return tid_;}
 
 private:
     AttachThread(const AttachThread&) = delete;

binaryurp/source/bridge.hxx

@@ -88,10 +88,10 @@ public:
     // thread:
     void terminate(bool final);
 
-    com::sun::star::uno::Reference< com::sun::star::connection::XConnection >
+    const com::sun::star::uno::Reference< com::sun::star::connection::XConnection >&
     getConnection() const { return connection_;}
 
-    com::sun::star::uno::Reference< com::sun::star::bridge::XInstanceProvider >
+    const com::sun::star::uno::Reference< com::sun::star::bridge::XInstanceProvider >&
     getProvider() const { return provider_;}
 
     com::sun::star::uno::Mapping & getCppToBinaryMapping() { return cppToBinaryMapping_;}

binaryurp/source/proxy.hxx

@@ -43,9 +43,9 @@ public:
         rtl::Reference< Bridge > const & bridge, OUString const & oid,
         com::sun::star::uno::TypeDescription const & type);
 
-    OUString getOid() const { return oid_;}
+    const OUString& getOid() const { return oid_;}
 
-    com::sun::star::uno::TypeDescription getType() const { return type_;}
+    const com::sun::star::uno::TypeDescription& getType() const { return type_;}
 
     void do_acquire();
 

bridges/inc/bridges/cpp_uno/shared/cppinterfaceproxy.hxx

@@ -57,7 +57,7 @@ public:
     Bridge * getBridge() { return pBridge; }
     uno_Interface * getUnoI() { return pUnoI; }
     typelib_InterfaceTypeDescription * getTypeDescr() { return pTypeDescr; }
-    OUString getOid() { return oid; }
+    const OUString& getOid() { return oid; }
 
     // non virtual methods called on incoming vtable calls #1, #2
     void acquireProxy();

configmgr/source/localizedvaluenode.hxx

@@ -39,7 +39,7 @@ public:
 
     virtual OUString getTemplateName() const override;
 
-    css::uno::Any  getValue() const { return value_;}
+    const css::uno::Any&  getValue() const { return value_;}
     css::uno::Any *getValuePtr(int layer)
     {
         setLayer(layer);

configmgr/source/rootaccess.hxx

@@ -72,7 +72,7 @@ public:
 
     OUString getAbsolutePathRepresentation();
 
-    OUString getLocale() const { return locale_;}
+    const OUString& getLocale() const { return locale_;}
 
     bool isUpdate() const { return update_;}
 

cppcanvas/source/inc/canvasgraphichelper.hxx

@@ -55,8 +55,8 @@ namespace cppcanvas
         protected:
             // for our clients
             // ===============
-            CanvasSharedPtr                                                      getCanvas() const {  return mpCanvas; }
-            css::uno::Reference< css::rendering::XGraphicDevice >                getGraphicDevice() const {  return mxGraphicDevice; }
+            const CanvasSharedPtr&                                               getCanvas() const {  return mpCanvas; }
+            const css::uno::Reference< css::rendering::XGraphicDevice >&         getGraphicDevice() const {  return mxGraphicDevice; }
             const css::rendering::RenderState&                                   getRenderState() const;
 
         private:

cppcanvas/source/mtfrenderer/implrenderer.cxx

@@ -2698,7 +2698,7 @@ namespace cppcanvas
                                                                   rSubset ) );
                 }
 
-                ::basegfx::B2DRange getBounds() const
+                const ::basegfx::B2DRange& getBounds() const
                 {
                     return maBounds;
                 }

cppcanvas/source/wrapper/implspritecanvas.hxx

@@ -64,7 +64,7 @@ namespace cppcanvas
                 TransformationArbiter();
 
                 void                        setTransformation( const ::basegfx::B2DHomMatrix& rViewTransform );
-                ::basegfx::B2DHomMatrix     getTransformation() const {  return maTransformation; }
+                const ::basegfx::B2DHomMatrix& getTransformation() const {  return maTransformation; }
 
             private:
                 ::basegfx::B2DHomMatrix     maTransformation;

desktop/source/app/cmdlineargs.hxx

@@ -55,7 +55,7 @@ class CommandLineArgs
         CommandLineArgs(const CommandLineArgs&) = delete;
         const CommandLineArgs& operator=(const CommandLineArgs&) = delete;
 
-        boost::optional< OUString > getCwdUrl() const { return m_cwdUrl; }
+        const boost::optional< OUString >& getCwdUrl() const { return m_cwdUrl; }
 
         // Access to bool parameters
         bool                IsMinimized() const { return m_minimized;}
@@ -93,7 +93,7 @@ class CommandLineArgs
         bool                WantsToLoadDocument() const { return m_bDocumentArgs;}
         bool                IsTextCat() const { return m_textcat;}
 
-        OUString            GetUnknown() const { return m_unknown;}
+        const OUString&     GetUnknown() const { return m_unknown;}
 
         // Access to string parameters
         bool                    HasSplashPipe() const { return m_splashpipe;}
@@ -106,13 +106,13 @@ class CommandLineArgs
         std::vector< OUString > GetForceNewList() const;
         std::vector< OUString > GetPrintList() const;
         std::vector< OUString > GetPrintToList() const;
-        OUString       GetPrinterName() const { return m_printername;}
-        OUString       GetLanguage() const { return m_language;}
+        const OUString&         GetPrinterName() const { return m_printername;}
+        const OUString&         GetLanguage() const { return m_language;}
         std::vector< OUString > const & GetInFilter() const { return m_infilter;}
         std::vector< OUString > GetConversionList() const;
-        OUString       GetConversionParams() const { return m_conversionparams;}
-        OUString       GetConversionOut() const;
-        OUString       GetPidfileName() const { return m_pidfile;}
+        const OUString&         GetConversionParams() const { return m_conversionparams;}
+        OUString                GetConversionOut() const;
+        const OUString&         GetPidfileName() const { return m_pidfile;}
 
         // Special analyzed states (does not match directly to a command line parameter!)
         bool IsEmpty() const { return m_bEmpty;}

desktop/source/deployment/gui/dp_gui_theextmgr.hxx

@@ -100,8 +100,8 @@ public:
     // Tools
     bool supportsOptions( const css::uno::Reference< css::deployment::XPackage > &xPackage ) const;
     static PackageState getPackageState( const css::uno::Reference< css::deployment::XPackage > &xPackage );
-    css::uno::Reference< css::uno::XComponentContext > getContext() const { return m_xContext; }
-    css::uno::Reference< css::deployment::XExtensionManager > getExtensionManager() const { return m_xExtensionManager; }
+    const css::uno::Reference< css::uno::XComponentContext >& getContext() const { return m_xContext; }
+    const css::uno::Reference< css::deployment::XExtensionManager >& getExtensionManager() const { return m_xExtensionManager; }
     bool isReadOnly( const css::uno::Reference< css::deployment::XPackage > &xPackage ) const;
 
 

desktop/source/deployment/gui/dp_gui_updateinstalldialog.hxx

@@ -86,7 +86,7 @@ private:
     };
     void setError(INSTALL_ERROR err, OUString const & sExtension, OUString const & exceptionMessage);
     void setError(OUString const & exceptionMessage);
-    css::uno::Reference< css::deployment::XExtensionManager > getExtensionManager() const
+    const css::uno::Reference< css::deployment::XExtensionManager >& getExtensionManager() const
             { return m_xExtensionManager; }
 
     rtl::Reference< Thread > m_thread;

desktop/source/deployment/misc/dp_descriptioninfoset.cxx

@@ -124,7 +124,7 @@ public:
 
     ~ExtensionDescription();
 
-    css::uno::Reference<css::xml::dom::XNode> getRootElement() const
+    const css::uno::Reference<css::xml::dom::XNode>& getRootElement() const
     {
         return m_xRoot;
     }

desktop/source/deployment/registry/inc/dp_backend.h

@@ -346,7 +346,7 @@ public:
     inline OUString const & getCachePath() const { return m_cachePath; }
     inline bool transientMode() const { return m_cachePath.isEmpty(); }
 
-    inline OUString getContext() const {return m_context; }
+    const OUString& getContext() const {return m_context; }
 
     // XEventListener
     virtual void SAL_CALL disposing( css::lang::EventObject const & evt )

desktop/source/deployment/registry/sfwk/dp_parceldesc.hxx

@@ -45,7 +45,7 @@ private:
     sal_Int32 skipIndex;
 public:
     ParcelDescDocHandler():m_bIsParsed( false ), skipIndex( 0 ){}
-    OUString getParcelLanguage() { return m_sLang; }
+    const OUString& getParcelLanguage() { return m_sLang; }
     bool isParsed() { return m_bIsParsed; }
     // XDocumentHandler
     virtual void SAL_CALL startDocument()

embeddedobj/source/inc/commonembobj.hxx

@@ -170,8 +170,8 @@ private:
                 const css::uno::Reference< css::embed::XStorage >& xNewParentStorage,
                 const OUString& aNewName );
 
-    OUString GetDocumentServiceName() const { return m_aDocServiceName; }
-    OUString GetPresetFilterName() const { return m_aPresetFilterName; }
+    const OUString& GetDocumentServiceName() const { return m_aDocServiceName; }
+    const OUString& GetPresetFilterName() const { return m_aPresetFilterName; }
 
     css::uno::Reference< css::io::XInputStream >
         StoreDocumentToTempStream_Impl( sal_Int32 nStorageFormat,

embeddedobj/source/inc/docholder.hxx

@@ -164,7 +164,7 @@ public:
         m_xOutplaceInterceptor = xOutplaceInterceptor;
     }
 
-    css::uno::Reference< css::util::XCloseable > GetComponent() { return m_xComponent; }
+    const css::uno::Reference< css::util::XCloseable >& GetComponent() { return m_xComponent; }
 
 // XEventListener
     virtual void SAL_CALL disposing( const css::lang::EventObject& Source ) throw (css::uno::RuntimeException, std::exception) override;

extensions/source/bibliography/datman.hxx

@@ -138,10 +138,10 @@ public:
 
         css::uno::Sequence< OUString>           getDataSources();
 
-        OUString                    getActiveDataSource() {return aDataSourceURL;}
+        const OUString&             getActiveDataSource() {return aDataSourceURL;}
         void                        setActiveDataSource(const OUString& rURL);
 
-        OUString                    getActiveDataTable() { return aActiveDataTable;}
+        const OUString&             getActiveDataTable() { return aActiveDataTable;}
         void                        setActiveDataTable(const OUString& rTable);
 
         void                        setFilter(const OUString& rQuery);

extensions/source/bibliography/general.hxx

@@ -161,7 +161,7 @@ public:
 
     virtual bool                HandleShortCutKey( const KeyEvent& rKeyEvent ) override; // returns true, if key was handled
 
-    inline rtl::Reference<BibGeneralPageFocusListener> GetFocusListener() { return mxBibGeneralPageFocusListener; }
+    const rtl::Reference<BibGeneralPageFocusListener>& GetFocusListener() { return mxBibGeneralPageFocusListener; }
 
     void focusGained(const css::awt::FocusEvent& rEvent) throw( css::uno::RuntimeException, std::exception );
     void focusLost(const css::awt::FocusEvent& rEvent) throw( css::uno::RuntimeException, std::exception );

extensions/source/bibliography/toolbar.hxx

@@ -51,7 +51,7 @@ public:
     BibToolBarListener(BibToolBar *pTB, const OUString& aStr, sal_uInt16 nId);
     virtual ~BibToolBarListener();
 
-    OUString           GetCommand() const { return aCommand;}
+    const OUString&          GetCommand() const { return aCommand;}
 
     // css::lang::XEventListener
     // we do not hold References to dispatches, so there is nothing to do on disposal

extensions/source/dbpilots/controlwizard.hxx

@@ -107,7 +107,7 @@ namespace dbp
         bool    travelNext() { return OControlWizard_Base::travelNext(); }
 
     public:
-        css::uno::Reference< css::uno::XComponentContext >
+        const css::uno::Reference< css::uno::XComponentContext >&
             getComponentContext() const { return m_xContext; }
 
         const OControlWizardContext&    getContext() const { return m_aContext; }

extensions/source/logging/loghandler.hxx

@@ -65,7 +65,7 @@ namespace logging
         inline  rtl_TextEncoding
                 getTextEncoding() const { return m_eEncoding; }
 
-        inline  css::uno::Reference< css::logging::XLogFormatter >
+        const css::uno::Reference< css::logging::XLogFormatter >&
                 getFormatter() const { return m_xFormatter; }
         inline  void
                 setFormatter( const css::uno::Reference< css::logging::XLogFormatter >& _rxFormatter )

extensions/source/propctrlr/commoncontrol.hxx

@@ -74,7 +74,7 @@ namespace pcr
 
         // XPropertyControl
         ::sal_Int16 SAL_CALL getControlType() throw (css::uno::RuntimeException) { return m_nControlType; }
-        css::uno::Reference< css::inspection::XPropertyControlContext > SAL_CALL getControlContext() throw (css::uno::RuntimeException) { return m_xContext; }
+        const css::uno::Reference< css::inspection::XPropertyControlContext >& SAL_CALL getControlContext() throw (css::uno::RuntimeException) { return m_xContext; }
         void SAL_CALL setControlContext( const css::uno::Reference< css::inspection::XPropertyControlContext >& _controlcontext ) throw (css::uno::RuntimeException);
         bool SAL_CALL isModified(  ) throw (css::uno::RuntimeException) { return m_bModified; }
         void SAL_CALL notifyModifiedValue(  ) throw (css::uno::RuntimeException);

forms/source/component/GroupManager.hxx

@@ -145,7 +145,7 @@ public:
     explicit OGroup(const OUString& rGroupName);
     virtual ~OGroup();
 
-    OUString GetGroupName() const { return m_aGroupName; }
+    const OUString& GetGroupName() const { return m_aGroupName; }
     css::uno::Sequence< css::uno::Reference< css::awt::XControlModel>  > GetControlModels() const;
 
     void InsertComponent( const css::uno::Reference< css::beans::XPropertySet>& rxElement );

forms/source/inc/limitedformats.hxx

@@ -77,7 +77,7 @@ namespace frm
         void        setFormatKeyPropertyValue( const css::uno::Any& _rNewValue );
         // setFormatKeyPropertyValue should only be called with a value got from convertFormatKeyPropertyValue!
 
-        css::uno::Reference< css::util::XNumberFormatsSupplier >
+        const css::uno::Reference< css::util::XNumberFormatsSupplier >&
                     getFormatsSupplier() const { return s_xStandardFormats; }
 
     private:

forms/source/xforms/computedexpression.hxx

@@ -66,7 +66,7 @@ protected:
 
     /// allow manipulation of the expression before it is evaluated
     // the default implementation is to do nothing...
-    const OUString _getExpressionForEvaluation() const { return msExpression; }
+    const OUString& _getExpressionForEvaluation() const { return msExpression; }
 
     /// obtain a (suitable) XPathAPI implementation
     static css::uno::Reference<css::xml::xpath::XXPathAPI> _getXPathAPI(const xforms::EvaluationContext& aContext);
@@ -82,7 +82,7 @@ public:
 
 
     /// get the expression string
-    OUString getExpression() const { return msExpression;}
+    const OUString& getExpression() const { return msExpression;}
 
     /// set a new expression string
     void setExpression( const OUString& rExpression );

forms/source/xforms/mip.hxx

@@ -64,7 +64,7 @@ public:
     // - type (static; default: xsd:string)
     //        (currently default implemented as empty string)
     bool hasTypeName() const { return mbHasTypeName; }
-    OUString getTypeName() const { return msTypeName; }
+    const OUString& getTypeName() const { return msTypeName; }
     void setTypeName( const OUString& );
     void resetTypeName();
 
@@ -94,7 +94,7 @@ public:
 
     // explain _why_ a constraint failed
     void setConstraintExplanation( const OUString& );
-    OUString getConstraintExplanation() const { return msConstraintExplanation; }
+    const OUString& getConstraintExplanation() const { return msConstraintExplanation; }
 
     // - calculate (computed XPath; default: has none (false))
     //   (for calculate, we only store whether a calculate MIP is present;

forms/source/xforms/pathexpression.hxx

@@ -69,7 +69,7 @@ public:
 
     // get the result of this expression as node/node list/...
     css::uno::Reference<css::xml::dom::XNode> getNode() const;
-    const NodeVector_t getNodeList() const { return maNodes;}
+    const NodeVector_t& getNodeList() const { return maNodes;}
     css::uno::Reference<css::xml::dom::XNodeList> getXNodeList() const;
 
 };

forms/source/xforms/xpathlib/extension.hxx

@@ -46,8 +46,8 @@ private:
 public:
     CLibxml2XFormsExtension() {}
 
-    css::uno::Reference< css::xforms::XModel > getModel() { return m_aModel;}
-    css::uno::Reference< css::xml::dom::XNode > getContextNode() { return m_aContextNode;}
+    const css::uno::Reference< css::xforms::XModel >& getModel() { return m_aModel;}
+    const css::uno::Reference< css::xml::dom::XNode >& getContextNode() { return m_aContextNode;}
 
     virtual css::xml::xpath::Libxml2ExtensionHandle SAL_CALL getLibxml2ExtensionHandle() throw (css::uno::RuntimeException, std::exception) override;
     virtual void SAL_CALL initialize(const css::uno::Sequence< css::uno::Any >& aSequence) throw (css::uno::RuntimeException, std::exception) override;

fpicker/source/office/OfficeFilePicker.cxx

@@ -70,8 +70,8 @@ public:
 
     FilterEntry( const OUString& _rTitle, const UnoFilterList& _rSubFilters );
 
-    OUString     getTitle() const { return m_sTitle; }
-    OUString     getFilter() const { return m_sFilter; }
+    const OUString& getTitle() const { return m_sTitle; }
+    const OUString& getFilter() const { return m_sFilter; }
 
     /// determines if the filter has sub filter (i.e., the filter is a filter group in real)
     bool            hasSubFilters( ) const;

fpicker/source/office/PlacesListBox.hxx

@@ -66,9 +66,9 @@ class PlacesListBox : public Control
         void SetSizePixel( const Size& rNewSize ) override;
         void updateView( );
 
-        VclPtr<PushButton> GetAddButton() const { return mpAddBtn; }
-        VclPtr<PushButton> GetDeleteButton() const { return mpDelBtn; }
-        VclPtr<PlacesListBox_Impl> GetPlacesListBox() const { return mpImpl; }
+        const VclPtr<PushButton>& GetAddButton() const { return mpAddBtn; }
+        const VclPtr<PushButton>& GetDeleteButton() const { return mpDelBtn; }
+        const VclPtr<PlacesListBox_Impl>& GetPlacesListBox() const { return mpImpl; }
 
         virtual bool Notify( NotifyEvent& rNEvt ) override;
 

idlc/inc/idlc/inheritedinterface.hxx

@@ -42,7 +42,7 @@ public:
 
     bool isOptional() const { return optional; }
 
-    OUString getDocumentation() const { return documentation; }
+    const OUString& getDocumentation() const { return documentation; }
 
 private:
     AstType const * interface;

l10ntools/inc/xmlparse.hxx

@@ -62,8 +62,8 @@ public:
     )
     : m_sName( rName ), m_sValue( rValue ) {}
 
-    OString GetName() const { return m_sName; }
-    OString GetValue() const { return m_sValue; }
+    const OString& GetName() const { return m_sName; }
+    const OString& GetValue() const { return m_sValue; }
 
     void setValue( const OString &rValue ){ m_sValue = rValue; }
 };
@@ -171,7 +171,7 @@ public:
     virtual XMLNodeType GetNodeType() const override { return XMLNodeType::XFILE; }
 
     /// returns file name
-    OString GetName() const { return m_sFileName; }
+    const OString& GetName() const { return m_sFileName; }
     void SetName( const OString &rFilename ) { m_sFileName = rFilename; }
     const std::vector<OString>& getOrder() const { return m_vOrder; }
 
@@ -229,7 +229,7 @@ public:
     virtual XMLNodeType GetNodeType() const override { return XMLNodeType::ELEMENT; }
 
     /// returns element name
-    OString GetName() const { return m_sElementName; }
+    const OString& GetName() const { return m_sElementName; }
 
     /// returns list of attributes of this element
     XMLAttributeList *GetAttributeList() { return m_pAttributes.get(); }
@@ -247,7 +247,7 @@ public:
     void SetPos             ( int nPos )                    { m_nPos = nPos; }
     void SetOldRef          ( OString const & sOldRef )     { m_sOldRef = sOldRef; }
 
-    OString GetOldref() const       { return m_sOldRef;      }
+    const OString& GetOldref() const       { return m_sOldRef;      }
 };
 
 /** Holds character data
@@ -270,7 +270,7 @@ public:
     virtual XMLNodeType GetNodeType() const override { return XMLNodeType::DATA; }
 
     /// returns the data
-    OString GetData() const { return m_sData; }
+    const OString& GetData() const { return m_sData; }
 
     /// adds new character data to the existing one
     void AddData( const OString &rData ) { m_sData += rData; }
@@ -296,7 +296,7 @@ public:
     virtual XMLNodeType GetNodeType() const override { return XMLNodeType::COMMENT; }
 
     /// returns the comment
-    OString GetComment() const { return m_sComment; }
+    const OString& GetComment() const { return m_sComment; }
 };
 
 /** Holds additional file content like those for which no handler exists
@@ -319,7 +319,7 @@ public:
     virtual XMLNodeType GetNodeType() const override { return XMLNodeType::DEFAULT; }
 
     /// returns the comment
-    OString GetDefault() const { return m_sDefault; }
+    const OString& GetDefault() const { return m_sDefault; }
 };
 
 /** struct for error information, used by class SimpleXMLParser

l10ntools/inc/xrmmerge.hxx

@@ -55,7 +55,7 @@ protected:
         const OString &rCloseTag
     )=0;
 
-    OString GetGID() { return sGID; }
+    const OString& GetGID() { return sGID; }
 
 public:
     XRMResParser();

l10ntools/source/po.cxx

@@ -49,10 +49,10 @@ public:
     virtual             ~GenPoEntry();
                         // Default copy constructor and copy operator work well
 
-    OString     getReference() const    { return m_sReference; }
-    OString     getMsgCtxt() const      { return m_sMsgCtxt; }
-    OString     getMsgId() const        { return m_sMsgId; }
-    OString     getMsgStr() const       { return m_sMsgStr; }
+    const OString& getReference() const    { return m_sReference; }
+    const OString& getMsgCtxt() const      { return m_sMsgCtxt; }
+    const OString& getMsgId() const        { return m_sMsgId; }
+    const OString& getMsgStr() const       { return m_sMsgStr; }
     bool        isFuzzy() const         { return m_bFuzzy; }
     bool        isNull() const          { return m_bNull; }
 

lingucomponent/source/languageguessing/guess.hxx

@@ -48,8 +48,8 @@ class Guess{
 
         ~Guess();
 
-        string GetLanguage() { return language_str;}
-        string GetCountry() { return country_str;}
+        const string& GetLanguage() { return language_str;}
+        const string& GetCountry() { return country_str;}
 
     protected:
         string language_str;

linguistic/source/lngopt.hxx

@@ -59,7 +59,7 @@ public:
 
     static OUString    GetName( sal_Int32 nWID );
 
-    const css::uno::Sequence< OUString >
+    const css::uno::Sequence< OUString >&
             GetActiveDics() const   { return pData->aActiveDics; }
 };
 

mysqlc/source/mysqlc_driver.hxx

@@ -100,7 +100,7 @@ namespace connectivity
             sal_Int32 SAL_CALL getMajorVersion()                            throw(RuntimeException, std::exception) SAL_OVERRIDE;
             sal_Int32 SAL_CALL getMinorVersion()                            throw(RuntimeException, std::exception) SAL_OVERRIDE;
 
-            inline Reference< css::lang::XMultiServiceFactory > getFactory() const { return m_xFactory; }
+            const Reference< css::lang::XMultiServiceFactory >& getFactory() const { return m_xFactory; }
 
             static rtl_TextEncoding getDefaultEncoding() { return RTL_TEXTENCODING_UTF8; }
 

package/inc/ZipOutputEntry.hxx

@@ -72,7 +72,7 @@ public:
     void createBufferFile();
     void setParallelDeflateException(const ::css::uno::Any &rAny) { m_aParallelDeflateException = rAny; }
     css::uno::Reference< css::io::XInputStream > getData() const;
-    ::css::uno::Any getParallelDeflateException() const { return m_aParallelDeflateException; }
+    const css::uno::Any& getParallelDeflateException() const { return m_aParallelDeflateException; }
     void closeBufferFile();
     void deleteBufferFile();
 

package/inc/ZipOutputStream.hxx

@@ -57,7 +57,7 @@ public:
 
     void finish()
         throw(css::io::IOException, css::uno::RuntimeException);
-    css::uno::Reference< css::io::XOutputStream > getStream();
+    const css::uno::Reference< css::io::XOutputStream >& getStream();
 
     static sal_uInt32 getCurrentDosTime();
     static void setEntry( ZipEntry *pEntry );

package/inc/ZipPackageBuffer.hxx

@@ -40,7 +40,7 @@ public:
     virtual ~ZipPackageBuffer();
 
     inline void realloc ( sal_Int32 nSize ) { m_aBuffer.realloc ( nSize ); }
-    inline const css::uno::Sequence < sal_Int8> getSequence () const { return m_aBuffer; }
+    const css::uno::Sequence < sal_Int8>& getSequence () const { return m_aBuffer; }
 
     // XInputStream
     virtual sal_Int32 SAL_CALL readBytes( css::uno::Sequence< sal_Int8 >& aData, sal_Int32 nBytesToRead )

package/source/zipapi/ZipOutputStream.cxx

@@ -189,7 +189,7 @@ void ZipOutputStream::finish()
     m_aZipList.clear();
 }
 
-css::uno::Reference< css::io::XOutputStream > ZipOutputStream::getStream()
+const css::uno::Reference< css::io::XOutputStream >& ZipOutputStream::getStream()
 {
     return m_xStream;
 }

pyuno/source/module/pyuno_impl.hxx

@@ -351,8 +351,8 @@ public:
              const css::uno::Sequence< css::uno::Type > & types );
 
     static css::uno::Sequence< sal_Int8 > getUnoTunnelImplementationId();
-    PyRef getWrappedObject() { return mWrappedObject; }
-    css::uno::Sequence< css::uno::Type > getWrappedTypes() { return mTypes; }
+    const PyRef& getWrappedObject() const { return mWrappedObject; }
+    const css::uno::Sequence< css::uno::Type >& getWrappedTypes() const { return mTypes; }
     virtual ~Adapter();
 
     // XInvocation

rsc/inc/rscclobj.hxx

@@ -38,7 +38,7 @@ public:
                 ObjNode( const RscId & rId, CLASS_DATA pData, sal_uLong lKey );
     ObjNode *   DelObjNode( RscTop * pClass, sal_uLong lFileKey );
     sal_uInt32  GetId() const override;
-    RscId       GetRscId() const { return aRscId; }
+    const RscId& GetRscId() const { return aRscId; }