Kaydet (Commit) b09deb07 authored tarafından Noel Grandin's avatar Noel Grandin

loplugin:constparams handle constructors

had to change the structure of the plugin considerably, was too messy to
structure it to do the calculations on a per-function basis

Change-Id: I4edee7735f726101105c607368124a08dba21086
Reviewed-on: https://gerrit.libreoffice.org/40516Tested-by: 's avatarJenkins <ci@libreoffice.org>
Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
üst 587d6e13
......@@ -61,7 +61,7 @@ namespace accessibility
@param _xParent
is our parent accessible object
*/
AccessibleIconChoiceCtrl( SvtIconChoiceCtrl& _rIconCtrl,
AccessibleIconChoiceCtrl( SvtIconChoiceCtrl const & _rIconCtrl,
const css::uno::Reference< css::accessibility::XAccessible >& _xParent );
// XTypeProvider
......
......@@ -74,7 +74,7 @@ namespace accessibility
@param _xParent
is our parent accessible object
*/
AccessibleListBox( SvTreeListBox& _rListBox,
AccessibleListBox( SvTreeListBox const & _rListBox,
const css::uno::Reference< css::accessibility::XAccessible >& _xParent );
// XTypeProvider
......
......@@ -44,7 +44,7 @@ namespace accessibility
// Ctor() and Dtor()
AccessibleIconChoiceCtrl::AccessibleIconChoiceCtrl( SvtIconChoiceCtrl& _rIconCtrl, const Reference< XAccessible >& _xParent ) :
AccessibleIconChoiceCtrl::AccessibleIconChoiceCtrl( SvtIconChoiceCtrl const & _rIconCtrl, const Reference< XAccessible >& _xParent ) :
VCLXAccessibleComponent( _rIconCtrl.GetWindowPeer() ),
m_xParent ( _xParent )
......
......@@ -49,7 +49,7 @@ namespace accessibility
// Ctor() and Dtor()
AccessibleListBox::AccessibleListBox( SvTreeListBox& _rListBox, const Reference< XAccessible >& _xParent ) :
AccessibleListBox::AccessibleListBox( SvTreeListBox const & _rListBox, const Reference< XAccessible >& _xParent ) :
VCLXAccessibleComponent( _rListBox.GetWindowPeer() ),
m_xParent( _xParent )
......
......@@ -438,7 +438,7 @@ BasicLibInfo* BasicLibInfo::Create( SotStorageStream& rSStream )
return pInfo;
}
BasicManager::BasicManager( SotStorage& rStorage, const OUString& rBaseURL, StarBASIC* pParentFromStdLib, OUString* pLibPath, bool bDocMgr ) : mbDocMgr( bDocMgr )
BasicManager::BasicManager( SotStorage& rStorage, const OUString& rBaseURL, StarBASIC* pParentFromStdLib, OUString const * pLibPath, bool bDocMgr ) : mbDocMgr( bDocMgr )
{
Init();
......@@ -604,7 +604,7 @@ void BasicManager::SetLibraryContainerInfo( const LibraryContainerInfo& rInfo )
SetGlobalUNOConstant( "DialogLibraries", uno::Any( mpImpl->maContainerInfo.mxDialogCont ) );
}
BasicManager::BasicManager( StarBASIC* pSLib, OUString* pLibPath, bool bDocMgr ) : mbDocMgr( bDocMgr )
BasicManager::BasicManager( StarBASIC* pSLib, OUString const * pLibPath, bool bDocMgr ) : mbDocMgr( bDocMgr )
{
Init();
DBG_ASSERT( pSLib, "BasicManager cannot be created with a NULL-Pointer!" );
......
......@@ -292,8 +292,8 @@ class UCBStream : public SvStream
Reference< XStream > xS;
Reference< XSeekable > xSeek;
public:
explicit UCBStream( Reference< XInputStream > & xIS );
explicit UCBStream( Reference< XStream > & xS );
explicit UCBStream( Reference< XInputStream > const & xIS );
explicit UCBStream( Reference< XStream > const & xS );
virtual ~UCBStream() override;
virtual std::size_t GetData( void* pData, std::size_t nSize ) override;
virtual std::size_t PutData( const void* pData, std::size_t nSize ) override;
......@@ -302,13 +302,13 @@ public:
virtual void SetSize( sal_uInt64 nSize ) override;
};
UCBStream::UCBStream( Reference< XInputStream > & rStm )
UCBStream::UCBStream( Reference< XInputStream > const & rStm )
: xIS( rStm )
, xSeek( rStm, UNO_QUERY )
{
}
UCBStream::UCBStream( Reference< XStream > & rStm )
UCBStream::UCBStream( Reference< XStream > const & rStm )
: xS( rStm )
, xSeek( rStm, UNO_QUERY )
{
......
......@@ -1197,7 +1197,7 @@ namespace
PackedFileEntry(
sal_uInt32 nFullFileSize,
sal_uInt32 nCrc32,
FileSharedPtr& rFile,
FileSharedPtr const & rFile,
bool bDoCompress)
: mnFullFileSize(nFullFileSize),
mnPackFileSize(nFullFileSize),
......@@ -1549,7 +1549,7 @@ namespace
return bRetval;
}
bool tryPush(FileSharedPtr& rFileCandidate, bool bCompress)
bool tryPush(FileSharedPtr const & rFileCandidate, bool bCompress)
{
sal_uInt64 nFileSize(0);
......
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
struct Class1
{
int const * m_f1;
Class1(int * f1) : m_f1(f1) {} // expected-error {{this parameter can be const [loplugin:constparams]}}
};
struct Class2
{
int * m_f2;
Class2(int * f2) : m_f2(f2) {}
};
struct Class3
{
int * m_f2;
Class3(void * f2) : m_f2(static_cast<int*>(f2)) {}
};
/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */
......@@ -65,7 +65,7 @@ void OOperandValue::setValue(const ORowSetValue& _rVal)
m_aValue = _rVal;
}
OOperandParam::OOperandParam(OSQLParseNode* pNode, sal_Int32 _nPos)
OOperandParam::OOperandParam(OSQLParseNode const * pNode, sal_Int32 _nPos)
: OOperandRow(static_cast<sal_uInt16>(_nPos), DataType::VARCHAR) // Standard-Type
{
OSL_ENSURE(SQL_ISRULE(pNode,parameter),"Argument is not a parameter");
......
......@@ -134,7 +134,7 @@ void OPredicateCompiler::start(OSQLParseNode const * pSQLParseNode)
}
OOperand* OPredicateCompiler::execute(OSQLParseNode* pPredicateNode)
OOperand* OPredicateCompiler::execute(OSQLParseNode const * pPredicateNode)
{
OOperand* pOperand = nullptr;
if (pPredicateNode->count() == 3 && // Expression is bracketed
......@@ -408,7 +408,7 @@ void OPredicateCompiler::execute_ISNULL(OSQLParseNode const * pPredicateNode)
m_aCodeList.push_back(pOperator);
}
OOperand* OPredicateCompiler::execute_Operand(OSQLParseNode* pPredicateNode)
OOperand* OPredicateCompiler::execute_Operand(OSQLParseNode const * pPredicateNode)
{
OOperand* pOperand = nullptr;
......
......@@ -31,7 +31,7 @@ using namespace ::com::sun::star::uno;
Blob::Blob(isc_db_handle* pDatabaseHandle,
isc_tr_handle* pTransactionHandle,
ISC_QUAD& aBlobID):
ISC_QUAD const & aBlobID):
Blob_BASE(m_aMutex),
m_pDatabaseHandle(pDatabaseHandle),
m_pTransactionHandle(pTransactionHandle),
......
......@@ -58,7 +58,7 @@ namespace connectivity
public:
Blob(isc_db_handle* pDatabaseHandle,
isc_tr_handle* pTransactionHandle,
ISC_QUAD& aBlobID);
ISC_QUAD const & aBlobID);
// ---- XBlob ----------------------------------------------------
virtual sal_Int64 SAL_CALL
......
......@@ -26,7 +26,7 @@ using namespace ::com::sun::star::uno;
Clob::Clob(isc_db_handle* pDatabaseHandle,
isc_tr_handle* pTransactionHandle,
ISC_QUAD& aBlobID):
ISC_QUAD const & aBlobID):
Clob_BASE(m_aMutex),
m_aBlob(new connectivity::firebird::Blob(pDatabaseHandle, pTransactionHandle, aBlobID))
{
......
......@@ -41,7 +41,7 @@ namespace connectivity
public:
Clob(isc_db_handle* pDatabaseHandle,
isc_tr_handle* pTransactionHandle,
ISC_QUAD& aBlobID);
ISC_QUAD const & aBlobID);
// ---- XClob ----------------------------------------------------
virtual sal_Int64 SAL_CALL
......
......@@ -349,7 +349,7 @@ void Connection::notifyDatabaseModified()
IMPLEMENT_SERVICE_INFO(Connection, "com.sun.star.sdbc.drivers.firebird.Connection",
"com.sun.star.sdbc.Connection")
Reference< XBlob> Connection::createBlob(ISC_QUAD* pBlobId)
Reference< XBlob> Connection::createBlob(ISC_QUAD const * pBlobId)
{
MutexGuard aGuard(m_aMutex);
checkDisposed(Connection_BASE::rBHelper.bDisposed);
......@@ -362,7 +362,7 @@ Reference< XBlob> Connection::createBlob(ISC_QUAD* pBlobId)
return xReturn;
}
Reference< XClob> Connection::createClob(ISC_QUAD* pBlobId)
Reference< XClob> Connection::createClob(ISC_QUAD const * pBlobId)
{
MutexGuard aGuard(m_aMutex);
checkDisposed(Connection_BASE::rBHelper.bDisposed);
......
......@@ -211,11 +211,11 @@ namespace connectivity
* @throws css::uno::RuntimeException
*/
css::uno::Reference< css::sdbc::XBlob>
createBlob(ISC_QUAD* pBlobID);
createBlob(ISC_QUAD const * pBlobID);
/// @throws css::sdbc::SQLException
/// @throws css::uno::RuntimeException
css::uno::Reference< css::sdbc::XClob>
createClob(ISC_QUAD* pBlobID);
createClob(ISC_QUAD const * pBlobID);
/**
* Create and/or connect to the sdbcx Catalog. This is completely
......
......@@ -45,7 +45,7 @@ namespace connectivity
Tables(const css::uno::Reference< css::sdbc::XDatabaseMetaData >& rMetaData,
::cppu::OWeakObject& rParent,
::osl::Mutex& rMutex,
::connectivity::TStringVector& rNames) : sdbcx::OCollection(rParent, true, rMutex, rNames), m_xMetaData(rMetaData) {}
::connectivity::TStringVector const & rNames) : sdbcx::OCollection(rParent, true, rMutex, rNames), m_xMetaData(rMetaData) {}
// TODO: we should also implement XDataDescriptorFactory, XRefreshable,
// XAppend, etc., but all are optional.
......
......@@ -30,7 +30,7 @@ using namespace ::com::sun::star::uno;
Users::Users(const uno::Reference< XDatabaseMetaData >& rMetaData,
OWeakObject& rParent,
Mutex& rMutex,
TStringVector& rNames) :
TStringVector const & rNames) :
OCollection(rParent,
true,
rMutex,
......
......@@ -42,7 +42,7 @@ namespace connectivity
Users(const css::uno::Reference< css::sdbc::XDatabaseMetaData >& rMetaData,
::cppu::OWeakObject& rParent,
::osl::Mutex& rMutex,
::connectivity::TStringVector& rNames);
::connectivity::TStringVector const & rNames);
// TODO: we should also implement XDataDescriptorFactory, XRefreshable,
// XAppend, etc., but all are optional.
......
......@@ -117,7 +117,7 @@ ResultSetMetaData::ResultSetMetaData(
const css::uno::Reference< css::sdbc::XResultSet > & origin,
ResultSet * pResultSet,
ConnectionSettings **ppSettings,
PGresult *pResult,
PGresult const *pResult,
const OUString &schemaName,
const OUString &tableName ) :
m_xMutex( refMutex ),
......
......@@ -94,7 +94,7 @@ public:
const css::uno::Reference< css::sdbc::XResultSet > & origin,
ResultSet *pResultSet,
ConnectionSettings **pSettings,
PGresult *pResult,
PGresult const *pResult,
const OUString &schemaName,
const OUString &tableName );
......
......@@ -110,7 +110,7 @@ namespace connectivity
class OOperandParam : public OOperandRow
{
public:
OOperandParam(connectivity::OSQLParseNode* pNode, sal_Int32 _nPos);
OOperandParam(connectivity::OSQLParseNode const * pNode, sal_Int32 _nPos);
};
// Value operands
......
......@@ -59,7 +59,7 @@ namespace connectivity
void dispose();
void start(connectivity::OSQLParseNode const * pSQLParseNode);
OOperand* execute(connectivity::OSQLParseNode* pPredicateNode);
OOperand* execute(connectivity::OSQLParseNode const * pPredicateNode);
void Clean();
bool isClean() const {return m_aCodeList.empty();}
......@@ -81,7 +81,7 @@ namespace connectivity
void execute_ISNULL(connectivity::OSQLParseNode const * pPredicateNode);
/// @throws css::sdbc::SQLException
/// @throws css::uno::RuntimeException
OOperand* execute_Operand(connectivity::OSQLParseNode* pPredicateNode);
OOperand* execute_Operand(connectivity::OSQLParseNode const * pPredicateNode);
/// @throws css::sdbc::SQLException
/// @throws css::uno::RuntimeException
void execute_Fold(OSQLParseNode const * pPredicateNode);
......
......@@ -769,7 +769,7 @@ namespace cppcanvas
const OUString& rText,
sal_Int32 nStartPos,
sal_Int32 nLen,
VirtualDevice& rVDev,
VirtualDevice const & rVDev,
const CanvasSharedPtr& rCanvas,
const OutDevState& rState );
......@@ -781,7 +781,7 @@ namespace cppcanvas
const OUString& rText,
sal_Int32 nStartPos,
sal_Int32 nLen,
VirtualDevice& rVDev,
VirtualDevice const & rVDev,
const CanvasSharedPtr& rCanvas,
const OutDevState& rState,
const ::basegfx::B2DHomMatrix& rTextTransform );
......@@ -833,7 +833,7 @@ namespace cppcanvas
const OUString& rText,
sal_Int32 nStartPos,
sal_Int32 nLen,
VirtualDevice& rVDev,
VirtualDevice const & rVDev,
const CanvasSharedPtr& rCanvas,
const OutDevState& rState ) :
mxFont( rState.xFont ),
......@@ -872,7 +872,7 @@ namespace cppcanvas
const OUString& rText,
sal_Int32 nStartPos,
sal_Int32 nLen,
VirtualDevice& rVDev,
VirtualDevice const & rVDev,
const CanvasSharedPtr& rCanvas,
const OutDevState& rState,
const ::basegfx::B2DHomMatrix& rTextTransform ) :
......@@ -1190,7 +1190,7 @@ namespace cppcanvas
sal_Int32 nStartPos,
sal_Int32 nLen,
const uno::Sequence< double >& rOffsets,
VirtualDevice& rVDev,
VirtualDevice const & rVDev,
const CanvasSharedPtr& rCanvas,
const OutDevState& rState );
EffectTextArrayAction( const ::basegfx::B2DPoint& rStartPoint,
......@@ -1202,7 +1202,7 @@ namespace cppcanvas
sal_Int32 nStartPos,
sal_Int32 nLen,
const uno::Sequence< double >& rOffsets,
VirtualDevice& rVDev,
VirtualDevice const & rVDev,
const CanvasSharedPtr& rCanvas,
const OutDevState& rState,
const ::basegfx::B2DHomMatrix& rTextTransform );
......@@ -1252,7 +1252,7 @@ namespace cppcanvas
sal_Int32 nStartPos,
sal_Int32 nLen,
const uno::Sequence< double >& rOffsets,
VirtualDevice& rVDev,
VirtualDevice const & rVDev,
const CanvasSharedPtr& rCanvas,
const OutDevState& rState ) :
mxTextLayout(),
......@@ -1292,7 +1292,7 @@ namespace cppcanvas
sal_Int32 nStartPos,
sal_Int32 nLen,
const uno::Sequence< double >& rOffsets,
VirtualDevice& rVDev,
VirtualDevice const & rVDev,
const CanvasSharedPtr& rCanvas,
const OutDevState& rState,
const ::basegfx::B2DHomMatrix& rTextTransform ) :
......@@ -1527,7 +1527,7 @@ namespace cppcanvas
const ::basegfx::B2DRectangle& rOutlineBounds,
const uno::Reference< rendering::XPolyPolygon2D >& rTextPoly,
const uno::Sequence< double >& rOffsets,
VirtualDevice& rVDev,
VirtualDevice const & rVDev,
const CanvasSharedPtr& rCanvas,
const OutDevState& rState );
OutlineAction( const ::basegfx::B2DPoint& rStartPoint,
......@@ -1538,7 +1538,7 @@ namespace cppcanvas
const ::basegfx::B2DRectangle& rOutlineBounds,
const uno::Reference< rendering::XPolyPolygon2D >& rTextPoly,
const uno::Sequence< double >& rOffsets,
VirtualDevice& rVDev,
VirtualDevice const & rVDev,
const CanvasSharedPtr& rCanvas,
const OutDevState& rState,
const ::basegfx::B2DHomMatrix& rTextTransform );
......@@ -1604,7 +1604,7 @@ namespace cppcanvas
const ::basegfx::B2DRectangle& rOutlineBounds,
const uno::Reference< rendering::XPolyPolygon2D >& rTextPoly,
const uno::Sequence< double >& rOffsets,
VirtualDevice& rVDev,
VirtualDevice const & rVDev,
const CanvasSharedPtr& rCanvas,
const OutDevState& rState ) :
mxTextPoly( rTextPoly ),
......@@ -1645,7 +1645,7 @@ namespace cppcanvas
const ::basegfx::B2DRectangle& rOutlineBounds,
const uno::Reference< rendering::XPolyPolygon2D >& rTextPoly,
const uno::Sequence< double >& rOffsets,
VirtualDevice& rVDev,
VirtualDevice const & rVDev,
const CanvasSharedPtr& rCanvas,
const OutDevState& rState,
const ::basegfx::B2DHomMatrix& rTextTransform ) :
......
......@@ -398,7 +398,7 @@ namespace drawinglayer
public:
explicit Executor(
std::shared_ptr<comphelper::ThreadTaskTag>& rTag,
std::shared_ptr<comphelper::ThreadTaskTag> const & rTag,
processor3d::ZBufferProcessor3D* pZBufferProcessor3D,
const primitive3d::Primitive3DContainer& rChildren3D)
: comphelper::ThreadTask(rTag),
......
......@@ -237,8 +237,8 @@ public:
virtual void dispose() override;
};
static sal_uInt16 lcl_FindLogicalName(BibConfig* pConfig ,
const OUString& rLogicalColumnName)
static sal_uInt16 lcl_FindLogicalName(BibConfig const * pConfig ,
const OUString& rLogicalColumnName)
{
for(sal_uInt16 i = 0; i < COLUMN_COUNT; i++)
{
......
......@@ -366,7 +366,7 @@ bool BibFrameController_Impl::SaveModified(const Reference< form::runtime::XForm
return bResult;
}
static vcl::Window* lcl_GetFocusChild( vcl::Window* pParent )
static vcl::Window* lcl_GetFocusChild( vcl::Window const * pParent )
{
sal_uInt16 nChildren = pParent->GetChildCount();
for( sal_uInt16 nChild = 0; nChild < nChildren; ++nChild)
......
......@@ -157,7 +157,7 @@ bool LdapUserProfileBe::readLdapConfiguration(
bool LdapUserProfileBe::getLdapStringParam(
uno::Reference<container::XNameAccess>& xAccess,
uno::Reference<container::XNameAccess> const & xAccess,
const OUString& aLdapSetting,
OUString& aServerParameter)
{
......
......@@ -116,7 +116,7 @@ class LdapUserProfileBe : private LdapProfileMutexHolder, public BackendBase
uno::Reference<uno::XComponentContext> const & context,
LdapDefinition * definition, OUString * loggedOnUser);
static bool getLdapStringParam(uno::Reference<container::XNameAccess>& xAccess,
static bool getLdapStringParam(uno::Reference<container::XNameAccess> const & xAccess,
const OUString& aLdapSetting,
OUString& aServerParameter);
......
......@@ -77,7 +77,7 @@ static OUString getImplementationName()
namespace
{
Image GetMenuBarIcon( MenuBar* pMBar )
Image GetMenuBarIcon( MenuBar const * pMBar )
{
OUString sResID;
vcl::Window *pMBarWin = pMBar->GetWindow();
......
......@@ -307,7 +307,7 @@ bool isRangeResultOpCode( OpCode eOp )
checked, bRight==true means opcodes for right side. If bRPN==true
it doesn't matter.
*/
bool isPotentialRangeType( FormulaToken* pToken, bool bRPN, bool bRight )
bool isPotentialRangeType( FormulaToken const * pToken, bool bRPN, bool bRight )
{
switch (pToken->GetType())
{
......
......@@ -153,8 +153,8 @@ class MenuBarManager:
struct MenuItemHandler
{
MenuItemHandler( sal_uInt16 aItemId,
css::uno::Reference< css::frame::XStatusListener >& xManager,
css::uno::Reference< css::frame::XDispatch >& rDispatch ) :
css::uno::Reference< css::frame::XStatusListener > const & xManager,
css::uno::Reference< css::frame::XDispatch > const & rDispatch ) :
nItemId( aItemId ),
xSubMenuManager( xManager ),
xMenuItemDispatch( rDispatch ) {}
......
......@@ -36,7 +36,7 @@ class FWE_DLLPUBLIC SaxNamespaceFilter :
public ::cppu::WeakImplHelper< css::xml::sax::XDocumentHandler >
{
public:
SaxNamespaceFilter( css::uno::Reference< css::xml::sax::XDocumentHandler >& rSax1DocumentHandler );
SaxNamespaceFilter( css::uno::Reference< css::xml::sax::XDocumentHandler > const & rSax1DocumentHandler );
virtual ~SaxNamespaceFilter() override;
// XDocumentHandler
......
......@@ -121,7 +121,7 @@ class FWE_DLLPUBLIC OWriteToolBoxDocumentHandler final
public:
OWriteToolBoxDocumentHandler(
const css::uno::Reference< css::container::XIndexAccess >& rItemAccess,
css::uno::Reference< css::xml::sax::XDocumentHandler >& rDocumentHandler );
css::uno::Reference< css::xml::sax::XDocumentHandler > const & rDocumentHandler );
~OWriteToolBoxDocumentHandler();
/// @throws css::xml::sax::SAXException
......
......@@ -35,7 +35,7 @@ using namespace ::com::sun::star::uno;
namespace framework{
SaxNamespaceFilter::SaxNamespaceFilter( Reference< XDocumentHandler >& rSax1DocumentHandler ) :
SaxNamespaceFilter::SaxNamespaceFilter( Reference< XDocumentHandler > const & rSax1DocumentHandler ) :
m_xLocator( nullptr ),
xDocumentHandler( rSax1DocumentHandler ),
m_aXMLAttributeNamespace( "xmlns" ),
......
......@@ -583,7 +583,7 @@ OUString OReadToolBoxDocumentHandler::getErrorLineString()
OWriteToolBoxDocumentHandler::OWriteToolBoxDocumentHandler(
const Reference< XIndexAccess >& rItemAccess,
Reference< XDocumentHandler >& rWriteDocumentHandler ) :
Reference< XDocumentHandler > const & rWriteDocumentHandler ) :
m_xWriteDocumentHandler( rWriteDocumentHandler ),
m_rItemAccess( rItemAccess )
{
......
......@@ -58,8 +58,8 @@ class SvParseException : public std::exception
{
public:
SvIdlError aError;
SvParseException( SvTokenStream & rInStm, const OString& rError );
SvParseException( const OString& rError, SvToken& rTok );
SvParseException( SvTokenStream const & rInStm, const OString& rError );
SvParseException( const OString& rError, SvToken const & rTok );
};
......
......@@ -28,14 +28,14 @@
#include <osl/file.hxx>
SvParseException::SvParseException( SvTokenStream & rInStm, const OString& rError )
SvParseException::SvParseException( SvTokenStream const & rInStm, const OString& rError )
{
SvToken& rTok = rInStm.GetToken();
aError = SvIdlError( rTok.GetLine(), rTok.GetColumn() );
aError.SetText( rError );
};
SvParseException::SvParseException( const OString& rError, SvToken& rTok )
SvParseException::SvParseException( const OString& rError, SvToken const & rTok )
{
aError = SvIdlError( rTok.GetLine(), rTok.GetColumn() );
aError.SetText( rError );
......
......@@ -133,8 +133,8 @@ protected:
virtual ~BasicManager() override;
public:
BasicManager( SotStorage& rStorage, const OUString& rBaseURL, StarBASIC* pParentFromStdLib = nullptr, OUString* pLibPath = nullptr, bool bDocMgr = false );
BasicManager( StarBASIC* pStdLib, OUString* pLibPath = nullptr, bool bDocMgr = false );
BasicManager( SotStorage& rStorage, const OUString& rBaseURL, StarBASIC* pParentFromStdLib = nullptr, OUString const * pLibPath = nullptr, bool bDocMgr = false );
BasicManager( StarBASIC* pStdLib, OUString const * pLibPath = nullptr, bool bDocMgr = false );
/** deletes the given BasicManager instance
......
......@@ -93,7 +93,7 @@ protected:
public:
PropertyChgHelper(
const css::uno::Reference< css::uno::XInterface > &rxSource,
css::uno::Reference< css::linguistic2::XLinguProperties > &rxPropSet,
css::uno::Reference< css::linguistic2::XLinguProperties > const &rxPropSet,
int nAllowedEvents );
virtual ~PropertyChgHelper() override;
......@@ -138,7 +138,7 @@ class PropertyHelper_Thes :
public:
PropertyHelper_Thes(
const css::uno::Reference< css::uno::XInterface > &rxSource,
css::uno::Reference< css::linguistic2::XLinguProperties > &rxPropSet );
css::uno::Reference< css::linguistic2::XLinguProperties > const &rxPropSet );
virtual ~PropertyHelper_Thes() override;
// XPropertyChangeListener
......@@ -158,7 +158,7 @@ class LNG_DLLPUBLIC PropertyHelper_Thesaurus
public:
PropertyHelper_Thesaurus(
const css::uno::Reference< css::uno::XInterface > &rxSource,
css::uno::Reference< css::linguistic2::XLinguProperties > &rxPropSet );
css::uno::Reference< css::linguistic2::XLinguProperties > const &rxPropSet );
~PropertyHelper_Thesaurus();
void AddAsPropListener();
void RemoveAsPropListener();
......@@ -193,7 +193,7 @@ protected:
public:
PropertyHelper_Spell(
const css::uno::Reference< css::uno::XInterface > &rxSource,
css::uno::Reference< css::linguistic2::XLinguProperties > &rxPropSet );
css::uno::Reference< css::linguistic2::XLinguProperties > const &rxPropSet );
virtual ~PropertyHelper_Spell() override;
virtual void SetTmpPropVals( const css::beans::PropertyValues &rPropVals ) override;
......@@ -222,7 +222,7 @@ class LNG_DLLPUBLIC PropertyHelper_Spelling
public:
PropertyHelper_Spelling(
const css::uno::Reference< css::uno::XInterface > &rxSource,
css::uno::Reference< css::linguistic2::XLinguProperties > &rxPropSet );
css::uno::Reference< css::linguistic2::XLinguProperties > const &rxPropSet );
~PropertyHelper_Spelling();
void AddAsPropListener();
......@@ -266,7 +266,7 @@ protected:
public:
PropertyHelper_Hyphen(
const css::uno::Reference< css::uno::XInterface > &rxSource,
css::uno::Reference< css::linguistic2::XLinguProperties > &rxPropSet);
css::uno::Reference< css::linguistic2::XLinguProperties > const &rxPropSet);
virtual ~PropertyHelper_Hyphen() override;
virtual void SetTmpPropVals( const css::beans::PropertyValues &rPropVals ) override;
......@@ -292,7 +292,7 @@ class LNG_DLLPUBLIC PropertyHelper_Hyphenation
public:
PropertyHelper_Hyphenation(
const css::uno::Reference< css::uno::XInterface > &rxSource,
css::uno::Reference< css::linguistic2::XLinguProperties > &rxPropSet);
css::uno::Reference< css::linguistic2::XLinguProperties > const &rxPropSet);
~PropertyHelper_Hyphenation();
void AddAsPropListener();
......
......@@ -554,7 +554,7 @@ public:
This constructor is internal only.
*/
inline RegistryKey(Registry& registry,
inline RegistryKey(Registry const & registry,
RegKeyHandle hKey);
protected:
......@@ -645,7 +645,7 @@ inline RegistryKey::RegistryKey()
{ }
/// @cond INTERNAL
inline RegistryKey::RegistryKey(Registry& registry, RegKeyHandle hKey)
inline RegistryKey::RegistryKey(Registry const & registry, RegKeyHandle hKey)
: m_registry(registry)
, m_hImpl(hKey)
{
......