loplugin:unnecessaryoverride (dtors) in stoc

Change-Id: I60652dbac6a76eacdbb4e951a636e7a40e88a6a6

stoc/source/corereflection/crenum.cxx

@@ -42,7 +42,6 @@ public:
         : IdlMemberImpl( pReflection, rName, pTypeDescr, pTypeDescr )
         , _nValue( nValue )
         {}
-    virtual ~IdlEnumFieldImpl() override;
 
     // XInterface
     virtual Any SAL_CALL queryInterface( const Type & rType ) throw(css::uno::RuntimeException, std::exception) override;
@@ -65,10 +64,6 @@ public:
     virtual void SAL_CALL set( Any & rObj, const Any & rValue ) throw(css::lang::IllegalArgumentException, css::lang::IllegalAccessException, css::uno::RuntimeException, std::exception) override;
 };
 
-IdlEnumFieldImpl::~IdlEnumFieldImpl()
-{
-}
-
 // XInterface
 
 Any IdlEnumFieldImpl::queryInterface( const Type & rType )

stoc/source/defaultregistry/defaultregistry.cxx

@@ -52,8 +52,6 @@ class NestedRegistryImpl    : public WeakAggImplHelper4 < XSimpleRegistry, XInit
 public:
     NestedRegistryImpl( );
 
-    virtual ~NestedRegistryImpl() override;
-
     // XServiceInfo
     virtual OUString SAL_CALL getImplementationName(  ) throw(RuntimeException, std::exception) override;
     virtual sal_Bool SAL_CALL supportsService( const OUString& ServiceName ) throw(RuntimeException, std::exception) override;
@@ -100,8 +98,6 @@ public:
     NestedKeyImpl( const OUString& aKeyName,
                     NestedKeyImpl* pKey);
 
-    virtual ~NestedKeyImpl() override;
-
     // XRegistryKey
     virtual OUString SAL_CALL getKeyName() throw(RuntimeException, std::exception) override;
     virtual sal_Bool SAL_CALL isReadOnly(  ) throw(InvalidRegistryException, RuntimeException, std::exception) override;
@@ -191,12 +187,6 @@ NestedKeyImpl::NestedKeyImpl( const OUString& rKeyName,
     m_state = m_xRegistry->m_state;
 }
 
-
-NestedKeyImpl::~NestedKeyImpl()
-{
-}
-
-
 void NestedKeyImpl::computeChanges()
 {
     Guard< Mutex > aGuard( m_xRegistry->m_mutex );
@@ -1106,9 +1096,6 @@ NestedRegistryImpl::NestedRegistryImpl( )
     : m_state(0)
 {}
 
-
-NestedRegistryImpl::~NestedRegistryImpl() {}
-
 class RegistryEnumueration : public WeakImplHelper< XEnumeration >
 {
 public:

stoc/source/implementationregistration/implreg.cxx

@@ -1196,7 +1196,6 @@ class ImplementationRegistration
 {
 public:
     explicit ImplementationRegistration( const Reference < XComponentContext > & rSMgr );
-    virtual ~ImplementationRegistration() override;
 
     // XServiceInfo
     OUString                        SAL_CALL getImplementationName() throw(RuntimeException, std::exception) override;
@@ -1277,11 +1276,6 @@ ImplementationRegistration::ImplementationRegistration( const Reference < XCompo
     , m_xCtx( xCtx )
 {}
 
-
-// ~ImplementationRegistration()
-
-ImplementationRegistration::~ImplementationRegistration() {}
-
 // XServiceInfo
 OUString ImplementationRegistration::getImplementationName() throw(RuntimeException, std::exception)
 {

stoc/source/inspect/introspection.cxx

@@ -707,7 +707,6 @@ class ImplIntrospectionAccess : public IntrospectionAccessHelper
 
 public:
     ImplIntrospectionAccess( const Any& obj, rtl::Reference< IntrospectionAccessStatic_Impl > const & pStaticImpl_ );
-    virtual ~ImplIntrospectionAccess() override;
 
     // Methods from XIntrospectionAccess
     virtual sal_Int32 SAL_CALL getSuppliedMethodConcepts()
@@ -832,11 +831,6 @@ ImplIntrospectionAccess::ImplIntrospectionAccess
     mnLastMethodConcept = -1;
 }
 
-ImplIntrospectionAccess::~ImplIntrospectionAccess()
-{
-}
-
-
 Reference<XElementAccess> ImplIntrospectionAccess::getXElementAccess()
 {
     ResettableGuard< Mutex > aGuard( m_aMutex );

stoc/source/invocation/invocation.cxx

@@ -99,7 +99,6 @@ public:
     Invocation_Impl( const Any & rAdapted, const Reference<XTypeConverter> &,
                                            const Reference<XIntrospection> &,
                                            const Reference<XIdlReflection> & );
-    virtual ~Invocation_Impl() override;
 
     // XInterface
     virtual Any         SAL_CALL queryInterface( const Type & aType) throw( RuntimeException, std::exception ) override;
@@ -246,9 +245,6 @@ Invocation_Impl::Invocation_Impl
     setMaterial( rAdapted );
 }
 
-Invocation_Impl::~Invocation_Impl() {}
-
-
 //### INTERFACE IMPLEMENTATIONS ####################################################################
 
 
@@ -1072,7 +1068,6 @@ class InvocationService
 {
 public:
     explicit InvocationService( const Reference<XComponentContext> & xCtx );
-    virtual ~InvocationService() override;
 
     // XServiceInfo
     OUString                    SAL_CALL getImplementationName() throw( RuntimeException, std::exception ) override;
@@ -1102,8 +1097,6 @@ InvocationService::InvocationService( const Reference<XComponentContext> & xCtx
     xIntrospection = theIntrospection::get(xCtx);
 }
 
-InvocationService::~InvocationService() {}
-
 // XServiceInfo
 OUString InvocationService::getImplementationName() throw( RuntimeException, std::exception )
 {

stoc/source/javaloader/javaloader.cxx

@@ -102,7 +102,6 @@ class JavaComponentLoader : public WeakImplHelper<XImplementationLoader, XServic
 public:
     explicit JavaComponentLoader(const css::uno::Reference<XComponentContext> & xCtx)
         throw(RuntimeException);
-    virtual ~JavaComponentLoader() throw() override;
 
 public:
     // XServiceInfo
@@ -296,10 +295,6 @@ JavaComponentLoader::JavaComponentLoader(const css::uno::Reference<XComponentCon
 
 }
 
-JavaComponentLoader::~JavaComponentLoader() throw()
-{
-}
-
 // XServiceInfo
 OUString SAL_CALL JavaComponentLoader::getImplementationName()
     throw(css::uno::RuntimeException, std::exception)

stoc/source/loader/dllcomponentloader.cxx

@@ -59,7 +59,6 @@ class DllComponentLoader
 {
 public:
     explicit DllComponentLoader( const Reference<XComponentContext> & xCtx );
-    virtual ~DllComponentLoader() override;
 
     // XServiceInfo
     virtual OUString SAL_CALL getImplementationName(  ) throw(css::uno::RuntimeException, std::exception) override;
@@ -83,10 +82,6 @@ DllComponentLoader::DllComponentLoader( const Reference<XComponentContext> & xCt
     m_xSMgr.set( xCtx->getServiceManager(), UNO_QUERY );
 }
 
-
-DllComponentLoader::~DllComponentLoader() {}
-
-
 OUString SAL_CALL DllComponentLoader::getImplementationName(  )
     throw(css::uno::RuntimeException, std::exception)
 {

stoc/source/namingservice/namingservice.cxx

@@ -76,7 +76,6 @@ class NamingService_Impl
     HashMap_OWString_Interface          aMap;
 public:
     NamingService_Impl();
-    virtual ~NamingService_Impl() override;
 
     // XServiceInfo
     virtual OUString SAL_CALL getImplementationName()
@@ -101,9 +100,6 @@ static Reference<XInterface> SAL_CALL NamingService_Impl_create(
 
 NamingService_Impl::NamingService_Impl() {}
 
-
-NamingService_Impl::~NamingService_Impl() {}
-
 // XServiceInfo
 OUString NamingService_Impl::getImplementationName()
     throw(css::uno::RuntimeException, std::exception)

stoc/source/proxy_factory/proxyfac.cxx

@@ -75,7 +75,6 @@ struct FactoryImpl : public ::cppu::WeakImplHelper< lang::XServiceInfo,
         typelib_InterfaceTypeDescription * pTypeDescr );
 
     FactoryImpl();
-    virtual ~FactoryImpl() override;
 
     // XServiceInfo
     virtual OUString SAL_CALL getImplementationName()
@@ -169,7 +168,6 @@ struct ProxyRoot : public ::cppu::OWeakAggObject
     virtual Any SAL_CALL queryAggregation( Type const & rType )
         throw (RuntimeException, std::exception) override;
 
-    virtual ~ProxyRoot() override;
     inline ProxyRoot( ::rtl::Reference< FactoryImpl > const & factory,
                       Reference< XInterface > const & xTarget );
 
@@ -303,12 +301,6 @@ inline binuno_Proxy::binuno_Proxy(
     uno_Interface::pDispatcher = binuno_proxy_dispatch;
 }
 
-
-ProxyRoot::~ProxyRoot()
-{
-}
-
-
 inline ProxyRoot::ProxyRoot(
     ::rtl::Reference< FactoryImpl > const & factory,
     Reference< XInterface > const & xTarget )
@@ -417,9 +409,6 @@ FactoryImpl::FactoryImpl()
     OSL_ENSURE( m_cpp2uno.is(), "### cannot get bridge C++ <-> uno!" );
 }
 
-
-FactoryImpl::~FactoryImpl() {}
-
 // XProxyFactory
 
 Reference< XAggregation > FactoryImpl::createProxy(

stoc/source/security/access_controller.cxx

@@ -79,8 +79,6 @@ class acc_Intersection
         Reference< security::XAccessControlContext > const & x2 );
 
 public:
-    virtual ~acc_Intersection() override;
-
     static inline Reference< security::XAccessControlContext > create(
         Reference< security::XAccessControlContext > const & x1,
         Reference< security::XAccessControlContext > const & x2 );
@@ -98,9 +96,6 @@ inline acc_Intersection::acc_Intersection(
     , m_x2( x2 )
 {}
 
-acc_Intersection::~acc_Intersection()
-{}
-
 inline Reference< security::XAccessControlContext > acc_Intersection::create(
     Reference< security::XAccessControlContext > const & x1,
     Reference< security::XAccessControlContext > const & x2 )
@@ -132,8 +127,6 @@ class acc_Union
         Reference< security::XAccessControlContext > const & x2 );
 
 public:
-    virtual ~acc_Union() override;
-
     static inline Reference< security::XAccessControlContext > create(
         Reference< security::XAccessControlContext > const & x1,
         Reference< security::XAccessControlContext > const & x2 );
@@ -151,9 +144,6 @@ inline acc_Union::acc_Union(
     , m_x2( x2 )
 {}
 
-acc_Union::~acc_Union()
-{}
-
 inline Reference< security::XAccessControlContext > acc_Union::create(
     Reference< security::XAccessControlContext > const & x1,
     Reference< security::XAccessControlContext > const & x2 )
@@ -192,17 +182,12 @@ public:
         : m_permissions( permissions )
     {}
 
-    virtual ~acc_Policy() override;
-
     // XAccessControlContext impl
     virtual void SAL_CALL checkPermission(
         Any const & perm )
         throw (RuntimeException, std::exception) override;
 };
 
-acc_Policy::~acc_Policy()
-{}
-
 void acc_Policy::checkPermission(
     Any const & perm )
     throw (RuntimeException, std::exception)
@@ -338,7 +323,6 @@ protected:
 
 public:
     explicit AccessController( Reference< XComponentContext > const & xComponentContext );
-    virtual ~AccessController() override;
 
     //  XInitialization impl
     virtual void SAL_CALL initialize(
@@ -431,9 +415,6 @@ AccessController::AccessController( Reference< XComponentContext > const & xComp
     }
 }
 
-AccessController::~AccessController()
-{}
-
 void AccessController::disposing()
 {
     m_mode = OFF; // avoid checks from now on xxx todo review/ better DYNAMIC_ONLY?

stoc/source/security/file_policy.cxx

@@ -72,7 +72,6 @@ protected:
 
 public:
     explicit FilePolicy( Reference< XComponentContext > const & xComponentContext );
-    virtual ~FilePolicy() override;
 
     // XPolicy impl
     virtual Sequence< Any > SAL_CALL getPermissions(
@@ -99,9 +98,6 @@ FilePolicy::FilePolicy( Reference< XComponentContext > const & xComponentContext
     , m_init( false )
 {}
 
-FilePolicy::~FilePolicy()
-{}
-
 void FilePolicy::disposing()
 {
     m_userPermissions.clear();

stoc/source/servicemanager/servicemanager.cxx

@@ -161,7 +161,6 @@ public:
         : aFactories( rFactories )
         , nIt( 0 )
         {}
-    virtual ~ServiceEnumeration_Impl() override {}
 
     // XEnumeration
     sal_Bool SAL_CALL hasMoreElements()
@@ -253,7 +252,6 @@ public:
         : aImplementationMap( rImplementationMap )
         , aIt( aImplementationMap.begin() )
         {}
-    virtual ~ImplementationEnumeration_Impl() override;
 
     // XEnumeration
     virtual sal_Bool SAL_CALL hasMoreElements()
@@ -267,8 +265,6 @@ private:
     HashSet_Ref::iterator           aIt;
 };
 
-ImplementationEnumeration_Impl::~ImplementationEnumeration_Impl() {}
-
 // XEnumeration
 sal_Bool ImplementationEnumeration_Impl::hasMoreElements()
     throw(css::uno::RuntimeException, std::exception)
@@ -372,7 +368,6 @@ class OServiceManager
 {
 public:
     explicit OServiceManager( Reference< XComponentContext > const & xContext );
-    virtual ~OServiceManager() override;
 
     // XInitialization
     void SAL_CALL initialize( Sequence< Any > const & args )
@@ -512,7 +507,6 @@ protected:
 public:
     explicit OServiceManagerWrapper(
         Reference< XComponentContext > const & xContext );
-    virtual ~OServiceManagerWrapper() override;
 
     // XServiceInfo
     virtual OUString SAL_CALL getImplementationName() throw (RuntimeException, std::exception) override
@@ -642,8 +636,6 @@ void OServiceManagerWrapper::disposing()
     m_root.clear();
 }
 
-OServiceManagerWrapper::~OServiceManagerWrapper() {}
-
 OServiceManagerWrapper::OServiceManagerWrapper(
     Reference< XComponentContext > const & xContext )
     : t_OServiceManagerWrapper_impl( m_mutex )
@@ -667,11 +659,6 @@ OServiceManager::OServiceManager( Reference< XComponentContext > const & xContex
     , m_bInDisposing( false )
 {}
 
-/**
- * Destroy the ServiceManager
- */
-OServiceManager::~OServiceManager() {}
-
 // XComponent
 void OServiceManager::dispose()
     throw(css::uno::RuntimeException, std::exception)
@@ -1270,7 +1257,6 @@ class ORegistryServiceManager : public OServiceManager
 {
 public:
     explicit ORegistryServiceManager( Reference< XComponentContext > const & xContext );
-    virtual ~ORegistryServiceManager() override;
 
     // XInitialization
     void SAL_CALL initialize(const Sequence< Any >& Arguments)
@@ -1332,13 +1318,6 @@ ORegistryServiceManager::ORegistryServiceManager( Reference< XComponentContext >
 {
 }
 
-/**
- * Destroy the ServiceManager
- */
-ORegistryServiceManager::~ORegistryServiceManager()
-{
-}
-
 // XComponent
 void ORegistryServiceManager::dispose()
     throw(css::uno::RuntimeException, std::exception)

stoc/source/simpleregistry/simpleregistry.cxx

@@ -58,8 +58,6 @@ class SimpleRegistry:
 public:
     SimpleRegistry() {}
 
-    virtual ~SimpleRegistry() override {}
-
     osl::Mutex mutex_;
 
 private:

stoc/source/typeconv/convert.cxx

@@ -251,7 +251,6 @@ class TypeConverter_Impl : public WeakImplHelper< XTypeConverter, XServiceInfo >
 
 public:
     TypeConverter_Impl();
-    virtual ~TypeConverter_Impl() override;
 
     // XServiceInfo
     virtual OUString SAL_CALL getImplementationName() throw( RuntimeException, std::exception ) override;
@@ -269,8 +268,6 @@ public:
 
 TypeConverter_Impl::TypeConverter_Impl() {}
 
-TypeConverter_Impl::~TypeConverter_Impl() {}
-
 // XServiceInfo
 OUString TypeConverter_Impl::getImplementationName() throw( RuntimeException, std::exception )
 {