Kaydet (Commit) 9c51e6fb authored tarafından Caolán McNamara's avatar Caolán McNamara

pvs-studio: V716 Suspicious type conversion in return statement

https://docs.microsoft.com/en-us/windows/desktop/api/objidl/nf-objidl-irunnableobject-isrunning

has IRunnableObject::IsRunning as returning BOOL unlike ::Run which returns HRESULT

Change-Id: I992d8ba33502eff56b582e1cb9b73f6227c383b8
Reviewed-on: https://gerrit.libreoffice.org/62169
Tested-by: Jenkins
Reviewed-by: 's avatarCaolán McNamara <caolanm@redhat.com>
Tested-by: 's avatarCaolán McNamara <caolanm@redhat.com>
üst e04e7a72
......@@ -1283,10 +1283,9 @@ STDMETHODIMP InprocEmbedDocument_Impl::Run( LPBINDCTX pbc )
return E_FAIL;
}
BOOL STDMETHODCALLTYPE InprocEmbedDocument_Impl::IsRunning()
{
if ( CheckDefHandler() )
if (CheckDefHandler())
{
ComSmart< IRunnableObject > pIRunObj;
HRESULT hr = m_pDefHandler->QueryInterface( IID_IRunnableObject, reinterpret_cast<void**>(&pIRunObj) );
......@@ -1296,11 +1295,9 @@ BOOL STDMETHODCALLTYPE InprocEmbedDocument_Impl::IsRunning()
return pIRunObj->IsRunning();
}
return E_FAIL;
return FALSE;
}
STDMETHODIMP InprocEmbedDocument_Impl::LockRunning( BOOL fLock, BOOL fLastUnlockCloses )
{
if ( CheckDefHandler() )
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment