loplugin:unusedmethods

Change-Id: I7f26ee112ed89ee3e69c56930260565f66ff145b
Reviewed-on: https://gerrit.libreoffice.org/40442Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

compilerplugins/clang/unusedmethods.unused-returns.results

@@ -30,7 +30,7 @@ chart2/source/view/main/OpenGLRender.hxx:121
     int OpenGLRender::Create2DCircle(int)
 connectivity/source/drivers/evoab2/NResultSet.hxx:125
     class com::sun::star::uno::Reference<class com::sun::star::uno::XInterface> connectivity::evoab::OEvoabResultSet::operator*()
-connectivity/source/drivers/evoab2/NResultSetMetaData.hxx:53
+connectivity/source/drivers/evoab2/NResultSetMetaData.hxx:51
     class com::sun::star::uno::Reference<class com::sun::star::sdbc::XResultSetMetaData> connectivity::evoab::OEvoabResultSetMetaData::operator Reference()
 connectivity/source/inc/java/lang/Object.hxx:118
     int connectivity::java_lang_Object::callIntMethodWithIntArg_ThrowRuntime(const char *,struct _jmethodID *&,int) const
@@ -270,6 +270,8 @@ include/vcl/gdimtf.hxx:185
     class SvStream & GDIMetaFile::Read(class SvStream &)
 include/vcl/graphicfilter.hxx:259
     class ErrCode GraphicFilter::ExportGraphic(const class Graphic &,const class INetURLObject &,unsigned short,const class com::sun::star::uno::Sequence<struct com::sun::star::beans::PropertyValue> *)
+include/vcl/menu.hxx:460
+    unsigned short MenuBar::AddMenuBarButton(const class Image &,const class Link<struct MenuBar::MenuBarButtonCallbackArg &, _Bool> &,const class rtl::OUString &)
 lotuswordpro/source/filter/lwpsvstream.hxx:76
     class LwpSvStream & LwpSvStream::ReadUInt8(unsigned char &)
 lotuswordpro/source/filter/lwpsvstream.hxx:77

editeng/source/rtf/svxrtf.cxx

@@ -568,67 +568,6 @@ void SvxRTFParser::ReadFontTable()
         SetDefault( RTF_DEFF, nDfltFont );
 }
 
-OUString& SvxRTFParser::GetTextToEndGroup( OUString& rStr )
-{
-    rStr.clear();
-    int _nOpenBrakets = 1;  // the first was already detected earlier!!
-
-    while( _nOpenBrakets && IsParserWorking() )
-    {
-        switch( GetNextToken() )
-        {
-        case '}':       --_nOpenBrakets;    break;
-        case '{':
-            {
-                if( RTF_IGNOREFLAG != GetNextToken() )
-                    SkipToken();
-                else if( RTF_UNKNOWNCONTROL != GetNextToken() )
-                    SkipToken( -2 );
-                else
-                {
-                    // filter out at once
-                    ReadUnknownData();
-                    int nToken = GetNextToken();
-                    if( '}' != nToken )
-                        eState = SvParserState::Error;
-                    break;
-                }
-                ++_nOpenBrakets;
-            }
-            break;
-
-        case RTF_TEXTTOKEN:
-            rStr += aToken;
-            break;
-        }
-    }
-    SkipToken();        // the closing brace is evaluated "above"
-    return rStr;
-}
-
-util::DateTime SvxRTFParser::GetDateTimeStamp( )
-{
-    util::DateTime aDT;
-    bool bContinue = true;
-
-    while( bContinue && IsParserWorking() )
-    {
-        int nToken = GetNextToken();
-        switch( nToken )
-        {
-        case RTF_YR:    aDT.Year = (sal_uInt16)nTokenValue;     break;
-        case RTF_MO:    aDT.Month = (sal_uInt16)nTokenValue;    break;
-        case RTF_DY:    aDT.Day = (sal_uInt16)nTokenValue;      break;
-        case RTF_HR:    aDT.Hours = (sal_uInt16)nTokenValue;    break;
-        case RTF_MIN:   aDT.Minutes = (sal_uInt16)nTokenValue;  break;
-        default:
-            bContinue = false;
-        }
-    }
-    SkipToken();        // the closing brace is evaluated "above"
-    return aDT;
-}
-
 void SvxRTFParser::ClearColorTbl()
 {
     while ( !aColorTbl.empty() )

include/editeng/svxrtf.hxx

@@ -249,10 +249,6 @@ protected:
     void ReadAttr( int nToken, SfxItemSet* pSet );
     void ReadTabAttr( int nToken, SfxItemSet& rSet );
 
-    // Read Document-Info
-    css::util::DateTime GetDateTimeStamp( );
-    OUString& GetTextToEndGroup( OUString& rStr );
-
     inline SfxItemSet& GetAttrSet();
     // no text yet inserted? (SttPos from the top stack entry!)
     bool IsAttrSttPos();

include/tools/unqidx.hxx

@@ -41,10 +41,7 @@ public:
 
     Index Insert( void* p );
     // insert value with key, replacing existing entry if necessary
-    void* Remove( Index aIndex );
     void* Get( Index aIndex ) const;
-
-    Index GetIndexOf( void const* p ) const;
 };
 
 template<typename T>

sc/inc/userdat.hxx

@@ -54,7 +54,6 @@ class ScIMapInfo : public SdrObjUserData
     ImageMap        aImageMap;
 
 public:
-                    ScIMapInfo();
                     ScIMapInfo( const ImageMap& rImageMap );
                     ScIMapInfo( const ScIMapInfo& rIMapInfo );
     virtual         ~ScIMapInfo() override;

sc/source/core/data/userdat.cxx

@@ -35,11 +35,6 @@ ScDrawObjData* ScDrawObjData::Clone( SdrObject* ) const
     return new ScDrawObjData( *this );
 }
 
-ScIMapInfo::ScIMapInfo() :
-    SdrObjUserData( SdrInventor::ScOrSwDraw, SC_UD_IMAPDATA )
-{
-}
-
 ScIMapInfo::ScIMapInfo( const ImageMap& rImageMap ) :
     SdrObjUserData( SdrInventor::ScOrSwDraw, SC_UD_IMAPDATA ),
     aImageMap( rImageMap )

sc/source/ui/inc/undobase.hxx

@@ -115,7 +115,6 @@ protected:
     void EndUndo();
     void EndRedo();
 
-    void AdjustHeight();
     void ShowBlock();
 };
 

sc/source/ui/undo/undobase.cxx

@@ -379,48 +379,6 @@ void ScMultiBlockUndo::EndRedo()
     ScSimpleUndo::EndRedo();
 }
 
-void ScMultiBlockUndo::AdjustHeight()
-{
-    ScDocument& rDoc = pDocShell->GetDocument();
-
-    ScopedVclPtrInstance< VirtualDevice > pVirtDev;
-    Fraction aZoomX( 1, 1 );
-    Fraction aZoomY = aZoomX;
-    double nPPTX, nPPTY;
-    ScTabViewShell* pViewShell = ScTabViewShell::GetActiveViewShell();
-    if (pViewShell)
-    {
-        ScViewData& rData = pViewShell->GetViewData();
-        nPPTX = rData.GetPPTX();
-        nPPTY = rData.GetPPTY();
-        aZoomX = rData.GetZoomX();
-        aZoomY = rData.GetZoomY();
-    }
-    else
-    {
-        // Leave zoom at 100
-        nPPTX = ScGlobal::nScreenPPTX;
-        nPPTY = ScGlobal::nScreenPPTY;
-    }
-
-    sc::RowHeightContext aCxt(nPPTX, nPPTY, aZoomX, aZoomY, pVirtDev);
-    for (size_t i = 0, n = maBlockRanges.size(); i < n; ++i)
-    {
-        const ScRange& r = *maBlockRanges[i];
-        bool bRet = rDoc.SetOptimalHeight(aCxt, r.aStart.Row(), r.aEnd.Row(), r.aStart.Tab());
-
-        if (bRet)
-        {
-            // tdf#76183: recalculate objects' positions
-            rDoc.SetDrawPageSize(r.aStart.Tab());
-
-            pDocShell->PostPaint(
-                0, r.aStart.Row(), r.aStart.Tab(), MAXCOL, MAXROW, r.aEnd.Tab(),
-                PaintPartFlags::Grid | PaintPartFlags::Left);
-        }
-    }
-}
-
 void ScMultiBlockUndo::ShowBlock()
 {
     if ( IsPaintLocked() )

sd/inc/imapinfo.hxx

@@ -31,9 +31,6 @@ class SdIMapInfo : public SdrObjUserData, public SfxListener
     ImageMap        aImageMap;
 
 public:
-                    SdIMapInfo() :
-                        SdrObjUserData( SdrInventor::StarDrawUserData, SD_IMAPINFO_ID ) {};
-
                     SdIMapInfo( const ImageMap& rImageMap ) :
                         SdrObjUserData( SdrInventor::StarDrawUserData, SD_IMAPINFO_ID ),
                         aImageMap( rImageMap ) {};

starmath/inc/smmod.hxx

@@ -53,8 +53,7 @@ OUString SmResId(const char* pId);
 class SmLocalizedSymbolData
 {
 public:
-    SmLocalizedSymbolData();
-    ~SmLocalizedSymbolData();
+    SmLocalizedSymbolData() = delete;
 
     static const OUString GetUiSymbolName( const OUString &rExportName );
     static const OUString GetExportSymbolName( const OUString &rUiName );

starmath/source/smmod.cxx

@@ -47,14 +47,6 @@ OUString SmResId(const char* pId)
     return Translate::get(pId, SM_MOD()->GetResLocale());
 }
 
-SmLocalizedSymbolData::SmLocalizedSymbolData()
-{
-}
-
-SmLocalizedSymbolData::~SmLocalizedSymbolData()
-{
-}
-
 const OUString SmLocalizedSymbolData::GetUiSymbolName( const OUString &rExportName )
 {
     OUString aRes;

tools/source/memtools/unqidx.cxx

@@ -37,25 +37,6 @@ UniqueIndexImpl::Index UniqueIndexImpl::Insert( void* p )
     return nUniqIndex++;
 }
 
-void* UniqueIndexImpl::Remove( Index nIndex )
-{
-    std::map<Index, void*>::iterator it = maMap.find( nIndex );
-    if ( it != maMap.end() )
-    {
-        // Allow to recycle freed indexes, as was done by
-        // original implementation based on a vector
-        // This is not really needed when using a map, and
-        // really unique indexes might be better/safer?
-        if ( nIndex < nUniqIndex )
-            nUniqIndex = nIndex;
-
-        void* p = it->second;
-        maMap.erase( it );
-        return p;
-    }
-    return nullptr;
-}
-
 void* UniqueIndexImpl::Get( Index nIndex ) const
 {
     std::map<Index, void*>::const_iterator it = maMap.find( nIndex );
@@ -64,12 +45,4 @@ void* UniqueIndexImpl::Get( Index nIndex ) const
     return nullptr;
 }
 
-UniqueIndexImpl::Index UniqueIndexImpl::GetIndexOf(void const * p) const
-{
-    for( std::map<Index, void*>::const_iterator it = maMap.begin(); it != maMap.end(); ++it )
-        if( it->second == p )
-            return it->first;
-    return IndexNotFound;
-}
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */