Kaydet (Commit) 9585521c authored tarafından Tamas Bunth's avatar Tamas Bunth Kaydeden (comit) Tamás Bunth

tdf#70425 do not close cursor explicitly

A cursor need only be closed in this manner if it was previously
opened and associated with stmt_handle by isc_dsql_set_cursor_name()

See Interbase API Guide: isc_dsql_free_statement

Change-Id: Iadb0dcf83ee58b6196112c44d922528a3f56f7ea
Reviewed-on: https://gerrit.libreoffice.org/46132Tested-by: 's avatarJenkins <ci@libreoffice.org>
Reviewed-by: 's avatarTamás Bunth <btomi96@gmail.com>
üst 9ccc1f59
......@@ -250,17 +250,6 @@ sal_Bool SAL_CALL OPreparedStatement::execute()
if (m_xResultSet.is()) // Checks whether we have already run the statement.
{
disposeResultSet();
// Closes the cursor from the last run.
// This doesn't actually free the statement -- using DSQL_close closes
// the cursor and keeps the statement, using DSQL_drop frees the statement
// (and associated cursors).
aErr = isc_dsql_free_statement(m_statusVector,
&m_aStatementHandle,
DSQL_close);
if (aErr)
evaluateStatusVector(m_statusVector,
"isc_dsql_free_statement: close cursor",
*this);
}
aErr = isc_dsql_execute(m_statusVector,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment