loplugin:countusersofdefaultparams in include/oox..sax

Change-Id: Ifb24c0f536d9c00bc9eb8c782d6854052f2d37b9
Reviewed-on: https://gerrit.libreoffice.org/31408Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

include/oox/dump/dumperbase.hxx

@@ -1039,8 +1039,8 @@ private:
 class ItemGuard
 {
 public:
-    explicit            ItemGuard( const OutputRef& rxOut, const String& rName = EMPTY_STRING ) :
-                     mrOut( *rxOut ) { mrOut.startItem( rName ); }
+    explicit            ItemGuard( const OutputRef& rxOut, const String& rName ) :
+                            mrOut( *rxOut ) { mrOut.startItem( rName ); }
                         ~ItemGuard() { mrOut.endItem(); }
     void                cont() { mrOut.contItem(); }
 private:
@@ -1632,7 +1632,7 @@ protected:
                             const OUString& rSysFileName,
                             const BinaryInputStreamRef& rxRecStrm,
                             const String& rRecNames,
-                            const String& rSimpleRecs = EMPTY_STRING );
+                            const String& rSimpleRecs );
 
     sal_Int64           getRecId() const { return mnRecId; }
     sal_Int64           getRecSize() const { return mnRecSize; }
@@ -1675,7 +1675,7 @@ protected:
                             const BinaryInputStreamRef& rxBaseStrm,
                             const OUString& rSysFileName,
                             const String& rRecNames,
-                            const String& rSimpleRecs = EMPTY_STRING );
+                            const String& rSimpleRecs );
 
     virtual bool        implStartRecord( BinaryInputStream& rBaseStrm, sal_Int64& ornRecPos, sal_Int64& ornRecId, sal_Int64& ornRecSize ) override;
     virtual bool        implReadRecordHeader( BinaryInputStream& rBaseStrm, sal_Int64& ornRecId, sal_Int64& ornRecSize ) = 0;

include/oox/dump/oledumper.hxx

@@ -50,7 +50,7 @@ protected:
     OUString     dumpAnsiString32( const String& rName );
     OUString     dumpUniString32( const String& rName );
 
-    sal_Int32           dumpStdClipboardFormat( const String& rName = EMPTY_STRING );
+    sal_Int32    dumpStdClipboardFormat( const String& rName );
     OUString     dumpAnsiString32OrStdClip( const String& rName );
     OUString     dumpUniString32OrStdClip( const String& rName );
 
@@ -734,10 +734,9 @@ protected:
     virtual void        implDumpRecordBody() override;
 
 private:
-    OUString     dumpByteString( const String& rName = EMPTY_STRING );
-    OUString     dumpUniString( const String& rName = EMPTY_STRING );
-
-    OUString     dumpByteStringWithLength( const String& rName = EMPTY_STRING );
+    OUString     dumpByteString( const String& rName );
+    OUString     dumpUniString( const String& rName );
+    OUString     dumpByteStringWithLength( const String& rName );
 
 private:
     VbaSharedData&      mrVbaData;

include/oox/export/chartexport.hxx

@@ -207,7 +207,8 @@ private:
 
 public:
 
-    ChartExport( sal_Int32 nXmlNamespace, ::sax_fastparser::FSHelperPtr pFS, css::uno::Reference< css::frame::XModel >& xModel, ::oox::core::XmlFilterBase* pFB = nullptr, DocumentType eDocumentType = DOCUMENT_PPTX );
+    ChartExport( sal_Int32 nXmlNamespace, ::sax_fastparser::FSHelperPtr pFS, css::uno::Reference< css::frame::XModel >& xModel,
+                 ::oox::core::XmlFilterBase* pFB, DocumentType eDocumentType );
     virtual ~ChartExport() {}
 
     sal_Int32           GetChartID( );

include/oox/export/shapes.hxx

@@ -126,7 +126,10 @@ private:
 
 public:
 
-    ShapeExport( sal_Int32 nXmlNamespace, ::sax_fastparser::FSHelperPtr pFS, ShapeHashMap* pShapeMap = nullptr, ::oox::core::XmlFilterBase* pFB = nullptr, DocumentType eDocumentType = DOCUMENT_PPTX, DMLTextExport* pTextExport = nullptr );
+    ShapeExport( sal_Int32 nXmlNamespace, ::sax_fastparser::FSHelperPtr pFS,
+                 ShapeHashMap* pShapeMap, ::oox::core::XmlFilterBase* pFB,
+                 DocumentType eDocumentType = DOCUMENT_PPTX,
+                 DMLTextExport* pTextExport = nullptr );
     virtual ~ShapeExport() {}
 
     void SetURLTranslator(const std::shared_ptr<URLTransformer>& pTransformer);

include/oox/helper/binaryinputstream.hxx

@@ -152,7 +152,7 @@ public:
             True = NUL characters are inserted into the imported string.
             False = NUL characters are replaced by question marks (default).
      */
-    OString      readCharArray( sal_Int32 nChars, bool bAllowNulChars = false );
+    OString      readCharArray( sal_Int32 nChars, bool bAllowNulChars );
 
     /** Reads a byte character array and returns a Unicode string.
 
@@ -351,7 +351,7 @@ public:
      */
     explicit            RelativeInputStream(
                             BinaryInputStream& rInStrm,
-                            sal_Int64 nSize = SAL_MAX_INT64 );
+                            sal_Int64 nSize );
 
     /** Returns the size of the data block in the wrapped stream offered by
         this wrapper. */

include/oox/helper/binarystreambase.hxx

@@ -100,7 +100,7 @@ public:
         @param nAnchorPos
             Position in the stream the data blocks are aligned to.
      */
-    void                alignToBlock( sal_Int32 nBlockSize, sal_Int64 nAnchorPos = 0 );
+    void                alignToBlock( sal_Int32 nBlockSize, sal_Int64 nAnchorPos );
 
 protected:
     explicit            BinaryStreamBase( bool bSeekable ) : mbEof( false ), mbSeekable( bSeekable ) {}

include/oox/helper/containerhelper.hxx

@@ -44,7 +44,7 @@ struct ValueRange
     sal_Int32           mnFirst;
     sal_Int32           mnLast;
 
-    explicit     ValueRange( sal_Int32 nValue = 0 ) : mnFirst( nValue ), mnLast( nValue ) {}
+    explicit     ValueRange( sal_Int32 nValue ) : mnFirst( nValue ), mnLast( nValue ) {}
     explicit     ValueRange( sal_Int32 nFirst, sal_Int32 nLast ) : mnFirst( nFirst ), mnLast( nLast ) {}
 
     bool         operator==( const ValueRange& rRange ) const { return (mnFirst == rRange.mnFirst) && (mnLast == rRange.mnLast); }

include/oox/helper/graphichelper.hxx

@@ -133,7 +133,7 @@ public:
         @return  The URL of the created and internally cached graphic object. */
     OUString     importGraphicObject(
                             const css::uno::Reference< css::io::XInputStream >& rxInStrm,
-                            const WMF_EXTERNALHEADER* pExtHeader = nullptr ) const;
+                            const WMF_EXTERNALHEADER* pExtHeader ) const;
 
     /** Creates a persistent graphic object from the passed binary memory block.
         @return  The URL of the created and internally cached graphic object. */

include/oox/mathml/importutils.hxx

@@ -120,7 +120,7 @@ public:
     struct OOX_DLLPUBLIC AttributeList
     {
         OUString& operator[] (int token);
-        OUString attribute( int token, const OUString& def = OUString()) const;
+        OUString attribute( int token, const OUString& def) const;
         bool attribute( int token, bool def ) const;
         sal_Unicode attribute( int token, sal_Unicode def ) const;
         // when adding more attribute() overloads, add also to XmlStream itself

include/oox/ole/olehelper.hxx

@@ -105,7 +105,7 @@ namespace OleHelper
     OOX_DLLPUBLIC sal_Int32    decodeOleColor(
                             const GraphicHelper& rGraphicHelper,
                             sal_uInt32 nOleColor,
-                            bool bDefaultColorBgr = true );
+                            bool bDefaultColorBgr );
 
     /** Returns the OLE color from the passed UNO RGB color.
      */

include/oox/ole/vbacontrol.hxx

@@ -191,7 +191,7 @@ public:
                             const css::uno::Reference< css::uno::XComponentContext >& rxContext,
                             const css::uno::Reference< css::frame::XModel >& rxDocModel,
                             const GraphicHelper& rGraphicHelper,
-                            bool bDefaultColorBgr = true );
+                            bool bDefaultColorBgr );
 
     /** Imports the form and its embedded controls, and inserts the form with
         all its controls into the passed dialog library. */

include/oox/ppt/pptshape.hxx

@@ -54,7 +54,7 @@ class PPTShape : public oox::drawingml::Shape
 public:
 
     PPTShape( const oox::ppt::ShapeLocation eShapeLocation,
-                const sal_Char* pServiceType = nullptr );
+                const sal_Char* pServiceType );
     virtual ~PPTShape() override;
 
     using oox::drawingml::Shape::addShape;
@@ -65,7 +65,7 @@ public:
             const oox::drawingml::Theme* pTheme,
             const css::uno::Reference< css::drawing::XShapes >& rxShapes,
             basegfx::B2DHomMatrix& aTransformation,
-            ::oox::drawingml::ShapeIdMap* pShapeMap = nullptr );
+            ::oox::drawingml::ShapeIdMap* pShapeMap );
 
     ShapeLocation getShapeLocation() const { return meShapeLocation; };
     void setReferenced( bool bReferenced ){ mbReferenced = bReferenced; };

include/package/Inflater.hxx

@@ -39,7 +39,7 @@ protected:
     sal_Int32   doInflateBytes (css::uno::Sequence < sal_Int8 > &rBuffer, sal_Int32 nNewOffset, sal_Int32 nNewLength);
 
 public:
-    Inflater(bool bNoWrap = false);
+    Inflater(bool bNoWrap);
     ~Inflater();
     void SAL_CALL setInput( const css::uno::Sequence< sal_Int8 >& rBuffer );
     bool SAL_CALL needsDictionary(  ) { return bNeedDict;}

include/sax/fastattribs.hxx

@@ -65,10 +65,9 @@ class SAX_DLLPUBLIC FastTokenHandlerBase
      * @return Tokenized form of pStr
      */
     static sal_Int32 getTokenFromChars(
-                         const css::uno::Reference<
-                             css::xml::sax::XFastTokenHandler > &xTokenHandler,
+                         const css::uno::Reference<css::xml::sax::XFastTokenHandler > &xTokenHandler,
                          FastTokenHandlerBase *pTokenHandler /* can be NULL */,
-                         const char *pStr, size_t nLength = 0 );
+                         const char *pStr, size_t nLength );
 };
 
 class SAX_DLLPUBLIC FastAttributeList : public ::cppu::WeakImplHelper1< css::xml::sax::XFastAttributeList >

include/sax/fshelper.hxx

@@ -70,7 +70,7 @@ class SAX_DLLPUBLIC FastSerializerHelper
 {
 public:
 
-    FastSerializerHelper( const css::uno::Reference< css::io::XOutputStream >& xOutputStream, bool bWriteHeader = true );
+    FastSerializerHelper( const css::uno::Reference< css::io::XOutputStream >& xOutputStream, bool bWriteHeader );
 
     ~FastSerializerHelper();
 

include/sax/tools/converter.hxx

@@ -67,8 +67,8 @@ public:
     /** convert measure to string */
     static void convertMeasure( OUStringBuffer& rBuffer,
                                 sal_Int32 nMeasure,
-                                sal_Int16 SourceUnit = css::util::MeasureUnit::MM_100TH,
-                                sal_Int16 nTargetUnit = css::util::MeasureUnit::INCH  );
+                                sal_Int16 SourceUnit,
+                                sal_Int16 nTargetUnit  );
 
     /** convert string to boolean */
     static bool convertBool( bool& rBool,